From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC655A04C1; Wed, 2 Sep 2020 17:41:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F004B137D; Wed, 2 Sep 2020 17:41:17 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E4C66E07 for <dev@dpdk.org>; Wed, 2 Sep 2020 17:41:15 +0200 (CEST) IronPort-SDR: Zrt4WOHgmSfWsvLZ2ENjIF4OZQaqUU3zkPm7xp6Rdj4YRi4uae7umjAczXw2hpY9usqqFd8gqE Ir/axbHDH9WA== X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="156675835" X-IronPort-AV: E=Sophos;i="5.76,383,1592895600"; d="scan'208";a="156675835" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 08:41:14 -0700 IronPort-SDR: 0apsuVPp08hYrPuslLL3ZJPK5bD8T0YnyE2sn18BgkeMEwSJ3KtrHfAfeNsQe6PxACzjPz83P1 0OxvsTlfBi5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,383,1592895600"; d="scan'208";a="315156396" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 02 Sep 2020 08:41:14 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 2 Sep 2020 08:41:13 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 2 Sep 2020 08:41:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 2 Sep 2020 08:41:12 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.50) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 2 Sep 2020 08:41:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZ16VFSPT2ULORLRTWhQ7szmR1a6b7gui5cZ98a0uSepa3mxW9JVYxteeCKdo8nJw1wK0ZBWYVhKlzeZ1s9eJIh6oz2mFaHcxBRm9EXViSLM0QtYHuj2AJuhVtlFaYa3psxQTjf8Vn5tZJG60awYCTdsmGAtKqtJ0LDlj0EYs7EIxQWsPQO4wz4zwO6TKlZ63Ww2qACwO+UcbcnRhJXK6ELPi3h8TPFGh693/TgMCqRaFWYwvmYd1TN+FrYhuOjeSH3aNgmny3OeY+wXjr+4QzQ0/7K6rPomyqZrzhFX1iVCyYu30WL5x3RYyELUlwHQEVeWzcdXWLhCQbFvUZClVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=08Z1RLgfpRLfeEUgOWaIi6S5HnJnQrh0yOdNOI4srXQ=; b=he4up5kl8L1qWjXlbVuiusmjcWzTPaiiurx7YqLeM+64YIBw0xDirvWKvtC5xfWFXmWggsLFLMJ/1m54jKVpzJwORyc7vyGuWouw9IFhNuQst5uWUcuTyYHl9EKmYQhhsCaqI2f1k6/kusHJD7+SuSpiCvXNjZS62PB5PVjGR52F+vpeUHAVjkN4FwotmKFNAJ4sM8NdUASxlUYC1HPFDB1NlmzRNBaH4a+blA52z/9GH8jEyUGSHPh9Z96OEjeziOlJzducMdCJl6KEqF2C58If4rxovJ8B2+ceyKVA2CaC3xycfa8xIzz+siP4Q+KV8ztf3u8oTNErN02BRI86tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=08Z1RLgfpRLfeEUgOWaIi6S5HnJnQrh0yOdNOI4srXQ=; b=K0a39przoLewFVRfObB2pZMG6RCIBJRml016bLOf6Sqya2Zl1Tpyp+xeWh/VlfN/GtDgUN9QjlnBSbwo9DOIMivND2JWlDGT985WOIcVzYTLe9526gI55sAS9U6s+5ogKiV/uA/sdCDYGeKO/oM33/SZm/artv2gxgOuyjV14x0= Received: from BN6PR11MB1555.namprd11.prod.outlook.com (2603:10b6:405:c::11) by BN8PR11MB3618.namprd11.prod.outlook.com (2603:10b6:408:90::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Wed, 2 Sep 2020 15:41:10 +0000 Received: from BN6PR11MB1555.namprd11.prod.outlook.com ([fe80::b008:b0a:9a8d:124d]) by BN6PR11MB1555.namprd11.prod.outlook.com ([fe80::b008:b0a:9a8d:124d%11]) with mapi id 15.20.3326.025; Wed, 2 Sep 2020 15:41:10 +0000 From: "Pattan, Reshma" <reshma.pattan@intel.com> To: Patrick Keroulas <patrick.keroulas@radio-canada.ca>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [[PATCH v3 3/4] pdump: convert timestamp to nanoseconds on Rx path Thread-Index: AQHWYfh5nanMJqaQ/U6xmE4Ne6WmiKlVsEdg Date: Wed, 2 Sep 2020 15:41:10 +0000 Message-ID: <BN6PR11MB1555126911F4D3D9D6BE2BCCFF2F0@BN6PR11MB1555.namprd11.prod.outlook.com> References: <20200724202315.19533-1-patrick.keroulas@radio-canada.ca> <20200724202315.19533-4-patrick.keroulas@radio-canada.ca> In-Reply-To: <20200724202315.19533-4-patrick.keroulas@radio-canada.ca> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: radio-canada.ca; dkim=none (message not signed) header.d=none;radio-canada.ca; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.44.8.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60b38fd9-4fa9-4e7d-1e5e-08d84f569dd0 x-ms-traffictypediagnostic: BN8PR11MB3618: x-microsoft-antispam-prvs: <BN8PR11MB3618866026EA3816A9836489FF2F0@BN8PR11MB3618.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:3383; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sdk+8xWjLkQuoXoA4pVeDxdIHdJ1+nj6s01DTmfbKjgw6V4pd5wz2ampOPO9Q0wEzmC95X58aTRHMt4pJrEBF2f1ECJhbndfhKqGppwdkRBa4WTt3NhuetVgTiQUsamgYGyVugHjzD/utiVvCQgogyvzaX7dMdzietAClqCxfSU8jUdUPgYOeSUC47BvHKWBfs+MlIo7ExdH6vVXmcrrINHuHvRo8NtD54a5cdZUWM/5NVgxi4dw57pHGu71opNqwEjIQK//58QDEQVypv3J1o3qA7JyJ6fvo3Xt5EgIRS/hi3MyfGp3D0/rxmPdXE+NUA0sW/OePaQgDB8nT8iJvQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1555.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(366004)(39860400002)(376002)(136003)(2906002)(9686003)(110136005)(52536014)(5660300002)(4744005)(8936002)(55016002)(83380400001)(26005)(478600001)(6506007)(7696005)(66556008)(33656002)(316002)(86362001)(71200400001)(64756008)(76116006)(66446008)(66476007)(66946007)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: b8JjmcH6Ruu7g45HQMakw/SKMK2mq2o9ZDFKo1cHEYFtDGxnm9WxHkwF/cnppzNWKUJrSpuubSf2VASg+iK4YQK12ezxw9KU7lVzI/KQf5PQRoumwFrptE3f/GMaJ6CsRAdOAdNCUQ9OLkhWuw2tLMy/QkMf75UALgEyB5OH1N9iSs3aVCqkUzptdFlxH7s7GuLSebSY00QwTzWURKGkKo5dwO/X01fTmUVLSyZyhhjdjJH+QCQ6/UzCxr/vpv2g2wdS3jHMKrPgkV7ukI6aeQi94n+59AsMfFI+YrmDW22BtOSZM5iVX4Dn/oFz9vQrPMw9jQ76Au4qnVMydzUJFb8I7RIf8xeFL6LOwebCXVKzmC+XVKj7zMFExNAnLD+Mhj7OVpVJNxsl3vddT5CtQLlI7b0B4vPZZEzR1t1rITXXnbPgFPnHUAhp2ft/dYzKnHrkRlPFzZ1C7XT4dPaB1MRQ0iAxii7mTJ9vbTK5fVtRWca8jgHi6qnQJM1O6nFoOKiOtP7dsbz50HgoneuaCl6Jww8SlEvxo6a517pfkt6ftK0zXC41xONg96VDd3lZzAlmqHz2rwx5mF8RaFWS/E6eBcZXtF9gAjnBInYFSqLcYOu2WHGC01envEi2y4J8x7MdMp+fxLFwrhN+xAm29A== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1555.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60b38fd9-4fa9-4e7d-1e5e-08d84f569dd0 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2020 15:41:10.3670 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z9qlGaoMO4kygFzL4Lk8nDHPs/iyCdyLguOfZVSdMNioXP0+2Od+p7nEUBnV9t7t4Fg+V/o2FB2K0xNPy8t0Sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3618 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [[PATCH v3 3/4] pdump: convert timestamp to nanoseconds on Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > + rte_eth_read_clock(port, &start_cycles); > + rte_eth_get_clock_freq(port, &hz); Do you need to check return value of these calls to handle -ENOTSUP? And a= void timestamping marking. If -ENOTSUP, then hz value is 0 and using hz in function pdump_ts_to_ns() m= ight be illegal. > + gettimeofday(&now, NULL); Same here, need to handle return value carefully? Thanks, Reshma