From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Power, Ciara" <ciara.power@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Laatz, Kevin" <kevin.laatz@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue
Date: Fri, 9 Oct 2020 09:08:42 +0000 [thread overview]
Message-ID: <BN6PR11MB15558126008F4F08B24EF620FF080@BN6PR11MB1555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xKxL=+f5vN7dZio2HLiiaX9TR266wXeuG1E_fMpnUvSA@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue
>
> On Fri, Oct 9, 2020 at 10:36 AM Pattan, Reshma <reshma.pattan@intel.com>
> wrote:
> > > >> +* ethdev: Renamed basic statistics per queue. An underscore is
> > > >> +inserted
> > > >> + between the queue number and the rest of the xstat name:
> > > >> +
> > > >> + * ``rx_qN*`` -> ``rx_qN_*``
> > > >> + * ``tx_qN*`` -> ``tx_qN_*``
> > > >> +
> > > >
> > > >As far as I remember collect plugin was using xstat output, does
> > > >this rename affects it? Or any other telemetry application relying on xstats.
> > > >
> > > >Harry, Ciara, Kevin, do you know anything that will be affected from
> rename?
> > >
> > > I don't think this change will affect anything with telemetry
> > > itself, but I am not so familiar with the CollectD plugin, Reshma may be able
> to verify that.
> >
> > Neither collectd has any dependency on naming.
>
> I am not sure about this statement.
> collectd dpdkstats plugin does seem to inspect the names.
>
Hi,
I should have been more clear on this, It is dpdk_telemetry plugin of collectd I am talking about, as I worked on that.
dpdk_telemetry plugin of collectd do not have dependency on the naming.
dpdkstats plugin I did not work on, so I cannot comment on that, might be Harry able to help with that .
Thanks,
Reshma
next prev parent reply other threads:[~2020-10-09 9:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 21:48 Thomas Monjalon
2020-10-08 9:09 ` Bruce Richardson
2020-10-08 9:10 ` Kevin Traynor
2020-10-08 10:29 ` Asaf Penso
2020-10-09 21:00 ` Ferruh Yigit
2020-10-09 21:01 ` Ferruh Yigit
2020-10-08 15:41 ` Ferruh Yigit
2020-10-09 8:32 ` Power, Ciara
2020-10-09 8:36 ` Pattan, Reshma
2020-10-09 9:02 ` David Marchand
2020-10-09 9:08 ` Pattan, Reshma [this message]
2020-10-09 16:53 ` Kevin Laatz
2020-10-09 19:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB15558126008F4F08B24EF620FF080@BN6PR11MB1555.namprd11.prod.outlook.com \
--to=reshma.pattan@intel.com \
--cc=arybchenko@solarflare.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).