From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9B026A0535; Tue, 4 Feb 2020 16:52:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E93A91C206; Tue, 4 Feb 2020 16:52:57 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E4F551C1A6 for <dev@dpdk.org>; Tue, 4 Feb 2020 16:52:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 07:52:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,402,1574150400"; d="scan'208";a="429848767" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 04 Feb 2020 07:52:55 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 07:52:54 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 07:52:54 -0800 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.51) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 07:52:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hl8Ea5M1uMxznmZ/GIKfOOL4WWskMdMs4bQ4zTLZaD4crzE9fmbmHVuQxAsKT1mf78zTC+BQEg1NfRMFUooL8Ml5UZCpam6GMU9SKiL9gxmSRF4TwTAMfPq65aDrHkjeuKD5E85NFKw8MrtoOuJpJhXMBtN8HZR3sqwQwaYRbeQwXo89zhZ8Y4A4NuyBxfE3HXO8btgh9thH9nOZsZ6KZC3zqDos8UHYfeHNsfumx05UFC4XRmAoMpM5RuIleqHF788dgGx9Y/gEF4MiiJwaDmnu9KmFdsJffAZfoQWtHC+ryutsn9oCAYHCpx7sZxh4gHt76w2grxmOAhEvuVVPgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y02p1jJ398UGopHe50pSpjrJjUPUI35ZY0jQYIsvYqY=; b=jUQNsv6bGUyxoDn5fzYEaRcVWvQyxV5HZ+E3Iuk+XdQiJsDcQ1lsGdY8Q+BRKtzzTggFKpShLHRp0mM/jQlurne7YNlp1qIYhOAYUfsWA7+bt2RRAztGIerpLln8yCX2gmN9BZf3lGV8FPfm1E0oLm0vGs3hm8Hf8MPtYAqE9wROl9CpY93khdh4mreeOeM4GUJG8SDt/sqjxSipBVaA/B5pSmWqh3SIAV+6/W2XXxbYYcO329cZc9kIxsMLgyLhFhHqqLYW0twzIp7tNeojfMPzmYDmOw8yNOeNZ/VveJWOEFmYT6WkQ2mdqIK/OrVKxM/iYRFPgkhpbmdUM6wMPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y02p1jJ398UGopHe50pSpjrJjUPUI35ZY0jQYIsvYqY=; b=hr7Hs8VQx20wbRJBv8BmW3b8Da0v3lH1vwbNw7e3lhyhqjEXkblBOINO3XrBxu1dW5dUxpJFUZ4NbD+XUJ40l5rplfTQk75HPqNnPrFQjz2RSbW4B2/0shRCqGRxhbCvUSl1fj1Zkv4uxbT3HcUZSvFMmz/M0C34xEQQgtOmuZY= Received: from BN6PR11MB1796.namprd11.prod.outlook.com (10.175.99.136) by BN6PR11MB1345.namprd11.prod.outlook.com (10.173.32.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Tue, 4 Feb 2020 15:52:38 +0000 Received: from BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07]) by BN6PR11MB1796.namprd11.prod.outlook.com ([fe80::4519:125f:2122:de07%3]) with mapi id 15.20.2686.034; Tue, 4 Feb 2020 15:52:38 +0000 From: "Trahe, Fiona" <fiona.trahe@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, David Marchand <david.marchand@redhat.com>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "bluca@debian.org" <bluca@debian.org>, "ktraynor@redhat.com" <ktraynor@redhat.com>, Ray Kinsella <mdr@ashroe.eu>, "dev@dpdk.org" <dev@dpdk.org>, Akhil Goyal <akhil.goyal@nxp.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> CC: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Anoob Joseph <anoobj@marvell.com>, "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "dodji@seketeli.net" <dodji@seketeli.net>, Andrew Rybchenko <arybchenko@solarflare.com>, "aconole@redhat.com" <aconole@redhat.com>, "Trahe, Fiona" <fiona.trahe@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2 4/4] add ABI checks Thread-Index: AQHV1smFGAWDLtMfdkaM/74xTf+RAKgB6XuAgAAHoQCAAB+HAIAAAt+AgAFOQgCAAEVxAIAA3urQgANfUACAABrKgIABOz0AgACAVwCAAAb/gIAAFsaAgAAktQCAAN6iAIAAJLJQgAAxliA= Date: Tue, 4 Feb 2020 15:52:38 +0000 Message-ID: <BN6PR11MB179688305FF722D57FEBF62FE4030@BN6PR11MB1796.namprd11.prod.outlook.com> References: <20191220152058.10739-1-david.marchand@redhat.com> <4ed777ce-8320-4636-2c9c-62bb96b66392@ashroe.eu> <2546229.NgBsaNRSFp@xps> <6660180.4vTCxPXJkl@xps> <BN6PR11MB179692C72753461896CB9B11E4030@BN6PR11MB1796.namprd11.prod.outlook.com> In-Reply-To: <BN6PR11MB179692C72753461896CB9B11E4030@BN6PR11MB1796.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmI4NDA5MDYtMjRlOC00OTFlLTg2ODYtM2IwODhlZTg2YjZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNUliQXB3QzkwY1VnYjIwT0Y2UlNFNVwvZ2FYUHY0UjN1YzNBdEFWQjlCM1VuYTJKWklLakx6SE1sbXdZbWpNZloifQ== dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20005567-d215-4287-8acb-08d7a98a42b0 x-ms-traffictypediagnostic: BN6PR11MB1345: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BN6PR11MB1345AEE2FD621C4E29C3C764E4030@BN6PR11MB1345.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(136003)(376002)(346002)(39860400002)(199004)(189003)(7416002)(26005)(316002)(71200400001)(81166006)(5660300002)(4326008)(81156014)(8936002)(66556008)(66446008)(66476007)(8676002)(66946007)(64756008)(52536014)(76116006)(7696005)(107886003)(6506007)(110136005)(86362001)(54906003)(2940100002)(55016002)(2906002)(33656002)(186003)(9686003)(6636002)(478600001)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB1345; H:BN6PR11MB1796.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uNTwm/iTqIOXs2yQEBIGyP4rJRZyUgRnLEPQ1EvTxSjYqRc2DhIPfjscQh5DAABEYuB4qF1y3kFClyj2yS9vAZDe3ZG0hZ+wH8jLWe61B5Fy6/jjv3y/ehA6qBrJN2JWPtCa0anETMCTMR0FrJpey5u6dskYz98IUa5pCyzdeBfiv3uKEvzUFZcS832kUBz2EI2M4yHoCSKefLoZ1iuL7Eppti6MlRBgj1RUNIfcdNhRQpHZGJdISUh10p4m7+XGKh7BrRk3/AVRqZUqxmGOPoBhYo0zjvulcEYV65pwUpCpHD43FsvCjMXYhHP8dfbdK3Egk8ut8Reh7pgksKukK3C8fH+xzSL/0yurCOXn41tu/0VeGSnggO0GxqF/M6x/KA8VSHcJcfd3DIAwgOchUTbbzsA+7BsjNJEbxidad/PvzJeBmvbeUksyV63YKp2kmSKo3dBa50KEnfDtzvKNnzEZqmErgOZTm8UMVqmoG17dhwUAY6oYGZp4VZKQx1/I x-ms-exchange-antispam-messagedata: 4YAFQgJd6ztSqWd1re4oQX4SvLsiQKAVtJXxmn0SDpsSHrVCpNKqd7C32oWL/qVRYTehSHH4eXHr88Eafnn15Bdomy9VwTMwU/YLJEuMZDtrira+nYOPly2LS2AxplUQzqff8IzSrVsv2B/6CmJhIw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 20005567-d215-4287-8acb-08d7a98a42b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 15:52:38.3787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RIW3fQMBHJKADqtj9pZB18fF0prEwNjYVWje2kzN/6lsiyMCiiHGcZorX9Sbp+xqdJXurXLZbLCATYYc4DjZyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1345 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > We are working on a patch, when it is ready we will send it. > If it's not ready by end of your today, of course, go ahead with (b) and > we will work towards 20.05. We will not be sending a patch today. The patch we're working on will provide two versions of rte_cryptodev_info_= get(), both call the same PMD function from the dev_ops info_get fn ptr. The default version operates s as normal, the 19.11 version searches through the list returned by the PMD, looking for sym.aead.algo =3D ChaChaP= oly, it needs to strip it from the list. As PMDs just pass a ptr to their capabilities list ( it isn't a linked list= , but an array with an end marker =3D RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST) if the API layer detects Chacha it must allocate some space and store a local copy of = the trimmed list. This must be stored only once per device. This versioning will apply to any PMD which wants to take advantage of the = new API between now and 20.11. Note, I expect the ABI checker tools will still complain of ABI breakage as= the LIST_END value will still change. We are also reviewing all other cryptodev APIs in case there is any other A= PI which needs versioning. =20 Anyone see any problem with this approach?