From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70DD0A00C5; Thu, 1 Dec 2022 07:08:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5993C40FAE; Thu, 1 Dec 2022 07:08:23 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 99D0240A7F for ; Thu, 1 Dec 2022 07:08:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669874901; x=1701410901; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nLoOWo0YsGXypD9pagKAjGefVh3oH3BbNdbcUOzfA2s=; b=jsx634RvXfwrCdr7Cj8fmAeMOx1XfKaqLvrYoC1h5pRrmqJJI6OtRPYX JDWM6FvvtIt74BcNfxJ28F4/GePY+w7AgP+hIF+ffyvZWGEP6mBxWEDse TUxcPpll9Yo3ciHyZSJZ8a7fK3zUgICay4cOvkEo33kna1zyNd2VTOvbG x/pJfEGcaGm9J+U/HSCnQwbvHKL1w3p29LR+uapwsiZb32NijLfOibhIh gJR5TvCWpS7bkhOEaLsTNco/ZEoMBgvUCHV0/gdFMHBXjgEmknytiKIpj E89y1ClAWUf7xdObpAV5nQr2EfTvnJttGgVrpSa6wq/6cmUFtqmPOMq67 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="316752030" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="316752030" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2022 22:08:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10547"; a="889593300" X-IronPort-AV: E=Sophos;i="5.96,207,1665471600"; d="scan'208";a="889593300" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 30 Nov 2022 22:08:13 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 30 Nov 2022 22:08:01 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 30 Nov 2022 22:08:01 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 30 Nov 2022 22:08:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DVEcKvkHQd6IgTNKCdUg72jjkEcXxTsA9wtEh+EMTUFKYWMnF/SyIFfEzlf+4Nf94bo48S6479au17H9sXgOk+qHjxIJqIO3DYaahL/av/iWXjBy3WrFoUvwsNIbWBaMxoWlgytMzV7SpSubXdeEWVVGMUq+b3tdz3Mr/Ne+w74dDRZ1zqEs7w6CImwJaAplfP+kb1xpzRV62HJsD/7NwvrC5n21/xsGrX79l3863mwXPG9r0dDZzzTeE+YU05NTDfTshVkeMOp9qTivAWNwkF5NWw7p26E8ZGYz/BaHajaoue9RPBu6u21SSoYnRY2F+oa8uhy26+5pLxEvgr/oEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UmqLuOOxFEGtojaXfJcOiaqh4sU6caMNUutAXkDx7v8=; b=PDAtztLlKuuQhj3Xxzsky1YCvNEpKC/F6wLDv5pmJt5/371NSTwppi0VqM/ejy625MbWxhpGIuT+vGb3GlwjRHdLbMKRDpNLxbsxhhPFgVJ6e8hn1W4bcu7dTD+Kf3HMFljnfzcJZ3aMAHUesL4RybjUej0Hs3QKOYfu7GT8Mr0O4gnhZUKjQatL2BtKdzdWnMgcRiDiWplFKh+0cOQougD4rsSacm7QrM9WSrrcWYPnD0ThmPiwosamCRF1dsjcldk6ZUm4xAdaVl0SO31Y1+CLMsPFnksptWjGZIIclMaudXFYL/f19Rucsu9EEA4vPi1BjTkhdd5R+jqRtM1f7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN6PR11MB3858.namprd11.prod.outlook.com (2603:10b6:405:7e::17) by CO1PR11MB5171.namprd11.prod.outlook.com (2603:10b6:303:94::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Thu, 1 Dec 2022 06:07:58 +0000 Received: from BN6PR11MB3858.namprd11.prod.outlook.com ([fe80::bcd5:db3f:fde8:7e4]) by BN6PR11MB3858.namprd11.prod.outlook.com ([fe80::bcd5:db3f:fde8:7e4%4]) with mapi id 15.20.5857.023; Thu, 1 Dec 2022 06:07:58 +0000 From: "Naga Harish K, S V" To: "Kundapura, Ganapati" , "dev@dpdk.org" , "jerinj@marvell.com" , "Gujjar, Abhinandan S" CC: "Jayatheerthan, Jay" Subject: RE: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats Thread-Topic: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats Thread-Index: AQHZBN6lrQ4/3YMn10G2Tj1NN6Af865Yi4Kg Date: Thu, 1 Dec 2022 06:07:58 +0000 Message-ID: References: <20221130171014.1723899-1-ganapati.kundapura@intel.com> <20221130171014.1723899-2-ganapati.kundapura@intel.com> In-Reply-To: <20221130171014.1723899-2-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN6PR11MB3858:EE_|CO1PR11MB5171:EE_ x-ms-office365-filtering-correlation-id: db58fc6d-32c1-4cff-8de6-08dad3626522 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ercyvuZLqDmFIxGUhdrsgPiowVAnNEYwgtPEt7EZ4ZW0tqpIQPg12vtEhK+7ek5t9nA7Ue5RVHWMBo270fwhqTU9w54wdXITWk7vuzzMBo4bYaR3Gw5AL/c5etUyS9Y/kSfwZDjeJ0nflqcpUnPm9Ms9Xr5j6pUS6/S9Uff0WPUMD6Yd2n7MsFOckk7C3NKWXeMfIzb7rmqycY4KgPrMB7lPGMhSf7gLdGbTB/QDbwqwgYfxQ79Z9PeU5++vQ2jO68f91wNIrD82XvG8BJXxwZgzKqSZ1LvqzJEfvarJf0oIO6m/OjX/duO9exbn1Nuyawxe2Q8BuX1+5Xi/K0J7W8DUqQxHahFOMKc1dGFFC3Y39HNTJOvM6J3asP6Seu4ph4uK8N51CK3DNKKNMoTvyjlo8UyIQa+kHzHibgQ4MiBhoXOc8jlKnxO4oWrA/MHI3h1R7Rj2snapnG17vn/vKxIAgk5t9/awcfyetVvZr95eIZW5kpYviXSWXL2Z7U/y3eOjGPdnLmBr2/VbNucGA94+gloY0oq9dK1t/K9Iyjo/h//Hj3vhhQJMd4cpWcLQCymRlp/c+111UuA27NmzRbfR4jjKAAadMdKd0Wn46Vs8kC9M28Qim9aG8EklQlSEk+ymrtZ8XqEtITsKNCc6upiy7C1Qalb24rGC6U6mScX0qI0Qi1pdFJe2BV0aIGB1K76ATDjRKdeS8b+vfNBzzWjTFZAOK95Y4+l7/5j5JVdgyYJbGsYBlIDcBWyl+cZ6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB3858.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(346002)(376002)(396003)(136003)(451199015)(55016003)(38070700005)(19273905006)(86362001)(33656002)(966005)(71200400001)(53546011)(6506007)(7696005)(110136005)(9686003)(478600001)(107886003)(26005)(5660300002)(41300700001)(52536014)(8936002)(316002)(6636002)(2906002)(4326008)(66946007)(66476007)(64756008)(66556008)(8676002)(76116006)(66446008)(38100700002)(82960400001)(122000001)(186003)(83380400001)(563064011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?clB+nzjkU3mhpxoNng0PPN67aREGVNzTzzLNwWHkcFZYdgoYp2oxW8JBKouT?= =?us-ascii?Q?oIyTA4hcLl5h553xlMsKqbKTrrPBZ0or3eu0svs6KRCJRVgRzx5gwMiey2U4?= =?us-ascii?Q?f1WP5Mf7mxPKG3r6ibrlSNk/VfeWF3mGkw3AFym+heFxKrguXfBELAf45R1h?= =?us-ascii?Q?y9lN4pB9iHiSebvGXFXHMs4elAPh7Hcvp3oz1pL8kxERBJZWGhq2jCdjmxP3?= =?us-ascii?Q?NxLgrISr6irTwiiGGLkImpY4U1DhDR5B9SsqTSdp/ZI3dQjzTzqWZGQ9jn+l?= =?us-ascii?Q?uKwer/dF1Cl+A4c08Wk3meeiA8LRJCScaEHgGfZMhEa+Fy0Ede4jKlwzgK5I?= =?us-ascii?Q?uoiLwHtbpnND8iMWGE4mzrIXtZtMvjoHQmP4slRFrgzspT9u98VBURFLT7TI?= =?us-ascii?Q?RFpyQ9aV+NayCgVUKUw1UdwudxecANZyCzQv9vRKXCREpJXDhxvkuWJySroO?= =?us-ascii?Q?oQmDPFxu0KCMwuHM/E4arUAAISLj/5mMzJTuQtxGmw46bkz7HeeTH12ppBhe?= =?us-ascii?Q?qE+k+bqTlYBQhsdLLd0SDZjN9fjKzms0/6IJjvPICjBUnslND4Sg2cQYb3Cg?= =?us-ascii?Q?TVbXEGkbrk0oPL7qiOrI+MBU3J2rFZRjF3/GvX+7zglF45f4SmuR4WBK73/a?= =?us-ascii?Q?y1+CJEyU58iRCnUdMRIDPZTwZTYNNdHfw1saRyyr3LQ8HoQMYDvgwcAjZ00V?= =?us-ascii?Q?/Lqikx/PpIH4keSzSmU/ViLSCogFnl+rzKqEUTsWGlPLcys/XnbjHCNsfhpi?= =?us-ascii?Q?26vkIsiqT8T/jZA+TWrkc3S1V5RMWqWseZyI7xYWhJPS3XFFGQXWgdsFXeHW?= =?us-ascii?Q?TwU5/ky8YXIUE4gumrXnnSXk4+oCudvNFUUQNU1ovZcUOnN79tWQ2EpleRQP?= =?us-ascii?Q?dEm5QJdyMC0eZ7mZELW4Q1QWPa0Nv3M0YsRc03Z4DbGPt7aZBGpDjTEkTLUx?= =?us-ascii?Q?pd+vvYRLOd+UK9CyDYhcfU8WQmeUb+1RmaSXRFILahJKWOxJ401gTPmKKmid?= =?us-ascii?Q?isa3brTp18zye3b1ZNdkteFSH+MBfs7QazmbNJAlz6+uMD0dNw6/9QtLnF5R?= =?us-ascii?Q?AjQP0w1QY99L/Tafrfg1ks6Xixs/rxwceJtZeS/r2JueT3U5Z92jn77v8kgB?= =?us-ascii?Q?BI5uZ1eBzINu4ZQagqHt8Dwp7LWiOjMzYQUvju43sq4CW3bOWe4i0BbALAL/?= =?us-ascii?Q?XM0E5PkOKlzWaNMeuB2jnDchZbmAGxr8J6oPkWUPKCZVWWd5Qosnf51cBs8S?= =?us-ascii?Q?Z0yFrnPMhhC1HF4+ZeM3nqAqksaNQ+6Smu4LZSpWNf1442KEy944JIhSo3j0?= =?us-ascii?Q?LlDF8qOxeNyJnVjZw3/BZrP7a1uedurf19t99W4YKmEL7F9LqTMpKt57Mukl?= =?us-ascii?Q?ch2K47y6xGJZKe6wn1tbH959yCAZhpatJh8SRxBTKt3Awceeyv+8brwg7zrv?= =?us-ascii?Q?8+nRdK167P0tQICAvdOGcYtzx18mVlVxe4qkw/4VLMDcvY4u8Uk3/n4YzPwP?= =?us-ascii?Q?K8mS2h5GwYy1bDLrCoAgoaT8EtbbV5PlO/v7nQ+5zTbt0fbrrQVzDO8LvfD7?= =?us-ascii?Q?DaCp6i4V0dGBFAhCPjj4+Ki2Rh26VW7BnJ7+lTm+VydHNuDSXR6UqgwMmuNn?= =?us-ascii?Q?5A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB3858.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db58fc6d-32c1-4cff-8de6-08dad3626522 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2022 06:07:58.2896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f+Xh6spxMKmYnO4FIRVg4PxrCJ4M8kVDquzVKg8oze1SYTGW1gnnN1nFJVWVHa5OWhVhEdlbyZvcU1vivPhw41PmY9XagCR75y2xIPiHf+Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5171 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ganapti, > -----Original Message----- > From: Kundapura, Ganapati > Sent: Wednesday, November 30, 2022 10:40 PM > To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V > ; Gujjar, Abhinandan S > > Cc: Jayatheerthan, Jay > Subject: [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats As per the DPDK contribute guidelines, the subject line should use the impe= rative of the verb (like instructions to the code base). http://doc.dpdk.org/guides/contributing/patches.html Please change the subject lines for all patches in the patch set wherever i= t is required. Also is it optimizing the stats update or fixing wrong stats update? >=20 > crypto_enq_count is updated on failure to enqueue ops to cryptodev. >=20 > Updated crypto_enq_count on successful enqueue of ops to cryptodev. >=20 > Signed-off-by: Ganapati Kundapura >=20 > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > b/lib/eventdev/rte_event_crypto_adapter.c > index 1c0a22b..ef3dbe9 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -485,6 +485,9 @@ eca_enq_to_cryptodev(struct event_crypto_adapter > *adapter, struct rte_event *ev, > cdev_id, > qp_id, >=20 > &nb_enqueued); > + stats->crypto_enq_count +=3D nb_enqueued; > + n +=3D nb_enqueued; > + > /** > * If some crypto ops failed to flush to cdev and > * space for another batch is not available, stop @@ - > 495,9 +498,6 @@ eca_enq_to_cryptodev(struct event_crypto_adapter > *adapter, struct rte_event *ev, > &qp_info->cbuf))) > adapter->stop_enq_to_cryptodev =3D true; > } > - > - stats->crypto_enq_count +=3D nb_enqueued; > - n +=3D nb_enqueued; > } >=20 > return n; > -- > 2.6.4