From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EDABA0C43; Fri, 1 Oct 2021 06:42:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AD554067A; Fri, 1 Oct 2021 06:42:34 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4E73D40040 for ; Fri, 1 Oct 2021 06:42:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="212605833" X-IronPort-AV: E=Sophos;i="5.85,337,1624345200"; d="scan'208";a="212605833" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 21:42:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,337,1624345200"; d="scan'208";a="438291044" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 30 Sep 2021 21:42:31 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 21:42:31 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 21:42:30 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 21:42:30 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 21:42:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JJTOlQBa1wMwsRu4MsOHQ9dA2jDhmAAqEbCOYMA0bNDHAW2DAEw8L/L3ePBub08P3hlKttlYR5B2JMoilprqjMc++oB8VSNTtfmumowNL45fJjWbjVqXYkLL+cYZ1BpbzESbYJyRpufO32Mz9jqCm+LZdwrX1N4kWA8b9lx8hpUoypk/Znb1KDZFpZwjymHzlN/1vBOyuNI77d32bIBPw4N/aMfISWycbT8szrYBeLm8/Weo42C+UcdFux5ZWjDtXphaWHTZya3MJ0t+z3Xxlh62lQFLbtDLQEcy6oD8t1Z9VrtJtdre+T8+99M/7lNyomeWOnLJv1b/1QI5DRdfiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I7etuYF1omdyip1cqumR+J0YlZBooDTBH0xDY4eDPDg=; b=SKoyhRfH74iEOrXkkdyc90qTz4B68FSQjogYdbdO5C7wvGxeXl2aguWZt6u7N2ycfMOQEL5aEOSravvYzmC3dOFzI/kTmvj6YAYqtjNNU5Z1FQ1/aVbv4a8HZwjRPlM7Wlw3PboJyS9CTgfHdWnuX+nRtjSJK3kj8qjheREc2f0OS7drstXnkK744ouCIUphPzgPprugNEx39c5P+CmMYq6u3u/LXcfuLu4hyKi2HzJGMCDC3KApdYydrLUb8UIKr7+41GCKfi/MKjzh4EV07DUEXJ85llgYKGcEN5WZnr7dnxkmxmCYkCiuoFX4Yz1u9hxXJIJIHy8VWL3hm8fyeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7etuYF1omdyip1cqumR+J0YlZBooDTBH0xDY4eDPDg=; b=RpkwZLGJYRrOwe494SY5J0H4m+WOWqUKO5UcXIXemfAR5DpSHLnrGglGGJHF2VZvbIkSaESY0pNIkjwKzKZZITJKw1Zt2suw39aDW7FClP3P323oKkIsKgrzuwEliAyIsBTlB1HeRSMSer9umCUsIW2cFaSht23RhAgrkiNMwno= Received: from BN6PR11MB3858.namprd11.prod.outlook.com (2603:10b6:405:7e::17) by BN9PR11MB5305.namprd11.prod.outlook.com (2603:10b6:408:136::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Fri, 1 Oct 2021 04:42:29 +0000 Received: from BN6PR11MB3858.namprd11.prod.outlook.com ([fe80::7517:ca48:88e9:540d]) by BN6PR11MB3858.namprd11.prod.outlook.com ([fe80::7517:ca48:88e9:540d%6]) with mapi id 15.20.4566.017; Fri, 1 Oct 2021 04:42:29 +0000 From: "Naga Harish K, S V" To: "Kundapura, Ganapati" , "jerinjacobk@gmail.com" , "dev@dpdk.org" CC: "Jayatheerthan, Jay" Thread-Topic: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf get Thread-Index: AQHXtfsyfBA6xTEp2ESs1qcSoZf+LKu9j8iA Date: Fri, 1 Oct 2021 04:42:29 +0000 Message-ID: References: <20210930124712.424427-1-ganapati.kundapura@intel.com> <20210930130001.430924-1-ganapati.kundapura@intel.com> In-Reply-To: <20210930130001.430924-1-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b4062321-29d6-4318-9991-08d98495e021 x-ms-traffictypediagnostic: BN9PR11MB5305: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:494; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ty/S4HvnIxMbJyl07hr9M+DzNgX+MgeL2DGsAe5WP2h0CopsWOOWRpVEksNoQ8K2Rc2vKo/kqT+NweyG7Ttnm3LCYMVamkYqppZdaEHWe6go84INIBilpBn9mW0lbL8XMo+hdFLzdkWwuxLr/Tv8lZDaDMY5zW4u/xozI4yZfeAsNbTDGdb9JuVd1DzdBbJiLUjJnP9il9ib8yJGFrTynLZarI0zH7//6WJCiSqs18sfmmKBGUlr7aYUrSo7WRM/Js32Eb31E+KGb/lKRxIxLXOKXvdMf8ydVUxjh32IOJCOzq1zcQh1OX1AH/NTy1fPs4St/TaOXfuJf0MDjyGtv0GmqZxftDvBcVqN0TGm5nUWtf3k3ts+wbIjEDe6OIS6Wvv2Pc7vRM4CpbU2x7pVWIs5GUikqlZTbKSBP1rgPgPsVPlxH05uFxoaS3FV4rbE1PMXPRwfaCB7veOys18UkiihYUkQexTh4Rqsp9MuJxnV17EeBQEyypmsvK74H0xjs8qdekkt6oVnXqSjhvUNWLKHBFtHMhlhhbA5JwnBn5KkYWLg4DEfvgE/4DfX0u/eLje0ktBVw7lS6Ci5KKAvpXrGX/ea/5Ol3PdCrdMFkuW0lz/D0K/ChO5cdop5MH9tgpTy8dandz4DenphTQhSFDAIqGVsPdf+op8yNvT7s12FG0TSdXcubVDgUZPr9Tw7HPGTmn2nTTR0YT/x9eOcNQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB3858.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(122000001)(6506007)(53546011)(186003)(76116006)(38100700002)(38070700005)(110136005)(107886003)(66476007)(66556008)(316002)(66446008)(83380400001)(66946007)(64756008)(508600001)(33656002)(55236004)(2906002)(55016002)(8676002)(4326008)(7696005)(71200400001)(86362001)(52536014)(8936002)(5660300002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a82ktCI/UtkKkR2JfdR8Lhnl9fvvi9kUf7dFtmf/p0tE3LlR0CYP4b5LrIa4?= =?us-ascii?Q?1FCwqgG7E6Un4Z6bii+zdC20Dj7JhpSpronUxgNsFQqC6lxYNO1TomXkgIMV?= =?us-ascii?Q?eP1H2XEBReOIzZkBxo+RA1+K48ZZCEu88OKSKozsIyXEUWxlEdb2famlGMav?= =?us-ascii?Q?cogB5OAFXsffg2hUKwHQ9xLHXbkckUX8w45jwCzKC/vowMdZB9cJ1Q6NJoqN?= =?us-ascii?Q?MZrnz6R0uAZSCJngcLZ1NBnRfd+i4f0GVoswBfdhY4tAMi7IiZvX/8Ts/nUc?= =?us-ascii?Q?8Dwok9jGjj8xg8kB3C7+AIvsTwGYOm6zURT8DJ9fpgOw/oijgoNHZ36b2+bI?= =?us-ascii?Q?7f0ozmNqeKRTuBwttvxKzzU8dOPy9q+V9XdDMabGFXJLInqbAh2GtJzZvK1v?= =?us-ascii?Q?z90QqrlrhkMIhLvVgeoUbBjRdPjOK9fcpoXz497gOln+VHmLA6rJKuxCGwZH?= =?us-ascii?Q?13vO926HZCx4bG3xatz/yvFgC/DAxUeFpoVYXYl0RW0bEaIiH2rOxf3MixDA?= =?us-ascii?Q?V74zS7a1RhsuU4AwCJe6o8qAoLPY33nczT9BaxBKQLQQDX1/I6juKOxwbYsh?= =?us-ascii?Q?s1wq2HZA9l8GFtxFmS5cU4c0evwkL5p4/LnUauHVC11N/OJ35ErFsXQ8Jua/?= =?us-ascii?Q?3dvmeREMKYanlCVFScHeCwFm++kwYHqYalxnkVDPv44EeIJSM3tDRZaCbU/B?= =?us-ascii?Q?NRXzxfCg/oQnA4JAp+Xt7At2iKmAD3ppRgYlij15x+CR9OcvpJXW+IvabsXs?= =?us-ascii?Q?PZkwUvTU3U8QXMcQlJvKabvbZJvTVTvOHKEdFuwa8D6WYnpeRO4V+54sav2j?= =?us-ascii?Q?PCtn1FbDOTnZYBzuGyX0EfZfqeYV9VEBfsJTvcIlBOpVGHDU5EvU7bcmikVQ?= =?us-ascii?Q?DmlKPDOSs5dBPFU9432WznIjxEdzjTmdbbOrmz9aKpQaY5wOfNOIT5FpsMcx?= =?us-ascii?Q?AsnM/Tu5wqU6aRjoz9dG3X9omWw8qyiVIKzWcMIXsTV54s/HivE9Ee1rPSED?= =?us-ascii?Q?3u9kxXoMGnH0jsCZmMbaITI864L9fmXoK696R2DPAf/uDA2QD2SiMtAxC9qh?= =?us-ascii?Q?ik3Z0n9a6GfnJVIEY3Wnfgz/kGDXIKAif1ukZq6R410j34+lCyNh0DqfbkIi?= =?us-ascii?Q?XIjnC82nkM8JnYMgK5GjcYQEIw7AcIBRJs8KXz+80DFVVidmbajCFSfn8eer?= =?us-ascii?Q?VEkSBuiruAr7FOnEp2zXLPRErQV/FcNwY5g07Jdt/GVOK4EwKJNNQ4SPaek2?= =?us-ascii?Q?u2h16BhbtB/PIBCZgXDnGG3ji20G/gzNqpnU2czuy26KxZLCsv/Y8grouqSF?= =?us-ascii?Q?ulA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB3858.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4062321-29d6-4318-9991-08d98495e021 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2021 04:42:29.3148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: efbc4u6SfOBJjT5aGLezS9XMSMACk4AVTPBIS732HqqRKUVdxc8mQ+n8NWnRC5aGLJl5kMk+bwVAZ/p8/Qu121gDAxUCYirSkYNUF+n6wxU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5305 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ganapati, > -----Original Message----- > From: dev On Behalf Of Ganapati Kundapura > Sent: Thursday, September 30, 2021 6:30 PM > To: jerinjacobk@gmail.com; dev@dpdk.org > Cc: Jayatheerthan, Jay > Subject: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue con= f > get The commit message can be "fix segfault in queue conf get API" >=20 > rte_event_eth_rx_adapter_queue_conf_get() segfaults if called without > queue added to the Rx adapter. >=20 > Added check to no queues in Rx adapter and error out on being called with > no queue in Rx adapter. >=20 > Added test case to call queue conf get without queues in Rx adapter. >=20 You may need to mention the commit details which is getting fixed. > Signed-off-by: Ganapati Kundapura >=20 > --- > v2: > * Corrected typo in the comment > --- >=20 > diff --git a/app/test/test_event_eth_rx_adapter.c > b/app/test/test_event_eth_rx_adapter.c > index 13664a3..d0dc552 100644 > --- a/app/test/test_event_eth_rx_adapter.c > +++ b/app/test/test_event_eth_rx_adapter.c > @@ -751,20 +751,48 @@ static int > adapter_queue_conf(void) > { > int err; > - struct rte_event_eth_rx_adapter_queue_conf queue_conf; > + struct rte_event_eth_rx_adapter_queue_conf queue_conf =3D {0}; >=20 > - err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > TEST_DEV_ID, > + /* Case 1: queue conf get without any queues in Rx adapter */ > + err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > + TEST_ETHDEV_ID, > + 0, &queue_conf); > + TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > + > + /* Add queue to Rx adapter */ > + queue_conf.ev.queue_id =3D 0; > + queue_conf.ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC; > + queue_conf.ev.priority =3D RTE_EVENT_DEV_PRIORITY_NORMAL; > + > + err =3D rte_event_eth_rx_adapter_queue_add(TEST_INST_ID, > + TEST_ETHDEV_ID, > + 0, &queue_conf); > + TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > + > + /* Case 2: queue conf get with queue added to Rx adapter */ > + err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > + TEST_ETHDEV_ID, > 0, &queue_conf); > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); >=20 > - err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > TEST_DEV_ID, > + /* Case 3: queue conf get with invalid rx queue id */ > + err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > + TEST_ETHDEV_ID, > -1, &queue_conf); > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); >=20 > - err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > TEST_DEV_ID, > + /* Case 4: queue conf get with NULL queue conf struct */ > + err =3D rte_event_eth_rx_adapter_queue_conf_get(TEST_INST_ID, > + TEST_ETHDEV_ID, > 0, NULL); > TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); >=20 > + /* Delete queue from the Rx adapter */ > + err =3D rte_event_eth_rx_adapter_queue_del(TEST_INST_ID, > + TEST_ETHDEV_ID, > + 0); > + TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > + > return TEST_SUCCESS; > } >=20 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index 10491ca..2a84490 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -2844,12 +2844,13 @@ > rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > return -EINVAL; >=20 > dev_info =3D &rx_adapter->eth_devices[eth_dev_id]; > - queue_info =3D &dev_info->rx_queue[rx_queue_id]; > - if (!queue_info->queue_enabled) { > + if (dev_info->rx_queue =3D=3D NULL || > + !dev_info->rx_queue[rx_queue_id].queue_enabled) { > RTE_EDEV_LOG_ERR("Rx queue %u not added", > rx_queue_id); > return -EINVAL; > } >=20 > + queue_info =3D &dev_info->rx_queue[rx_queue_id]; > qi_ev =3D (struct rte_event *)&queue_info->event; >=20 > memset(queue_conf, 0, sizeof(*queue_conf)); > -- > 2.6.4