From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 248F1A04B5; Thu, 10 Sep 2020 11:24:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01F7E1C0CE; Thu, 10 Sep 2020 11:24:18 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5D9C02BA8 for ; Thu, 10 Sep 2020 11:24:17 +0200 (CEST) IronPort-SDR: xQ++WeGeXTLTC26GP+tUpSHot3mxoPCE1V7dPh/wo6TIe6O4sATp6BdoM/F/4pE7qH63v0VeL8 Y80IMZuj8tXA== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="157778871" X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="157778871" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 02:24:16 -0700 IronPort-SDR: ryryVdAIzgchaV/5IJzB/Oeh6rM+w/BpX6EYp8kz9j7iTj6Zl4L4TSe7xluf7ut2PHY/BjkZ1N 2uQXKF3baTrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="407708880" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 10 Sep 2020 02:24:16 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 10 Sep 2020 02:24:16 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 10 Sep 2020 02:24:15 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 10 Sep 2020 02:24:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kpB1569vvPv8FoAlbfcC+sD2KNkFjsieK4N+3MdkKDafYpTk1jA0Y3hm3pnJJu1I/2+xHGS1ll5a1z7HEoiR6taJAdSF8+z8muoE7rxUmo26Vr8uwuJecsEAeoQrp7QydruW3L1Xw+2gzhCLd3wB6BT/EI0fQSsGAsfMI0xcTsiseoRcDonG3oGtNO3y5RmNUxs+lmbj5KJECDkLUA6aaOfz/uWZAI4k8ZpRMkrWBf+LBg+bZiEoItgQ/nBdaDvgLgYRmqc63U3oCoo33G3/M/p7QC1SR2Pt69NSMKHSv6QFoQoLyYm4CxwlUfu0XsI+uIOIitjgZBkHM1qQwN9pkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XK4NbWAB889Pd0Lj1RXIt9iJ/adC8kmVjFuefALaazM=; b=Ds5R1B3ZyFPlPUET0UX0TKMTjI2v0f7B9fSJFr1PpF4Ir90LcBr6lAGJNMjutf/uN2pdfgFyvH/6hK1l7cipISSkHDVhpSy1YBjb7JGrZfOISxV8T9guVME4UVx3nMSuQmJKVK1Drilz8Cxr6b3qTjX3ykvM7cr+JYXLghHUvTtSC0TBqigieG3cU4msXq7JfYahSHAeRYhM8vcWTsWj4Eknlztaj+fi2gPSscLAxvXvZTWol8T07WzeQZnouxmf6ajtod65vWUB8BUqcq81XjnfoS/pFtWcMPmwJi0FZPfFm/TF9K1e5rTyj1hgf+Pc98H73D45xPC2u2DQMIPFCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XK4NbWAB889Pd0Lj1RXIt9iJ/adC8kmVjFuefALaazM=; b=vIg/gkUNfx6I36L1p556aiYZdcDcef4kdOqlClN/hPnDFEaNkRyo9LGAZX+H72Zxs3HkF2fZ29rrf3uIFomiLo9eKoJ7ZRL+fiph8cfmtGszLJgWwvzaMRaebxf+T2q4zt1CLAcM5/ryh+0bTE7jSkpous1q6OP/Y5B134lb8WI= Received: from BN6PR11MB3890.namprd11.prod.outlook.com (2603:10b6:405:7a::20) by BN6PR11MB4100.namprd11.prod.outlook.com (2603:10b6:405:7a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 10 Sep 2020 09:24:13 +0000 Received: from BN6PR11MB3890.namprd11.prod.outlook.com ([fe80::1c71:1c6b:3813:2044]) by BN6PR11MB3890.namprd11.prod.outlook.com ([fe80::1c71:1c6b:3813:2044%4]) with mapi id 15.20.3348.017; Thu, 10 Sep 2020 09:24:13 +0000 From: "Zhang, AlvinX" To: "Guo, Jia" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4] net/iavf: support outer IP hash for GTPU Thread-Index: AQHWhyKvHT9LXFRfQEeNGlpLcB1zfalhVygAgAA+UFA= Date: Thu, 10 Sep 2020 09:24:13 +0000 Message-ID: References: <20200908095015.23708-3-alvinx.zhang@intel.com> <20200910032623.38168-1-alvinx.zhang@intel.com> <8033a27f7ade4db2921d96c671a2b78f@intel.com> In-Reply-To: <8033a27f7ade4db2921d96c671a2b78f@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7ab7b880-9079-4c2c-e2f5-08d8556b4838 x-ms-traffictypediagnostic: BN6PR11MB4100: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HRIJOcf0mRRGViHc+cgsUvgDio0YffHdNhJLuRcf2xdq2Y4c0AkKwIK36qgGMo9/PPHb3sJmfuxMMzpq4czrpMHQv8W18a1SRDzpxKoSFOrkpQXc8bid6+wvsQ3MHXQNRgb4QhErl8EQgZDBCdEU4zS2QVfqOf7bOe1SgvKBG9Sat+k+VH8i5nEEmhoCzLhyZC6U0oIOITotzeCMlpi7G0G0oDx6h4ULK7/z7uQ+ccCAiJN1LFyTItWDplX5zVgt+AYWKEWEHopKybe7Cvlc8D9dGbuQN85PPJCOFEmwjxyEFuAJsoplVflWiygkNBOS x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB3890.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(86362001)(76116006)(8676002)(186003)(7696005)(5660300002)(26005)(83380400001)(2906002)(4326008)(110136005)(71200400001)(316002)(66476007)(66946007)(55016002)(66556008)(64756008)(66446008)(478600001)(52536014)(53546011)(6506007)(6636002)(33656002)(9686003)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: oOqyiWltnNDmon0E0MNEWGujxH7+iTYQMukBMgVkLvckprlPjz/6LCtCgZmTJg3ispr9Vi1/HInVknxvB1NApXWw1UvfRMLuV9H1qrKagAkJMTiLh/8ccjzBHFWdeB4F4wQ22HXlGBIrhrZc+cCan/YjqQJZFeTwg1nl6IkeVpTCaDAhiIjCeWFcz47svSRxDfaUYur1STRBfDIE6CHRdR5x0g7/NQceARWq1OMuG6d2FYV2LPzL4vBuAVVw0jVDTr5TNqQZCjaKR1X9FO/YRip6j2PeGHpxw+Os9t4U7u3jDfBQ5nEmkyDk5cdySvBxkNGN9Fv0Ynssu1w42fnj4bHeWxjEoDUeeBng38Jx5k8G+mQn9dc0XPLSPaMHu2LZC/IFhW9CdueoeMp9vY1B1Cp0CQikKuFlXbLSxIZoBQgXszpsVf70l5uHxZ61kFlPwE3MP4I+k6iakwJZvDvmdCf849QAK5lEznW2LitZdMT2pPKmbAGnFIN5dBLNbIUTa7wrqfaxOGK7s30EkHZ8Y05Safdw3VF7HjHmZqJLQW38oiAVaNmR8HQSvrebMMcwaYQNej2oHSt4lPsnHdREnuY1VucAJK1uAZbAlwo40RPc6PIxTWoZXWusRM9GHpb/MgVqVs268nH7iNWfEC6Fcg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB3890.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ab7b880-9079-4c2c-e2f5-08d8556b4838 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2020 09:24:13.3195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kyEZNTXBcNJ59dGQubwSGAlj8z7DiAoD9CaFJgoZOfy8VaDYcUKkFTtadcgfHez3rqNVOe2c8TmOlGAnfH/LsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4100 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] net/iavf: support outer IP hash for GTPU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Guojia, > -----Original Message----- > From: Guo, Jia > Sent: Thursday, September 10, 2020 1:25 PM > To: Zhang, AlvinX ; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: RE: [PATCH v4] net/iavf: support outer IP hash for GTPU >=20 >=20 > > -----Original Message----- > > From: Zhang, AlvinX > > Sent: Thursday, September 10, 2020 11:26 AM > > To: Guo, Jia ; Zhang, Qi Z > > Cc: dev@dpdk.org; Zhang, AlvinX > > Subject: [PATCH v4] net/iavf: support outer IP hash for GTPU > > > > From: Alvin Zhang > > > > Add headers for GTPU, now outer IP hash can be configured as input > > sets for GTPU packet. > > >=20 > I think this patch will not cover outer IP hash for any GTPU case, only n= one-inner > GTPU case, right? >=20 > > Signed-off-by: Alvin Zhang > > --- > > > > V2: Modify codes according to comments. > > V3: Refact all codes. > > V4: Fix compatibility issues. > > > > drivers/net/iavf/iavf_hash.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/drivers/net/iavf/iavf_hash.c > > b/drivers/net/iavf/iavf_hash.c index > > aab8b14..3ec32d9 100644 > > --- a/drivers/net/iavf/iavf_hash.c > > +++ b/drivers/net/iavf/iavf_hash.c > > @@ -132,6 +132,9 @@ struct iavf_hash_flow_cfg { > > VIRTCHNL_PROTO_HDR_PFCP, \ > > FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_PFCP_SEID), > > {BUFF_NOUSED} } > > > > +#define proto_hdr_gtpu { \ > > +VIRTCHNL_PROTO_HDR_GTPU_IP, 0, {BUFF_NOUSED} } > > + >=20 > I still not funs of set field to zero here since it should be general use= for other > case, it could specific refine to 0 when parsing pattern if need. In V1 patch I have put TEID field as input set, but the kernel driver did n= ot supported this field and returned success. That's mean the rule has been created succeed, but it did not work. >=20 > > #define TUNNEL_LEVEL_OUTER0 > > #define TUNNEL_LEVEL_INNER1 > > > > @@ -256,6 +259,14 @@ struct virtchnl_proto_hdrs ipv6_pfcp_tmplt =3D { > > TUNNEL_LEVEL_OUTER, 2, {proto_hdr_ipv6, proto_hdr_pfcp} }; > > > > +struct virtchnl_proto_hdrs outer_ipv4_udp_gtpu_tmplt =3D { > > +TUNNEL_LEVEL_OUTER, 3, {proto_hdr_ipv4, proto_hdr_udp, > > proto_hdr_gtpu} > > +}; > > + > > +struct virtchnl_proto_hdrs outer_ipv6_udp_gtpu_tmplt =3D { > > +TUNNEL_LEVEL_OUTER, 3, {proto_hdr_ipv6, proto_hdr_udp, > > proto_hdr_gtpu} > > +}; > > + > > /* rss type super set */ > > > > /* IPv4 outer */ > > @@ -348,6 +359,7 @@ struct virtchnl_proto_hdrs ipv6_pfcp_tmplt =3D { > > {iavf_pattern_eth_vlan_ipv4_udp, > > IAVF_RSS_TYPE_VLAN_IPV4_UDP,&outer_ipv4_udp_tmplt}, > > {iavf_pattern_eth_vlan_ipv4_tcp, > > IAVF_RSS_TYPE_VLAN_IPV4_TCP,&outer_ipv4_tcp_tmplt}, > > {iavf_pattern_eth_vlan_ipv4_sctp, > > IAVF_RSS_TYPE_VLAN_IPV4_SCTP,&outer_ipv4_sctp_tmplt}, > > +{iavf_pattern_eth_ipv4_gtpu,ETH_RSS_IPV4, > > &outer_ipv4_udp_gtpu_tmplt}, >=20 > There is also a question the same as the other mail loop of GTPC, should = it be > supper set here? As above, if user really set ETH_RSS_GTPU as input set, the rule will be cr= eated succeed, but it don't work. >=20 > > {iavf_pattern_eth_ipv4_gtpu_ipv4, > > IAVF_RSS_TYPE_GTPU_IPV4,&inner_ipv4_tmplt}, > > {iavf_pattern_eth_ipv4_gtpu_ipv4_udp, > > IAVF_RSS_TYPE_GTPU_IPV4_UDP,&inner_ipv4_udp_tmplt}, > > {iavf_pattern_eth_ipv4_gtpu_ipv4_tcp, > > IAVF_RSS_TYPE_GTPU_IPV4_TCP,&inner_ipv4_tcp_tmplt}, > > @@ -374,6 +386,7 @@ struct virtchnl_proto_hdrs ipv6_pfcp_tmplt =3D { > > {iavf_pattern_eth_vlan_ipv6_udp, > > IAVF_RSS_TYPE_VLAN_IPV6_UDP,&outer_ipv6_udp_tmplt}, > > {iavf_pattern_eth_vlan_ipv6_tcp, > > IAVF_RSS_TYPE_VLAN_IPV6_TCP,&outer_ipv6_tcp_tmplt}, > > {iavf_pattern_eth_vlan_ipv6_sctp, > > IAVF_RSS_TYPE_VLAN_IPV6_SCTP,&outer_ipv6_sctp_tmplt}, > > +{iavf_pattern_eth_ipv6_gtpu,ETH_RSS_IPV6, > > &outer_ipv6_udp_gtpu_tmplt}, > > {iavf_pattern_eth_ipv4_gtpu_ipv6, > > IAVF_RSS_TYPE_GTPU_IPV6,&inner_ipv6_tmplt}, > > {iavf_pattern_eth_ipv4_gtpu_ipv6_udp, > > IAVF_RSS_TYPE_GTPU_IPV6_UDP,&inner_ipv6_udp_tmplt}, > > {iavf_pattern_eth_ipv4_gtpu_ipv6_tcp, > > IAVF_RSS_TYPE_GTPU_IPV6_TCP,&inner_ipv6_tcp_tmplt}, > > -- > > 1.8.3.1 >=20