From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3F83A0547; Wed, 21 Apr 2021 15:03:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A403841AE3; Wed, 21 Apr 2021 15:03:38 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) by mails.dpdk.org (Postfix) with ESMTP id B82FC410F9 for ; Wed, 21 Apr 2021 15:03:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KY3ORMO3Q4GVhL/iygVVylQsokm/jEkr8tBFqA7nGYienW7eehSMc3A8M61JJxOsxB7p3LzP5JrOrW2jlx95A/69NEPYbAwYufNHD2FebUxRR41zFpP+sxtYcyyzctczuTBAt7t6VCoI9/+9EHZ5MfY9zTlKPARP8XrdDyKtXLsgHmpC2vVHwaeb+XubI9R6u7/DSNKfunh1swHekF26qxx+p96PcHjYMUsptYAnYl723g+1DTpO4Ij0zhYSGHG0pfCpCf54elki7QO3zGr1z2LB4zYnRL8QlEWENsbylegWraWM9MDabyv3ugIWIrgSp5g94em3F58BfPWxvIdZCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Sci+odnFu0KWY/PhhJOA0pt8UUW1yZal4kpKVJoJPU=; b=cY2JjyRTCCwu3aR9Twbid6DNmAZDBP2YwHHyZrrVBVfMi0Us2jJg/9NeqrJSdhbLRvrCQHQATVTEuSUjvNGgnX5OWsnP3oKXg1UiaF3LtIKPV9f7BZZVrM4QqLQz7+baxt1V5ZUOg0owg81xavjnKVCn7jWBUWcYXXRdOWcmBwfy/WVAyHjI1RIozpy98USrtaTEOYVJDWGY6PqEPERjrFUSP7ZqGVjl3B8L1pozqJDZBIfTbtpqr5lUrA3ZUF6ev8wWDnNVCupvyTuDawNAR2ggCV1GIb1/lFy8H2ZPVdjBT1zsmhgO+5Vh3M3L1CkWQvg/CJWmoTgAT8lAimutQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Sci+odnFu0KWY/PhhJOA0pt8UUW1yZal4kpKVJoJPU=; b=LR52lVsgr8zDPc/Hgzm9H+djQ7ZpiqdoQ+9FW8MD3LCFgPn4kVPuC4godgrlYY3ubxlmIqFOt77wQHd+RASF+z1N5XDIKQs1lxeoYM9FdeHKeuSGP0CMuta6ZdpzthsL2Id4xIR61XFDz4v5NM1xt2n+U9au13u1KQXc0tR86fbK3/lWoMoJ9hgN+ot0kNJ1ARtH/+GWU1oEL4wFq2B2FzxE/nGsoAnb6ZtDIQpcr/AHLWGWD5nBO5OtArdlktuIVXncBqo6EiY30aAhfSMzDflwxY0DWDwYiUETC4eNwSzBkZrA5of4wU7RIGjmilkAs5fJ9GpegvuM2QM+JAcmmA== Received: from BN6PR12MB1459.namprd12.prod.outlook.com (2603:10b6:405:e::8) by BN6PR12MB1940.namprd12.prod.outlook.com (2603:10b6:404:fd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Wed, 21 Apr 2021 13:03:32 +0000 Received: from BN6PR12MB1459.namprd12.prod.outlook.com ([fe80::54d0:8edb:c50e:6193]) by BN6PR12MB1459.namprd12.prod.outlook.com ([fe80::54d0:8edb:c50e:6193%12]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 13:03:31 +0000 From: Ali Alnubani To: Aaron Conole CC: NBU-Contact-Thomas Monjalon , Cristian Dumitrescu , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args Thread-Index: AQHXLym+aq0Z5K09nE+uPLkjVSohy6q94I+AgADGVRCAAFbB4oAAAHGw Date: Wed, 21 Apr 2021 13:03:31 +0000 Message-ID: References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <20210411232338.4005-2-cristian.dumitrescu@intel.com> <2003889.D9zfWNbQnx@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [217.111.27.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d5a06e8-d9ef-4552-de50-08d904c5dd66 x-ms-traffictypediagnostic: BN6PR12MB1940: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:1107; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qr8/P0iW/PFdFWSTPwBaWq2Nkc7QJ7YrcfKwb9+oO3flrw61ZvfVB9yWwcNSnwhUO8Q1vGOjURWOdZyYjT6StzmoX4kJAibKZsRWdqL8CIL5zXPxAm3lBcG60YgzGaRR+0SzWc/aA3Vd+f0+QKbOJ8EXAmQmAX88C3ytwE4rAO7R1zB8uNnE/S2UirfvTulMPZw6THSi07ME1IIADSdaO76iEDOqOD9B+ZIE5kYlm9sPj8MFhe8g6NviDpLXJByjPpPympSQhbbj8jQsGB72xrgDpRBXXptcN+2pQF22aOs7SR7XBTIgX56M73lEfvASyPN64RBNhBfDtgCzpd8YM9QRIDpFwG1+ERw3F6YnpVU0Oslm/9Ahr2Qexc3fHN4ZUNBgW1Lr0hqon/AcTtJDPBOFpyJsThR3AeShp1CZi6rbNlwLYNKrdN7dsqfgB9bq8/3edz9V27sB5OGfRzYbi7pRXOva6pKWF+pdnuvee4qF1ExNgqBkfLhxdhZwXRJEZZmbPwRQbted/bNpfbDBNdWFABxl/lSOhvQhifrQiaGIhtJjCE9UfOinmzvG/qhSIksqqmRHwLByN9Jg+OqxQgpUUoPkJoJx5Pvr3F5uY8jz+zl4YWayFH7Cj2ldIR0mGpIwz+3Ak8MGkT9JtKCd23DwkClC4swheGHsZzG6JMbAe/OcK4VGCYnMXn2CEoyk x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR12MB1459.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(8676002)(8936002)(54906003)(2906002)(55016002)(38100700002)(33656002)(5660300002)(52536014)(66476007)(66556008)(76116006)(64756008)(122000001)(9686003)(186003)(316002)(26005)(4326008)(6916009)(6506007)(71200400001)(53546011)(55236004)(83380400001)(966005)(478600001)(66446008)(86362001)(66946007)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?nLWu1IEtdRLNRKrTBLI6P9oqBtE8oR3hO3+TOrcppr2BZIYGI6kCra1FlMDe?= =?us-ascii?Q?jdF3Kp+eOWYTeoBLrs14utPLWVp+LkT3U/4SFIpieUXAnxnsG3pQa+k0yPv5?= =?us-ascii?Q?hDUizNtIVmPt3tW4rsFqCWM/eo6lv6UUNdyhu3YgPzjgsiZoYCFJjIqPh5Vh?= =?us-ascii?Q?UC44a+P2XBj0D75dM6aRy+9+i3XuLwun4eEIA/KO2dqr28QlKDdOUuUgD2P4?= =?us-ascii?Q?Xa47ohc3pe58VfMnZlL30bT278vpY6Ghz36xCHwrjT/7kwBIKU7BGE3WTPjK?= =?us-ascii?Q?z2A7uMad0QtwgadsCYuVv0yP+9F8zcsN9X/T8nvuXXDrx6m5FdHc/xe75opR?= =?us-ascii?Q?yR3gPcx8tEdhujRyw9OTVGx5532i4sN1WZcddt/nylixtIBNCKQwQ5pvi7L/?= =?us-ascii?Q?hO5Mb/sr2j4HjcxmlXjPS9fZOzv6e9HFpuoCFxLXp816SOovWAbG1NxT9tgW?= =?us-ascii?Q?g2o8ize1P5lriqIYFf84zm9Ujg0/wHZXQ89y6ts4NmBid7qb6SU4F3tm/If6?= =?us-ascii?Q?dV4qO2Syz8YLukpPdTr7fzIM2MJcaqsydtPmtpNKatEQ0tO3ELY3kzNViHip?= =?us-ascii?Q?0hNzmj8BhBgynyKYJzXs7q3fn1psrezhH+9hZpRivVHEFzvRSiaA3wHS5Dic?= =?us-ascii?Q?8Ktnq8vUA/OE5AgUbh/borJ41dZS9vsqpSbaufnW4B8IplvBBIBRw87SJeMC?= =?us-ascii?Q?Akt2eHIo3Pi38unJWNXJCuV+dDI9mK1/YBdlD52XBbkfTlhvqwsC6RceNLqj?= =?us-ascii?Q?JfSqRgm4+uVLkgZd+F/vfpxK2bjxh+5h8w2sqHaQ/3f0dqRkECyHLR6QKLUS?= =?us-ascii?Q?6iPtIuOiqO9AdtrZnKdUTCHB81s5WD5fW5v7lbrkniN2BILjmtWndtcX1WaU?= =?us-ascii?Q?tkKffgEbVivZtOL8IHnp/iKQcJ6MJCJooH+pTYdWtwAgjt9PMAzC0ehua/6b?= =?us-ascii?Q?TBP/BGWXZTiJBqCUh8112DKxwSPuvpgTIN+DPoTtqKdWLV0lwiDavFPYwYUd?= =?us-ascii?Q?hNJUpKO27GZ7nQYwCV28DD8Sm8SbGPcOYuBaDp/Ga2OFa05QzOB9s0sq9CvE?= =?us-ascii?Q?9jnGSX4kHr7Gzt54dQlbLGZTlYdKbRsb1jtFt+1V6NIQZGIa3rGoGKRxwmYQ?= =?us-ascii?Q?p2KU/934L9Zgeqn6oLogLSpNY26TtxdtPK6cikGbyDDT4hX4Vioe3VEsgWTo?= =?us-ascii?Q?TdFy97WeX+YBdQOo8cKviAIx+oGhLshU189gfc0GsdlF0707bqt073yBXppJ?= =?us-ascii?Q?+OSBFZJ9pp+qwb29J8FTwZQrJKpv6hW9tQYnZ53aj4GMTkY5x+5JzwvJR0E7?= =?us-ascii?Q?fseBdNqxWNpLX/aUeeHJE3w2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR12MB1459.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d5a06e8-d9ef-4552-de50-08d904c5dd66 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 13:03:31.8260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qely3kcBqxxqGbPYN4dLs5x5JaoKb5S/qJA3B3ZkPkZstzn6ajiZ/KTK54dkxbPl4EMv/M/xlVQgltnCm8DZ/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1940 Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Aaron Conole > Sent: Wednesday, April 21, 2021 3:57 PM > To: Ali Alnubani > Cc: NBU-Contact-Thomas Monjalon ; Cristian > Dumitrescu ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args >=20 > Ali Alnubani writes: >=20 > > Hi, > > > >> -----Original Message----- > >> From: dev On Behalf Of Thomas Monjalon > >> Sent: Tuesday, April 20, 2021 10:58 PM > >> To: Cristian Dumitrescu > >> Cc: dev@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > >> action args > >> > >> 12/04/2021 01:23, Cristian Dumitrescu: > >> > Each table entry is made up of match fields and action data, with th= e > >> > latter made up of the action ID and the action arguments. The approa= ch > >> > of having the user specify explicitly the endianness of the action > >> > arguments is difficult to be picked up by P4 compilers, as the P4 > >> > compiler is generally unaware about this aspect. > >> > > >> > This commit introduces the auto-detection of the endianness of the > >> > action arguments by examining the endianness of the their destinatio= n: > >> > network byte order (NBO) when they get copied to headers and host > byte > >> > order (HBO) when they get copied to packet meta-data or mailboxes. > >> > > >> > The endianness specification of each action argument as part of the > >> > rule specification, e.g. H(...) and N(...) is removed from the rule > >> > file and auto-detected based on their destination. The DMA instructi= on > >> > scope is made internal, so mov instructions need to be used. The > >> > pattern of transferring complete headers from table entry action arg= s > >> > to headers is detected, and the associated set of mov instructions > >> > plus header validate is internally detected and replaced with the > >> > internal-only DMA instruction to preserve performance. > >> > > >> > Signed-off-by: Cristian Dumitrescu > >> > >> Series applied, thanks > >> > >> > > > > I believe this patchset is causing the build failures in > https://bugs.dpdk.org/show_bug.cgi?id=3D683. >=20 > Where do you see those build errors? Compiler version, etc? For example= : >=20 > https://github.com/ovsrobot/dpdk/actions/runs/767327010 >=20 > This build was successful after rerunning with the prerequisite patch > applied to mainline. I am concerned why the CI didn't catch this. >=20 >From the ticket: > OS: CentOS 7.9.2009 > gcc: 4.8.5 > meson: 0.55.1 > ninja-build: 1.10.2 The build errors don't reproduce in Ubuntu 18.04. - Ali