From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30D20A0547; Wed, 21 Apr 2021 16:24:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AD3541AC8; Wed, 21 Apr 2021 16:24:41 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2044.outbound.protection.outlook.com [40.107.244.44]) by mails.dpdk.org (Postfix) with ESMTP id 4A22B410F9 for <dev@dpdk.org>; Wed, 21 Apr 2021 16:24:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=crW8Z14SvCmMan83hgfLcia2vFJo8EYvyIhm2fllZpAm/Y5AxbNFAYbahTZKxlB4kdBKXYvJWPcNfCq5sEVJpUwDy1dXeYpGd/zUwZdX8oLit8oZ06xtQ0AICM9JXbEjzCWZ9S/jdU5LA8sjYv/HzlMbhwt5BDSpiqP4V7J1KxKRDM4HdUvQ6aQvGLzVJVo/sZ91ESOBCzodjvCK7OOAwuLlulgEROdAr1RYCEDA/+TYQHWcyCw0DriDllkZJK04pSUtR0bVEK70+zTArLXo+HavyRFKJJo0o55SYhvqEPGByn4jCuTM6O8prbbBRuXfxhT21J1OF0dR/fWgagyhwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6WKLaQaH45q+cA7A809c9ly9/IyVkDHSLoNFnbbXZtk=; b=AIz4gj9/ywZPYNplGZ4avObEj2mOL1mOdyn4tMSVgQQquKqbB1bzSzU6bNCEIAb/QES2CVZjInhz6xny5430pwlWbUctAqhJeY+2od7XeSrsMrXYN/Qa0ImZt0XmmuaMQpz07mGWN/din1nE+yb1Tgt/+kpuRzwMC5z/OLhrWhbr3e07H/ldZR9tVf2UzAnL+tNcIPaZAkFoWL4Rbl6lZIwQCH+ykXxnugKVSnk+o1TaafzqEffclOI/qnxenZVMOI68jXXQA6aAFzNeUm0GclX5KzzSiCk7PsjdXWSltmPtcnyuHKhD4MOxxyCUwDs2sECTm8laDd7p5uwBK5Z3Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6WKLaQaH45q+cA7A809c9ly9/IyVkDHSLoNFnbbXZtk=; b=DwyE9LPXrMkXl0jErsFTxy/CASMNPt6fRXHe7UUKkVf8y0viHBoz5xn7bxRa2NweQt3XNIXHDGH2A6QsQavavJvzO6QuhZIerx6A9TGqbciYS+66UlmN509dXnQ5IOYlD/dguSb0KffxjAUqgfSj1vF3lwa6EFNlvsq3KPhT+2PvFY8Pw+VC8uXrc1vPJpYOWXTBegZYiATTmthlKHIvG1zih/ed8QOkddRYmb3JLjzaAmHNlbVO2ZIrjgFOTKN+biI3chO85H1y0jfbkrO29cyVRvGns2rmEK2eQIkTclXGKjpg37dn1icgBJ9Ag+Kj7LT11v7stj9cuA7uk0mrfg== Received: from BN6PR12MB1459.namprd12.prod.outlook.com (2603:10b6:405:e::8) by BN8PR12MB2977.namprd12.prod.outlook.com (2603:10b6:408:4a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Wed, 21 Apr 2021 14:24:37 +0000 Received: from BN6PR12MB1459.namprd12.prod.outlook.com ([fe80::54d0:8edb:c50e:6193]) by BN6PR12MB1459.namprd12.prod.outlook.com ([fe80::54d0:8edb:c50e:6193%12]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 14:24:37 +0000 From: Ali Alnubani <alialnu@nvidia.com> To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, Aaron Conole <aconole@redhat.com> Thread-Topic: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args Thread-Index: AQHXLym+aq0Z5K09nE+uPLkjVSohy6q94I+AgADGVRCAAGeSAIAAAHKw Date: Wed, 21 Apr 2021 14:24:37 +0000 Message-ID: <BN6PR12MB1459ABE9B91285C10FE387C7DA479@BN6PR12MB1459.namprd12.prod.outlook.com> References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <20210411232338.4005-2-cristian.dumitrescu@intel.com> <2003889.D9zfWNbQnx@thomas> <MWHPR12MB1472E652BD96C655CA1D0420DA479@MWHPR12MB1472.namprd12.prod.outlook.com> <DM6PR11MB27962257F240918DE54A0EB1EB479@DM6PR11MB2796.namprd11.prod.outlook.com> In-Reply-To: <DM6PR11MB27962257F240918DE54A0EB1EB479@DM6PR11MB2796.namprd11.prod.outlook.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [217.111.27.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4f72da03-a05c-4c1b-fb90-08d904d131ad x-ms-traffictypediagnostic: BN8PR12MB2977: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: <BN8PR12MB2977819BBDFD7DAEEA55534CDA479@BN8PR12MB2977.namprd12.prod.outlook.com> x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s8wOhkHkSNmJEyshvkyrd79/uD1BNI3WOWct4D3uQC5GFcmQliVOwrc+01scias9eyj2BNljV6SQ4+srOFEisn+IL8E2rELaBklX8lrOu5Nb62S8ga5Cfn2eIVU6moiF7q+mi4Qg906TDtKvl2phSG/Yb9rPEa4VHxd3CCT6QMjuxjzJ6neUyZqO/c3Cby9xSupcDhgcczhnvptVKrTATcAxZJPWnIVnk8cj2ePZuLeu3IcaJ4dPuamS0wogV1xYzABmKWIEFKBWuwt7SdGliA3lE1HIDWk1pJG8WWbkaod5HfxMWOYrIwus0ifQRCWnZGUHsJhkl8JB1cTPeMLysxwX9TrN0gR+JEIfqKOp7j97CifM5n7HHxZ9MunUDjLrVlUJL7Qjy/Pp0dxDB9+JiKYgyu4rn6f5UqkXrnJKb9jjlBR4eVMCRWxT60x/Q3kC4zWADZ+lC4yiEqgAikmz76L9IU48CUDOVzNxJ5LTLm8xvXVlGw+fOhpGszfMWwQH55vdwE+ZMltOJU3A8a764GXNiWGgApoIfvg2Kv/51LdwKNjnyI7HcIjaqs2IcoHB3mfsmmNjyYx5nWgfxFYYhBDGL5Hge0EUs2wO3eOoPposL9qtJ4VXc1J5Rr+hkPhBfNDIzr0SpZi0WJl69fifZsJAOQqv5ByCdQfHvA30jkaIjKaMaFZv4fm5+ngI9M1J x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR12MB1459.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(39860400002)(366004)(346002)(316002)(5660300002)(122000001)(86362001)(186003)(6916009)(4326008)(26005)(2906002)(38100700002)(66556008)(66446008)(66946007)(64756008)(54906003)(66476007)(478600001)(76116006)(52536014)(8676002)(966005)(7696005)(55016002)(9686003)(33656002)(55236004)(83380400001)(53546011)(6506007)(8936002)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?dWGdL6vxaNkjo44Ws5BvBnPq1kQXLjucYGjmpSyB/XGh1CiWWmURjmo+Nw5y?= =?us-ascii?Q?c/0Tryf8zmWJRxx/qHTi8vsgdjQFm+tE55xJWr5q38/D/Bt7uiUEitdRB/ql?= =?us-ascii?Q?KNJ50pBeX9OxVeeyzX63/hi2oxXUW44cwk5jMka4QViYTNSGHjJ2I1xe22wH?= =?us-ascii?Q?lXQ6IPHBMwxREvtkb5vs+H2KvCcDXDPhX8LhfQCwKoqxF7VrftauMoi7iV95?= =?us-ascii?Q?SBlYyecZ0tOL1b+G4k70P6MhvZ5kgR5u2teepx7c0c2GKBvtWNFknuVv08zu?= =?us-ascii?Q?P0VvpqZDrxbXe8B/G6DYqrHSRsBAOzVTEcYvhb9dbckxIbX+eNuQPf06lt6V?= =?us-ascii?Q?3FSQ4cs2k7tOSXJktX8I+y0gVn8DRMmKMB57hhxKoEbJC6u2+tkUbl6eUD8h?= =?us-ascii?Q?35INCMcbKG18EgHK1vRjnm0HTKcHkeaqT6PCAA9FieIkHFhWuAuYqa0+QP+m?= =?us-ascii?Q?6Z55tmsVFUjKdTM/C9EdC5MmFJM9jmYYNelELweRMMDR8PkigfYkmAxH9uSF?= =?us-ascii?Q?K+UYNWtNX4nuLFIebfyloN3JCJNRF7Sw/HfgAX88YQCnlq4NBLdFdpCL4/RY?= =?us-ascii?Q?tCDdXVfiOuHizEkbwhBCoOprqW3EvY0zIJ+wD9rZ9rJgCEaoeUKvCKdixJBQ?= =?us-ascii?Q?5QxLMd3OK1iiXmmuTKFWEIP8ueHr3xs/CYM5jpWyvTXFXKY9lSXDNfwQJ7wL?= =?us-ascii?Q?ni5epMjIZYOr0GFI7b3nUTevcvXC2D5Twe8x9yE0QUOi4XEe3yk8VBQhAvoW?= =?us-ascii?Q?+kayI0aPpRWZYhwrKhGDaj3P5y8IydumEbNXdycq2gQC1BnYXsfGBWIE2zoh?= =?us-ascii?Q?NAKZVxmB3l4e76SC9Uky/KANwWnGuy8vHNGz5jNwJ299LyqN5OvYJvvxhdw3?= =?us-ascii?Q?pTVpe28MqR52YSCXJabCqmVZES3cE+C76/jyLIEZx+pn2kctZIYzMw1XPX5M?= =?us-ascii?Q?Z7WFzwzURHpJB1wH9qFH2mO490qerSG9xJ9z0mfuMZYg3zSeQDz1bzgj+8jc?= =?us-ascii?Q?XsAxMvJKwzVpf0m4M6jw9TTbsqiNTgO14u91LPG2mdMsfCsEK5kd0Ih9AZNq?= =?us-ascii?Q?qa/JTVJBzKIgNELUCrR4fDaZV/1IB5a5QPKDWCp+LQsRSg85xRVxZ+B3Hhrd?= =?us-ascii?Q?wV+u+gNYURW3Bhy09NhrBvlpcY1wdX9GjIZQcXFTc+3nVoFGsan9S6QPXkEY?= =?us-ascii?Q?PJLc/FRYLrelgS0CxzyGL2WmG+MCNde74QimOe+pWt9GIWR79DIwiH7uWAEt?= =?us-ascii?Q?7/CjbFzS+r5ixvY3KT2Q8fdhC5IlcsAqoKxxsUfWfUOAKTvpmcCEv/zydspw?= =?us-ascii?Q?0KPSs0DYIwGxTCUWJPNrkg3T?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR12MB1459.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f72da03-a05c-4c1b-fb90-08d904d131ad X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 14:24:37.6468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1FD1nFntV3KsgSyIk045QNtosV1zUs0t91dyTzH9ZEm6vWA+5w6qwL3VBV1tOzhstzpP4PAeZv1O7FNhDuLOUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2977 Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Cristian, > -----Original Message----- > From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Sent: Wednesday, April 21, 2021 4:58 PM > To: Ali Alnubani <alialnu@nvidia.com>; NBU-Contact-Thomas Monjalon > <thomas@monjalon.net>; Aaron Conole <aconole@redhat.com> > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args >=20 >=20 >=20 > > -----Original Message----- > > From: Ali Alnubani <alialnu@nvidia.com> > > Sent: Wednesday, April 21, 2021 8:50 AM > > To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Dumitrescu, > > Cristian <cristian.dumitrescu@intel.com>; Aaron Conole > > <aconole@redhat.com> > > Cc: dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > > action args > > > > Hi, > > > > > -----Original Message----- > > > From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon > > > Sent: Tuesday, April 20, 2021 10:58 PM > > > To: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness o= f > > > action args > > > > > > 12/04/2021 01:23, Cristian Dumitrescu: > > > > Each table entry is made up of match fields and action data, with t= he > > > > latter made up of the action ID and the action arguments. The appro= ach > > > > of having the user specify explicitly the endianness of the action > > > > arguments is difficult to be picked up by P4 compilers, as the P4 > > > > compiler is generally unaware about this aspect. > > > > > > > > This commit introduces the auto-detection of the endianness of the > > > > action arguments by examining the endianness of the their destinati= on: > > > > network byte order (NBO) when they get copied to headers and host > > byte > > > > order (HBO) when they get copied to packet meta-data or mailboxes. > > > > > > > > The endianness specification of each action argument as part of the > > > > rule specification, e.g. H(...) and N(...) is removed from the rule > > > > file and auto-detected based on their destination. The DMA instruct= ion > > > > scope is made internal, so mov instructions need to be used. The > > > > pattern of transferring complete headers from table entry action ar= gs > > > > to headers is detected, and the associated set of mov instructions > > > > plus header validate is internally detected and replaced with the > > > > internal-only DMA instruction to preserve performance. > > > > > > > > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > > > > > > Series applied, thanks > > > > > > > > > > I believe this patchset is causing the build failures in > > https://bugs.dpdk.org/show_bug.cgi?id=3D683. > > > > Regards, > > Ali >=20 > Hi Ali, >=20 > I checked this issue and here are my findings: >=20 > 1. The compiler warnings are NOT caused by this patch, all of them are > triggered by older code. Git-bisect pointed to this patch. The errors didn't reproduce without it. > 2. Why were they not triggered before? Either this is the first time Cent= OS 7 > is run or the compiler has a mind of its own (my vote goes to the former)= . The check ci/iol-testing contains an image with gcc 4.8.5 (RHEL 7), and I s= ee now that it reproduced the errors in recent patches. See the failing bui= ld check in https://lab.dpdk.org/results/dashboard/patchsets/16682/ (under = dpdk_meson_compile). > 3. These are all 100% fake issues that are probably triggered by the old = GCC > version from CentOS 7. >=20 > I just sent a patch now (you are copied on it) with some harmless local > variable initializations in the hope it will stop these warnings on CentO= S 7. As I > don't have access to a CentOS 7 machine, can you please confirm whether > the warnings are fixed? >=20 I submitted a patch and updated the status of the Bugzilla ticket a few hou= rs ago. See https://bugs.dpdk.org/show_bug.cgi?id=3D683#c4. > As the warnings are triggered selectively for just more occurrences of a > common pattern as opposed to all occurrences, I am trying to fix all > occurrences of this pattern in order to prevent the same warnings showing > up again. >=20 I only initialized occurrences of dst_struct_id and src_struct_id to resolv= e it though, maybe rebase and update your patch if you think initializing t= he rest is necessary? Thanks, Ali