From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A07DA046B for ; Thu, 25 Jul 2019 18:51:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E2FF1C395; Thu, 25 Jul 2019 18:51:51 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 186671C377 for ; Thu, 25 Jul 2019 18:51:49 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6PG0INN010563; Thu, 25 Jul 2019 09:51:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=AsIewQn/GNGwGrZaAZtIFYZvpSSNNNGnDDzAVbdqxOA=; b=qEByXV37YoNH1gJGfNHgDg4FUEBW08xzAaGz4h0pZIqYOlvQ2J6H6Aqw7aSbwI2HaKhU oy3VGNCrqfTGpT9lHimflJESYW2k5CcRjdwLC6balyhayCGEQ7kH2cj6mDa16u3hXlj/ xb1dlstkVfjQSDGKwxPTULCM/VTJ5BC8hQd7tR0aCimynmPqqOsRn+ow71+460U1J9Pp gNKCxhbpwtJ/4ZhHpV3rYE80hDA64bLqMDKmaLe9hWSdeONZZ/Zor/vwkLawOse9UO27 YLfb7ts4cve60XVFcAFN6ETFgKTkS2XuUUj7D/QzdQKKVj+rF/0RC8j+EctJU1yfNHiN BA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2tx62527ws-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 25 Jul 2019 09:51:49 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 25 Jul 2019 09:51:47 -0700 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.52) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 25 Jul 2019 09:51:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VVWiZ1dUXDrDDLe9RrASNBt+eRCKIa0Oz6ObZHAsFPAMvV8iLanCyfAngV0Rc1vHOu1CJWzY0UJmbbxnsE+WdZEGUk9Najxrl3lY7h6vY/bc/db7sYI94oWidDPTeWRi3m54QQlS0EUnfbKZ9PeeQx7Ku6Wqz3ZPVBw11Z2mOEPbUP6dC3NnmJTvd0JDaL+WC6gCLF2s7qIX6MwMDeENxvDkBhezrdxIFmy5hfJCWsHTby/d1/seGjMmIOAVApsxCtG/f7a/db9hHpQUW4Z7nMUJ03VWFrmbQZfgd3oCyo1tUkdFcrCtoi1EkDoHOS8VxNnCR8q5iN7Nn07FJ1PKqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AsIewQn/GNGwGrZaAZtIFYZvpSSNNNGnDDzAVbdqxOA=; b=cDOYb2AOoJ028PK4j+lOlAc/BWJSmGlxI/F/S04qiCda3WPIa+EavDIMcrD5qhaSm+xjxS2I8Ixazn6vvhxgVtHzcwvsGcLWggiFSuFFaWr9ltpKiBa4UNT/Ia9Yk1mDXMtY8ERnY7eu96BCulYhVFChd64T+XkmAS6+7+ZOWBp5OCg9veAvhV7guUHut0Kl9b1YO6XKa5qE7CSCEbzi0cwDjEUO1wjF+uMTyJKJmC1ip3JROqDSKYCwKK6W4HTT1wqbgpy+yBD9icWiPYVqmuUWWVmhET473ow69M6cld2Sytg0LVqpndPgMqL6HVjYL53Cc8LwTJj8P6yTT0nLug== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AsIewQn/GNGwGrZaAZtIFYZvpSSNNNGnDDzAVbdqxOA=; b=Jb/AJloewW9IZjl1mB5P+mdjRJexuMzNvv45Tz/u7fwCLU61JEgy23zofsz5OoooUNDrAmECgbJ+WhWaGZ11ViPfxeoWtMKBI1Of4AundxEN4bdkeD+XMSk9HcQTwGfCyLkZlCTHUTkwybz3erLU0v3PSJ/EuCIyvvFnMfHzXoI= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB2017.namprd18.prod.outlook.com (10.161.157.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Thu, 25 Jul 2019 16:51:44 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b9c4:1fd1:a47e:cd72%6]) with mapi id 15.20.2094.017; Thu, 25 Jul 2019 16:51:44 +0000 From: Shally Verma To: "Kusztal, ArkadiuszX" , "Nowak, DamianX" , "dev@dpdk.org" CC: "Trahe, Fiona" , Ayuj Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Anoob Joseph , "Narayana Prasad Raju Athreya" Thread-Topic: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto Thread-Index: AQHU5IKFVp7P4HphXkK8vll685vq76bbkpHggAApGCCAAA1c8IAABSkAgAB6QkA= Date: Thu, 25 Jul 2019 16:51:44 +0000 Message-ID: References: <20190326141549.16125-1-damianx.nowak@intel.com> <20190327094521.16414-1-damianx.nowak@intel.com> <20190327094521.16414-2-damianx.nowak@intel.com> <06EE24DD0B19E248B53F6DC8657831551B282BC2@hasmsx109.ger.corp.intel.com> <06EE24DD0B19E248B53F6DC8657831551B282C78@hasmsx109.ger.corp.intel.com> In-Reply-To: <06EE24DD0B19E248B53F6DC8657831551B282C78@hasmsx109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8518ce4b-7af1-43d8-3f74-08d711205fe8 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN6PR1801MB2017; x-ms-traffictypediagnostic: BN6PR1801MB2017: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(346002)(39850400004)(396003)(376002)(43544003)(199004)(189003)(13464003)(52536014)(316002)(6246003)(33656002)(7696005)(81156014)(81166006)(110136005)(107886003)(53936002)(66556008)(66476007)(64756008)(25786009)(66066001)(74316002)(66446008)(8936002)(66946007)(68736007)(256004)(14444005)(71190400001)(71200400001)(2501003)(54906003)(305945005)(2906002)(55016002)(4326008)(76116006)(99286004)(6116002)(478600001)(9686003)(186003)(446003)(486006)(229853002)(86362001)(26005)(476003)(55236004)(3846002)(102836004)(6506007)(14454004)(6436002)(53546011)(5660300002)(11346002)(76176011)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB2017; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: hku9bbsnTiOuG7Q69nxLMfVQCI/fYnrkjDpQA09A+IDQcMd0rXppx1yDYewETPlao8MjjMdHq17fp1KLktw4ZOnyv0T87LwhLozTDYLWT+TGmDSSu8vZCb2mexiUDa3Hrmt3esccVG0UxI1iZaa3DnNdQVzYFMa+cvdDotLx9RwC/u3W/HGYJhc5ZFiID+bUCT532+VLYas5cXBRAR0X8sT2eVz9bWDc6BmerjiNVINRagBlMZcIUd09cNxPfoVnWvzOpkWonLVaDI0QvNC9mhJFDrm6xMlR1B4Wz8HZvOpufNYeKNBx2/LjQVslih8bwb+NzkuWLTIh6QNfwXlTGDydO5OJhDqy4Tex5R58S/DgTMpjcKXAolhI3+0wlqE49XOevxJhhkKTIeY4pnFkEdFIupp9sq5oWs7RX+gWeqw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8518ce4b-7af1-43d8-3f74-08d711205fe8 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2019 16:51:44.0627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shallyv@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB2017 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-25_06:2019-07-25,2019-07-25 signatures=0 Subject: Re: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Thursday, July 25, 2019 3:08 PM > To: Shally Verma ; Nowak, DamianX > ; dev@dpdk.org > Cc: Trahe, Fiona ; Ayuj Verma > ; Sunila Sahu ; Kanaka Durga > Kotamarthy ; Anoob Joseph > ; Narayana Prasad Raju Athreya > > Subject: RE: [dpdk-dev] [PATCH v5 1/1] test: new test structure for > asymmetric crypto >=20 >=20 >=20 > > -----Original Message----- > > From: Shally Verma [mailto:shallyv@marvell.com] > > Sent: Thursday, July 25, 2019 11:17 AM > > To: Kusztal, ArkadiuszX ; Nowak, DamianX > > ; dev@dpdk.org > > Cc: Trahe, Fiona ; Ayuj Verma > > ; Sunila Sahu ; Kanaka > Durga > > Kotamarthy ; Anoob Joseph > > ; Narayana Prasad Raju Athreya > > > > Subject: RE: [dpdk-dev] [PATCH v5 1/1] test: new test structure for > > asymmetric crypto > > > > > > > > > -----Original Message----- > > > From: Kusztal, ArkadiuszX > > > Sent: Thursday, July 25, 2019 2:06 PM > > > To: Shally Verma ; Nowak, DamianX > > > ; dev@dpdk.org > > > Cc: Trahe, Fiona ; Ayuj Verma > > > ; Sunila Sahu ; Kanaka > > Durga > > > Kotamarthy ; Anoob Joseph > > > ; Narayana Prasad Raju Athreya > > > > > > Subject: RE: [dpdk-dev] [PATCH v5 1/1] test: new test structure for > > > asymmetric crypto > > > > > > > > > > > > > -----Original Message----- > > > > From: Shally Verma [mailto:shallyv@marvell.com] > > > > Sent: Thursday, July 25, 2019 9:18 AM > > > > To: Nowak, DamianX ; dev@dpdk.org > > > > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX > > > > ; Ayuj Verma > ; > > > > Sunila Sahu ; Kanaka Durga Kotamarthy > > > > ; Anoob Joseph ; > > > Narayana > > > > Prasad Raju Athreya > > > > Subject: RE: [dpdk-dev] [PATCH v5 1/1] test: new test structure > > > > for asymmetric crypto > > > > > > > > Hi Damian, Fiona, Arek > > > > > > > > Though am bit late to come back to this. But I have question on > > > > mod_exp test vector. > > > > Please see below. > > > > > > > > > -----Original Message----- > > > > > From: dev On Behalf Of Damian Nowak > > > > > Sent: Wednesday, March 27, 2019 3:15 PM > > > > > To: dev@dpdk.org > > > > > Cc: fiona.trahe@intel.com; arkadiuszx.kusztal@intel.com; Damian > > > > > Nowak > > > > > Subject: [dpdk-dev] [PATCH v5 1/1] test: new test structure for > > > > > asymmetric crypto > > > > > > > > > > This patch adds new test structure for modexp and modinv for > > > > > asymmetric cryptography > > > > > > > > > > Signed-off-by: Damian Nowak > > ... > > > > > > > +static const struct > > > > > +modex_test_data modex_test_case[] =3D { { > > > > > + .description =3D "Modular Exponentiation " > > > > > + "(mod=3D128, base=3D20, exp=3D3, > res=3D128)", > > > > > + .xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX, > > > > ... > > > > > + .modulus =3D { > > > > > + .data =3D { > > > > > + 0xb3, 0xa1, 0xaf, 0xb7, 0x13, 0x08, 0x00, 0x0a, > > > > There's already a testvector mod_p[] in file with leading 0. Where > > > > as I see this one duplicate of that but without leading 0. > > > > Could you tell me if you ever tested with mod_p[] with leading 0 > > > > and if your qat PMD passed that? > > > > > > [AK] - Hi Shally, > > > The problem with this vector is that it has 1024bit long number but > > > sizeof(mod_p) Is 129 bytes (1032 bit). > > > It is no problem for QAT to get correct result, but test will fail > > > because QAT PMD will return 129 bytes of date (with leading zero, > > > number right-shifted) so comparison will fail. This is the same > > > question as > > padding NONE for RSA. > > > Should we trim zeroes, or shouldn't we. > > [Shally] Ya. Now, I correlate changes that you proposed to another RSA > > xform patch. Because Spec simply expect Key input as positive integer > > and does not know if its DER formatted input. > > > > So, I have one question here: How QAT is handling leading 0? Do you > > pass data as is to HW with 0 in it and it is still able to produce > > correct result for you? > [AK] - We pass as is (with 0), it will still produce correct result (4096= bits are > size upper limit for QAT currently). So there may be any number of leadin= g > zeroes up to 512bytes, and we don't care. Right now there are discrepanci= es > between OPENSSL and QAT in that as QAT will return shifted data and > OPENSSL will not, we need to choose one way or other. [Shally] "shifted data" mean? Can you help clarify with some example here? >=20 > Or, you take care in PMD to remove it and then append it back later at > > o/p? > > In case, you pass to HW, then does all bytes after 0 store correct o/p? > > > > > > > > > > > + 0x35, 0xdc, 0x2b, 0x20, 0x8d, 0xa1, 0xb5, > 0xce, > > > > > + 0x47, 0x8a, 0xc3, 0x80, 0xf4, 0x7d, 0x4a, 0xa2, > > > > > + 0x62, 0xfd, 0x61, 0x7f, 0xb5, 0xa8, 0xde, 0x0a, > > > > > + 0x17, 0x97, 0xa0, 0xbf, 0xdf, 0x56, 0x5a, 0x3d, > > > > > + 0x51, 0x56, 0x4f, 0x70, 0x70, 0x3f, 0x63, 0x6a, > > > > > + 0x44, 0x5b, 0xad, 0x84, 0x0d, 0x3f, 0x27, > 0x6e, > > > > > + 0x3b, 0x34, 0x91, 0x60, 0x14, 0xb9, 0xaa, > 0x72, > > > > > + 0xfd, 0xa3, 0x64, 0xd2, 0x03, 0xa7, 0x53, 0x87, > > > > > + 0x9e, 0x88, 0x0b, 0xc1, 0x14, 0x93, 0x1a, 0x62, > > > > > + 0xff, 0xb1, 0x5d, 0x74, 0xcd, 0x59, 0x63, 0x18, > > > > > + 0x11, 0x3d, 0x4f, 0xba, 0x75, 0xd4, 0x33, > 0x4e, > > > > > + 0x23, 0x6b, 0x7b, 0x57, 0x44, 0xe1, 0xd3, > 0x03, > > > > > + 0x13, 0xa6, 0xf0, 0x8b, 0x60, 0xb0, 0x9e, > 0xee, > > > > > + 0x75, 0x08, 0x9d, 0x71, 0x63, 0x13, 0xcb, 0xa6, > > > > > + 0x81, 0x92, 0x14, 0x03, 0x22, 0x2d, 0xde, 0x55 > > > > > + }, > > > > > + .len =3D 128 > > > > > + }, > > > > > + .result_len =3D 128 > > > > > +}, > > > > .... > > > > > /* modular operation test data */ uint8_t base[] =3D { > > > > > 0xF8, 0xBA, 0x1A, 0x55, 0xD0, 0x2F, 0x85, > > > > > -- > > > > > 2.7.4