From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id DE6AB1B429 for ; Tue, 12 Feb 2019 06:27:31 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1C5PfMh025112; Mon, 11 Feb 2019 21:27:31 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=XS7Vh2Bc18hZSyz/F6A8G+FcawMlCLJ6fTKqZmqVdpY=; b=tukfY6lirBG606dbA6R3R2vx0iKYKUedjgc84xKsH49kyvf1cOZqjSXf+B327lTfeoW0 1Vp6/LLFo8NEKx9s4oyPYmFvrpAw+XfoA0Q8FEGW3djawc36jPkVK85dmhzfHNDIshzt OzanUEp/qkMz6pIG5z/03HLoa73My5C8fn9jQlCPlsYV508Zz8e/TGSYBh77q45Du+7p Cp1s4+WcfcOpTS41PrUOiHmii0MIPvHmly8VeQ3YlPQREkrKyfpMEk+cesVHjiQlLYqw Upkh7vckgwBfOEG+3KN8CbWkqmfHKfjIvHQtAubExm6msi4sBOxcBD/ZxPGftxyr5ZRg Kw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2qkktn8m2x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 11 Feb 2019 21:27:30 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 11 Feb 2019 21:27:29 -0800 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.56) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 11 Feb 2019 21:27:29 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XS7Vh2Bc18hZSyz/F6A8G+FcawMlCLJ6fTKqZmqVdpY=; b=NlHc7Zwvc4kpphIfSwnPYPrX3RHc+sZQQD2nmGspX4b5HPaFQbWffzo4lIHjFzSaUHb1GU2rHkvc0qI0/GUzpEY9TaMFUvT24sE96cFfYo5BkmANQsqmpueZqBSdUdifx7JR6YeoDTce9Ln5U2XTy2wBGwW2sjUndeu2BqK9XmM= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB2049.namprd18.prod.outlook.com (10.161.152.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.21; Tue, 12 Feb 2019 05:27:26 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::9403:ace8:3dc7:355]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::9403:ace8:3dc7:355%5]) with mapi id 15.20.1601.023; Tue, 12 Feb 2019 05:27:26 +0000 From: Shally Verma To: "Kusztal, ArkadiuszX" , Ayuj Verma , "Trahe, Fiona" CC: "akhil.goyal@nxp.com" , Kanaka Durga Kotamarthy , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 0/3] adding op-type crt sign and decrypt Thread-Index: AQHUvg1gQkJoFzcev0ymVfke48+GsaXVmWXEgACVmtCAA+zJ5IAAVXaggAAS47A= Date: Tue, 12 Feb 2019 05:27:25 +0000 Message-ID: References: <20190206111405.30860-1-ayverma@marvell.com> , <348A99DA5F5B7549AA880327E580B435896EBE65@IRSMSX101.ger.corp.intel.com> <06EE24DD0B19E248B53F6DC8657831551B13B064@hasmsx109.ger.corp.intel.com> In-Reply-To: <06EE24DD0B19E248B53F6DC8657831551B13B064@hasmsx109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8e70a31c-f54c-4864-3258-08d690aac60c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020); SRVR:BN6PR1801MB2049; x-ms-traffictypediagnostic: BN6PR1801MB2049: x-microsoft-exchange-diagnostics: 1; BN6PR1801MB2049; 20:ZDyKVBPnsrEux/gOgeKbp9eqCEizz/dtPG5fHBPDeXkfGeimnos6LCpbgW0S9idZl0RNFlhgMww0NZyb2eNX/WzW7hJAu+OytMieQCn/5e+HPCSMdCZM63EKy99EoTs7crVInzE2Es17WwQ9Yw3ylrcWdWuAtV7Av8rfOCOfopM= x-microsoft-antispam-prvs: x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(39860400002)(136003)(366004)(199004)(189003)(51444003)(110136005)(76176011)(68736007)(229853002)(316002)(3846002)(446003)(26005)(561944003)(476003)(486006)(6116002)(8676002)(14444005)(81156014)(6436002)(4326008)(2906002)(256004)(11346002)(55236004)(33656002)(54906003)(99286004)(186003)(7696005)(6506007)(53546011)(305945005)(102836004)(7736002)(25786009)(105586002)(106356001)(14454004)(478600001)(66066001)(97736004)(8936002)(93886005)(53936002)(81166006)(71190400001)(71200400001)(9686003)(86362001)(6246003)(55016002)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB2049; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NlpVFjyqKEdcZR/E5BHoUKLsB9bsFjcBCCrVIbZS9T1xOSIibtxvWyaLwaob2mm2y+s4rx5XI/t5H50UcecX+hKa5VyyCN2XcaV8QbDeShTZ05FsQ7s+EVvaYlj7gKBLYuEtQ5W5tG1GNbdORskJgnMwwzHsEpSpuYLLeinUxKE0T4NNU164SWFqEA+U7XbjGxLjHvx2ccsvLMTsxNGcauIIE4wwxgBbcbSBtd4V4D6tmh/qEpzmcW18q6kySt10pgMi0RGNapKOlso8e2i3WVMOZMC7Hakp+9Ou/ZSb1fORhihgzkbwmxWw6Ji7b6XbjdTuni9qFfIlF5gnOErCLlzT4RA99ktZqsRg3bciLlz/ktnHG9gMce9zHLNw8ckOdjGI9uZxcTVo7S/m/40DwjNSaQWXlPi9UpcPiq4mls4= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8e70a31c-f54c-4864-3258-08d690aac60c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2019 05:27:25.8049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB2049 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-12_04:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902120040 Subject: Re: [dpdk-dev] [PATCH 0/3] adding op-type crt sign and decrypt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 05:27:32 -0000 HI Arek, From: Kusztal, ArkadiuszX =20 Sent: 11 February 2019 17:11 To: Ayuj Verma ; Trahe, Fiona ;= Shally Verma Cc: akhil.goyal@nxp.com Subject: [EXT] RE: [PATCH 0/3] adding op-type crt sign and decrypt External Email=20 ________________________________________ Hi Ayuj, Few comments from me.=A0 Some PMDs can only support RSA private key operations using CRT keys (quintuple) only. Thus it is required to add in PMD RSA xform capability which key type is supported to perform sign and decrypt ops. Thus add an another op_type RTE_CRYPTO_OP_TYPE_SIGN_CRT and RTE_CRYPTO_OP_TYPE_DECRYPT_CRT, which would mean perform an private key op using CRT keys (quintuple) only. [AK] - What would be the purpose of enum rte_crypto_rsa_priv_key_type key_t= ype in RSA XFORM then? [Shally] PMDs, like openssl, can support private key ops with both key type= i.e. one can invoke RSA_Sign() with quintuple keys or exponent keys.=20 Openssl in its capability would reflect it support ops with both key types.= that's why key_type is still required in xform.=20 PMD would reflect its capability to support these operations using its op_type mask. App should query RSA xform capability API to check if specific op_type is supported, thus call operation with relevant key type. Another proposal is, it is not known if non-crt keys is used at all to perform otherwise naturally slow RSA private keys operations. So, it is also possible to deprecate RSA_KEY_TYPE_EXPONENT altogether and just use quintuple key type for private key operations. In that case, there is no need to add another SIGN/DECRYPT_CRT variant, current SIGN and DECRYPT operation default to using quintuple RSA keys. [AK] - even if I generally agree that all drivers will be using CRT by defa= ult (when quintuple keys provided) I think that if some PMD cannot support = mod exp, it should fail on session init or should receive unsupported error= on dequeue. [Shally] Sorry this isn't clear to me when you say "if some PMD cannot supp= ort mod exp, it should fail on session init" . modexp is exported as separa= te xform on lib, if PMD doesn't support this xform, it will not be in its c= apability. Or do you mean to say, we can leave exponent key type support , if PMD does= n't support operations using this type, it can will fail during session_ini= t()? modexp is base for all RSA operation, so any PMD has to support it internal= ly in any case. Ayuj Verma (3): =A0 lib/cryptodev: add crt sign and decrypt ops =A0 crypto/openssl: update op-type mask with crt ops =A0 test/crypto: check for rsa capa for op-type =A0drivers/crypto/openssl/rte_openssl_pmd_ops.c |=A0 4 +- =A0lib/librte_cryptodev/rte_crypto_asym.h=A0=A0=A0=A0=A0=A0 |=A0 8 ++++ =A0test/test/test_cryptodev_asym.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 |= 47 ++++++++++++++++++++ =A03 files changed, 58 insertions(+), 1 deletion(-) --=20 2.20.0 Regards, Arek