From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 7789AF11 for ; Wed, 16 Jan 2019 12:21:59 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0GBKB9J024601; Wed, 16 Jan 2019 03:21:58 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=j9whfD9kQYJZn9o59NMJ6ByammmDhEWDeEsl0/osk5Y=; b=hycyuBo91VRXmIiDPn4oFOaQT2PW94UE69jzB4+Qjq/+4MbQ5ucqWuy/CI++Lt0QgWr8 Wx+ymOSVP8F4ZKx2oY+q21bzV0USRL3GINijcSEXKHzG+NJFrXEkNqoM7898zCxA3PVp V2XlgWwVE55y3k4G/W8jwmFNkyP4mrSKb9zhZagc/WFzsrzgtei+Cz0sdNX6s2LTr3JB 33JX5i5JPJGDQwip85cyHeJxR8BoLtNqgPz29WyyJxv+QotuxR6cwsN1R6zerCdG12WG WbXzz47kVUUwECozXRxC5tXMBSkWiGQ1h85wSYVZdSfX0T4hg/O3PadCkXmcJBLWiscE xw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2q22qk08g0-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 16 Jan 2019 03:21:58 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 16 Jan 2019 03:21:57 -0800 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (104.47.32.58) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 16 Jan 2019 03:21:57 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j9whfD9kQYJZn9o59NMJ6ByammmDhEWDeEsl0/osk5Y=; b=OfDGLU7lyx9gRw+eXJquNHrfsysOy9ws1fbuJol9t73dNl7a2UVXXWnfOfqLRRiiI8dfngsRuhTUp6ug9/YuxvsJD+h9TWISwMfLE0EP9DsVtDfisO7ZAo0hTaxfUF4frr5bp3RBERRHt4A/qh7dDRejv7b31Xfnry0BNUhX61w= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB2004.namprd18.prod.outlook.com (10.161.156.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.20; Wed, 16 Jan 2019 11:21:54 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b199:d845:678e:8d72]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::b199:d845:678e:8d72%4]) with mapi id 15.20.1516.019; Wed, 16 Jan 2019 11:21:52 +0000 From: Shally Verma To: "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Verma, Shally" , "Stephen Hemminger" CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Jozwiak, TomaszX" , "Gupta, Ashish" , "Daly, Lee" , "Luse, Paul E" , "Trahe, Fiona" , Anoob Joseph , Tejasree Kondoj Thread-Topic: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done Thread-Index: AQHUhqDGWiQ91k5Oqk2PFjUWQ0rZTKWEsrkAgAD8tICAAL6WgIAirlqAgAjqCTA= Date: Wed, 16 Jan 2019 11:21:52 +0000 Message-ID: References: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com> <20181119175349.2bd2fdd1@xeon-e3> <348A99DA5F5B7549AA880327E580B4358967C84F@IRSMSX101.ger.corp.intel.com> <20181120100703.34c462e9@xeon-e3> <348A99DA5F5B7549AA880327E580B435896A4B55@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B435896A5DB3@IRSMSX101.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN6PR1801MB2004; 20:9EGA+aAYy8IoKeKD2OhvHGCgdosyP32Qd0PDn4sQwrF3E+/DEYFOerSO3gg1EMZHHpgEf2bEy/Mgfl3jskSY2REyAADvRuxC7qHKJpNX6pcLElJo5YhZbcpE4ahW3NKaynnhBe/XdVczgN2c67mWD0J2MGxwQKjusAuqWGpRFIA= x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(39860400002)(136003)(396003)(13464003)(199004)(189003)(7416002)(33656002)(5660300001)(14444005)(256004)(74316002)(68736007)(71190400001)(71200400001)(86362001)(316002)(54906003)(97736004)(53936002)(110136005)(229853002)(7736002)(305945005)(4326008)(25786009)(55016002)(99286004)(6436002)(6246003)(107886003)(2906002)(9686003)(8676002)(105586002)(478600001)(106356001)(93886005)(7696005)(81156014)(81166006)(14454004)(66066001)(186003)(55236004)(6506007)(102836004)(476003)(11346002)(53546011)(26005)(446003)(486006)(76176011)(6116002)(8936002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB2004; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 841d174e-2d04-4e26-a578-08d67ba4d0e2 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:BN6PR1801MB2004; x-ms-traffictypediagnostic: BN6PR1801MB2004: x-microsoft-antispam-prvs: x-forefront-prvs: 091949432C received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Ov98jA5TQYUAjh183ww0AqOTkLYzE/Gi3CjeOJRET8SMiO0uNg7qoL5Reiarco7HklmcHnMRAHU5QlLHj6I9uFw1evFNiSqOfD7x8o5qOpLn9OLuz3JGLLp3RaO75hloUIR8sDe/8rDSTtXsER4cIgikigTtmUGOX9LzNUgizULSroRVeojxxgYC00Iuf6KuWQm5AsOzRExBnlrhJ8Q8sj/v3bybMyAX4haLrFJVpVgOiKmmac3if4Ymr81eiV9BKeycxvU83t2a2IiS61YEAnKjd/1Hxdq/WKk9ig9kjH7AolZBLp/F1hZ/EBfd/uZp2NErymZoy/BI8s04UYNKFJD14sEko0X9Fi9JkMnVFaiCUMdgkmfeAE7YNbho9Rkr6JdC8wHBHqsW15QW+eaJ6GOp2+r0btorj2vtPmYUnYI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 841d174e-2d04-4e26-a578-08d67ba4d0e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2019 11:21:52.6879 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB2004 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-01-16_05:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901160096 X-Mailman-Approved-At: Thu, 17 Jan 2019 10:25:34 +0100 Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 11:21:59 -0000 Hi Pablo, Fiona >-----Original Message----- >From: De Lara Guarch, Pablo >Sent: 11 January 2019 00:17 >To: Trahe, Fiona ; Verma, Shally ; Stephen Hemminger > >Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX ; Gupta, Ashish >; Daly, Lee ; Luse, Paul E ; Trahe, Fiona > >Subject: RE: [dpdk-dev] [PATCH] compressdev: add feature flag to specify w= here processing is done > >External Email > >Hi Shally, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Trahe, Fiona >> Sent: Wednesday, December 19, 2018 5:10 PM >> To: Verma, Shally ; Stephen Hemminger >> >> Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX >> ; Gupta, Ashish ; >> Daly, Lee ; Luse, Paul E ; Tr= ahe, >> Fiona >> Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify >> where processing is done >> >> Hi Shally, >> >> > -----Original Message----- >> > From: Verma, Shally [mailto:Shally.Verma@cavium.com] >> > Sent: Tuesday, December 18, 2018 10:48 PM >> > To: Trahe, Fiona ; Stephen Hemminger >> > >> > Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX >> > ; Gupta, Ashish >> ; >> > Daly, Lee ; Luse, Paul E >> > Subject: RE: [dpdk-dev] [PATCH] compressdev: add feature flag to >> > specify where processing is done >> > >> > >> > >> > >-----Original Message----- >> > >From: Trahe, Fiona >> > >Sent: 18 December 2018 20:13 >> > >To: Stephen Hemminger >> > >Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX >> > >; Verma, >> > Shally >> > >; Gupta, Ashish >> ; >> > >Daly, Lee >> > ; Luse, Paul E >> > >; Trahe, Fiona >> > >Subject: RE: [dpdk-dev] [PATCH] compressdev: add feature flag to >> > >specify where processing is done >> > > >> > >External Email >> > > >> > >Hi Stephen >> > > >> > >//snip// >> > >> > > Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag >> > >> > > to specify where processing is >> > done >> > >> > > >> > >> > > On Tue, 20 Nov 2018 01:39:48 +0000 Fiona Trahe >> > >> > > wrote: >> > >> > > >> > >> > > > A new device feature flag, >> > >> > > > RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE >> > >> > > > is added. A PMD which processes operations using a software >> > >> > > > acceleration engine should set this if the bulk of the >> > >> > > > processing is done during the dequeue. It should leave it >> > >> > > > cleared if the bulk of the processing is done during the >> > >> > > > enqueue (default). >> > >> > > > An application may find this useful for tuning. >> > >> > > > >> > >> > > > Signed-off-by: Fiona Trahe >> > >> > > >> > >> > > What application? or is this "if we build it they will come?" >> > >> > [Fiona] Our storage team asked for this, so not quite. >> > >> > Seems like it might by generically useful, so a bit of the latter >> > >> > too :) Would you prefer I removed that line? >> > >> >> > >> Hopefully, there would be one or more open source projects using th= e >> API. >> > >> I just did a survey of DPDK an 1/3 of it is never used by any open >> > >> source project. Hate to see more dead code and special cases creat= ed. >> > >> >> > >> At least, some example code in examples would help. Something like >> > >> a simple in memory compressed storage server using a network API >> > >> (SMB?/SSH?/FTP?) >> > >[Fiona] There is no compressdev sample app yet. >> > >However I've double-checked with the SPDK team, they're currently >> > >integrating compressdev and intend to push a patch to SPDK - a storag= e >> open-source project - using this flag. >> > [Shally] Am seeing some of our HW based PMD also leveraging this >> > choice. So I would say to make it generic feature flag instead of SW s= pecific. >> [Fiona] I can do but would like to understand this better first. >> My understanding of HW offload is that the enqueue is just packaging up >> the op and sending to the HW. >> And the dequeue is just collecting the result from the HW and passing ba= ck >> to the op. >> The work is done by the HW accelerator, in between those 2 API calls, no= t >> using any CPU cycles. >> So what would it mean for HW to set OP_DONE_IN_DEQUEUE? > >Any comments on this? I agree with Fiona that this flag makes sense on SW = only, >but it seems that you have another use case. So, after having internal discussions, it is realized this feature will be = useful for particular scenario in HW also (though not very common in practice but still in use). Some hw based PMD, example current octeontx compression, enqueues an op and= wait for it to complete in enqueue itself to ensure in-order completion and then return. By giving = this control to app, it can dictate PMD whether=20 to wait for its completion in enqueue or dequeue. This is useful where out= -of-order completion of ops negatively impact app=20 performance. Such app can use this flag to alter PMD behaviour. Also, we ha= ve another PMD, where it internally takes similar flag to make this decision, having it exposed will make it more portable. Thanks Shally > >Thanks, >Pablo > >> >> > Thanks >> > Shally