From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id DBBA83572 for ; Tue, 12 Mar 2019 13:04:12 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2CC0BjA028485; Tue, 12 Mar 2019 05:04:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=2ESo3k3TSicli6LpsJfEvlJ/zasa6Vn3cswm0iFFOPA=; b=oZHzSKzZPThYQl1Gv9/DgvvG1kk5DCuRO/uSZKHrhoR/SMxx+uRM9auC2/SAlc49T93W ZG95GFAQFWutK/cVOPN8sTNUiHOvmjCnWycCmGr8oMO7vakH/09PNF2idGFv4VU9oG7w btiK7kJ5x/7w7Al7Uh8ocdWWpYDWftoVq+y9Imax/teW4RQnwiL28N+VIDwO+dUafWN6 g/5TDkNWzE3a1HsRPZbSNh1d8JfhavxRMizR/PDgIOK3nytVF0YGsetOJv2lvJVNBoIj HU0s6tYS7FTJXS06NZ63GvyhHpJiEuqg+oX7SJiPzC6zzhn30MR8DFwj+WZ3+t5//ShL xA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2r69kgrf95-17 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 Mar 2019 05:04:10 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 12 Mar 2019 05:04:04 -0700 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.59) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 12 Mar 2019 05:04:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ESo3k3TSicli6LpsJfEvlJ/zasa6Vn3cswm0iFFOPA=; b=HLTKzgADEK4nfkkyadJBO2YqWuMAWZXYE3JBGAA7QPoPxf61uD2g0YtyqOyiJl+eyZB+kZMBtd3n4yCq6JrrKzuyYqa7YFxRO/kW5XndiYUSChVpMbiXMf8YdgJYlFM/pWFCZRDL+cOH4V1XHjz8ef3PeBM+OWJD2yHj1PXIUCs= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB1970.namprd18.prod.outlook.com (10.161.155.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.19; Tue, 12 Mar 2019 12:04:02 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::45ea:7319:2d92:aa63]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::45ea:7319:2d92:aa63%2]) with mapi id 15.20.1686.021; Tue, 12 Mar 2019 12:04:02 +0000 From: Shally Verma To: Konstantin Ananyev , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "umesh.kartha@caviumnetworks.com" , "pablo.de.lara.guarch@intel.com" , "shally.verma@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: fix restore crypto op alignment and layout Thread-Index: AQHU1O/0+Cy9GCtfckmR6NvC0TtLK6YH69VQ Date: Tue, 12 Mar 2019 12:04:02 +0000 Message-ID: References: <1551967994-8112-1-git-send-email-konstantin.ananyev@intel.com> In-Reply-To: <1551967994-8112-1-git-send-email-konstantin.ananyev@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f3877524-4fe3-4b98-fc09-08d6a6e2d198 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:BN6PR1801MB1970; x-ms-traffictypediagnostic: BN6PR1801MB1970: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; BN6PR1801MB1970; 23:MtAv8M1oHFezD4w7m9pRtOXMrm6dyAdFaO33Ewd?= =?us-ascii?Q?ncEuMZQ5Ifaq9bgOnpK1Ae1UmOrVV/TxA24NV6wGM17HX7HFNlXw8MhiDhl8?= =?us-ascii?Q?ZqRccXZ+FDguXqtgZTv0wO4Zg3lsvPAWXUdgCnE/ATlRl4ayOQAwQOaJ+V1n?= =?us-ascii?Q?Ru2PIEX2UsVEhmGAE2r6pNQFZbbAMpXjVFahSjOzPx+SJuJPy2mExAuxmaGr?= =?us-ascii?Q?WrRDgnEmTc5gHXBrFkoRyZnbBZdEd/WgzS6jzd/R2vitLrWlgOllOWqdhDoq?= =?us-ascii?Q?fodXjI2H7YX5jP+zkXJy3HqRsxdOpZdVbIgfih71AewPz2+5gwSKpvLxHBrZ?= =?us-ascii?Q?dDURGwpQhVklXB5QieqohN01HL3oYk8vKdmx8FUFPwxt7NTadX++CT3iU3e2?= =?us-ascii?Q?7rrLGqOSkDv4Hy2vXhrr3U3Pslm4AWkjHFczJSvx8fkbuP/Ta/XgdA84Fdhf?= =?us-ascii?Q?h/ico3Qj7UCSfCj41a0lcMH4o79XQBW5louMBK3tNud9rjQfjsICkxXcpNfG?= =?us-ascii?Q?C/Yl/iMDLPzFIiH04kPpen5bxpnKPZOnBhnqCol7MKgoC5TTtWSOzef7gOEr?= =?us-ascii?Q?N9QOjNeVx07vwhPPE58kFSVhs8p7ZH0/o7x5NILhWwCuZHGKsBHs7hpdq/Ql?= =?us-ascii?Q?m+wvWeyjoYYPPBUYX/um6j06sO9aUnnSgCLIzbYH8t2hg/OCAdIjQ91jZF1G?= =?us-ascii?Q?Lf8U6wHUMTDqH7yg4CLjGQisAX18bJczq33MtMRIPMdDWmC/ehzghRWr2Pyb?= =?us-ascii?Q?Ny2CV7nU6OLGSCPTjAMMKjsuLwF/UUC8kQrKOk5Hlhbjx3pap9hKkXUV4di/?= =?us-ascii?Q?rVRSSLSW3YcnhsCOz6Y8dppPT4p+xJT0TKAujAYD3zGcsuuYlndHM7PclASm?= =?us-ascii?Q?O21pye7V+G2FdUyrne/kEwkGZ+Jbwa3gtRFJDkqM2JGEW84Fl9OhxHcD7Jbm?= =?us-ascii?Q?Pq4MGW24BFn414CEfj8VKc3qROg6Ujlkeq4RrxsyF/DSsPlP4n4Ccx5daigX?= =?us-ascii?Q?Fbn6gLlWYDofUl/4M7RyNgoB8lyacJ0TWzCXHMyr9W69In1Fu/4L5Q9QOe0j?= =?us-ascii?Q?0irBTyMv9G1N/xQI0DjeE084pX5i3D+BlY3UQ8cPDt5k82Hs+2niUihnEtbG?= =?us-ascii?Q?6FwekwYkaouWVODPi7MIQDshcqY4MyTnMrlWsaQvH/Rp1TgXdzF5RyD/bD71?= =?us-ascii?Q?hGjqWuAcyTjEFJOqY0MyYOiLyXtLXaQIBSRJ81p0Ujp5unk7UuscGYQqomVT?= =?us-ascii?Q?gPbrNcX4iua+sKZnwg+6D2TUZWrP5Tlq5cW7neoi0MFYj/SR75OJhmOXuiMc?= =?us-ascii?Q?Swg=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09749A275C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(39860400002)(396003)(346002)(376002)(199004)(189003)(13464003)(476003)(102836004)(2501003)(486006)(33656002)(6506007)(55236004)(76176011)(2906002)(97736004)(7696005)(81156014)(53546011)(305945005)(446003)(26005)(186003)(25786009)(6436002)(3846002)(7736002)(66066001)(68736007)(81166006)(6116002)(106356001)(11346002)(14454004)(86362001)(229853002)(105586002)(316002)(74316002)(4326008)(55016002)(99286004)(9686003)(8936002)(53936002)(5660300002)(256004)(478600001)(6246003)(14444005)(52536013)(71190400001)(54906003)(110136005)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB1970; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: tTr5r9bHtmgzFJbufn/FxxZnaOfnfDx+Ysrl+gNh/2vW3bW6Qy/THvl+ow4pKZOOdMG0hTytB9tCsAPq8nIZNJs6Jm3R9osfYhIMXhR+a+wFrqplFYOS4az57BCNpU+wk7gZozu+exuO+rKJ8GEjjsc3Ci+Hwvp29gI8ChCN5/hWX2UvBwPUoocEgywvUUX0ukCHofsk0/8maFvoum+YEJ22ZZP8oYj9B6PZSS4y+bRWYUDTLw7iGoCoDUnL2cO3lM1p1eBHZhz8d19pCzRe2l2aKmaE1FMOJKJzoR7kjF6I6JZO5z1byGv1YRp+j3UcOjOaArhP1fahQkBRZLCF0/bh4JSnW7oFot8MAvsGRmlU4SwWrrk2KJUUPGrzeN7BXTfAh2pF7vo3tb/JYcz29fi2+aj99yAvRhH5gm5/ILE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f3877524-4fe3-4b98-fc09-08d6a6e2d198 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2019 12:04:02.7416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB1970 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-12_06:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: fix restore crypto op alignment and layout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 12:04:13 -0000 > -----Original Message----- > From: dev On Behalf Of Konstantin Ananyev > Sent: Thursday, March 7, 2019 7:43 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; umesh.kartha@caviumnetworks.com; > pablo.de.lara.guarch@intel.com; shally.verma@caviumnetworks.com; > Konstantin Ananyev > Subject: [dpdk-dev] [PATCH] cryptodev: fix restore crypto op alignment an= d > layout >=20 > in 18.08 new cache-aligned structure rte_crypto_asym_op was introduced. > As it also was included into rte_crypto_op, it caused implicit change in > rte_crypto_op layout and alignment: now rte_crypto_op is cahce-line align= ed > has a hole of 40/104 bytes between phys_addr and sym/asym op. > It looks like unintended ABI breakage, plus such change can cause negativ= e > performance effects: > - now status and sym[0].m_src lies on different cache-lines, so > post-process code would need extra cache-line read. > - new alignment causes grow of the space requirements and cache-line > reads/updates for structures that contain rte_crypto_op inside. > As there seems no actual need to have rte_crypto_asym_op cache-line > aligned, and rte_crypto_asym_op is not intended to be used on it's own - = the > simplest fix is just to remove cache-line alignment for it. > As the immediate positive effect: on IA ipsec-secgw performance increased > by 5-10% (depending on the crypto-dev and algo used). > My guess that on machines with 128B cache-line and lookaside-protocol > capable crypto devices the impact will be even more noticeable. >=20 > Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions"= ) >=20 > Signed-off-by: Konstantin Ananyev > --- It's a valid point that asym_op is not going to be used standalone. Thanks = for pointing it out.=20 Acked-by: Shally Verma