From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 51D164F9B for ; Wed, 6 Feb 2019 10:37:59 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x169TpdR015793; Wed, 6 Feb 2019 01:37:57 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=o8aG6/IDcSNYkU7oj99H22LJiA1BtDK7vGcsAJeitpM=; b=f9mOONcZqiDJqn1WrpUoATkWbfJjaOjJZ2njD/2OoytcM+LaM//QDJ9EHWhkxwm3RptV f8n/u8B+W7r+gNtxYOt4y7s6R3WQLxv9LzXvb+Hy43offhTMmMslCOm5k9ybZvIvYI2S t2C1sH0M8tsV3ajhgRxipLSO8p1utOGWOoFVL5mk0gyXgx7jjpmU2TU+4XIgYqbD0Mww N2hmyjO/qJwnRnwLlaeQS65ZPaJBqmiidT4bo/5x/4RhvadCCUvgI423Y/Q///2Wmzq+ Um/yfa5rGRLaK2d1hZhNMh7VFJK+qGnXhA4/uoJ6weDtRK57rcvMWHuHWG0a6Ez5NH0P Kw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2qfc17k6wt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 06 Feb 2019 01:37:56 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 6 Feb 2019 01:37:55 -0800 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.54) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 6 Feb 2019 01:37:55 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o8aG6/IDcSNYkU7oj99H22LJiA1BtDK7vGcsAJeitpM=; b=MlhMq4ueAZDWfaHQHxQcXghw7QNotXV9RSKMsiA3BOAWyS4PzOCeDOuLDkxNBliVtJFPUOERWDVFI7QR1kwd5sPjfrzPuUBEnpVjOcFH31v5PSOLTgh1b9cRq3BFRCE5/14cIAkSQs6mpwO8kTIr2jXpJG/raVK+84rZy3+Btfk= Received: from BN6PR1801MB2052.namprd18.prod.outlook.com (10.161.157.11) by BN6PR1801MB1971.namprd18.prod.outlook.com (10.161.153.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.19; Wed, 6 Feb 2019 09:37:53 +0000 Received: from BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::9403:ace8:3dc7:355]) by BN6PR1801MB2052.namprd18.prod.outlook.com ([fe80::9403:ace8:3dc7:355%5]) with mapi id 15.20.1601.016; Wed, 6 Feb 2019 09:37:53 +0000 From: Shally Verma To: "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" , "sunila.sahu@caviumnetworks.com" , "ashish.gupta@caviumnetworks.com" , "umesh.kartha@caviumnetworks.com" Thread-Topic: [PATCH v2] cryptodev: rework mod exp and mod inv comments Thread-Index: AQHUvX9878posf0A2U+FPkA8IrDLOKXSNecQgABNKwCAAAEJoA== Date: Wed, 6 Feb 2019 09:37:53 +0000 Message-ID: References: <20190205181941.10484-1-arkadiuszx.kusztal@intel.com> <06EE24DD0B19E248B53F6DC8657831551B12F825@hasmsx109.ger.corp.intel.com> In-Reply-To: <06EE24DD0B19E248B53F6DC8657831551B12F825@hasmsx109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BN6PR1801MB1971; 20:pH3Fe2VRR72U2jeSTt60bz3kAEjeya0sdJDDtNiJOlUJsbYwZfNqPbufZ+cHOWLuL2greLMImz6wiHm8pSFLXWNFBjd/0sNvUlovkciG51XgeTNlfXZcUzToMbfKNmxMuniFjB3XsZo07X5S2vYas21bLpvF9SNpTHyXm00m5Ys= x-ms-office365-filtering-correlation-id: 74edba48-2e7e-445d-6d7f-08d68c16c496 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020); SRVR:BN6PR1801MB1971; x-ms-traffictypediagnostic: BN6PR1801MB1971: x-microsoft-antispam-prvs: x-forefront-prvs: 0940A19703 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(136003)(346002)(366004)(396003)(189003)(199004)(13464003)(4326008)(71200400001)(71190400001)(256004)(14444005)(316002)(25786009)(110136005)(54906003)(8676002)(476003)(186003)(81156014)(97736004)(7736002)(102836004)(74316002)(11346002)(446003)(229853002)(305945005)(26005)(81166006)(486006)(33656002)(53936002)(8936002)(7696005)(9686003)(55016002)(6436002)(55236004)(2906002)(68736007)(6506007)(53546011)(76176011)(99286004)(2501003)(106356001)(6246003)(105586002)(86362001)(66066001)(478600001)(14454004)(3846002)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR1801MB1971; H:BN6PR1801MB2052.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: FnYAJzdWA4azujHyCrLeROfJLviNkckhfkNHxmsEJDlF5ooc9L1Ua+Q/B1v/6lPFhyU+sBMMaveQYWFbxlJhYs8jQ4OaSAtv8qPhTEh6PTqL/QD4HSkQE+YaKzSQo6Zs7NIwFXqXPAV7JEdNB87u0tuA/lip0x7tVhI3SO6UXiZRPSlVuSG96e/27Y3q7RpYp7d63TnvhMXy7tnW4fz1eTDsBYR3//q9UBO4pWxrxnHGUuxL7Y28QMesXc6kKdxMWvwPk/OqCW/GgkX+LsD0c8guazhLHRjZjftIG5TjPvVeRq17HTn/gONppRFn+vOfgt5DsN4lcAY94TuqOxRgQbdfDiaQvH96UGryiVbf9zEEdFd8k4JP6dVS9ZGCX/K6yY2G7k/EqiU5OvUQb92QhouuCZWiVQx6kqtk8t6MDcg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 74edba48-2e7e-445d-6d7f-08d68c16c496 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2019 09:37:53.4315 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1801MB1971 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-06_06:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=998 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902060075 Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: rework mod exp and mod inv comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 09:37:59 -0000 >-----Original Message----- >From: Kusztal, ArkadiuszX >Sent: 06 February 2019 15:04 >To: Shally Verma ; dev@dpdk.org >Cc: akhil.goyal@nxp.com; Trahe, Fiona ; sunila.sahu= @caviumnetworks.com; >ashish.gupta@caviumnetworks.com; umesh.kartha@caviumnetworks.com >Subject: [EXT] RE: [PATCH v2] cryptodev: rework mod exp and mod inv commen= ts > >External Email > >---------------------------------------------------------------------- >Hi Shally, > >Thanks for your feedback. > >> -----Original Message----- >> From: Shally Verma [mailto:shallyv@marvell.com] >> Sent: Wednesday, February 6, 2019 6:08 AM >> To: Kusztal, ArkadiuszX ; dev@dpdk.org >> Cc: akhil.goyal@nxp.com; Trahe, Fiona ; >> sunila.sahu@caviumnetworks.com; ashish.gupta@caviumnetworks.com; >> umesh.kartha@caviumnetworks.com >> Subject: RE: [PATCH v2] cryptodev: rework mod exp and mod inv comments >> >> HI Arek, >> >> Acked with minor feedback. >> >> >-----Original Message----- >> >From: Arek Kusztal >> >Sent: 05 February 2019 23:50 >> >To: dev@dpdk.org >> >Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; >> >shally.verma@caviumnetworks.com; sunila.sahu@caviumnetworks.com; >> >ashish.gupta@caviumnetworks.com; umesh.kartha@caviumnetworks.com; >> Arek >> >Kusztal >> >Subject: [PATCH v2] cryptodev: rework mod exp and mod inv comments >> > >> >External Email >> > >> >This patch changes modular exponentiation and modular multiplicative >> >inverse API comments to make it more precise. >> > >> >Signed-off-by: Arek Kusztal >> >--- >> >v2: >> >- grammar fixes >> > >> > lib/librte_cryptodev/rte_crypto_asym.h | 44 >> > ++++++++++++++++++++++------------ >> > 1 file changed, 29 insertions(+), 15 deletions(-) >> > >> Acked-by: Shally Verma >> >> >diff --git a/lib/librte_cryptodev/rte_crypto_asym.h >> >b/lib/librte_cryptodev/rte_crypto_asym.h >> >index 5e185b2..9582ee3 100644 >> >--- a/lib/librte_cryptodev/rte_crypto_asym.h >> >+++ b/lib/librte_cryptodev/rte_crypto_asym.h >> >@@ -72,8 +72,8 @@ enum rte_crypto_asym_xform_type { >> > * Refer to rte_crypto_asym_op_type >> > */ >> > RTE_CRYPTO_ASYM_XFORM_MODINV, >> >- /**< Modular Inverse >> >- * Perform Modulus inverse b^(-1) mod n >> >+ /**< Modular Multiplicative Inverse >> >+ * Perform Modular Multiplicative Inverse b^(-1) mod n >> > */ >> > RTE_CRYPTO_ASYM_XFORM_MODEX, >> > /**< Modular Exponentiation >> >@@ -233,29 +233,39 @@ struct rte_crypto_rsa_xform { struct >> >rte_crypto_modex_xform { >> > rte_crypto_param modulus; >> > /**< modulus >> >- * Prime modulus of the modexp transform operation in octet-str= ing >> >- * network byte order format. >> >+ * Pointer to the modulus data for modexp transform operation >> >+ * in octet-string network byte order format, any positive inte= ger >> >+ * >> This statement looks incomplete. You can write it "it should be positive >> integer " but is it required to be mentioned? Coz input is array of uint= 8_t so >> assumption is it will be positive. >> >Actually by this we meant that there is no constraint (if should be prime= , co-prime, semi-prime, multi-prime, less than... etc), >But yes this is only informational and probably could even be omitted So, will you be re-wording these comments for better clarity? Thanks Shally > >> ... >> > struct rte_crypto_modinv_xform { >> > rte_crypto_param modulus; >> > /**< >> >- * Pointer to the prime modulus data for modular >> >- * inverse operation in octet-string network byte >> >- * order format. >> >+ * Pointer to the modulus data for modular multiplicative inver= se >> >+ * operation in octet-string network byte order format, >> >+ * positive integer >> Same comment as above. >> >> >+ * >> >+ * In case this number is equal to zero the driver shall set >> >+ * the crypto op status field to RTE_CRYPTO_OP_STATUS_ERROR >> >+ * >> >+ * This number shall be relatively prime to base >> >+ * in corresponding Modular Multiplicative Inverse >> >+ * rte_crypto_mod_op_param >> > */ >> > }; >> > >> >@@ -317,14 +327,18 @@ struct rte_crypto_dsa_xform { >> > >> ... >> >> >2.1.0