From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5102A04C1; Mon, 10 Aug 2020 11:52:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 151AB1C027; Mon, 10 Aug 2020 11:52:28 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 5B5A6F94 for ; Mon, 10 Aug 2020 11:52:26 +0200 (CEST) IronPort-SDR: SsIgfABnjfL00E9wUsz9zq9/KYgMnr1DCMdUod4PcWi4MtKSjpx/lryf0n9rRqkmCBYLek85Dx pQ99OCcPODeQ== X-IronPort-AV: E=McAfee;i="6000,8403,9708"; a="133557040" X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="133557040" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 02:52:23 -0700 IronPort-SDR: B8t9961Xm24PGY+MqUGmdJCzD3B0tmXfU5XHYZfDvxKp+oPVaIpk8fk2oH2eKAt80fXPPJ9sCb YxnBPMUAqmSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="368564636" Received: from orsmsx605-2.jf.intel.com (HELO ORSMSX605.amr.corp.intel.com) ([10.22.229.85]) by orsmga001.jf.intel.com with ESMTP; 10 Aug 2020 02:52:23 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 10 Aug 2020 02:52:22 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 10 Aug 2020 02:52:22 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX152.amr.corp.intel.com (10.22.226.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Aug 2020 02:52:22 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.45) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Aug 2020 02:52:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XAEdonuNVTj0cEdT6PZgUDayTZqSBAT6rw9gffE1cVAF2uLvS3Aa0gNY+1rrmHNVmBwiZwyYk825hxWue15YIJy2Y4pq6b9OFKLtVfrQP4kytqeVr9s/+UMeqIuKVdkxxywxlwIJbfKq5x44NiSEb6D6cE6q2bHOvuTzIAZ9LuwySo6DBW3ZLscOUpeOUWIK1keNZmBhj/nLnAHbEUdiXxkeekCDIwMgY14YZ8O1ZKaEE6MdWOD37AQNHvcy6qYPH397VpOT36Y78XTMmjyrMqN3u9OdUNu6EH+XCCtmMSY5K0w09CSkpw59q3Bhbe/JpkFDoNdeaHMSz/CO44yAZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T2NVvDOEtWcDrUypaTCJYTYx12wS/WinVyN5Z1aahko=; b=BNKjzQCWMngZ/5NP5ouW19kw7OjvUXGQRRapRx95i2GwSJnbw0cttLM9C/AcJPkCm1rK5DPnpRm6KGS6d4sGfJSCj8bwq1HUFk+HUD0umqi5QkWNJDcUgVx4T+rFu3dZR77ypw+QRlNMpO0cIkHqcOTVIsU+WuPceoXvPaZikWVZnQrFuTx0oZvuLoXQSnAksRjJJ+PkX29a/NjS4TcYHkNMn652EVE0eyyhEkh76E+cbpW/o49+hyyVDvnrZ0y0gqZS/+9+odusuNrMhTwo9GBO9iwbA5QyN6IGkVuXkIOcht3ID/KpEaaUhI2OT+CI5rhyDnlWvlsiqPPpsi41LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T2NVvDOEtWcDrUypaTCJYTYx12wS/WinVyN5Z1aahko=; b=LUl3YHEvAOmd1sIN2Cy5XocT4Eq/KpfK1oRnuM8e2FcvoM2EH6+jb6Vcigxa1UApcnPCV1eszvbBbanPCgzIwp9OzjZrSHKsNX48q2yY9eLil5r5Kv9xUDlm8BFheXYxIqjrVgLHRs49F3/2/49mnCX55qSYGF+QGiyI2p5uqIQ= Received: from BN7PR11MB2548.namprd11.prod.outlook.com (2603:10b6:406:b3::19) by BN8PR11MB3682.namprd11.prod.outlook.com (2603:10b6:408:88::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.22; Mon, 10 Aug 2020 09:52:20 +0000 Received: from BN7PR11MB2548.namprd11.prod.outlook.com ([fe80::98a5:2ddd:172c:d62f]) by BN7PR11MB2548.namprd11.prod.outlook.com ([fe80::98a5:2ddd:172c:d62f%3]) with mapi id 15.20.3261.024; Mon, 10 Aug 2020 09:52:20 +0000 From: "Power, Ciara" To: Stephen Hemminger CC: "dev@dpdk.org" , "Richardson, Bruce" , "Van Haaren, Harry" , "Stokes, Ian" Thread-Topic: [dpdk-dev] [PATCH 20.11 00/12] add max SIMD bitwidth to EAL Thread-Index: AQHWbNTA7L+FoZ4LaEaCSQ/EdKeSM6ks01WAgARJoXA= Date: Mon, 10 Aug 2020 09:52:20 +0000 Message-ID: References: <20200807155859.63888-1-ciara.power@intel.com> <20200807091917.0ae3a7f4@hermes.lan> In-Reply-To: <20200807091917.0ae3a7f4@hermes.lan> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [37.228.239.229] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6746ed9-b6f5-4c11-06fc-08d83d1312e5 x-ms-traffictypediagnostic: BN8PR11MB3682: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WhZk70TjYYS3ruxLqPebpvXqUVMblLkp9IfQDX+j4/pIzQCpTJIgiFxB8bWlpEkHnXLpMtzSP3z1wXmi3gxB7VmP6QDBXrFPPS+fA/nniCqDHJZV4dT+zmiaWchgO6cXsUiqi6DpBs+0eD7GIds28HhzUCz9C8lw3hNvPrUroX5Uevu5q+WG/KHkerrKiyRo4pfw1p6FqK1ymZfOHMyN7IHw1G5dFXhSewy2n1m+os4ruWvbMVPGW2nmrXYHD8aezPcKUhMGzx9Uh9IygjsJdLpb4l+069n602YlL/GEv0m/1KOW6bZh0kwZc08xAs7f x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR11MB2548.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(396003)(376002)(39860400002)(346002)(54906003)(316002)(6916009)(71200400001)(9686003)(83380400001)(55016002)(107886003)(26005)(478600001)(66446008)(66556008)(52536014)(66476007)(64756008)(186003)(76116006)(86362001)(66946007)(2906002)(4326008)(6506007)(8676002)(7696005)(33656002)(5660300002)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 7IkgYgW5PBmiIDxYdtXhTue4TBDkc8YyPTQy1ryP/0tOtC6ENF769amv+Rnek7vyludDgD7G6uyx+NfHok9LAYcN3QXGJz1YZtgw+D/lRI7OAOc1MpZyMPmAcQLNQMTea8+TF/VJIm3R+QmFEADC5y6g5kWNmzvgQAp8zQ68xAkaLX/eomMkR2X9EMucVBIJpeSMFwweWtfCMrnEYZz8jMFVOWGc+MilT4t/7XBJv43rbgFSWBPNa2U7kJGNUAp4DOiZcSS2g8ibFa3wOXdoykj4Wmq9l9/doY8ARn6lSWnL58imHwnY0i0T+AczU5xXYBQhZQOt1rxjNu2rSqu7pcBfdPisNIS3EIou0LcbVhOQOYwkXqforGNL8Wd6T442/d2CD3WkFO0TCWPGW/jHopvLnlMJEJNlvlwikvc64Bg97BUvvHL4+ry9rXJuooFIQGdcCq5vjRvzw/pvyZBuyeMgeJYUuS+4vX6zI+G2ao2PJBuLSDYdJN67rwlMGeYftyJgKvUusYoiqxq+a+/zxEl6G5PXD0pPpaSl8h4lIV7SWYDakWX4qQAZ80ucKI6Zg3EREIhMby40rru1PM2R7D1RJuM2bdOPYWjami6GLaITwoA7opC2ICKosGq0PEFO5P2bLOFYU4bodGRr7Gs1+A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR11MB2548.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6746ed9-b6f5-4c11-06fc-08d83d1312e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2020 09:52:20.1538 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rDEIq8L1u/RphdZP+rpWhNwQ6eyuFKLaW1IkYZatpkiPinypYjVu7CPUMa2L0ytaDfdyDfQbYOVIZeuqB8NlqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3682 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 20.11 00/12] add max SIMD bitwidth to EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, To give an overview of the rationale behind the patchset: - It allows other apps such as OVS and VPP which already make use of AVX-512 to indicate that they are happy for DPDK to use AVX-512 too. - It allows the end-user to override those settings if so desired. - It allows an easy way for the user to test with different vector paths b= y limiting bitwidths. I can add some documentation for this in a v2, thanks for the suggestion. - Ciara >-----Original Message----- >From: Stephen Hemminger >Sent: Friday 7 August 2020 17:19 >To: Power, Ciara >Cc: dev@dpdk.org; Richardson, Bruce >Subject: Re: [dpdk-dev] [PATCH 20.11 00/12] add max SIMD bitwidth to EAL > >On Fri, 7 Aug 2020 16:58:47 +0100 >Ciara Power wrote: > >> A number of components in DPDK have optional AVX-512 or other vector >> code paths which can be selected at runtime. Rather than having each >> component provide its own mechanism to select a code path, this >> patchset adds support for a single setting to control what code paths ar= e >used. >> This can be used to enable some non-default code paths e.g. ones using >> AVX-512, but also to limit the code paths to certain vector widths, or >> to scalar code only, which is useful for testing. >> >> The max SIMD bitwidth setting can be set by the app itself through use >> of the available API, or can be overriden by a commandline argument >> passed by the user. >> >> Ciara Power (12): >> eal: add max SIMD bitwidth >> eal: add default SIMD bitwidth values >> net/i40e: add checks for max SIMD bitwidth >> net/axgbe: add checks for max SIMD bitwidth >> net/bnxt: add checks for max SIMD bitwidth >> net/enic: add checks for max SIMD bitwidth >> net/fm10k: add checks for max SIMD bitwidth >> net/iavf: add checks for max SIMD bitwidth >> net/ice: add checks for max SIMD bitwidth >> net/ixgbe: add checks for max SIMD bitwidth >> net/mlx5: add checks for max SIMD bitwidth >> net/virtio: add checks for max SIMD bitwidth >> >> drivers/net/axgbe/axgbe_rxtx.c | 3 +- >> drivers/net/bnxt/bnxt_ethdev.c | 6 ++- >> drivers/net/enic/enic_rxtx_vec_avx2.c | 3 +- >> drivers/net/fm10k/fm10k_ethdev.c | 11 ++-- >> drivers/net/i40e/i40e_rxtx.c | 19 ++++--- >> drivers/net/iavf/iavf_rxtx.c | 16 +++--- >> drivers/net/ice/ice_rxtx.c | 20 ++++--- >> drivers/net/ixgbe/ixgbe_rxtx.c | 7 ++- >> drivers/net/mlx5/mlx5_ethdev.c | 3 +- >> drivers/net/virtio/virtio_ethdev.c | 12 +++-- >> lib/librte_eal/arm/include/rte_vect.h | 2 + >> lib/librte_eal/common/eal_common_options.c | 63 >++++++++++++++++++++++ >> lib/librte_eal/common/eal_internal_cfg.h | 8 +++ >> lib/librte_eal/common/eal_options.h | 2 + >> lib/librte_eal/include/generic/rte_vect.h | 2 + >> lib/librte_eal/include/rte_eal.h | 31 +++++++++++ >> lib/librte_eal/ppc/include/rte_vect.h | 2 + >> lib/librte_eal/rte_eal_version.map | 4 ++ >> lib/librte_eal/x86/include/rte_vect.h | 2 + >> 19 files changed, 184 insertions(+), 32 deletions(-) >> > >This looks useful, could you add some documentation on rationale and how >you expect application to set it.