From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C753A0350; Mon, 22 Jun 2020 05:05:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AEF81C117; Mon, 22 Jun 2020 05:05:23 +0200 (CEST) Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) by dpdk.org (Postfix) with ESMTP id EBA341C10F for ; Mon, 22 Jun 2020 05:05:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3688; q=dns/txt; s=iport; t=1592795121; x=1594004721; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=D2r0kyp1Sqp9q7ikPcW8BRoyfwh5B4NwKGtuRoGYSW8=; b=iSDN/ZLevRHKSy3YsqC5t/nbNLax6LtPEataAokCqiOtLMhmPOmviBsH CIJ5n7lfxb3QrkjpGkgXOmnF5FrU+9wke1VkraCGv/nDL/x8aATtNjD1s YXIpRxl2j6P72ITRjdHXyCVM5AvGC4fNhngWA/4W3FNQqv1nkH/qEtNQq s=; IronPort-PHdr: =?us-ascii?q?9a23=3AY6yqMh30oYJP6HPGsmDT+zVfbzU7u7jyIg8e44?= =?us-ascii?q?YmjLQLaKm44pD+JxWGu6dtkVbWUISd4PVB2KLasKHlDGoH55vJ8HUPa4dFWB?= =?us-ascii?q?JNj8IK1xchD8iIBQyeTrbqYiU2Ed4EWApj+He2YkhIEdnzZhvZpXjhpTIXEw?= =?us-ascii?q?/0YAxyIOm9E4XOjsOxgua1/ZCbYwhBiDenJ71oKxDjpgTKvc5Qioxneas=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CuBQAJH/Be/4gNJK1mHAEBAQEBAQc?= =?us-ascii?q?BARIBAQQEAQFAgUqBUlEHgUcvLAqHYAONQJhUglIDVQsBAQEMAQEtAgQBAYR?= =?us-ascii?q?HAoIoAiQ4EwIDAQELAQEFAQEBAgEGBG2FWwyFcgEBAQEDEhUTBgEBNwELBAI?= =?us-ascii?q?BCBEEAQEfEDIdCAIEAQ0FCBqFUAMuAawVAoE5iGF0gQEzgwEBAQWFDRiCDgm?= =?us-ascii?q?BOIJnhA+BcIN9GoFBP4FUgk0+hD+DRYItjnYjpT4KglqZSZ57kSueSAIEAgQ?= =?us-ascii?q?FAg4BAQWBaiKBVnAVgyRQFwINjh6DcYgtgXABOHQCNQIGCAEBAwl8jykBgRA?= =?us-ascii?q?BAQ?= X-IronPort-AV: E=Sophos;i="5.75,265,1589241600"; d="scan'208";a="770811126" Received: from alln-core-3.cisco.com ([173.36.13.136]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 22 Jun 2020 03:05:19 +0000 Received: from XCH-RCD-005.cisco.com (xch-rcd-005.cisco.com [173.37.102.15]) by alln-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id 05M35JEM004011 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 22 Jun 2020 03:05:19 GMT Received: from xhs-rcd-001.cisco.com (173.37.227.246) by XCH-RCD-005.cisco.com (173.37.102.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Jun 2020 22:05:19 -0500 Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 21 Jun 2020 22:05:18 -0500 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 21 Jun 2020 22:05:18 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mb9bG8gEE71nPH74wlLQVbDZVHg8F44B/vzRu/VcDNFfhJGCINdGH1nnL4j3lSB9cYamkF2zZZ99Gvx0RIrDgAmIVZTnMSECO/9is6c9UtfdsTCO1sHQsnzkBdP65TwDUaTqYDHQAImpE5xPmB6YWJ6HtkDlME76sel78Oe6abLclz0aL38SSdGNPn5huHvXty5o2tXRRYi31i0ieF+tm/3RJSc5zCI9dOYVJuiV1sOCsGG6J0H3AU9gbb2y3rTxjXyvZ8TfMOr5so+gtgd1AGJ1q2FLDYw0wNMkDLAmpzYs6I3F3Dm3pJ1BL4gc9j8bkZsWyZZChGkdlLOEyor9nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QUmrvuXEvKf8FJ9pDGFchoyYVJV/ZoHC2eFTIC6aVbM=; b=HGrgsg/MaQ3U7lTg19s+roErrFGXxjijgU7R3TEofi9UFCKHAVlO6u+omn8AzBeVhmrrYnreSI92+RB8WO7P2f+3/14Gm3v7zLMpuIp7cH8ivO7lzj9PO5qnSKgMUpi8iak9r/6ko8LJg3Enrf4j04WIk9ch3w9nqybk/VIYN77o65leVNHejrA0DRZvhEz3dzI/huJFmA1CoKEQ4YxQB104qIUYsN0bY9ZKxyYuaWBI5AHlrLn8BS08h7xD5GM8HJVd0AuxOxAtKj3Q9Hx+nqtlZ3icIHt/RVJf884Bn9FlzLjgA6z1Kn9/d4B/+f5RVZLuROjT7engkbMvYjKETw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QUmrvuXEvKf8FJ9pDGFchoyYVJV/ZoHC2eFTIC6aVbM=; b=BRIqHNZobOCHk4ULVtGeYrj3b/70VVIJOW6zAKKWmBv6NzeJlNmv+28tWlWy5z0d8hEh27roMzY8/4WCre0ioFCWGTK4bcwE90Q7rt1jhRCS8n1bClTHc3MTCmnE0AKY432qwyPB0P8VQK0O0zD2KlaWPv0MbRsrKF8Tm2Yma30= Received: from BN7PR11MB2738.namprd11.prod.outlook.com (2603:10b6:406:b3::26) by BN8PR11MB3732.namprd11.prod.outlook.com (2603:10b6:408:83::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Mon, 22 Jun 2020 03:05:18 +0000 Received: from BN7PR11MB2738.namprd11.prod.outlook.com ([fe80::e137:4e1:9503:bdec]) by BN7PR11MB2738.namprd11.prod.outlook.com ([fe80::e137:4e1:9503:bdec%3]) with mapi id 15.20.3109.026; Mon, 22 Jun 2020 03:05:18 +0000 From: "Hyong Youb Kim (hyonkim)" To: "Wei Hu (Xavier)" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "anatoly.burakov@intel.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@nxp.com" , "John Daley (johndale)" , "qi.z.zhang@intel.com" , "xiao.w.wang@intel.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "beilei.xing@intel.com" , "jia.guo@intel.com" , "heinrich.kuhn@netronome.com" , "hkalra@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "kirankumark@marvell.com" , "rmody@marvell.com" , "shshaikh@marvell.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities Thread-Index: AQHWSD/32c3ZafmBskC/oiDGENErq6jj8pBw Date: Mon, 22 Jun 2020 03:05:17 +0000 Message-ID: References: <1592794047-51529-1-git-send-email-xavier.huwei@huawei.com> <1592794047-51529-3-git-send-email-xavier.huwei@huawei.com> In-Reply-To: <1592794047-51529-3-git-send-email-xavier.huwei@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=cisco.com; x-originating-ip: [64.104.44.106] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 80d7f57d-8891-48c1-379b-08d8165917dd x-ms-traffictypediagnostic: BN8PR11MB3732: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:268; x-forefront-prvs: 0442E569BC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CS3C2DPChGopK1BzlkQ26Wk5D4TBwChILRX8Hgqv/U+n2cd5fJqDg6SDqBaiQ9eIDCfEAkp9IZrYhf3rwlcCVCRgMG0GEKR3DU1vMIUOAtF01wFX31GrfeBlgxIxdYykoKivOa9e1sc8gS7o9vsA7F+KSp5j0bUxb+xSvkP/kC8T+Vop+wezOFY0uCelGNnjGZ6GXk0bF0Y9IN76RWjRuBP3ZxXWslUBIc5APOJHc6nMTus3VzTXOyx1aBg9eVrLru+4Y57q0dVZ53RbFqTVa6ZwiEkN6yiM222bBAQdVB+GkNmYwjNnZ0CfaiPwXEHqprL6wOPVWdK0/ctywVR6taPAUqN9Zh96UAz44FvlsfKDeA79lcZFkl5FrGaYkVRg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR11MB2738.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(366004)(346002)(39860400002)(376002)(52536014)(2906002)(55016002)(9686003)(71200400001)(7696005)(33656002)(5660300002)(66946007)(66556008)(66476007)(186003)(83380400001)(76116006)(64756008)(8936002)(53546011)(6506007)(86362001)(66446008)(26005)(8676002)(7416002)(316002)(110136005)(4326008)(478600001)(921003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 2QfBbJp2fbQMYU6mIOgJAABHE0ayDhR257omWnsdXkirE/4IPa71TA98wqpOKdbhPHAYyhcFfeujU+BG8q23AzevHW0jRKViMIrKF2WT3nnj1TJwMkUOjOL+r0r61ttzsWxGFilBFf/e5EATwC2EjprTjT5OUsWlMZXHqfzpGGLra5Un0aQQVT702daIjsWeXKfdqSqJ7M6vkmS1itkNSkHK6JKnP6eE/wocph0w0dsUcTtQkCy0XnJ+wM0BhM1Sw2mpm0/NxIIAfU4PexlzwNG6zkOQ098p/CYbCCDUBlONpx3cIZhYe+e2/vNdgq8SiVI/w6L94T0hdSgscIxBiSqtt1poouf4B+M/9muW+m5EKAnDV2n34Abhx66W/hLInyqiqax7dqf7hJF0lJm54jk59aAe35nZLdET1vUZTRyL6/VsgtGvmDyRL1jkMg2lJtY010SEW55AAaJnvA1yLBu9Nlo3B3eU0gOSSTn8scU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 80d7f57d-8891-48c1-379b-08d8165917dd X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2020 03:05:17.8210 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2Nlvdw5XrCPNgABu1ba6X2dRmLwoA6WnwusUoZJvZXAgoTELmGckLBYZJilQQIdE0Oj+dr3kMIQv7yI/23n42Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3732 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.37.102.15, xch-rcd-005.cisco.com X-Outbound-Node: alln-core-3.cisco.com Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: > -----Original Message----- > From: Wei Hu (Xavier) > Sent: Monday, June 22, 2020 11:47 AM > To: thomas@monjalon.net; ferruh.yigit@intel.com; > arybchenko@solarflare.com; anatoly.burakov@intel.com; > hemant.agrawal@nxp.com; sachin.saxena@nxp.com; John Daley (johndale) > ; Hyong Youb Kim (hyonkim) ; > qi.z.zhang@intel.com; xiao.w.wang@intel.com; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; > beilei.xing@intel.com; jia.guo@intel.com; heinrich.kuhn@netronome.com; > hkalra@marvell.com; jerinj@marvell.com; ndabilpuram@marvell.com; > kirankumark@marvell.com; rmody@marvell.com; shshaikh@marvell.com > Cc: dev@dpdk.org; xavier.huwei@huawei.com > Subject: [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative > capabilities >=20 > Currently, there is a potential problem that calling the API function > rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the > driver does not support. If the PMD driver does not support certain VLAN > hardware offloads and does not check for it, the hardware setting will > not change, but the VLAN offloads in dev->data->dev_conf.rxmode.offloads > will be turned on. >=20 > It is supposed to check the hardware capabilities to decide whether the > relative callback needs to be called just like the behavior in the API > function named rte_eth_dev_configure. And it is also needed to cleanup > duplicated checks which are done in some PMDs. Also, note that it is > behaviour change for some PMDs which simply ignore (with error/warning > log > message) unsupported VLAN offloads, but now it will fail. >=20 > Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengchang Tang > Signed-off-by: Wei Hu (Xavier) > Acked-by: Andrew Rybchenko > --- > v2 -> v3: Add __rte_unused to avoid unused parameter 'dev' and 'mask' > warning. > v1 -> v2: cleanup duplicated checks which are done in some PMDs. > --- > drivers/net/dpaa2/dpaa2_ethdev.c | 5 ----- > drivers/net/enic/enic_ethdev.c | 12 ------------ > drivers/net/fm10k/fm10k_ethdev.c | 23 ++--------------------- > drivers/net/hinic/hinic_pmd_ethdev.c | 6 ------ > drivers/net/i40e/i40e_ethdev.c | 5 ----- > drivers/net/nfp/nfp_net.c | 5 ----- > drivers/net/octeontx/octeontx_ethdev_ops.c | 10 ---------- > drivers/net/octeontx2/otx2_vlan.c | 5 ----- > drivers/net/qede/qede_ethdev.c | 3 --- > lib/librte_ethdev/rte_ethdev.c | 21 +++++++++++++++++++++ > 10 files changed, 23 insertions(+), 72 deletions(-) >=20 [...] > diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethde= v.c > index 32d5397..ef8900d 100644 > --- a/drivers/net/enic/enic_ethdev.c > +++ b/drivers/net/enic/enic_ethdev.c > @@ -374,18 +374,6 @@ static int enicpmd_vlan_offload_set(struct > rte_eth_dev *eth_dev, int mask) > enic->ig_vlan_strip_en =3D 0; > } >=20 > - if ((mask & ETH_VLAN_FILTER_MASK) && > - (offloads & DEV_RX_OFFLOAD_VLAN_FILTER)) { > - dev_warning(enic, > - "Configuration of VLAN filter is not supported\n"); > - } > - > - if ((mask & ETH_VLAN_EXTEND_MASK) && > - (offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)) { > - dev_warning(enic, > - "Configuration of extended VLAN is not > supported\n"); > - } > - > return enic_set_vlan_strip(enic); > } >=20 For enic, Acked-by: Hyong Youb Kim Thanks. -Hyong