From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 548B7A2EEB for ; Wed, 11 Sep 2019 10:46:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10C3B1E980; Wed, 11 Sep 2019 10:46:58 +0200 (CEST) Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) by dpdk.org (Postfix) with ESMTP id 999301E900 for ; Wed, 11 Sep 2019 10:46:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3872; q=dns/txt; s=iport; t=1568191616; x=1569401216; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7PrkQFTNVZlv6pyJ7GvYBUEf5+FxHlxOFjG38OLPCuQ=; b=dXb7XGz4KEpRMmYJtPAVSlSYzqqcaQG8v0XhbTKbEJUIbxI25dNa4TI5 XVYx0G2/Y5yviY5Hiy3OwFlcZm+jXpawyYqJG0p5tL79mQhzwy+TQjBfy UuvEBeQesmq9P+vISzGs/1gXg7YvdsE17hURxUYZhhmlkUKKmI7+CHr/3 A=; IronPort-PHdr: =?us-ascii?q?9a23=3Abjlh9BQJpCY5xSXWul1Jodii79psv++ubAcI9p?= =?us-ascii?q?oqja5Pea2//pPkeVbS/uhpkESXBdfA8/wRje3QvuigQmEG7Zub+FE6OJ1XH1?= =?us-ascii?q?5g640NmhA4RsuMCEn1NvnvOiwrG8JBVVpN9HCgOk8TE8H7NBXf?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AJAACws3hd/5BdJa1lGgEBAQEBAgE?= =?us-ascii?q?BAQEHAgEBAQGBUwUBAQEBCwGBRFADgUMgBAsqh2gDhFKGKYJcl3CBLhSBEAN?= =?us-ascii?q?UCQEBAQwBAS0CAQGEPwKCUyM0CQ4CAwEDAgMBAQQBAQECAQYEbYUuDIVKAQE?= =?us-ascii?q?BAQIBEhUTBgEBNwEEBwQCAQgOAwQBARYJEDIdCAIEAQ0FCBqEawMODwECnjQ?= =?us-ascii?q?CgTiIYYFyM4J9AQEFgQUBAYQAGIIWCYE0AYt3GIFAP4ERRoJMPoN/Rz2CfoI?= =?us-ascii?q?mjFyfbwqCIZUSmQqNf5huAgQCBAUCDgEBBYFSOIFYcBWDJ1AQFIFODBeDT4o?= =?us-ascii?q?cATZzgSmOfwEB?= X-IronPort-AV: E=Sophos;i="5.64,492,1559520000"; d="scan'208";a="335308504" Received: from rcdn-core-8.cisco.com ([173.37.93.144]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 11 Sep 2019 08:46:55 +0000 Received: from XCH-ALN-013.cisco.com (xch-aln-013.cisco.com [173.36.7.23]) by rcdn-core-8.cisco.com (8.15.2/8.15.2) with ESMTPS id x8B8ktbo027908 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 11 Sep 2019 08:46:55 GMT Received: from xhs-aln-002.cisco.com (173.37.135.119) by XCH-ALN-013.cisco.com (173.36.7.23) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 11 Sep 2019 03:46:54 -0500 Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-aln-002.cisco.com (173.37.135.119) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 11 Sep 2019 03:46:53 -0500 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 11 Sep 2019 03:46:53 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MBLBDNMe78quYpzkIkRCfV5iNgg69qcqt0/5VWqvKN4+asuEh7EuCvkWcOg3Qbwi8DxNQj/zNj52S5CieqVKW9CArIj4JESiCMeM2JY/nbQAl0McTj9NQSikeO3rQxP059qcfaC4JWbjrva4wP1g1n0dH3Hrs2OKOzB+AJMfhtV6/MZvixNKEH2Aw1i6ayKqjWc0h0n3cO8cWo4+Nfwds8xkOhwJl7l1StzdDDU5k3AWqKrZk7lL/usRW/jpy6CiMdki+FeZck7697euyXZwH+MLjqZ8fSCVbWDnI2xBpZ+vWaP+SPmBsO/arqmuQvJT4NjqA037LWDkLwTvQCVcEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vi48zJhkcEyc9zKo1EtDznb09jHwm/usjUOa0ylGvZ8=; b=l3YSig8VeeLdQ/CqnZhXhsVOYzQmCy/JDrJXuNhb56j0XbHHRH1DBUdhSQ7rXHkamh7UYTLF0shqTLAzV7dnXpEb/LJ4xPKFb8Lte850BX9+5Qeg2fEdbrp7BlCeeRmXQxzruA1EIdQIXEVHB10BptfMy1j8k7wbUp6r47e9Oi21nlRdLarT8MmWNYM+Jem8qQH3o5G94w2dL1BtGdyY3n2EH5NMn9Sc6jf+z1g+zCyXfcGN1lhOsfA1KuoQJ9hCSF4QxgbKOX6zMFqfAVWpBoFJyHT2ewztCOV65iOJLzguM39VVSmZy4skdLQmI/xJL0pEThGUOqwspEGroiGDqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vi48zJhkcEyc9zKo1EtDznb09jHwm/usjUOa0ylGvZ8=; b=b2k8+QwfbhmSxywp67wHznlJ9+sBoE+FoRK9vX7rtOAfz2Cw/PRqsScpOC1Wyz1zj5D0uY//IA8FGr1uOAh3rZgKeb4/9QGlz1SMsy1j1xCbd4nzezHoR46C/lx4s1t8kGtXc4hAOq/TO6wWup3mh9FlE9ORxaMqidgoKZAeaE0= Received: from BN7PR11MB2738.namprd11.prod.outlook.com (52.135.245.154) by BN7PR11MB2691.namprd11.prod.outlook.com (52.135.245.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.21; Wed, 11 Sep 2019 08:46:52 +0000 Received: from BN7PR11MB2738.namprd11.prod.outlook.com ([fe80::482e:6776:9bfe:cccf]) by BN7PR11MB2738.namprd11.prod.outlook.com ([fe80::482e:6776:9bfe:cccf%5]) with mapi id 15.20.2263.015; Wed, 11 Sep 2019 08:46:52 +0000 From: "Hyong Youb Kim (hyonkim)" To: Andrew Rybchenko , "John W. Linville" , Xiaolong Ye , Qi Zhang , Igor Russkikh , "Pavel Belous" , Allain Legacy , Matt Peters , "Ravi Kumar" , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , "Somnath Kotur" , Chas Williams , "Rahul Lakkireddy" , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Gagandeep Singh , "John Daley (johndale)" , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Yongseok Koh , "Viacheslav Ovsiienko" , Zyta Szpak , "Liron Himi" , Tomasz Duszynski , "Stephen Hemminger" , "K. Y. Srinivasan" , Haiyang Zhang , Rastislav Cernay , Jan Remes , Alejandro Lucero , Jerin Jacob , "Nithin Dabilpuram" , Kiran Kumar K , Keith Wiles , Maciej Czekaj , Maxime Coquelin , "Tiwei Bie" , Zhihong Wang , Yong Wang , Thomas Monjalon , Ferruh Yigit CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status Thread-Index: AQHVZwYnXUhhbxP/CkaHgozmUlvOwKcmIJBQ Date: Wed, 11 Sep 2019 08:46:52 +0000 Message-ID: References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-5-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1568030331-16526-5-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hyonkim@cisco.com; x-originating-ip: [2001:420:c0dc:1002::1ab] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1eaa6ab8-31d3-483a-a846-08d7369497aa x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BN7PR11MB2691; x-ms-traffictypediagnostic: BN7PR11MB2691: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 0157DEB61B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(189003)(199004)(13464003)(11346002)(478600001)(102836004)(52536014)(6116002)(6246003)(446003)(476003)(14454004)(7736002)(46003)(64756008)(66446008)(66556008)(71190400001)(71200400001)(486006)(76116006)(66946007)(66476007)(2906002)(316002)(5660300002)(33656002)(86362001)(99286004)(8936002)(6436002)(186003)(110136005)(14444005)(256004)(81156014)(1191002)(53936002)(81166006)(9686003)(55016002)(8676002)(1511001)(74316002)(53546011)(25786009)(6506007)(7366002)(7406005)(7696005)(7416002)(4326008)(305945005)(229853002)(76176011)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR11MB2691; H:BN7PR11MB2738.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JB9+gbD4yXGNL+vtELTwW0B8sRMRAniWBvU4OfzMcWoNeNPDUrW0ibsXSDu2hh7L71ERCuA/loi9/QUaeJhLSpkWGkeOX8Uq6S+Y0c73yuLAcUq5A3T2u5w3KVGeuIWc+NDgWZ1D35GUPZT5e39ySx2haNN27oAJjLQHPG4+CzWoa05WXCycgU7JfppkWB8zyUQHyov1slfFwjbaaKx0WHULmOczsyyfOoUnIxSCkr6Amm1ZoDHFM51u56+/emEbH35Q7z6Bb12Xq0eEScMYiAAJUH8PFl/ljK/91Oy6HrGr7uEAxC7B5T1VmJSO41SkCQZXeva0m10k4C/sU9epppIImtw42e6qxGbCWLAMy4/bCN/EZtt68abjhOfYGDyfoIM7J13vo4JVn2PJigVDOLzmn6L53jSLYGheg/hG3SY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1eaa6ab8-31d3-483a-a846-08d7369497aa X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2019 08:46:52.0370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WbhEapm0soFC9Y3T9h0j/+4iBqxJjW9Au6iTJ7xfz5sNgCaodFL9MzwrY9e5JppMLSh2rSZdfa7OGFJwGn6K1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2691 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.23, xch-aln-013.cisco.com X-Outbound-Node: rcdn-core-8.cisco.com Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Andrew Rybchenko > Sent: Monday, September 9, 2019 8:59 PM [...] > Subject: [PATCH v2 04/13] ethdev: change promiscuous callbacks to return > status >=20 > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. >=20 > When correct return status is unclear from driver code, -EAGAIN is used. >=20 > Signed-off-by: Andrew Rybchenko > --- [...] > drivers/net/enic/enic.h | 2 +- > drivers/net/enic/enic_ethdev.c | 22 +++++++--- > drivers/net/enic/enic_main.c | 4 +- [...] > static void > diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h > index 5a92508f00..72b1e7956b 100644 > --- a/drivers/net/enic/enic.h > +++ b/drivers/net/enic/enic.h > @@ -305,7 +305,7 @@ int enic_get_link_status(struct enic *enic); > int enic_dev_stats_get(struct enic *enic, > struct rte_eth_stats *r_stats); > void enic_dev_stats_clear(struct enic *enic); > -void enic_add_packet_filter(struct enic *enic); > +int enic_add_packet_filter(struct enic *enic); > int enic_set_mac_address(struct enic *enic, uint8_t *mac_addr); > int enic_del_mac_address(struct enic *enic, int mac_index); > unsigned int enic_cleanup_wq(struct enic *enic, struct vnic_wq *wq); > diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethde= v.c > index 90fdeda901..5d48930a9d 100644 > --- a/drivers/net/enic/enic_ethdev.c > +++ b/drivers/net/enic/enic_ethdev.c > @@ -603,29 +603,39 @@ static const uint32_t > *enicpmd_dev_supported_ptypes_get(struct rte_eth_dev *dev) > return NULL; > } >=20 > -static void enicpmd_dev_promiscuous_enable(struct rte_eth_dev > *eth_dev) > +static int enicpmd_dev_promiscuous_enable(struct rte_eth_dev *eth_dev) > { > struct enic *enic =3D pmd_priv(eth_dev); > + int ret; >=20 > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > - return; > + return -ENOTSUP; Should return -E_RTE_SECONDARY to be consistent with other handlers that check primary/secondary. >=20 > ENICPMD_FUNC_TRACE(); >=20 > enic->promisc =3D 1; > - enic_add_packet_filter(enic); > + ret =3D enic_add_packet_filter(enic); > + if (ret !=3D 0) > + enic->promisc =3D 0; > + > + return ret; > } >=20 > -static void enicpmd_dev_promiscuous_disable(struct rte_eth_dev > *eth_dev) > +static int enicpmd_dev_promiscuous_disable(struct rte_eth_dev *eth_dev) > { > struct enic *enic =3D pmd_priv(eth_dev); > + int ret; >=20 > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > - return; > + return -ENOTSUP; Should return -E_RTE_SECONDARY here too. > ENICPMD_FUNC_TRACE(); > enic->promisc =3D 0; > - enic_add_packet_filter(enic); > + ret =3D enic_add_packet_filter(enic); > + if (ret !=3D 0) > + enic->promisc =3D 1; > + > + return ret; > } >=20 > static void enicpmd_dev_allmulticast_enable(struct rte_eth_dev *eth_dev) > diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c > index 40af3781b3..f4e76a057a 100644 > --- a/drivers/net/enic/enic_main.c > +++ b/drivers/net/enic/enic_main.c > @@ -1364,10 +1364,10 @@ int enic_set_vlan_strip(struct enic *enic) > enic->rss_enable); > } >=20 > -void enic_add_packet_filter(struct enic *enic) > +int enic_add_packet_filter(struct enic *enic) > { > /* Args -> directed, multicast, broadcast, promisc, allmulti */ > - vnic_dev_packet_filter(enic->vdev, 1, 1, 1, > + return vnic_dev_packet_filter(enic->vdev, 1, 1, 1, > enic->promisc, enic->allmulti); > } >=20 A couple minor comments above. Other than those, patch works fine for enic. Feel free to add my ack on v2.. Acked-by: Hyong Youb Kim Thanks. -Hyong