Re: [dpdk-dev] [PATCH v6 03/14] doc: remove references to make from NICs guides

["Hyong Youb Kim (hyonkim)" <hyonkim@cisco.com>]

> -----Original Message-----
> From: Ciara Power <ciara.power@intel.com>
> Sent: Friday, October 9, 2020 7:21 PM
> To: dev@dpdk.org
[...]
> Subject: [PATCH v6 03/14] doc: remove references to make from NICs guides
> 
> Make is no longer supported for compiling DPDK, references are now
> removed in the documentation.
[...]
>  doc/guides/nics/enic.rst           |  9 -----
[...]
> diff --git a/doc/guides/nics/enetc.rst b/doc/guides/nics/enetc.rst
> index 3c896eeffa..6203f4d799 100644
> --- a/doc/guides/nics/enetc.rst
> +++ b/doc/guides/nics/enetc.rst
> @@ -113,5 +113,3 @@ Driver compilation and testing
>  Follow instructions available in the document
>  :ref:`compiling and testing a PMD for a NIC <pmd_build_and_test>`
>  to launch **testpmd**
> -
> -To compile in performance mode, please set
> ``CONFIG_RTE_CACHE_LINE_SIZE=64``
> diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst
> index a28a7f4e47..be6a034279 100644
> --- a/doc/guides/nics/enic.rst
> +++ b/doc/guides/nics/enic.rst
> @@ -20,13 +20,6 @@ should be downloaded from
> https://core.dpdk.org/download/
>  Configuration information
>  -------------------------
> 
> -- **DPDK Configuration Parameters**
> -
> -  The following configuration options are available for the ENIC PMD:
> -
> -  - **CONFIG_RTE_LIBRTE_ENIC_PMD** (default y): Enables or disables
> inclusion
> -    of the ENIC PMD driver in the DPDK compilation.
> -
>  - **vNIC Configuration Parameters**
> 
>    - **Number of Queues**
> @@ -583,8 +576,6 @@ The value depends on the memory configuration of
> the application, DPDK and
>  PMD.  Typically, the limit has to be raised to higher than 2GB.
>  e.g., 2621440
> 
> -The compilation of any unused drivers can be disabled using the
> -configuration file in config/ directory (e.g., config/common_linux).
>  This would help in bringing down the time taken for building the
>  libraries and the initialization time of the application.
> 

Hi,

Could you remove the remaining two lines as well ("This would ... application.")?

For enic,
Acked-by: Hyong Youb Kim <hyonkim@cisco.com>

Thanks.
-Hyong