From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23364A2EFC for ; Mon, 16 Sep 2019 09:04:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CCB991C119; Mon, 16 Sep 2019 09:04:08 +0200 (CEST) Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) by dpdk.org (Postfix) with ESMTP id 3AC2E1C112 for ; Mon, 16 Sep 2019 09:04:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2480; q=dns/txt; s=iport; t=1568617446; x=1569827046; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AUAPebXNaMs8rCDhEc7T9Nur7TuA+e7wrotFhV8cYtg=; b=ISP64Ib4gBJHV9BGRqhUoJKAMK5GWvprTx9zobeZA1chGBr5JPRu10Y/ G6yIw9ZsTtd5C1BZwE3iad26zJlSiL7RUg8wAXlsaabHMJM/Ng6UFR5C7 NYTUdM/L8N2Wlc8XlaP1aZTHMOStgKtipxNLtRccHOCnt8jZRYl3tjeI5 U=; IronPort-PHdr: =?us-ascii?q?9a23=3A3nzwhR29HxtYDqONsmDT+zVfbzU7u7jyIg8e44?= =?us-ascii?q?YmjLQLaKm44pD+JxKHt+51ggrPWoPWo7JfhuzavrqoeFRI4I3J8RVgOIdJSw?= =?us-ascii?q?dDjMwXmwI6B8vQCVz8Kv3ragQxHd9JUxlu+HToeUU=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AmAACaM39d/4oNJK1mGwEBAQEDAQE?= =?us-ascii?q?BBwMBAQGBVAUBAQELAYFEUAOBQyAECyqHaAOKb4Jcl3GBLhSBEANUCQEBAQw?= =?us-ascii?q?BAS0CAQGEPwKCZSM1CA4CAwkBAQQBAQECAQUEbYUuDIVKAQEBAwESFRMGAQE?= =?us-ascii?q?3AQsEAgEIDgMEAQEWCRAyHQgCBAENBQgahGsDDg8BAp42AoE4iGGBcjOCfQE?= =?us-ascii?q?BBYEGAQGDfxiCFwmBNAGLdxiBQD+BV4JMPoN/RwU4gn6CJoxnkSmOXgqCIpU?= =?us-ascii?q?bmRmOCZkCAgQCBAUCDgEBBYFTATaBWHAVgyeCQgwXg0+KHAE2c4Epj00BAQ?= X-IronPort-AV: E=Sophos;i="5.64,510,1559520000"; d="scan'208";a="618656530" Received: from alln-core-5.cisco.com ([173.36.13.138]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 16 Sep 2019 07:03:33 +0000 Received: from XCH-RCD-005.cisco.com (xch-rcd-005.cisco.com [173.37.102.15]) by alln-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id x8G73X36020657 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 16 Sep 2019 07:03:33 GMT Received: from xhs-aln-001.cisco.com (173.37.135.118) by XCH-RCD-005.cisco.com (173.37.102.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 16 Sep 2019 02:03:32 -0500 Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 16 Sep 2019 02:03:22 -0500 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 16 Sep 2019 03:03:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XsF8IP6E/YGhhdHkwtNwqyj0F2fBJtJW/JVrt8nZ2ZtubE6OS/Vh0+Q9F/GpNMuCUlqa/EalIaCOtE0dAMDOaQ3jGtPHcgRbcdfv0I4XHWUT9tyf7fxeKrrPiEEdiOm4Tz72dnHUfh2juK7wcm2f9QKA+cSH9Pp8/2BUR37VW09bv8kKX2/CV1q4r2vgULAza4uj4ZUnB+dPFBf2PgTWB4GoOqcRbVnl/My3EHHMgIGBXPY+e2bjWshylCV3i/QDZGQLGLaL33C8EQkoeurxf+OtjOoedrjop09P0tQZ3v0WL2UjQWBMwJl5UFp0JC9AZIsKSyxDfXr0IuCV7abS1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=otsAMsqrE07RohWB0M8/8CksljOckDAuhqxiIbLJ6wQ=; b=gWwkMv1juDB5fV352f1O5cQeh9mnEuYnrAi+SIGHfUGgiNCkr/OKsIWM6ZVLFPGcxXJ2Tn0MXauRQrrDp/jIx41PVyZxz0UkQTDA/dmZwUxdu8xz7C0C0jASJPv9mmhyt9INDOj1fD856qmWaB7Rr3tEvNEWWma2psIMlKZmg9kHppNjXjDavWknjUtu1nAGj4yQYRo/zEl9P0quyGv0vd74C+7gSTIsZfowLkZLmHQs6gZu9mvnf+3mki6wmJL08ks4+IwhqCjF/S9cD3oZNgzAROoTiudVfB5C7Wtt3IMWUzmZfmxn1J0R4pPUEVBpRmc1y5k2YH2jxg8TtXLGzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=otsAMsqrE07RohWB0M8/8CksljOckDAuhqxiIbLJ6wQ=; b=LZRYnbS4jeE5knqBtZAHv/Ei1LbFUJWwYrc7cxXm3ecjMmStU9u9genvq/cH+fBlIK5+KXZ9W4ptuz3PzDJngV2POtbKR5zxd7DD6nZEJb0J2h9w2evc56KcE25cB85JAJ3DuLSJfAnBYPuM4ZAp6kd2TSiCMqyHb+CVxSdI0YQ= Received: from BN7PR11MB2738.namprd11.prod.outlook.com (52.135.245.154) by BN7PR11MB2849.namprd11.prod.outlook.com (52.135.246.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.13; Mon, 16 Sep 2019 07:03:21 +0000 Received: from BN7PR11MB2738.namprd11.prod.outlook.com ([fe80::482e:6776:9bfe:cccf]) by BN7PR11MB2738.namprd11.prod.outlook.com ([fe80::482e:6776:9bfe:cccf%5]) with mapi id 15.20.2263.023; Mon, 16 Sep 2019 07:03:20 +0000 From: "Hyong Youb Kim (hyonkim)" To: Andrew Rybchenko , Igor Russkikh , Pavel Belous , "Ravi Kumar" , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , "Somnath Kotur" , Chas Williams , "Rahul Lakkireddy" , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Gagandeep Singh , "John Daley (johndale)" , Gaetan Rivet , "Qi Zhang" , Xiao Wang , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Tomasz Duszynski , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Rastislav Cernay , Jan Remes , Jerin Jacob , Nithin Dabilpuram , "Kiran Kumar K" , Keith Wiles , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Thomas Monjalon , Ferruh Yigit CC: "dev@dpdk.org" , Ivan Ilchenko Thread-Topic: [PATCH 4/7] ethdev: change allmulticast callbacks to return status Thread-Index: AQHVZwgH+I0+AhhXM02HGX7FeIN5Xact6QHA Date: Mon, 16 Sep 2019 07:03:20 +0000 Message-ID: References: <1568031190-16510-1-git-send-email-arybchenko@solarflare.com> <1568031190-16510-5-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1568031190-16510-5-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hyonkim@cisco.com; x-originating-ip: [2001:420:c0dc:1002::a5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf7375e6-6b8e-4fe2-d920-08d73a73f570 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:BN7PR11MB2849; x-ms-traffictypediagnostic: BN7PR11MB2849: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0162ACCC24 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(13464003)(199004)(189003)(76176011)(486006)(316002)(478600001)(71200400001)(53546011)(6506007)(102836004)(186003)(5660300002)(446003)(11346002)(14454004)(229853002)(71190400001)(476003)(14444005)(256004)(46003)(6246003)(33656002)(7696005)(6436002)(86362001)(99286004)(76116006)(4326008)(7736002)(6116002)(1511001)(8676002)(81156014)(81166006)(8936002)(66556008)(7406005)(7416002)(66946007)(110136005)(66476007)(2906002)(64756008)(9686003)(54906003)(55016002)(305945005)(74316002)(53936002)(66446008)(52536014)(25786009)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR11MB2849; H:BN7PR11MB2738.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lfxeMJVGs+m7OcnZ5Vut3h1FJUCh9VUrnWW89Af9Yp49dJjYxml96qgIEQfJPdz2HRw0uFoaR0PGURhojJSt1JjKH1RsnXdCOQakhPja0xCgE1ML9gZj5dvrkp6c0sftYFo1MA2H1+gepBunaDb5thkYAZsr3EXLaFBRvOYTmNh1np6ENq9GlCjkKKkxfaJ8IzMGAgkdwk8GQE4t69hFxSgOKem3256LmubuoM+2UAiENve1qUKIFtX7uedRo1Vpipw5Z5DsgUdKEiGTy9RGT9/9pTQAVWwXasNBhbS/u5k4GIi6mnCLoL4Sy4rgwjQtEkN+fr5/AIzu3fVWWSR7ivgTkx2EXbRBKmM91+G5TV3UQAmlCkNnPmTI6cY23XgWrUYomOp1neOuVtZAWeHBKsXiufQ7IU5LPdrF3tjBaEg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bf7375e6-6b8e-4fe2-d920-08d73a73f570 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2019 07:03:20.7139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RPnKZ9hFJ1+lrZO/GbitgxkRcTiKsxst9XNR0MTaDrh2cUeEfwXyLiE0sgs+PYWspIbcSQKD7rxJK03R2t2wBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2849 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.37.102.15, xch-rcd-005.cisco.com X-Outbound-Node: alln-core-5.cisco.com Subject: Re: [dpdk-dev] [PATCH 4/7] ethdev: change allmulticast callbacks to return status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Andrew Rybchenko > Sent: Monday, September 9, 2019 9:13 PM [...] > Subject: [PATCH 4/7] ethdev: change allmulticast callbacks to return stat= us >=20 > From: Ivan Ilchenko >=20 > Enabling/disabling of allmulticast mode is not always successful and > it should be taken into account to be able to handle it properly. >=20 > When correct return status is unclear from driver code, -EAGAIN is used. >=20 > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > --- [...] > drivers/net/enic/enic_ethdev.c | 22 +++++++--- [...] > diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethde= v.c > index 5d48930a9d..e12ca213ae 100644 > --- a/drivers/net/enic/enic_ethdev.c > +++ b/drivers/net/enic/enic_ethdev.c > @@ -638,28 +638,38 @@ static int enicpmd_dev_promiscuous_disable(struct > rte_eth_dev *eth_dev) > return ret; > } >=20 > -static void enicpmd_dev_allmulticast_enable(struct rte_eth_dev *eth_dev) > +static int enicpmd_dev_allmulticast_enable(struct rte_eth_dev *eth_dev) > { > struct enic *enic =3D pmd_priv(eth_dev); > + int ret; >=20 > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > - return; > + return -ENOTSUP; Hi Andrew, If you are making v2, could you make this to return -E_RTE_SECONDARY, as in the promisc patch? >=20 > ENICPMD_FUNC_TRACE(); > enic->allmulti =3D 1; > - enic_add_packet_filter(enic); > + ret =3D enic_add_packet_filter(enic); > + if (ret !=3D 0) > + enic->allmulti =3D 0; > + > + return ret; > } >=20 > -static void enicpmd_dev_allmulticast_disable(struct rte_eth_dev *eth_dev= ) > +static int enicpmd_dev_allmulticast_disable(struct rte_eth_dev *eth_dev) > { > struct enic *enic =3D pmd_priv(eth_dev); > + int ret; >=20 > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > - return; > + return -ENOTSUP; Here too. I tested all 5 series (promisc, allmulti, ...) with enic, and my test cases all passed. Acked-by: Hyong Youb Kim Thanks. -Hyong >=20 > ENICPMD_FUNC_TRACE(); > enic->allmulti =3D 0; > - enic_add_packet_filter(enic); > + ret =3D enic_add_packet_filter(enic); > + if (ret !=3D 0) > + enic->allmulti =3D 1; > + > + return ret; > } >=20 > static int enicpmd_add_mac_addr(struct rte_eth_dev *eth_dev,