From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EB4AA04C8; Mon, 10 Aug 2020 19:27:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A65C3195; Mon, 10 Aug 2020 19:27:19 +0200 (CEST) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id E88DB25D9 for ; Mon, 10 Aug 2020 19:27:17 +0200 (CEST) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 10 Aug 2020 10:25:32 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 10 Aug 2020 10:27:16 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 10 Aug 2020 10:27:16 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 10 Aug 2020 17:27:13 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 10 Aug 2020 17:27:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k8ZVFgr1nUU4SdPOkBEB5Pns6zbrsqTZ700tG0KjMBtWJF/ng53AwW8oEDkEXRGTZf2Rk1vVL/Pqu8Y8jkNMqsyTU7/nE4COQtsSW5N5JMzuxn8fffRk0nIlZGI0AZT4vnRtCZec8DQUHlAYN4uY73oMbf28+99SuSzHA7sCgfJr9QIb70bpIF01PI0PoRma3KZChe51pcB/cOpu3zcoXnHvSV8/nYjXadJngaNdh25uawib2N7W62wM0FdBPeHBrTUF3kGyXxJy36ZuwSF9DCnWd4TFvVvdOYbh4Yd16JdGoR7BbQjrrW48LmBoSGR7yvr115Kl4P7X1uPwKKHCPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xD5NMLlDiIqGlzQ+U1vyPTmqg7blfJ9ZWRcpCRL9eLM=; b=mzto2SZ00ImIsGFQ7MNlGu3WNSU17fPdw+b9Dliupfy+x2tN9bkXEUJVlQVwQDgSpCbdxvSRpAGWI+wuJZKBpi6Ux/JYabfGxIPIT6Dvk6TwKrCZWfBnU0TV4dX7PEea46XcoGB7QuFd32G8g4clvpHM5CVvm8JWRHCW/YcQuOYn6ZvUk0YKQOJQ0nK5+vs4Y2d23UlbGuQsxbY/MmABf+JJeyAWbzxW/czwcX+QRK9kUG0ARpvMPklAtQghzQx3gnfK/SZiExZFghVqsWjUrTSuB6pDT2iim9U0FMT4eHDYBamC/VF+Rio4HSVucH3/bUbVFgnpnjVYNetvsbMNsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN7PR12MB2707.namprd12.prod.outlook.com (2603:10b6:408:2f::29) by BN6PR12MB1234.namprd12.prod.outlook.com (2603:10b6:404:1b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.20; Mon, 10 Aug 2020 17:26:58 +0000 Received: from BN7PR12MB2707.namprd12.prod.outlook.com ([fe80::5cfa:fb33:8411:1267]) by BN7PR12MB2707.namprd12.prod.outlook.com ([fe80::5cfa:fb33:8411:1267%4]) with mapi id 15.20.3261.024; Mon, 10 Aug 2020 17:26:58 +0000 From: Alexander Kozyrev To: Ciara Power , "dev@dpdk.org" CC: "bruce.richardson@intel.com" , Matan Azrad , Shahaf Shuler , "Viacheslav Ovsiienko" Thread-Topic: [dpdk-dev] [PATCH 20.11 11/12] net/mlx5: add checks for max SIMD bitwidth Thread-Index: AQHWbNVA/GWUWB1TKUSD+hvDDiTeN6kxjf6g Date: Mon, 10 Aug 2020 17:26:58 +0000 Message-ID: References: <20200807155859.63888-1-ciara.power@intel.com> <20200807155859.63888-12-ciara.power@intel.com> In-Reply-To: <20200807155859.63888-12-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [174.112.69.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1c2b4af9-f9ac-4154-fa70-08d83d52962d x-ms-traffictypediagnostic: BN6PR12MB1234: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: byW5qfgmN0dobxmsL+AiMFZWBA4PevFe0I0gYST+RA6QQK9/4A36/lkD8zfNSgntr5JIoSj1axHbrR5NQYp8qmOQLKJE5bHwxz1fCVyELo1jP9u5F1a4tzmqRvpOlT0/g+RHxnLCpdb5p4MV1LFY4Z99Ec41qleMIzGi7/HiEJzsEpYQ1qZ6jmAjjF/g/QOnMG6pWNdK3KZyj9ZSFKOF7ew+jXfrBrrZhjey9mZQSKydwcu9yZcmg343AhoyeR+dvEvO1wfixRAW1kCLl0qhQmP9bogoWPC0ha2HHHgIbM/2jWp0hJ0JWjxJ73vFJjak3PpxeYaQ/Gjz/y21E2nluA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR12MB2707.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(5660300002)(110136005)(26005)(186003)(71200400001)(316002)(9686003)(107886003)(478600001)(54906003)(83380400001)(55016002)(33656002)(4326008)(86362001)(8936002)(53546011)(7696005)(6506007)(66946007)(64756008)(66476007)(66446008)(66556008)(2906002)(76116006)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 6lydo25Af0K5Zr5TFwV/4UmCxuda22Hf8FUJC8tja6SU5uq8fwl8ehv1zTY4eV9xhVdU3pXVW2Pxvlx9B5kcMNR5v2HKzxamKImQz03H2AeCDDfJC1AIzL8+WWvGhxDTbXHNKIr9gF6n8TEvQO2JcJbjwdIqAAKDeLL6emEs9MljMskR15UsV0GN4emeHUl4U5c7uZ/+Gqq6Kf1xNd1y5YJtGQGaRhQpvGGpewLkf8zKv8Y/HTLc9p0HDrK2zpu4stToFaadmd3ezl2UcJyWIQGcPtVjUHCaahnfSuIL+xp2+5a8rZPvnpe9qo+/3M8log7uYxP1vor6seoXLx11Wihh/67R9KnVaSU/Ic7KIniL7f8gTJBM3je7/MKkdXmRnGImEHTSW2S+yWC8eNlAE6HJTn/r46ri8ZLlbw4ljtiX8Q4RR1LALkQl3pCR/yS9zZTrj8eOKJPF8KE5eJa0PY/xvgiEoDLPN7ncPlU5tXl0k6zbuE1S4OHwL6whm2fwn0myExWyanxe3r6HlBJmj//Qjq1u0yB00aBzE8zuIJY5vdE5BeXatnpaQG64fdM+3ZA9Tk3GyvJR6+ZN+6Py+Dj7LmCJX+b32tceneCkzjV+th0LFs2/SP4GTn8aTWZ0MTNsKK90Pg7/mCS/7qEZZg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR12MB2707.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c2b4af9-f9ac-4154-fa70-08d83d52962d X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2020 17:26:58.7524 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O/eYQSPhgKhOd163JErSqRwXIm9baLVaMvtwYKFs3zOv8jhR5AKAx7eFu+DhZZ+nSxEhWibL5RD9F+wQAStWXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1234 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1597080332; bh=xD5NMLlDiIqGlzQ+U1vyPTmqg7blfJ9ZWRcpCRL9eLM=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-exchange-transport-forked: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=ITaec4KQvNBGPG6b0UgVwq1b/8YIHPXuEwnJjhqcwWtQO8m80bAUvNqlAqfhm7G9e VpWhEfab2UTuOQSWw2Zp1VBaGhZDsh34zokz19+luNSOHLj44q1ji+vIMHK3LFZ++x EMdFM69pwHv9E8KLHOhqUElHpbr61w5OQI6HpOg+KmQW5G3WWorP6o/BeThlcojAZO kHoZESro6MrPw/PIBCPxhlFemARLvQ8Eug9dbwnmf4sGi+kDG+tMpSZKN06Pyn/B+O wWwin5LBo0m/1gMWnHd0QR0lDVAUNEdGBrjMJhh290FKT/MOa6c0EBv4pTLlO59eyE mCItQV0XxfhyA== Subject: Re: [dpdk-dev] [PATCH 20.11 11/12] net/mlx5: add checks for max SIMD bitwidth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Ciara Power > Sent: Friday, August 7, 2020 11:59 > To: dev@dpdk.org > Cc: bruce.richardson@intel.com; Ciara Power ; Mata= n > Azrad ; Shahaf Shuler ; > Viacheslav Ovsiienko > Subject: [dpdk-dev] [PATCH 20.11 11/12] net/mlx5: add checks for max SIMD > bitwidth >=20 > When choosing a vector path to take, an extra condition must be satisfied= to > ensure the max SIMD bitwidth allows for the CPU enabled path. >=20 > Cc: Matan Azrad > Cc: Shahaf Shuler > Cc: Viacheslav Ovsiienko >=20 > Signed-off-by: Ciara Power > --- > drivers/net/mlx5/mlx5_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethde= v.c > index cefb45064e..f322f82029 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -479,7 +479,8 @@ mlx5_select_rx_function(struct rte_eth_dev *dev) > eth_rx_burst_t rx_pkt_burst =3D mlx5_rx_burst; >=20 > MLX5_ASSERT(dev !=3D NULL); > - if (mlx5_check_vec_rx_support(dev) > 0) { > + if (mlx5_check_vec_rx_support(dev) > 0 && > + rte_get_max_simd_bitwidth() >=3D RTE_MAX_128_SIMD) > { > rx_pkt_burst =3D mlx5_rx_burst_vec; > DRV_LOG(DEBUG, "port %u selected Rx vectorized function", > dev->data->port_id); > -- > 2.17.1 Hi Ciara, what do you think about moving this condition inside the mlx5_che= ck_vec_rx_support() function?