From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD144A04F0; Mon, 13 Jan 2020 12:43:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 543551D151; Mon, 13 Jan 2020 12:43:08 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6DA5B1C225 for ; Mon, 13 Jan 2020 09:19:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 00:19:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="247641922" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 13 Jan 2020 00:19:34 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 00:19:33 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 13 Jan 2020 00:19:33 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 13 Jan 2020 00:19:33 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 00:19:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PK6U1CieVmkjyYGlKoWrEqwS1pCkejkTv+7YHwtrd33gwMWiya4b/b1SuJrlkr90GIKjOCBMvLTA7gFBvLw0cUHuNgaxXjXEQ5ONrR6KZ1CnhcvmbUozJuj33qPJEZI/Ai10yvQihYqWIPV8nsVfonNPnINdoj2fw/OhGqJ710t0zi2iI9FjQOvwGiQwlTc5SX5vnUjWfuT8pxTZEBChWbF7w79xsBeUoncOnPgqDOoimrEIA2ymQApepOX4wwqeyRSE/ZeGkBA0xCBvNHO1jfNz73OxidwTYiWEAkAONomt/HMmiy/pVKgjo+yEQgMFgQ3MrttW2AYZnltYo/FX5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eBKkomtcetp5aWdyYS+t45utFHsyIFkOMcFdtfZUS8U=; b=HcJB3qr2PlqzDTLAwmtiQrAp0AUo1kqeBa/Wk9G/b+mVd7hVIFWLuVzKQcKnZAfljJVVaJqwBTRQtdQlUFpuLSPRH3LwiUyQ1dADBsMhqRXJbA8s20A4/wtmhXzU5JaAhpXuPgBim0Ixdg4yAh9INuZehl3bsTF+w1dNfQlTnUQB512kmcpYC66l9oDk2jul+6GJ6kEGkfuRmihXr3WkHIJQhWGbR3hxU68FRNvw5Txk7k4PCJIbdpHROcRgHDzV2+Yyl/drDJoQxtg0qOwl0NnIky9rz59Yeo3ZKjI0xNWF2N0vOV9TrzrTztLGPZJ0unKqe4zzQ/hI+TCB5/DZ0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eBKkomtcetp5aWdyYS+t45utFHsyIFkOMcFdtfZUS8U=; b=H/pxxgldNngmtgySfxHTWorlIpDPeotRZ9WnCa9gtUECHsXfwh81jlbcPk/EpAt3RkMYkckM3fQvCKB9lmstwFgB28v0d8Niv0gyf+v18AaInd2AV3hqQwjS16wsykjnHJhXjW2wypBlaKgRVWNNqiS3HMqRIadfCYKhC4R9e7c= Received: from BN8PR11MB3571.namprd11.prod.outlook.com (20.178.221.206) by BN8PR11MB3634.namprd11.prod.outlook.com (20.178.220.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Mon, 13 Jan 2020 08:19:25 +0000 Received: from BN8PR11MB3571.namprd11.prod.outlook.com ([fe80::9c37:2592:42eb:8f4d]) by BN8PR11MB3571.namprd11.prod.outlook.com ([fe80::9c37:2592:42eb:8f4d%3]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 08:19:25 +0000 From: "Kwapulinski, Piotr" To: "Ye, Xiaolong" , "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 24/36] net/i40e/base: make i40e_set_mac_type() public Thread-Index: AQHVybvkvyliEIaN3ES+m035PVjQ4qfoQM6A Date: Mon, 13 Jan 2020 08:19:24 +0000 Message-ID: References: <20191202074935.97629-1-xiaolong.ye@intel.com> <20200113023949.26718-1-xiaolong.ye@intel.com> <20200113023949.26718-25-xiaolong.ye@intel.com> In-Reply-To: <20200113023949.26718-25-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=piotr.kwapulinski@intel.com; x-originating-ip: [134.191.221.107] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6093432c-3d03-4750-176b-08d798014d09 x-ms-traffictypediagnostic: BN8PR11MB3634: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(39860400002)(346002)(376002)(366004)(396003)(189003)(199004)(4326008)(5660300002)(86362001)(52536014)(6636002)(8936002)(55016002)(478600001)(8676002)(81156014)(110136005)(9686003)(7696005)(81166006)(316002)(6506007)(53546011)(66476007)(66446008)(71200400001)(2906002)(33656002)(186003)(26005)(66946007)(76116006)(66556008)(64756008); DIR:OUT; SFP:1102; SCL:1; SRVR:BN8PR11MB3634; H:BN8PR11MB3571.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tg+4e1PvNdTEzuzBKkaRNe8g04rU6ks1jH63TVxgbbzT+3cgzNK2LQPS1xnQQxnYDeoiOqgyypqCOEzRDIZHCm5jZY/bvsauJrq4vArDaInvvvOMb6Ucqc2baMw3hIsJMjyYxt+dsIGL3XrUKk+BcD5iWikkrqgmZBN63C6iUyas6+DlDikwSNUByvB0s5+Ypbk4AgLWgHHfkpL1r9i8n6Kv7TVYCMZ1dpDTUR8lSy9T+q+4p0Yyk29Ht63m1XzZ3uLE36xTnbgETLb9Sqpvf6/VApoa+s6wCJRipGki99x384AFKJ850cHpPebdDWy6Y8Kwvaz09te2pZMDUF7C1ON+txaFFWmQu0iqL+nP27dpX9DAATUtyIYBiJSQ4zgvjypmeeAohwrgX8ZXd5sGE7r/kx9aF8J2R3VtEd1UkjMRDL0+a27jadGSaIt5x3Z+ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6093432c-3d03-4750-176b-08d798014d09 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 08:19:24.8686 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8vo1Dwe6k+G/Wa4XKIRWmLxbA9LQMStyfzvvpQCfNfFfwAld0I71+8Pl+sVZ0gNETo0P+n0UUWyIan5o5zKcR4Ci5J0vhGT4nRkvBVqR8xE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3634 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 13 Jan 2020 12:43:07 +0100 Subject: Re: [dpdk-dev] [PATCH v4 24/36] net/i40e/base: make i40e_set_mac_type() public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ACK -----Original Message----- From: Ye, Xiaolong = Sent: Monday, January 13, 2020 3:40 AM To: Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org; Ye, Xiaolong ; Kwapulinski, Piotr = Subject: [PATCH v4 24/36] net/i40e/base: make i40e_set_mac_type() public Make i40e_set_mac_type() public. i40e driver requires i40e_set_mac_type() t= o be public. It is required for recovery mode handling. Without this patch = recovery mode could not be detected at probe() function. Signed-off-by: Piotr Kwapulinski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 4 ---- drivers/net/i40e/base/i40e_prototype.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i4= 0e_common.c index eddc91e36..4f87ec9fa 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -14,11 +14,7 @@ * This function sets the mac type of the adapter based on the * vendor ID and device ID stored in the hw structure. **/ -#if defined(INTEGRATED_VF) || defined(VF_DRIVER) enum i40e_status_code i4= 0e_set_mac_type(struct i40e_hw *hw) -#else -STATIC enum i40e_status_code i4= 0e_set_mac_type(struct i40e_hw *hw) -#endif { enum i40e_status_code status =3D I40E_SUCCESS; = diff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base= /i40e_prototype.h index afebf441d..2b6198985 100644 --- a/drivers/net/i40e/base/i40e_prototype.h +++ b/drivers/net/i40e/base/i40e_prototype.h @@ -472,10 +472,8 @@ void i40e_set_pci_config_data(struct i40e_hw *hw, u16 = link_status); #endif /* PF_DRIVER */ enum i40e_status_code i40e_enable_ee= e(struct i40e_hw *hw, bool enable); = -#if defined(I40E_QV) || defined(VF_DRIVER) enum i40e_status_code i40e_set= _mac_type(struct i40e_hw *hw); = -#endif extern struct i40e_rx_ptype_decoded i40e_ptype_lookup[]; = STATIC INLINE struct i40e_rx_ptype_decoded decode_rx_desc_ptype(u8 ptype) -- 2.17.1 -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.