From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EFEEA09E4; Fri, 29 Jan 2021 03:59:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4C5B4067B; Fri, 29 Jan 2021 03:59:40 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id CE23A40395 for ; Fri, 29 Jan 2021 03:59:38 +0100 (CET) IronPort-SDR: lzchAjiFm4hPnwm9ePuPizEeYOog3LpCQvOr8As3oARC58tVwHq2KoIEyPcIiVqLR7D1QoLQMR JnBDV/dqnoEQ== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="167453025" X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="167453025" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 18:59:36 -0800 IronPort-SDR: gC3C4hmhZ6cQjc+e39vccOWT/XFckA4q25IRJEa00f+IFqfAXuTKzVD1x82ZZZx78eO3Gvc+ZW clwiKpxO4YLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="370120719" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 28 Jan 2021 18:59:37 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 28 Jan 2021 18:59:37 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 28 Jan 2021 18:59:37 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.59) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 28 Jan 2021 18:59:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KIbPxSMHRqlvsWNxy1d00+q/VdyFyJluqVywYkSRotbgrlcxxtb7Ev9UFGOyTgO//U0H9mn6tmeqpCxeiPJQTwgtUf6uX2XpukN74rnvf/P4RG3GiOuzdUsX24NcMDi7+eTGHg7cCIuyEwHAF07C8jY7amuEwYQWjR9usxQEdZI+0H9fWeOsx3Eh4PsUQWhNzfCRNvNcB5G+pZAcHwPcsZSmG5u/xOivCl26FJDSWl1vnfnXz6xLaDF5XyF50QvDxLBWf4aIMSjfN4HBxvaOOLz/sV0GzDNZDIMY0tlxRKOqC/Cn0t5I3EsoSvzf+Gc1B/W+6VWZBpEbjl9VDwukkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pxkpPfKeR7dYPoa/baGFGZ0UT9yFhtbqZBeaUkR2zWE=; b=M+FOz0D8PznyPKRIDvIc0GVQLNC3nbJFA+7H5lcR7N2QObus/bdo5xjQg+vWyQ30bQkZRDwTo4cIeeHZduPN6flF3ws67CJKCr4fu4v8K1i/x50oXTirXe53lF3xQXsCg0m3MS5R1yhlEJmS1kTeAcicxq8I8wwUwPQedlDCF3tfK4WgIk65QTmHAthbcA0FJCH+5rIIXYe7jN/W+UkWAUgvU7YHFe9HKEoLh5xEqSLXrHtvx4qaDp8vvr4N9HPui63yaafAxqkZbZ51K03TTwjwl/r+c3feVircuDDoCz0ZmqhibjXG0MzhewsXXUbKgAhGQT7n7BpZYHLULd1ZMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pxkpPfKeR7dYPoa/baGFGZ0UT9yFhtbqZBeaUkR2zWE=; b=VB5hLdO1qXWtzgm+/onNBwn2wKQ+OR9baiKsnkdhK5Xdsn0LXBtvK58p6wSnzoDvRfHkKe4zs2fi2PUz77OxSrScMOedQ+pvUycLzupPQZqjBbfhfeLRDl116VrKDFwF4XOc7VCp63gQeP4pZPVduroVQlms9gqJjB+ylRMjKC4= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR1101MB2116.namprd11.prod.outlook.com (2603:10b6:405:58::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.11; Fri, 29 Jan 2021 02:59:34 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::b50a:60a1:8190:c67f]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::b50a:60a1:8190:c67f%6]) with mapi id 15.20.3784.017; Fri, 29 Jan 2021 02:59:34 +0000 From: "Wang, Haiyue" To: Paolo Valerio , "Yang, Qiming" CC: "Guo, Jia" , Aaron Conole , "dev@dpdk.org" Thread-Topic: ixgbe and UDP with zero checksum Thread-Index: AQHW9LNKYEOnPlbHCUiCOz71l2GA46o7uJHwgABGrYCAAdrE0IAAESnA Date: Fri, 29 Jan 2021 02:59:34 +0000 Message-ID: References: <87im7i12si.fsf@fed.void> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f8f3437e-c4b6-4565-4196-08d8c401e82d x-ms-traffictypediagnostic: BN6PR1101MB2116: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LXog6FLy9fq2u/5sawdbeu8W5TjzRkHV8Dbn/1lb4bkzQQoZRqHq40awPNGK3o9nYMReGCA9o4qJmDWFSbM+svbzRcjFSXDLIx22KweBeJCl568mhphedYi9q1rKjo8Dj1ZJGX8QfFJsR4U8hs6/+Taw8i72hdeCxrg8aGCxqa0h0M6rV7NsKvLSorMw0ffbOicKXOyghb5ksOXt1fX3+JN8jfjNGn8moqLsrsZkEQLKGceJiDC60DRI5douiQ0L5YcwH/CGLVpbld/g172cN6RbMIYbhztXI2O4Az6+siSc5547/9tnTdwQBjYkEmTkda19QCpGUGvIcSFZaAJauk6YNwuz2KZ+/bvpJr5i/YNNXKsEyOavYS8JotUzdKAq9MRx8qPS7rfWe5Svo1hSvEyryOQRP6tNPqj+LjsMt+zYwFopjT/WFBjypClVY/4dL7z4kVasKp5ioJSl2J2i9l8hLXNQqsr3wqfRwbDgLuQ6h0YKzgEPbDA0/ulJgAQfamwEvGOLP1xKlAuYxfqfxunyHvs4XSBBcGopbA8q9Pnhxwllw4mdmIPSasU4HFEaXODn2bJAC3dLhNtZr7SyiFQmS0VwhxZ4+ofVdyiGdVM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(76116006)(64756008)(2940100002)(54906003)(110136005)(4326008)(26005)(66476007)(33656002)(66946007)(66556008)(186003)(316002)(66446008)(8936002)(83380400001)(8676002)(966005)(6636002)(53546011)(2906002)(52536014)(5660300002)(6506007)(55016002)(71200400001)(7696005)(86362001)(9686003)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?E8ozMpmEVVh9ppn43AeL7SY9W+9sMRtlB15cItN3KahxghavyPHqix1SL33D?= =?us-ascii?Q?640ws3KgiOpTPPjQ/2ZRkQbEcdE2vAm6mLo9HQdirefHV2IkBQeDaljQKoab?= =?us-ascii?Q?ABgGo2wVuA9PTiT0oBReYfl8fuxv02ZK1ayJzJ/giI1S6RRy/CBqW6YDanX1?= =?us-ascii?Q?pvUgSN/2l0zxMWTSMkPoLqSWsfh//UvD7VLBjepr37fia1KgkZM+sVzoQrle?= =?us-ascii?Q?9yDwbTAmgiAqyB7QpSu0/Fma7ELhRwMBD1XJCUbZ62vcIS68nqUkiQJzhPjl?= =?us-ascii?Q?KAdEIGl7Qb/GUOWhsqpbBs0u9f5N0x/BSySWbKaXsoFBd7xfhSss+ERg9jV+?= =?us-ascii?Q?3bQghtqQHtMY4xyKIkuvoOasVkYisDlTSlRGDe03OYN6lpkNLyANq7Ryz7Xn?= =?us-ascii?Q?gqpZr2zHjemQ8NoT93gBdO6EH1jB9V4U09wQURSvLD3JxcovfiAv2t+wRKII?= =?us-ascii?Q?BV412szQYLwvwBQz1lUcnye7zsGKyUEKJDl/rJGzKslAQMyFsmIAfCNmODoW?= =?us-ascii?Q?BGwbcFz+J/pIv3OGjEz/zHZnQUSDzp8tHDv004dfe2mumn1lqdQ4t8RNytvW?= =?us-ascii?Q?JYmvdVe08DAnfhmjzH0bkkl8pqlpxDswSIX/dzxvUuO/86yPZ+SVGdD4/0AE?= =?us-ascii?Q?Eaj1g3xefwHWqBr8leDNHJ7eRdMPnYmUVa8GuvgLkD+tFT+eDkSzm4EyVWl5?= =?us-ascii?Q?Fo0DbfeblKeb9MrsjUpPVjeDh7103BsDB1fBNKwxduCWfo/cym2ZUCaK1px6?= =?us-ascii?Q?FaOrcTiHG+uMMl7+JPi7gjciK9E9/gu8VQ5/PP7edqtHjbQUFiNU3QriqD0X?= =?us-ascii?Q?CbEa5EouB6n2V+JYtbOm82UCG/e3iqxJoqCZtlmt/p1k5cv/UXASPwCcj1I4?= =?us-ascii?Q?/sFxGcKqUEWtBwzFUMf1p3Jc5raHym1CTaoxi+X/LcUIUJQQhBPYan8Jwl98?= =?us-ascii?Q?2h9XURXGz/t70Qh2Ls+eJygu605kxYaX4+rBKFwVW/rnhVspNwiUokvcM6ZF?= =?us-ascii?Q?iE7axK9ZWBMCms0/L4EAnVxWYXDhClZ2/1dLC8DmrK3fklBCOeO8DA/oSnu+?= =?us-ascii?Q?pv44ziN7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8f3437e-c4b6-4565-4196-08d8c401e82d X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2021 02:59:34.1357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cWhm7fnU2QuegdSF+4zo7N/+qFHr6Sy7m9tWa0udPYUlg9ZBNwBO7LYzzdJWj55NrqV0PgVPz9UYFXqxTQVA8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2116 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] ixgbe and UDP with zero checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Paolo, > -----Original Message----- > From: Wang, Haiyue > Sent: Friday, January 29, 2021 10:02 > To: Paolo Valerio > Cc: Guo, Jia ; Aaron Conole ; dev@= dpdk.org > Subject: RE: ixgbe and UDP with zero checksum >=20 > > -----Original Message----- > > From: Paolo Valerio > > Sent: Thursday, January 28, 2021 05:35 > > To: Wang, Haiyue > > Cc: Guo, Jia ; Aaron Conole ; de= v@dpdk.org > > Subject: RE: ixgbe and UDP with zero checksum > > > > "Wang, Haiyue" writes: > > > > > Hi Paolo, > > > > > >> -----Original Message----- > > >> From: Paolo Valerio > > >> Sent: Wednesday, January 27, 2021 21:50 > > >> To: dev@dpdk.org > > >> Cc: Guo, Jia ; Wang, Haiyue ; Aaron Conole > > >> > > >> Subject: ixgbe and UDP with zero checksum > > >> > > >> Hi, > > >> > > >> performing some tests, I noticed that on ixgbe when receiving UDP > > >> packets with zero checksum (no checksum) over IPv4, the correspondin= g > > >> ol_flag for the l4 checksum is set to PKT_RX_L4_CKSUM_BAD. > > >> > > >> In particular, this apparently has an impact on OvS using ct() actio= n > > >> where UDP packets with zero checksum are not tracked because of that= . > > > > > > > > >> > > >> [1] > > >> > > > https://patchwork.ozlabs.org/project/netdev/patch/20090724040031.30202.15= 31.stgit@localhost.localdomai > > >> n/ > > > > > > About 12 years old patch, it is hardware errata. For fixing this, > > > have to always disable vector Rx path for 82599, it seems not a > > > good idea to bring in this workaround. :( > > > > > > > Thanks for the answer. > > Yes, as I mentioned, the patch is old although still meaningful. > > I linked it mostly because it mentions the hw errata. > > >=20 > What's your PCI device ID ? My worked ixgbe: >=20 Sorry, I missed the PKT_RX_L4_CKSUM_BAD information, yes, my NIC have the i= ssue. > 86:00.0 Ethernet controller [0200]: Intel Corporation 82599ES 10-Gigabit = SFI/SFP+ Network Connection > [8086:10fb] (rev 01) >=20 > I'm wondering if people will complain that the patch will mark the real b= ad checksum UDP as Zero checksum is more popular case, please file a bug on https://bugs.dpdk.= org/ to trace the fix. Thanks for pointing it out. > GOOD. For handling this correctly, looks like driver needs to check the U= DP's checksum value, > if zero, then skip the error information, but this makes driver do the ne= twork stack things ... >=20 >=20