From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Liu, Yong" <yong.liu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect
Date: Fri, 15 May 2020 01:53:04 +0000 [thread overview]
Message-ID: <BN8PR11MB37950A0B8D6A3A132494C797B8BD0@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200515014056.44949-1-yong.liu@intel.com>
Hi Marvin,
Comments inline.
Thanks for the fix.
Best Regards,
Xiao
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Marvin Liu
> Sent: Friday, May 15, 2020 9:41 AM
> To: maxime.coquelin@redhat.com; Ye, Xiaolong <xiaolong.ye@intel.com>;
> Wang, Zhihong <zhihong.wang@intel.com>
> Cc: dev@dpdk.org; Liu, Yong <yong.liu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/virtio: disable event suppression when
> reconnect
>
> Event suppression should be disabled after virtqueue initialization. It
s/Event suppression/interrupt/g
> can be enabled by calling rte_eth_dev_rx_intr_enable later.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
> diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
> index 408bba236a..2702e120ee 100644
> --- a/drivers/net/virtio/virtqueue.c
> +++ b/drivers/net/virtio/virtqueue.c
> @@ -175,6 +175,7 @@ virtqueue_rxvq_reset_packed(struct virtqueue *vq)
>
> vring_desc_init_packed(vq, size);
>
> + virtqueue_disable_intr(vq);
> return 0;
> }
>
> @@ -211,5 +212,6 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq)
>
> vring_desc_init_packed(vq, size);
>
> + virtqueue_disable_intr(vq);
> return 0;
> }
> --
> 2.17.1
Can we backport it to LTS by cc stable?
next prev parent reply other threads:[~2020-05-15 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 1:40 Marvin Liu
2020-05-15 1:53 ` Wang, Xiao W [this message]
2020-05-15 2:41 ` Liu, Yong
2020-05-15 2:35 ` [dpdk-dev] [PATCH v2] net/virtio: fix unexpected event after reconnect Marvin Liu
2020-05-15 2:46 ` Wang, Xiao W
2020-05-15 7:51 ` Maxime Coquelin
2020-05-15 8:37 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB37950A0B8D6A3A132494C797B8BD0@BN8PR11MB3795.namprd11.prod.outlook.com \
--to=xiao.w.wang@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=xiaolong.ye@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).