From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7C41A034F; Fri, 15 May 2020 03:53:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 418D71D9B9; Fri, 15 May 2020 03:53:10 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AA0B11D9AD for ; Fri, 15 May 2020 03:53:08 +0200 (CEST) IronPort-SDR: 4bIckNdJ8iGIPIYEondJSEQQUwMg6WedL53STZ9EKHAlobZyA23A8Hn3nK0Rxxpqlrh+bLJo+r ZjUGWk0jwyNQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 18:53:07 -0700 IronPort-SDR: rGsgGnxfyTcw7jni44rOGPfivbt444ZO9T4KP9HMLZ3E3FEXuiqqaYjMjben/qj0GMgGjhkSGb xz7CN1niebNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,393,1583222400"; d="scan'208";a="464556160" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 14 May 2020 18:53:07 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 18:53:07 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 18:53:06 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 May 2020 18:53:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQOgn/YtyxvuEsj3jDoJE8u7bquWdtaJ7MQu+ukcKdMlv+MwG0wepAtu+MzUDX+miLE/bg9Lb7lISfma9HH67XUQN2fNLsz3n89KIQbLT8wdACBgUIc5cqqf1uafjwnAG5ZRSbzM8efji/jv9uI5ZiXGJ6JkaroSrUv9q09GfqZwc4BWIPEzT4Ui2yN59JKbzKB4XkAIOoN89DG3WFIDrAZt5Zr3+/A2ogA/NwlVnUlrh3CjtRIn13ENty/xfJoEAkmQn/IvP7j/7Nx615ZET04LnmQ9Tiv3qHCmsii83Rkgse8ehQAAHm/9sTV27L8TbDhyhNL67pVtr/xW3FOmfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lzoSvDIRde+BGS7WKkBgfViF82yU3mE1Yv/SF5O6s2w=; b=dhtSoqCAZU/oHkOJkFfRSPCDZ4VM7nGqOqg2tJ8zoa3Jn6XEMWl2TqN1H9zA3TwISoIu5o9wVSVK4JDgigbNnxJJKuU1+4BzlCmbos7+nHw33mxSEMxo72hCfXUxiAlpNlB7hRRKW5MbxSChc+GdXxsRhVlgzVxHIPca2nIdnW/4rYllTUhVWn/AJJNs3WUeTNsam3NP5izoACAKkg0PLKxWy3mrujLEtO5VgbZqSc90+o8SfohbPyakybOBeFd0oQ0KswUet/ejuX+sgkZOrcLM2866W48YcgdNCgvpuEbAFbjIYABbVXWQz//GnKfQXEJ3TBCSTOxTk4o8nwlsAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lzoSvDIRde+BGS7WKkBgfViF82yU3mE1Yv/SF5O6s2w=; b=A12BRPyplgQUTqGcY993J0F9obvWTOa0szgGvCJj+BK0HaAKkMsfopnRwMGDee3KsS4kMH/q6zXcZfocjjd4/uVMNixMpY33WDaqCgTuDgHHK2SVHuCxBiT5W1PchXqxeezAiLCq7jUOhiy8oXC+3+UsyUwVj5GEj9yvTWf08PE= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN8PR11MB3556.namprd11.prod.outlook.com (2603:10b6:408:8d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Fri, 15 May 2020 01:53:04 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::c96e:e522:e0dc:490c]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::c96e:e522:e0dc:490c%7]) with mapi id 15.20.3000.022; Fri, 15 May 2020 01:53:04 +0000 From: "Wang, Xiao W" To: "Liu, Yong" , "maxime.coquelin@redhat.com" , "Ye, Xiaolong" , "Wang, Zhihong" CC: "dev@dpdk.org" , "Liu, Yong" Thread-Topic: [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect Thread-Index: AQHWKlomLzukIYlBHUu1zOqUKZYjXqioYYDg Date: Fri, 15 May 2020 01:53:04 +0000 Message-ID: References: <20200515014056.44949-1-yong.liu@intel.com> In-Reply-To: <20200515014056.44949-1-yong.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa2bddc1-581c-46f3-ea74-08d7f872b510 x-ms-traffictypediagnostic: BN8PR11MB3556: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 04041A2886 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zMFaSC2LBMisgkJO7RwMXHSa/Vzx1LhVYbVfunCCGFhqSCUF4mTu2y9K3WM2v25Q9Rlwg3DHXjEHihmJqYN+ktw0knt2GHJPRkdx1PY5zTWJowBg+CmQgrPEytaHVIg/aoegrZYl+tpAUkQBXlt9RQ8DGwVOeUjE0Q61wD2Rdx16oMBz4VyhEUFLxlicfd7UIYHRg9roKw/5ziZDlyn8pxXoahqie3Rt94GkfnG+XJ2pHukwS4FsmXqtRJbYwZ9WbcP/cdGjRmcowkeZ5gN3M34eHfo+YzOpMOwdJWrTcRywUryxdy3DBQrDT/Dt+wzFT7OBxlAFas8o+MX0h2u/jIHJTURXxRWm7nad2+SCEcLmw0nlGuHtvk8lk6305C46awdfodLR+V7K3popIfKMuTAcvBCgl4lxLK+kVoEmEigDT8BmsNF68x3kGy9+WkTO x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39860400002)(366004)(376002)(396003)(346002)(4326008)(55016002)(9686003)(107886003)(2906002)(33656002)(66446008)(26005)(66556008)(64756008)(186003)(52536014)(5660300002)(71200400001)(66476007)(6506007)(7696005)(53546011)(76116006)(66946007)(6636002)(478600001)(316002)(8936002)(110136005)(54906003)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: zvdbC5/LI2/+7TrLsq1chgGHEDjmObgoEDwOuoT6eBv0JzsbgjJncHe0B0Vk6aUKkLmmJBIVP6XuV9vcg2glno9b7yc3wLMsjROQy7Zurw/JJarBolEb89ULY+vO5sgDD6M3Syt9927OTlHl8CaukwgprajTEvSFypD/vf0w0ffTc5QFg1P2QLTa4vWLSi1BsaJ9z2W4AtZr2PmdyoSxOfa9OuO0NwyCkXP7Y6c41ZfWFExGVkh5cPb6fH5nhxW17ooYzhF2YG1Wr+3fe/a4SKtdDg6n1bIOBQc3My6KinxUzeHa/iPTEIIkCr7hX0Wk4pJMVAHuhmuy1+P7r6fjv3ugfF/BZLZuH4NfTm2YJeepq+IEgveOfc1OkY/z6jiJB4lsWtfXpHrWw7yyn2H6gkFU5eWWdVrBrH4EIKBZVWbw/lr0uHI9aqd5X3RDpG4ejiFxbfcHI9MRxrM2N8tKYjoXeK9pYGFmJ5MkMV8i6dWnvKRvWaYEJzt7tv02Wb9U Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fa2bddc1-581c-46f3-ea74-08d7f872b510 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2020 01:53:04.1930 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WAhrR1n8GJOaPrYpF39DB9CYieAPRqYhDDMytGkee8WbqlMpzdfasnmEVvj9FP5hrZjbZP3ckhJqP6SjWPdQwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3556 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/virtio: disable event suppression when reconnect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Marvin, Comments inline. Thanks for the fix. Best Regards, Xiao > -----Original Message----- > From: dev On Behalf Of Marvin Liu > Sent: Friday, May 15, 2020 9:41 AM > To: maxime.coquelin@redhat.com; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org; Liu, Yong > Subject: [dpdk-dev] [PATCH] net/virtio: disable event suppression when > reconnect >=20 > Event suppression should be disabled after virtqueue initialization. It s/Event suppression/interrupt/g > can be enabled by calling rte_eth_dev_rx_intr_enable later. >=20 > Signed-off-by: Marvin Liu >=20 > diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueu= e.c > index 408bba236a..2702e120ee 100644 > --- a/drivers/net/virtio/virtqueue.c > +++ b/drivers/net/virtio/virtqueue.c > @@ -175,6 +175,7 @@ virtqueue_rxvq_reset_packed(struct virtqueue *vq) >=20 > vring_desc_init_packed(vq, size); >=20 > + virtqueue_disable_intr(vq); > return 0; > } >=20 > @@ -211,5 +212,6 @@ virtqueue_txvq_reset_packed(struct virtqueue *vq) >=20 > vring_desc_init_packed(vq, size); >=20 > + virtqueue_disable_intr(vq); > return 0; > } > -- > 2.17.1 Can we backport it to LTS by cc stable?