From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Xiaozhen Ban <benhaz1024@gmail.com>, "Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
Date: Wed, 17 Mar 2021 11:23:39 +0000 [thread overview]
Message-ID: <BN8PR11MB3795166681658FC6C4E2236CF76A9@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210317091544.53957-1-benhaz1024@gmail.com>
> -----Original Message-----
> From: Xiaozhen Ban <benhaz1024@gmail.com>
> Sent: Wednesday, March 17, 2021 17:16
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/e1000: fix filter control return value
>
> If filter_type not supported, eth_igb_filter_ctrl() will return
> incorrect value.
>
> Fixes: dd5c2dd7e5e5 ("igb: use generic filter control for ethertype filter")
> Cc: stable@dpdk.org
> Signed-off-by: Xiaozhen Ban <benhaz1024@gmail.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 1716d6b90..325461247 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4599,6 +4599,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
> default:
> PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> filter_type);
> + ret = -EINVAL;
> break;
> }
>
New design will be applied:
https://patchwork.dpdk.org/project/dpdk/patch/20210312174645.162801-2-thomas@monjalon.net/
> --
> 2.25.1
next prev parent reply other threads:[~2021-03-17 11:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 8:10 [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported banxiaozhen, benhaz1024
2020-12-08 9:04 ` Wang, Haiyue
2020-12-08 9:58 ` haz ben
2020-12-08 10:40 ` Wang, Haiyue
2020-12-08 11:05 ` Wang, Haiyue
2021-03-17 9:15 ` [dpdk-dev] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
2021-03-17 11:23 ` Wang, Haiyue [this message]
2021-03-18 11:44 ` Xiaozhen Ban
2021-03-18 15:28 ` Wang, Haiyue
2021-03-19 4:08 ` Xiaozhen Ban
2021-03-25 8:46 ` Zhang, Qi Z
2021-04-20 8:08 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-20 9:54 ` Zhang, Qi Z
2021-04-20 14:33 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB3795166681658FC6C4E2236CF76A9@BN8PR11MB3795.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=benhaz1024@gmail.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).