From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Yang, MurphyX" <murphyx.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Guo, Jia" <jia.guo@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>,
"Zhang, RobinX" <robinx.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix RSS RETA be reset after port start
Date: Mon, 29 Mar 2021 08:01:04 +0000 [thread overview]
Message-ID: <BN8PR11MB379519656DF3E0C398610A2BF77E9@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210329071957.31321-1-murphyx.yang@intel.com>
> -----Original Message-----
> From: Yang, MurphyX <murphyx.yang@intel.com>
> Sent: Monday, March 29, 2021 15:20
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia
> <jia.guo@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>;
> Yang, MurphyX <murphyx.yang@intel.com>
> Subject: [PATCH] net/ixgbe: fix RSS RETA be reset after port start
>
> If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting
> the device (but after setting everything else), then RSS RETA
> configuration be zero after starting the device.
>
> This patch gives a notification if the port not started.
>
> Bugzilla ID: 664
> Fixes: 249358424eab ("ixgbe: RSS RETA configuration")
>
> Signed-off-by: Murphy Yang <murphyx.yang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 8a9a21e7c2..41068fe646 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5015,11 +5015,19 @@ ixgbe_dev_rss_reta_update(struct rte_eth_dev *dev,
> uint32_t reta, r;
> uint16_t idx, shift;
> struct ixgbe_adapter *adapter = dev->data->dev_private;
> + struct rte_eth_dev_data *dev_data = dev->data;
> struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> uint32_t reta_reg;
>
> PMD_INIT_FUNC_TRACE();
>
> + if (!dev_data->dev_started) {
> + PMD_DRV_LOG(ERR,
> + "port %d must be started before configuration",
> + dev_data->port_id);
> + return -EBUSY;
-EIO is better ? Since no started, no busy at all. ;-)
> --
> 2.17.1
prev parent reply other threads:[~2021-03-29 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 7:19 Murphy Yang
2021-03-29 8:01 ` Wang, Haiyue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB379519656DF3E0C398610A2BF77E9@BN8PR11MB3795.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=murphyx.yang@intel.com \
--cc=qiming.yang@intel.com \
--cc=robinx.zhang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).