From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C1C9A052A; Tue, 2 Feb 2021 08:42:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 364A9240297; Tue, 2 Feb 2021 08:42:03 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7105A240290 for ; Tue, 2 Feb 2021 08:42:01 +0100 (CET) IronPort-SDR: gOuMVMNiXKkpRKmG6lhdLd7nn+lTZ/hyiRCUE6D0DQg1oC66uE+4XjUDQlZdGL24gezbP/GQhY jLAchm8pydKQ== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="180037035" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="180037035" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 23:42:00 -0800 IronPort-SDR: ZiqPr0eC1T6NpkW0MjCwrsPxKfKavTrwQXJMAXyBuDaz65InsvETZbq+wD+q54ml1hmHdNTO7S fReWZsF7U/Ew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="413412676" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 01 Feb 2021 23:41:57 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 1 Feb 2021 23:41:56 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 1 Feb 2021 23:41:56 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 1 Feb 2021 23:41:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMOVQkWm1TjNG7e5BHt9gqW5wE0lej5r3NB2LWmnQlYeiSV8qORQEICmmJC4u8CnLHnOsHqqVmxB6foCv4eWX1XPgZq4HH4/UirW0umC2lnSDm79xn3PjjWZ8Kt8MtnZW/Xnu5Z3XBjpMo9nPLNxlZEn/kWAkYKu6wEVZciM6jLhteZjebFsJAqI/82NDHSlUxwbACmm0GsxKlVPfyHdg9ZLdtXSyUhde+znvZc7jCjUg8LNdrvxQidppJeHUg7tXH0ujRujMO93bMIigKSC0r4iFwHIYlH3/34grpynUt22AYh/JIkzFWL/12iLLRNiMJukVZjvXEFmVpuPEN5djQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KsUDLO/kz13/ZKAR+ttpUirT3YOKzoXekYz0ls2J7jY=; b=KudkmaZLyViIwxkwgwPdm1IUly5B79JYzWYub+gpN86IViV6sBjyHIkXPcENUPt69QU7w/zdsO3DvNOb1jGYaBXuk2hluuOMZc2CqKEODSIbsxrUKQyQiBFlmPTnw1uopskReICuMtOisi6GxmsYImcHXY/Z1Icp2oWrQSb9VFbFSRct1NOJ4iTMxUrr5GsabXXDFPq/B6/GiXMYO78sXryjRkS9s8XpBlSrDZbbFCvzJhNFDTkYhdUizd8FRclT5/3VsIVNaa2RbXrhlk0AYJgugKeIXSzy2b0YzEK8HGou/n0Hs0YaLlTlPTwLZpn9fLId2MEV76h9ktuvKSSoNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KsUDLO/kz13/ZKAR+ttpUirT3YOKzoXekYz0ls2J7jY=; b=IttqRg0ihZQpdQIHc7U6OF02OWUOjprg7ssUIttiHjW1ntqxvk45KLZukN+498VxsTzf0EE6VwuOFl+tSGt1naBFLONTN2pep5smAaIghIuFUKzxUNDbkdBxnahXhWMKRuluHbEmsRvPlhVJq5y6UzFTLmC/z29BtoBXlP4vqQs= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN8PR11MB3635.namprd11.prod.outlook.com (2603:10b6:408:86::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.25; Tue, 2 Feb 2021 07:41:51 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::b50a:60a1:8190:c67f]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::b50a:60a1:8190:c67f%6]) with mapi id 15.20.3805.024; Tue, 2 Feb 2021 07:41:51 +0000 From: "Wang, Haiyue" To: Feifei Wang , Ruifeng Wang CC: "Guo, Jia" , Aaron Conole , "dev@dpdk.org" , "Yang, Qiming" , "Paolo Valerio" Thread-Topic: ixgbe and UDP with zero checksum Thread-Index: AQHW9LNKYEOnPlbHCUiCOz71l2GA46o7uJHwgABGrYCAAdrE0IAAESnAgAC/AACABdmjAA== Date: Tue, 2 Feb 2021 07:41:51 +0000 Message-ID: References: <87im7i12si.fsf@fed.void> <87zh0rlta9.fsf@fed.void> In-Reply-To: <87zh0rlta9.fsf@fed.void> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.221] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 32fd4dc2-ebcb-4087-91cc-08d8c74e0164 x-ms-traffictypediagnostic: BN8PR11MB3635: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NDcmm05l5R+49MQkdhQA2jScPtcoLStR7y/c8PZ9Nul4KZUakn0xrpegoB3csRBMy8eG0qRA3XJ0aqHMdDWJPqPO8y5TNkdJBR7yViaYjJBBbMK/8B4zU5X0rYSWCQpxB41+JtZ9jHv0Lr0mRVyu17V/d7eM9tJ17w1LxbGEyZKay2AVGN6grPf7YK9nuqUzNYPxB2G6q9AGTmyjhzc1ALq59TMC+wIY6AhyFfujbnloIPb4boagpyfisPTbXuX3Syhz1XdGpZu1vl+znbZPkxsPtTyN31i4Eiq5Yefr5CZfrmjja98Yh7fFQEtcZPgGCJvvljkPJ7j4YS49uxV0L6Ca/m/2jP5pX30mViC1sMyk3V3Sz5EAjFuXzrBfU+5Xlh29PsZKn8D/TfmQNTrfovHlpC9oMhqRE4gIk+Ae2lt1SGuZyIVvz9Dyp9cNB8m4s0NyZl0qNwNOO0/WuRW5ze5Fz/bs5WHFTURochy9d0tp6eJqv8eY7BjXUGtyV0ARt0+EuAysYnnx/yJsJg5aOB+VJiFbSX0loed8mpW/5J7o6LpEjzlvPVsm/Llje1HeRz2wedlWcegyGDSXifftWeL17T7Ki0CvB4l/bzDty8c= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(396003)(376002)(366004)(136003)(26005)(6506007)(53546011)(186003)(86362001)(4326008)(52536014)(66946007)(76116006)(66556008)(5660300002)(66476007)(966005)(66446008)(8936002)(55016002)(64756008)(7696005)(9686003)(33656002)(478600001)(2906002)(54906003)(110136005)(8676002)(71200400001)(83380400001)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?SCrXxU9RG8+YJAC/PmRvY6AAPGNk921ekffaQEyOXvZTsuvvpkXDphFdPEsK?= =?us-ascii?Q?am824DFx0ShRGyGYMjrNY93XKAFG47fd1i6Jl41gJXC5YfknjRrmC1Fhu9PD?= =?us-ascii?Q?qwfojbcN5s1DMUEDJUbI4UmbDFKPr+WjSLaBXS2l7p3Ma2pxtb/kqlnk7iUO?= =?us-ascii?Q?gZDEX0KaZWA28mBRCXQD2DuttEcCkqkQDkSHD6bDK6yVgxLoUOZshOW3etSE?= =?us-ascii?Q?v/RB6utXQ50xnSsY1lZ22XUySqQ43r0TfvLPyVZvuW2E+bMYH8ylbxFkCzat?= =?us-ascii?Q?UokrjGPjkFif3KW085PWSCeUhIRc2EVwiSsVFLM+QbanpjaYM/YfrCCp17R2?= =?us-ascii?Q?kZjcTv9/nNgKSgMZFMLaYrdkEwumfIPdaanE0REPtxwhEbQWQVERYSUubtw+?= =?us-ascii?Q?FvuNKnliMPF+sHnS5qYO27iLbi6xHwyMli+EuAzOZ7kRhKWD1uJ7gTVO+jtA?= =?us-ascii?Q?F7JyRowOGoLTzsWI5xqQij9Uho/WaljbtVMsJPBGfl9xAIY05QkwkmdW4pKO?= =?us-ascii?Q?4O5ping8fvG1WiCjTfmEVZrRbLbgrokHN193FegeVuDFudkr9VBfviiQZM7U?= =?us-ascii?Q?zC6WPEymEQIq8zfyTOZxnxYDB0j55g6ihFvRlEc3L77f6TXxil3bvNIhuL0o?= =?us-ascii?Q?xQ/x/WtHs1KzOo3/Qy/FJJ2Y4uV/YszD8JVGOOvMG66Ep7YvceMn9+ahzm8M?= =?us-ascii?Q?ewZNwVpkeglU+7ICJdlQRCwozjqG2qZTqQsBpq0Qc2YWCbq3ALBm3UGdWRzR?= =?us-ascii?Q?zDu+f+YmvRnXNKgeEx7GgcnYHul2ySQzrArfJivd/A74bL6N4r8iRYNoRzZw?= =?us-ascii?Q?u4tMIRRwmzF518fLRAYbvrhqWolw+PJL4VSSuDZe8FjPKGpgR6RL7iLhrzfL?= =?us-ascii?Q?64r6DnLRXzXpkDkhV0Oiaws+BlacJX6uIs1iwoLo/9LUjkg2m5AgufF7SC0G?= =?us-ascii?Q?K6OqZ6uyROC6rehJRP+J12AMskQp2HBtRmHuLfcZpWAZxIEPRZNNqUWOiqxT?= =?us-ascii?Q?C2qgVCMcRSz9CYBAKSkfSSEsMP+ccgmI98vRfZiKDDTtc/gUu24uulUXXSwS?= =?us-ascii?Q?O5mVMer/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32fd4dc2-ebcb-4087-91cc-08d8c74e0164 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2021 07:41:51.6650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Pt8W2uERrHZGtOwuFqjwDboP7/eahWY9iPvc6VGgL7t7ePn/sMhG89pYE+y/7M/GjSHRWXa8N4WKHc0+pzX7nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3635 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] ixgbe and UDP with zero checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" + ARM experts, Feifei and Ruifeng. Need your further support for ARM NEON path. https://patchwork.dpdk.org/patch/87617/ > -----Original Message----- > From: Paolo Valerio > Sent: Friday, January 29, 2021 22:20 > To: Wang, Haiyue ; Yang, Qiming > Cc: Guo, Jia ; Aaron Conole ; dev@= dpdk.org > Subject: RE: ixgbe and UDP with zero checksum >=20 > "Wang, Haiyue" writes: >=20 > > Hi Paolo, > > > >> -----Original Message----- > >> From: Wang, Haiyue > >> Sent: Friday, January 29, 2021 10:02 > >> To: Paolo Valerio > >> Cc: Guo, Jia ; Aaron Conole ; d= ev@dpdk.org > >> Subject: RE: ixgbe and UDP with zero checksum > >> > >> > -----Original Message----- > >> > From: Paolo Valerio > >> > Sent: Thursday, January 28, 2021 05:35 > >> > To: Wang, Haiyue > >> > Cc: Guo, Jia ; Aaron Conole ;= dev@dpdk.org > >> > Subject: RE: ixgbe and UDP with zero checksum > >> > > >> > "Wang, Haiyue" writes: > >> > > >> > > Hi Paolo, > >> > > > >> > >> -----Original Message----- > >> > >> From: Paolo Valerio > >> > >> Sent: Wednesday, January 27, 2021 21:50 > >> > >> To: dev@dpdk.org > >> > >> Cc: Guo, Jia ; Wang, Haiyue ; Aaron Conole > >> > >> > >> > >> Subject: ixgbe and UDP with zero checksum > >> > >> > >> > >> Hi, > >> > >> > >> > >> performing some tests, I noticed that on ixgbe when receiving UDP > >> > >> packets with zero checksum (no checksum) over IPv4, the correspon= ding > >> > >> ol_flag for the l4 checksum is set to PKT_RX_L4_CKSUM_BAD. > >> > >> > >> > >> In particular, this apparently has an impact on OvS using ct() ac= tion > >> > >> where UDP packets with zero checksum are not tracked because of t= hat. > >> > > > >> > > > >> > >> > >> > >> [1] > >> > >> > >> > > >> > https://patchwork.ozlabs.org/project/netdev/patch/20090724040031.30202.15= 31.stgit@localhost.localdomai > >> > >> n/ > >> > > > >> > > About 12 years old patch, it is hardware errata. For fixing this, > >> > > have to always disable vector Rx path for 82599, it seems not a > >> > > good idea to bring in this workaround. :( > >> > > > >> > > >> > Thanks for the answer. > >> > Yes, as I mentioned, the patch is old although still meaningful. > >> > I linked it mostly because it mentions the hw errata. > >> > > >> > >> What's your PCI device ID ? My worked ixgbe: > >> > > > > Sorry, I missed the PKT_RX_L4_CKSUM_BAD information, yes, my NIC have t= he issue. > > > >> 86:00.0 Ethernet controller [0200]: Intel Corporation 82599ES 10-Gigab= it SFI/SFP+ Network > Connection > >> [8086:10fb] (rev 01) > >> > >> I'm wondering if people will complain that the patch will mark the rea= l bad checksum UDP as > > > > Zero checksum is more popular case, please file a bug on https://bugs.d= pdk.org/ to trace the fix. > > > > Thanks for pointing it out. > > >=20 > ack, I'm going to file it. >=20 > Thanks, > Paolo >=20 > >> GOOD. For handling this correctly, looks like driver needs to check th= e UDP's checksum value, > >> if zero, then skip the error information, but this makes driver do the= network stack things ... > >> > >>