From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>, "Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error
Date: Tue, 20 Apr 2021 02:31:14 +0000 [thread overview]
Message-ID: <BN8PR11MB37953B89CB8A391B903EB9AFF7489@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210420020520.17936-1-alvinx.zhang@intel.com>
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Tuesday, April 20, 2021 10:05
> To: Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/igc: fix Rx packet size error
>
> When DEV_RX_OFFLOAD_KEEP_CRC is enabled, the PMD will minus 4 bytes
> of CRC from the size of a packet, but the NIC will strip the CRC
> because the CRC strip bit in DVMOLR register is not cleared. This
> will cause the size of a packet to be 4 bytes less.
>
> This patch updates the CRC strip bit according to whether
> DEV_RX_OFFLOAD_KEEP_CRC is enabled.
>
> Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>
> v2: Refine the codes.
> ---
> drivers/net/igc/igc_txrx.c | 30 ++++++++++++++++--------------
> 1 file changed, 16 insertions(+), 14 deletions(-)
>
Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> --
> 1.8.3.1
next prev parent reply other threads:[~2021-04-20 2:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 1:14 [dpdk-dev] [PATCH] " Alvin Zhang
2021-04-16 1:57 ` Wang, Haiyue
2021-04-19 7:14 ` Zhang, AlvinX
2021-04-19 7:43 ` Wang, Haiyue
2021-04-20 2:05 ` [dpdk-dev] [PATCH v2] " Alvin Zhang
2021-04-20 2:31 ` Wang, Haiyue [this message]
2021-04-21 11:46 ` Zhang, Qi Z
2021-04-20 9:10 ` Chen, LingliX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB37953B89CB8A391B903EB9AFF7489@BN8PR11MB3795.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).