From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91A4DA0C47; Tue, 6 Jul 2021 17:07:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CA2E4128B; Tue, 6 Jul 2021 17:07:31 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1F5AC4120E; Tue, 6 Jul 2021 17:07:29 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="189508245" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="189508245" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 08:07:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="410258803" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 06 Jul 2021 08:07:25 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 6 Jul 2021 08:07:24 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 6 Jul 2021 08:07:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 6 Jul 2021 08:07:24 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 6 Jul 2021 08:07:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4HvpIaD1mSwwuFZl6GU04Pd129UGxz6lsCau7nVTTUa5uVvVxXmwaz5cllOaMUx7DrAVnxiIrnte0hRpOeVAu9+cqDMDk6Cl0u2tP14rA8xC46ux8rtd/r/CM4PB1GYHQluXN8NnyCSbRcv6J1vWtqFbn5J72mwLx/7DFjD/8eb9X3mviMKRawC2SMWIWuBDpriPQ0UI+/mdGjIQ0mlUd/yi4r4iHLu6Ep01L5iL79kYDExyoTpU3ww2rGtdr1jo70/aZCh5FhEUqCh35b0C8RDnh51rMwffoEAomG1jWMB0zOuFf1lMIDaGGy0lakuh7dZCg1mR5/7JjY4UytcoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fo4tHdr5a+FrKd3+DjKn4BZpAYOQs95OVR3SR8rOISo=; b=OCUwDCanZdCG1YKOpAbpKDkFQxU+j0xfm97nii/MaDuT2YstH6v3mcvTse42emOjPaiMFRGu9pqQvg0i36WeYLkLzb/yZx7vhfhSdA33Qpq4R1Qxuta1DE3LtQRaUejUUBRmRrw79BtW5pSna89pwOxXb8ZB2DOYhXJ49Lk4kXbqvzDMpvg2EPXwKQU6AC+pvKRaUVc+Gv6IdcIrJ8E8heBltzDgJMCCwGzQ8Eikk/LRTs91aYQerBjBxjutbnU//4llMGaB1/rkJxXTlIVZ6jYf1zlsaOF2xjRhdKTonu8Q2jPFS9/QzWs2Aoc+YEsDSlrIm/DMowbRJ+t/2ZvADA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fo4tHdr5a+FrKd3+DjKn4BZpAYOQs95OVR3SR8rOISo=; b=uQxwqpr7hW0nSsOzq2k+RjzUhjPlvT4p6Y+HUJkqFtXF5pFP3RIhQBbuwnA2oluBOs+svBO8eUVPsKn0/UiVILTNvtlgvhdfOiUQTLoo63YsprAZzxDReZIRN6lxM/eFQbVYKtltYKI/Zdzj5KsVaaLlLJdVjB8/rpetnwbf7os= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB0033.namprd11.prod.outlook.com (2603:10b6:405:63::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23; Tue, 6 Jul 2021 15:07:21 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::8807:6661:e425:102]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::8807:6661:e425:102%7]) with mapi id 15.20.4287.033; Tue, 6 Jul 2021 15:07:21 +0000 From: "Wang, Haiyue" To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhang, Qi Z" , "Stillwell Jr, Paul M" Thread-Topic: [PATCH v2] net/ice: fix memzone leak when firmware is missing Thread-Index: AQHXcnEJoZT+ibWZhUaA/rx2Vk/7tqs2DBjQ Date: Tue, 6 Jul 2021 15:07:20 +0000 Message-ID: References: <20210706085643.5088-1-david.marchand@redhat.com> <20210706141237.30492-1-david.marchand@redhat.com> In-Reply-To: <20210706141237.30492-1-david.marchand@redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: feee402a-7784-4708-c69e-08d9408fc0e7 x-ms-traffictypediagnostic: BN6PR11MB0033: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KxdplFeUrkVFTAYahMgF+L17YlEn4rQV3GJtCXkYwRH0/ySufjJUSsDn7tk/3lkauVUZs+VXCbtq4DKQbT7m7VVsQQv8ecr1g5a5rk7hIBleFfDeHKW3hu37CkK32qeechaN8d9/59z6Kaa44VqFk50z9qFuDnkK7hb1DB0QCwf318nUtYDXtygEGSnB/j0E8WaXW2un4Nc2x/hY6v2z3o2qd2hvYz4O9pJIwqL0R8ldKNhLMAu3Ncg1r4m8bvbq1IfotjXG2L9dGXKNgg0gVsEOHLndjjGV9Fl+RzY9BErCZTXRA5ssEu2/2u9goQ8zwBb0pZdAeFPr/6nQ8ECHxZTLfwUMDu0NzNzcB+e68GVQr3yWY5TCrv9Hd2om0UbPtSV/+FC5UbUuWzFAclL/otUy7ITKCdcCGIN4nvKO5pk1nAStE3hZNoA9lJOS7QGJeeTYfYk5tOK3GqZhItyxsrXFT2AfDSO3XJhDsqaqMMrXYlUVKWUyeJgRsQK0+7gVMR+XqpDvIEJGVF6/h/pjkx/3LEEFIyBjVqy2rPiZRwzIU43vOryLtd592UHdJ5jMd0vjsxFWWTACS8+5l5LtPI43WUe8O4z/WG0Npw5T7vCa/+bwpEMgGT7lOOtLF+WwZwDwbsBf0eYSge0QnPielg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(346002)(376002)(39860400002)(136003)(366004)(8676002)(107886003)(478600001)(55016002)(54906003)(9686003)(76116006)(8936002)(4326008)(110136005)(71200400001)(66946007)(83380400001)(26005)(122000001)(66446008)(186003)(86362001)(64756008)(52536014)(66556008)(5660300002)(53546011)(66476007)(7696005)(6506007)(2906002)(33656002)(38100700002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5R/YdBBlp1A/BqYxy78wsNhdGBTewQyra2gQkZqmX/KVRgAxXEdtOU0AGZk0?= =?us-ascii?Q?q9V7j6bW3uwblaiuKk9MHEXMQCNQt5aT0Rpa+zLzSNPVXdisTbb2pLaULNN8?= =?us-ascii?Q?9GbPeuSUkG4vHEBHpLffrLLTEa8KCsSDZQ/n+jgViGpbPeci6K3tC05z7aKs?= =?us-ascii?Q?XgDH8adPzChb9VZq8UGeyUljo8+FIhyWzyq/Mxh1Oc4jBaK1oyRezNbF7Bt2?= =?us-ascii?Q?BlBYi6ahQ1pnvml0ewku2iws7ZQELZcsfdPC4i2ovqrbL4yUcTIQhqY+R79x?= =?us-ascii?Q?pSvzHocrbmeTVlSrrWngwNW1VflMGENMmUGKyjkucSsYZ3Gxn8SdoXPYGG/F?= =?us-ascii?Q?TAJ5WtzkQYmMOFdpFPKAgf1Fcj5t4/OTLSLA422U81ulXndt1TTYWk1lNnQ0?= =?us-ascii?Q?x82mCYUGtMQCSqv0bZlox1tqTX+nna/y4DO8DSYw1JnKdJAVg7Ci7tZgij5u?= =?us-ascii?Q?f1Ew3LP1UDzrowwXHvBKeGCykslyufEvo0aH+CY08+oYG0FElsq5eoBqerj3?= =?us-ascii?Q?wPb13BJIBivZ1C2gqqbObHhLJIxnfjkv1EMqH8UyypqKyRrofKkHD++Z8Ch2?= =?us-ascii?Q?HR3pPse8YClqjDe9WW32+thL8BE1Xvq+w+JyYJdQmxL/cSRmR2cv11PAgOXq?= =?us-ascii?Q?NvibDxs7cU3RNDLVUnV89lBBtNGmwFx0Nsc52U0EZxWbga1r1KxYmVx+ZZHA?= =?us-ascii?Q?G+lSNZtCeh8xMlzsgAUoMXOCSTsj31bsvqHunEFMyT+PCxPyaeL2rPR821vs?= =?us-ascii?Q?GDy3H9xU276nkMYmdzA57Jkptvm/AdwRR4PK2SV/Y0st1qXOuQ7Qbc3mCT36?= =?us-ascii?Q?tD5S//W1HtvHvgSAOyjbEiDXsc9koEaYEEiSchDleHx+PlrCIM3D6PBSHzJt?= =?us-ascii?Q?Qq+Si2kptAfEUANpd5xjSEzI6ZbrvjSOBryklcEDp2dqyDAo2IuFUGVnkmcz?= =?us-ascii?Q?mnwldsMWRhrcx63jDATrb+R7I1w+d3/Z8puab3hC+FK9mcbrow7gfRM6We5D?= =?us-ascii?Q?fND3PprrJxmB2hTxCao0tkOuohm9Lj3fxUuugzPnRt7Zm1N75mQgRXU6zQ7r?= =?us-ascii?Q?1hQhdG9lQQF5zVgvE6YVblD1q4gy64BDQMm24kYaSXMbfnaKqlYMmuBoUipl?= =?us-ascii?Q?EvDBYb+LidBWmyySCp4aagxxZMK1tDr1grTN7nGOpIo1mDYOKFfCZBQ3K77e?= =?us-ascii?Q?B65xb+ZgKloRLyylZLYQ0upLdngzynsxyupMZM1OoCcn0HHeGsOcXAEke9jf?= =?us-ascii?Q?YYKZmN8fdHJsQxZKry3l+KhWG2DUvG9pu0k0qDHQ8dz8Av+M2YCa7xKXkOFn?= =?us-ascii?Q?5W/IO38IbTN0VSlMnBO24A0O?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: feee402a-7784-4708-c69e-08d9408fc0e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2021 15:07:20.9372 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mHdJjPKHTbPipg6/5Ori+hiXEclYeDD94bHYUkA5NfGqkv7JPjOKt0FxBD4HZVUViB2la0LXL+1qvw+laBEENA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0033 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix memzone leak when firmware is missing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: David Marchand > Sent: Tuesday, July 6, 2021 22:13 > To: dev@dpdk.org > Cc: Wang, Haiyue ; stable@dpdk.org; Yang, Qiming <= qiming.yang@intel.com>; Zhang, > Qi Z ; Stillwell Jr, Paul M > Subject: [PATCH v2] net/ice: fix memzone leak when firmware is missing >=20 > Caught by our QE. > When the firmware is missing, memzones were not released. >=20 > $ dpdk-testpmd -c 0x1f -a 0:0:0.0 -- -i > ... >=20 > testpmd> dump_memzone > ... > Zone 6: name:, len:0x15040, virt:0x1661b24c0, socket_id:0, > flags:0 > physical segments used: > addr: 0x140000000 iova: 0x140000000 len: 0x40000000 pagesz: 0x40000000 >=20 > testpmd> port attach 0000:5e:00.0 > Attaching a new port... > EAL: Using IOMMU type 1 (Type 1) > EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:5e:00.0 (socket 0= ) > ice_load_pkg(): failed to open file: /lib/firmware/intel/ice/ddp/ice.pkg >=20 > ice_dev_init(): Failed to load the DDP package,Use safe-mode-support=3D1 = to > enter Safe Mode > EAL: Releasing PCI mapped resource for 0000:5e:00.0 > EAL: Calling pci_unmap_resource for 0000:5e:00.0 at 0x2200000000 > EAL: Calling pci_unmap_resource for 0000:5e:00.0 at 0x2202000000 > EAL: Driver cannot attach the device (0000:5e:00.0) > EAL: Failed to attach device on primary process > testpmd: Failed to attach port 0000:5e:00.0 >=20 > testpmd> dump_memzone > ... > Zone 139: name:, len:0x1000, > virt:0x1660ed800, socket_id:0, flags:0 physical segments used: > addr: 0x140000000 iova: 0x140000000 len: 0x40000000 pagesz: 0x40000000 >=20 > With 20 tries attaching a net/ice port, we would end up with: >=20 > EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:5e:00.0 (socket 0= ) > EAL: memzone_reserve_aligned_thread_unsafe(): Number of requested memzone > segments exceeds RTE_MAX_MEMZONE > ice_dev_init(): Failed to initialize HW >=20 > Fixes: a4c8c48fe3f4 ("net/ice: load OS default package") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > Changes since v1: > - switch to ice_deinit_hw() helper, > - fix build for Windows, >=20 > --- > drivers/net/ice/ice_ethdev.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Acked-by: Haiyue Wang > -- > 2.23.0