From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96115A0C45; Wed, 22 Sep 2021 15:51:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88FEF411E8; Wed, 22 Sep 2021 15:51:37 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id BCE48411A8; Wed, 22 Sep 2021 15:51:34 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="203749429" X-IronPort-AV: E=Sophos;i="5.85,314,1624345200"; d="scan'208";a="203749429" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2021 06:51:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,314,1624345200"; d="scan'208";a="653273036" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 22 Sep 2021 06:51:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 06:51:33 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 06:51:33 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 22 Sep 2021 06:51:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rwkq0M37Q3TOAI9g2AvSLUlTRRaDFqh9hgTRHgzLz9JFkDyXSromcSQqmwIRQdT7ZFOnqzXzxfFelCtKkqWa1AQbEnfn9QTq797J8OUyRKlVxkrBfVASyWH83W4xkdk8rfXn+hnx9/kJavPBdShFSgmOhbjHsVMhNvXZ26eUxa7lm7KY98en1B0qE0FVoFsN9MypIPcmdXkelyuNm5vl8Se4eGajvAU4YnfViFd+L1Ep0Ux1zE1JlV1Axzp+H5BmqC2EvYlXR6gWizzW5k0cFKMleml1B7GeKMMS49eCkJSzpYvTm7WQHMGilStJOejGwvJmC9yHZwhAkP8DxtWmGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JhyouFfqEXTSDNFelDc5+MHn7/v+dH1PgdwousxspyM=; b=aEgoAe2/nPLOvMFCJ1F2gRYjyZS4Y6k2ithMB79oxun1X95lPAN/BUySyNQuyVbbRh2Sx5PGbip4Jqybkrukf2zjwxdwR+x0e+IVM0SziUiF97K9wNHVC42x7QL9OVoMyDEp32sOUYRmdDAQoN5LA5xenq2GaBcSS6VNEND9EUuQVa7T/wzHAAlJtM3xtrb6Sp2fYBJ9b6NnQXZ6s/VkrkDNwAzhCI0phn7XYiEjSwohEwkDIxH7Bcbocg/7GP6tpIhCE/E4rWy96fuSMT5FT8daCNudGJ9g/LPX7ptmb+NyXBrL3CuvM+bsi3oKVIoZYAn5ZHf0DjEkPQPF30cdwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JhyouFfqEXTSDNFelDc5+MHn7/v+dH1PgdwousxspyM=; b=CKe4LpP3kervOZ0Ef6KKY66PbPmdOv2L2ZWNZJWANvt6nnsq8SdieQX8xCjhOLrmqFzeQD7SKAmarat89iYLM6b+kIWyiqGjhOJsEHj6JzEgQ4tddMBvM8aOA9e58w1GIz0zZ24THsaJPchChmI/zrVEZT6sCKY0FDMWPi5T/fw= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB3972.namprd11.prod.outlook.com (2603:10b6:405:7f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 22 Sep 2021 13:51:30 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7%3]) with mapi id 15.20.4544.014; Wed, 22 Sep 2021 13:51:30 +0000 From: "Wang, Haiyue" To: Yunjian Wang , "dev@dpdk.org" CC: "Xing, Beilei" , "Yang, Qiming" , "Zhang, Qi Z" , "dingxiaoxiong@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 4/4] net/ixgbe: fix memzone leak when re-configure the RX/TX queues Thread-Index: AQHXr7YQQ7/FumVlskCeKFQ8YZ9hZ6uwEjBw Date: Wed, 22 Sep 2021 13:51:30 +0000 Message-ID: References: <5903785d9846efe76eedab5480dd2858f0361da5.1632315160.git.wangyunjian@huawei.com> In-Reply-To: <5903785d9846efe76eedab5480dd2858f0361da5.1632315160.git.wangyunjian@huawei.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ec697cb-996b-4004-418b-08d97dd014bb x-ms-traffictypediagnostic: BN6PR11MB3972: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:989; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6zdLnkHzxsqBWD1jL4i232WlQ0O4xQuFcfZQrEaTdihUNQqn9Bzp/AXg8Yv8mKnkT4lQyhlN7Oztc6C10TWqIAawxkixkG0hYUlPKih0Un+J/qppcHr1JGs4KAsRGvB0+DBWKeenJ/dLIGmDHzpqyCQCUyGI0xC5Lnt8jUEmgs+W9JCEzuo5llK1Aa+dqSD60+8/bt7QHpychmg+6KuCsk4Xdh2lqs0G+Z3bGgAq3o4S5dwplmL276Blr6I3oqf2WkPu06QzKVbZe+jncf/y8kpmW15EHszvlcCGikHN6FkhemQLt0+fCZkcq7eIfRFoPiougAOyVixr1QHSqp6txwm4AvIUk3iEIaaURm8K589np/Ut9rbu9pePMiXC9MdstobrO6bDTjiUQny5OXx0e/B9ExB7njaVSFcQhLVhPelHnTNZCZWTE4zv2tYHM29Ur2cDqdlvZ2fhv7Iln3ucmOM1wQLCyCJgvtnlYniGPcFsLjTM62rCFI1Iqs3e+ZZIModuqYqLmMbss+OUa/Fs+RrmzHp91v1F+TVesmzGpbFswhVDbbqMN1/whKWj8Rp/4j7meSVMzHTKXYx6nMj84liCjMgtGGnUgQGf71FUx2MExaxCUnYShlppg/VZC+Mj+1FavWDAZFP2TFb4SZtN8VrEiIU4vKxeAEqDYhkgQt9Wx9Asc0CR2Zy8xWmT7ePdH6woOBz2jSgqB3RzI9rxkg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(26005)(76116006)(53546011)(71200400001)(122000001)(6506007)(5660300002)(186003)(66476007)(316002)(66946007)(52536014)(66556008)(66446008)(508600001)(4326008)(64756008)(7696005)(54906003)(110136005)(86362001)(33656002)(8936002)(2906002)(38070700005)(55016002)(83380400001)(9686003)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9sdUY613kzkmyA8YanAQE/HCPZRzduCAQ/CrMPgRPXHPC1lrZkBhuJ9+4iUa?= =?us-ascii?Q?3SUBsAsmYXBS7XBvkVtUBwIEageY1i9tManzAZBf7/dsWOUHphudxo8POpCs?= =?us-ascii?Q?LJ7B50g5jGXtdn9juSXmh+wfZGBjct5B7vcxXI3658FYUm8MOvjvEpgbb1om?= =?us-ascii?Q?o+LSUKH1V0tnS1r0S4cjncNy4e8yablwBqfmIX6pm25RG6v6/wi9eQ+VF1cf?= =?us-ascii?Q?oJ+ylarUufOW/4IpQwCbR9h99YwLCXSS50GyUl/IHqdZr2mg8zO7POqPxeAI?= =?us-ascii?Q?BPEj/lEVGJOhL54AQu1LpCGw9uycyAPU+zwWY9XgrMXY2nu0L/3ZXUgMSqvF?= =?us-ascii?Q?o7/IIApeaQVrQn++xpy4KrzuoJgk4LfN7CEBhg3ItEDmSxOpLKPltWcvA7Cd?= =?us-ascii?Q?FTPp5v54iEd+HGy7cRWR36XEAMHsuy7qq60IHuh7sgiK9BqL3qIuFcYd+DYX?= =?us-ascii?Q?I62JTckzt8A40aPzIm337Ee21NrSdsh2DA3zFvGVRX/IK4rTBQBEEq0Iq/E3?= =?us-ascii?Q?NmEHsA9AZtOpcBUSjavIVT6buYUl9kC0hfBqvUebL0uCKTKI3XI8rsqXgDnB?= =?us-ascii?Q?gWbuuPPGZvhNxu8Sw9UioB9WfUkw9KwUGCLQvhTuFn18RAw/kdSyN4nZLUSk?= =?us-ascii?Q?MqpcOAmQ5cOXRXL3XCxs3ioD8zfxnGw0TJ+QBlZFojaGaln3Ti4Gul4M8Ke8?= =?us-ascii?Q?KM5kS3zk9TYSSLKvA/FYrmqZZy6PITqbmefqa2OOhlx3xR8UXf0DFTK+0hij?= =?us-ascii?Q?1/TqptHmmCqQK3tpFE0ox/Zm3h0aYHBH6eFWCINh+srrD8ez6u9Joy2pOZBY?= =?us-ascii?Q?d902spXNuzZsB5WLopBmBetqVBqkaFrrk/FFXHO4vJMHmGNcm0+0k9CAvSvh?= =?us-ascii?Q?wC52aT6DNhwHUElTLPs6y83eFL31EFHTpVvL9m6qzrS2l/JrNSBU9xR7pfS1?= =?us-ascii?Q?OSbl+QLWR/pFsELUuXduJZIdEeLG83s7mvoF8H59mXBSwppjlTToLT0hLyhc?= =?us-ascii?Q?GDJUAbGsfx26ISUr55A1pUUq7tX5p2yTQRP0v+ob2slWdXiBXmt07K80S70B?= =?us-ascii?Q?+Zh0DDjJCDx8t0dqkOSi3L6BrGbie1Kc2KgrQTC25LcmC1+PzggcX8Hzx5gG?= =?us-ascii?Q?fFN68ml9sJwZqa1kOtD23pEWjshoF1+cDDkelZ6c7cPxiRlw7sls/kEyI1fr?= =?us-ascii?Q?d9IpgWwbdO/fblU02hKG/HmsgR0KtYz0eGDAMUnsN54RfRwQrJgMbGLoEOuh?= =?us-ascii?Q?ZjlCa4w1IpeME4pbDeyGie/lWlr+Edg/UGHvJ6YuBNVIDUUrFHkN941Ozgxe?= =?us-ascii?Q?lIiTuGh4+LChfouZVjKOCSwY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ec697cb-996b-4004-418b-08d97dd014bb X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 13:51:30.2972 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: brbgiutuVuCT1uvfbWaX7X3HCjnd1ADLJmTSNO61EmaiKVFwD1B60hvfc45WEasCggwbLJpJ9cWsYxzbHZTtRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3972 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 4/4] net/ixgbe: fix memzone leak when re-configure the RX/TX queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yunjian Wang > Sent: Wednesday, September 22, 2021 21:30 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxion= g@huawei.com; Yunjian Wang > ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v3 4/4] net/ixgbe: fix memzone leak when re-co= nfigure the RX/TX queues >=20 > Normally when closing the device the queue memzone should be > freed. But the memzone will be not freed, when device setup > ops like: >=20 > rte_eth_bond_slave_remove > -->__eth_bond_slave_remove_lock_free > ---->slave_remove > ------>rte_eth_dev_internal_reset > -------->rte_eth_dev_rx_queue_config > ---------->eth_dev_rx_queue_config > ------------>ixgbe_dev_rx_queue_release > rte_eth_dev_close > -->ixgbe_dev_close > ---->ixgbe_dev_free_queues > ------>ixgbe_dev_rx_queue_release > (not been called due to nb_rx_queues and nb_tx_queues are 0) >=20 > And when queue number is changed to small size, the BIG memzone > queue index will be lost. This will lead to a memory leak. So we > should release the memzone when releasing queues. >=20 > Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++++-- > drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++ > 2 files changed, 6 insertions(+), 2 deletions(-) >=20 Acked-by: Haiyue Wang > -- > 2.23.0