From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E21BA04B7; Wed, 14 Oct 2020 10:47:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EA7C1D576; Wed, 14 Oct 2020 10:47:04 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 98D3A1C1DC for ; Wed, 14 Oct 2020 10:47:02 +0200 (CEST) IronPort-SDR: gIxNl723WQaBZIQCPoxIuTP3b8CSHrllW4TBETd7hd/y4fkvgRivfpMbrL9sdghmtNWBoN0zXo Hp1gWTaCQfBQ== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="166125704" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="166125704" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 01:47:00 -0700 IronPort-SDR: p9T9rCvEm3s7IidVRQrMgnRAxL4LLiPaMC1lThGILfd3XajR2mybpD3KZDAkKcCPiFIkUSib/o vDGs82w/42Aw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="299888904" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 14 Oct 2020 01:47:00 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 14 Oct 2020 01:47:00 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 14 Oct 2020 01:47:00 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.53) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 14 Oct 2020 01:46:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dVrBaRW06in6XfnVFnNhhvt1DSAHRFeBVZFT9lc2WQ8IdjDLHb6tMpy0OkxZaTCLtwzM2kpWeZVilfAIwHZ/behTaD3jzShH2B3vE3n1XBJGa/eF/nYdZVyJ4qFHw3ZaG4YLdlO8JmD7AaBSvmkbUXtgNm/d6jf6QuUmVjxLWWBFbDuW7VLZPqw1jR4azTYlCyqD+iyCBeqFB6LiFjgjoFpSe15lLesSWrQEuQmIIrNqbM2sBRspltsHLDafZ02UIJBoJVAHWf9squGv/9Czw1ULKBgGYJ6HXU3B2ZrHsFndwU17jDiAsU5AY94zkQqcE9iSGmvToc8CYF1khqBg3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPxHID2nAjaxILGbT823Rpp+pYiFq5oHL+0vWzzlSso=; b=R+cXXik8hX4Zk3/MeCC65QuIPx0NVBoT/U6yT4rpGEnggLRKmYfR/oxBE0HpjbCVMLWnyC8xZV8bc61Cp10i0hcROHk++Llev4OC4sDjQcdbIAUtP0j123DJ5e2cY8m1MlkgfOib96VME8TUxz+s1fK4qeZCWtzm4/tiHl1Pok+PxTJf0C+4db9kkDodXqMc0yJP12TFHwxDa53KnSoBLXjrf9MpnDJRKx7eU6ZPeyjWnzIYqrXNjTx893I9cxoW2baYKVW+mFkB7YvwdldtVIzQ+V3ZAYn8SUnucqLYm0YUS/kgZhFExSmGwXwoQDkUOyPC1gpd8rIU/lUXo99lqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPxHID2nAjaxILGbT823Rpp+pYiFq5oHL+0vWzzlSso=; b=sdIhdDcpn3f3eG8QBEHA9QC195YmdpJmxJdVZbLw910GjuDhmaphxLLDMrHOPCZuJQFDHReUXx6QwIsLRYtwScDtEPqNMiKkVFPHFfFKGKqbGJUTRcljEgNm5adNZ3ZZcX7AJP/KS6EU5eAIAWW5XzJI1uYJzP/wlRnMoJcqX6E= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR1101MB2178.namprd11.prod.outlook.com (2603:10b6:405:51::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Wed, 14 Oct 2020 08:46:49 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3477.021; Wed, 14 Oct 2020 08:46:49 +0000 From: "Wang, Xiao W" To: "Yigit, Ferruh" , "John W. Linville" , "Loftus, Ciara" , "Zhang, Qi Z" , Shepard Siegel , Ed Czeck , "John Miller" , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , "Ajit Khaparde" , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , "Guo, Jia" , "Wang, Haiyue" , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , "Evgeny Schemeilin" , Igor Chauskin , "Gagandeep Singh" , John Daley , Hyong Youb Kim , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Wei Hu (Xavier)" , Yisen Zhuang , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , Alfredo Cardigliano , "Xu, Rosen" , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Tetsuya Mukawa , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , "Kiran Kumar K" , Akhil Goyal , "Richardson, Bruce" , Andrew Rybchenko , "Wiles, Keith" , Maciej Czekaj , Maxime Coquelin , "Xia, Chenbo" , "Wang, Zhihong" , Yong Wang , "Thomas Monjalon" CC: "dev@dpdk.org" Thread-Topic: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats Thread-Index: AQHWodGQEDo0Hl+IGE6D5Xx096XDFamWyQLg Date: Wed, 14 Oct 2020 08:46:48 +0000 Message-ID: References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <20201014022649.2165524-1-ferruh.yigit@intel.com> In-Reply-To: <20201014022649.2165524-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b5ec2a2-19ff-4de5-d180-08d8701db090 x-ms-traffictypediagnostic: BN6PR1101MB2178: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rodPfuWfo+1qkVgDqP+UzUOEOna6rDed1Y4+KWD6KYrRQdn2kdOentPhj4Zgi0dUA3f3BHRTiezQSK/5XeOEV7buWIAnzwLEbbi507GGBpZjiQXFcvUsLtyBLnJZwB3Y/kvIWHJwaFaK06il48C2ZiB8pqLmvELC6aGNfzZ74wJ+qsn6zY/hqrnbbJTsmAyFJRRkwsCGEiW1+9+SU4Wv2g4tA3QD8zsw7F8b/jGmLapy/ZR5O6m7xOFTCe09n0jVl5Bla3V3S9tusA2aihgLwQW0brQv+0zJAfxK9dWlO66w/RZhmowm2BhmeC8T+QJoBvdBuBeYbgF+behhzBA/iNwMd93TqcZCUhOe7OjQvXnlDmi4DkqFJAr+sTf2Vrs7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(396003)(376002)(136003)(366004)(71200400001)(5660300002)(4326008)(52536014)(53546011)(83380400001)(6506007)(66476007)(66556008)(66446008)(66946007)(76116006)(64756008)(7696005)(7416002)(7406005)(7366002)(186003)(8676002)(33656002)(1191002)(55016002)(478600001)(86362001)(8936002)(316002)(26005)(9686003)(110136005)(2906002)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: UocOdaFWC+M3CdJdRPiP0JpTVJMLv4Zx/drCEV5aEpDgwQnF9YrUhMTlUhQ7WeTDzpwEsZheWBt5brMsvRXEhvwLvC0MOGqUeSsqWDJKKT6KrljBNbxm5GuuUmH2HFXSkdrEx02Q6WCXWacRqF9lfTqf7WhVm0cJGSJeOCuUuOvGmA+5fDn23eaMJuwG4xIuVRk78FcUg1glEUeFYAm1XPNjVL7XXyMYplDCd/fhrLsBODksuGBqWJEOWi4DDeNsCcVEcY/8P6PS+lCLPEg3wB34rR/qGb6fRV/INEKRZHiFZ3ETqZrxeiCb4U+m2qS9gmHlk2mIXcCrrFC/ZgHs6aF/YSilgZehZFTp95WP0WZklXDXgaYIoYDHNSBsqDh9H9KtHX3ZtWrUF5PKUFDd5jXIKrKuzf8tEYD07SWT8/svqOYEm94BqvYS4T1U7qnYfJWkeZ1RFUfLTC/HBlXLpGeFPMxSe7k7xS8c80g3zNIcwREhyd1QErJ9nLDiUu/wK6FjefBw7tVhF9um1Bud357UPovR2wcJjTafyxGYq9m376J5BEbiQYIMxMBN0NQTlkxv/Z3q72SQ4DiOqX5jrwsL9ti4vAg+V8II4Rb94pg42hIpsGs7/R+CbBoN9RBminlXmkk6H7nG9DeuL1cjtg== Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b5ec2a2-19ff-4de5-d180-08d8701db090 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 08:46:48.5511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c8dBBEXKCUFceNELZ/+IcnLVMMhCDYjfa5c/Hg68COXDEL6EMw289bl4R8R0rOv4kWn9JgyDlGxqNdVbFGI6Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2178 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, BRs, Xiao > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, October 14, 2020 10:27 AM > To: Yigit, Ferruh ; John W. Linville > ; Loftus, Ciara ; Zhang, = Qi > Z ; Shepard Siegel > ; Ed Czeck ; > John Miller ; Igor Russkikh > ; Pavel Belous ; > Steven Webster ; Matt Peters > ; Somalapuram Amaranath > ; Rasesh Mody ; Shahed > Shaikh ; Ajit Khaparde > ; Somnath Kotur > ; Chas Williams ; Min > Hu (Connor) ; Rahul Lakkireddy > ; Hemant Agrawal > ; Sachin Saxena ; > Guo, Jia ; Wang, Haiyue ; > Marcin Wojtas ; Michal Krawczyk ; > Guy Tzalik ; Evgeny Schemeilin > ; Igor Chauskin ; > Gagandeep Singh ; John Daley ; > Hyong Youb Kim ; Gaetan Rivet ; > Wang, Xiao W ; Ziyang Xuan > ; Xiaoyun Wang > ; Guoyang Zhou > ; Wei Hu (Xavier) > ; Yisen Zhuang ; > Xing, Beilei ; Wu, Jingjing ; > Yang, Qiming ; Alfredo Cardigliano > ; Xu, Rosen ; Shijith Thotton > ; Srisivasubramanian Srinivasan > ; Jakub Grajciar ; Matan > Azrad ; Shahaf Shuler ; > Viacheslav Ovsiienko ; Zyta Szpak > ; Liron Himi ; Stephen Hemminger > ; K. Y. Srinivasan ; > Haiyang Zhang ; Long Li ; > Martin Spinler ; Heinrich Kuhn > ; Tetsuya Mukawa > ; Harman Kalra ; Jerin Jacob > ; Nithin Dabilpuram ; > Kiran Kumar K ; Akhil Goyal > ; Richardson, Bruce ; > Andrew Rybchenko ; Wiles, Keith > ; Maciej Czekaj ; Maxime > Coquelin ; Xia, Chenbo > ; Wang, Zhihong ; Yong > Wang ; Thomas Monjalon > > Cc: dev@dpdk.org > Subject: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue > xstats >=20 > Queue stats are stored in 'struct rte_eth_stats' as array and array size > is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >=20 > As a result of technical board discussion, decided to remove the queue > statistics from 'struct rte_eth_stats' in the long term. >=20 > Instead PMDs should represent the queue statistics via xstats, this > gives more flexibility on the number of the queues supported. >=20 > Currently queue stats in the xstats are filled by ethdev layer, using > some basic stats, when queue stats removed from basic stats the > responsibility to fill the relevant xstats will be pushed to the PMDs. >=20 > During the switch period, temporary > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' > device flag is created. Initially all PMDs using xstats set this flag. > The PMDs implemented queue stats in the xstats should clear the flag. >=20 > When all PMDs switch to the xstats for the queue stats, queue stats > related fields from 'struct rte_eth_stats' will be removed, as well as > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be > removed. >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/net/af_packet/rte_eth_af_packet.c | 1 + > drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + > drivers/net/ark/ark_ethdev.c | 2 ++ > drivers/net/atlantic/atl_ethdev.c | 2 ++ > drivers/net/avp/avp_ethdev.c | 1 + > drivers/net/axgbe/axgbe_ethdev.c | 2 ++ > drivers/net/bnx2x/bnx2x_ethdev.c | 1 + > drivers/net/bnxt/bnxt_ethdev.c | 1 + > drivers/net/bnxt/bnxt_reps.c | 3 ++- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- > drivers/net/cxgbe/cxgbe_ethdev.c | 2 ++ > drivers/net/dpaa/dpaa_ethdev.c | 2 ++ > drivers/net/dpaa2/dpaa2_ethdev.c | 2 ++ > drivers/net/e1000/em_ethdev.c | 1 + > drivers/net/e1000/igb_ethdev.c | 2 ++ > drivers/net/ena/ena_ethdev.c | 2 ++ > drivers/net/enetc/enetc_ethdev.c | 2 ++ > drivers/net/enic/enic_ethdev.c | 1 + > drivers/net/enic/enic_vf_representor.c | 3 ++- > drivers/net/failsafe/failsafe.c | 3 ++- > drivers/net/fm10k/fm10k_ethdev.c | 1 + For fm10k, Acked-by: Xiao Wang > drivers/net/hinic/hinic_pmd_ethdev.c | 2 ++ > drivers/net/hns3/hns3_ethdev.c | 2 ++ > drivers/net/hns3/hns3_ethdev_vf.c | 2 ++