DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: haz ben <benhaz1024@gmail.com>
Cc: "Guo, Jia" <jia.guo@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
Date: Tue, 8 Dec 2020 11:05:29 +0000	[thread overview]
Message-ID: <BN8PR11MB37954D86735F918DD12CFB49F7CD0@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAGApG6_VKcPtM56SU+-iFhneMdrQEz2Ws4mqNqpm_-Ns=386bQ@mail.gmail.com>

From: haz ben <benhaz1024@gmail.com>
Sent: Tuesday, December 8, 2020 17:58
To: Wang, Haiyue <haiyue.wang@intel.com>
Cc: ban, xiaozhen <benhaz1024@gmail.com>; Guo, Jia <jia.guo@intel.com>; dev@dpdk.org
Subject: Re: [PATCH] net/e1000: fix incorrect return value if filter type not supported.

my name is ban, xiaozhen.
the commit message is "net/e1000: fix incorrect return value if filter type not supported." does additional details should be add?

http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line

1.
./devtools/checkpatches.sh -n1

### net/e1000: fix incorrect return value if filter type not supported.

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 7 lines checked

0/1 valid patch

2.

./devtools/check-git-log.sh -1
Wrong headline format:
        net/e1000: fix incorrect return value if filter type not supported.
Headline too long:
        net/e1000: fix incorrect return value if filter type not supported.
Missing 'Fixes' tag:
        net/e1000: fix incorrect return value if filter type not supported.

Invalid patch(es) found - checked 1 patch

3. Please configure your mail system with plain text, not in rich text.

Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>> 于2020年12月8日周二 下午5:04写道:
> -----Original Message-----
> From: banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com> <banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo@intel.com<mailto:jia.guo@intel.com>>; Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>>
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>; banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
>
> From: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
>
> Signed-off-by: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>

The patch looks good.

The name format should be like "Banxiao Zhen", and the commit message is empty ?

> ---
>  drivers/net/e1000/igb_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
>       default:
>               PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
>                                                       filter_type);
> +             ret = -EINVAL;
>               break;
>       }
>
> --
> 2.24.3 (Apple Git-128)

  parent reply	other threads:[~2020-12-08 11:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  8:10 banxiaozhen, benhaz1024
2020-12-08  9:04 ` Wang, Haiyue
2020-12-08  9:58   ` haz ben
2020-12-08 10:40     ` Wang, Haiyue
2020-12-08 11:05     ` Wang, Haiyue [this message]
2021-03-17  9:15 ` [dpdk-dev] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
2021-03-17 11:23   ` Wang, Haiyue
2021-03-18 11:44     ` Xiaozhen Ban
2021-03-18 15:28       ` Wang, Haiyue
2021-03-19  4:08         ` Xiaozhen Ban
2021-03-25  8:46           ` Zhang, Qi Z
2021-04-20  8:08             ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-20  9:54               ` Zhang, Qi Z
2021-04-20 14:33                 ` Luca Boccassi
  -- strict thread matches above, loose matches on Subject: below --
2020-12-08  8:02 [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported banxiaozhen, benhaz1024

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR11MB37954D86735F918DD12CFB49F7CD0@BN8PR11MB3795.namprd11.prod.outlook.com \
    --to=haiyue.wang@intel.com \
    --cc=benhaz1024@gmail.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).