From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CB31A0548; Wed, 21 Apr 2021 09:34:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A89D54199D; Wed, 21 Apr 2021 09:34:26 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 60D5E4195D for ; Wed, 21 Apr 2021 09:34:25 +0200 (CEST) IronPort-SDR: lO4v8QhfQq9//fo6BsD7aVEE5MtUrulZumLfg1Lv3wQXwK/7oF7UoFjBINhCZTkSuVTaG6FUbT I+Sufikj2f2Q== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="195210220" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="195210220" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 00:34:24 -0700 IronPort-SDR: 0WMW8CG69AfosdkvUKukbcDvTDB8Lw2OrJ242C1L7QeDvrWYcIcTUJQNyRos/9a06ypLoXgxyL HWjkYnfqWRhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="427416167" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 21 Apr 2021 00:34:23 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 00:34:23 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 00:34:23 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 21 Apr 2021 00:34:23 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 21 Apr 2021 00:34:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OUDx7ckNkpYhA9VuaCb6EMyODCSFobmbmno+lMXTYWyj0n2MD9bd6buK4HhOG5xl2hqpYg/lzLtpeqN/MWO/BAGeFfSImWBTkBlECQGmKCl1cMQTRz5oz0mx+b4nd+MFmp2JaHhQUjjUzwgBWqQXbl2mNBA42E9C8RpbC0HrzhyauKuAsH51GV7ynlS9sxo68T4aI5kYeegRiV+8HnU9aZ6j97BY6LGNNVzRgYYECX/w4Oyq+emtFz4+OQmXpp36akyXRcIl+B16RPu5qowrytkH0ewJNyzJlto6UeTu+7bCoTxVmtVsUjwOImpYxX5dsnZsRIRC6SF6gVb1ecZ7Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rgNdYuDNQ3vyhrOAf7f3KxFU/TlYaOKF3d+vK2m2TZw=; b=fyiqDDUYj4RwrgoytHoZA7HvbTU79Ua5sZcLfr8i/iEKUkphS3AiMPmee+oX7z6bq1svkrX5x7q3clCImrpCZ2OVAvM2omfB6RX26dF4iDMaAAaG3vwTQWfPshCB61G3vfrIAZoNZhJlL6lFF/yICU40B1uAu22uNjL16lFdRWvXA3y/vLbcERe5I1dJDoopRj4C4UV04kXVQBc2lAj7razupC/svo9W5iZRg2YvgSMrDt7zHz6Hkie2V1HWwW26TKstO1cV5PfX+vEatqRDZRdEz3UXWBiZfAy61cw8CCqmsGRYdmlfC/cuFqoDHgjs0GX3q/oMJEvJ7lw4nGXgFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rgNdYuDNQ3vyhrOAf7f3KxFU/TlYaOKF3d+vK2m2TZw=; b=tdgJURoYt8vAQ9PugekrJZ2CV8lkVwUViYL0EVx5ZuRQhCbz0xVDGzictSa01oofzLXxSfc8nfXpKZBc/BMhwEXQa+G47MpimmQNijoQ+yKN+8999m4D0Cn54NHZy+THzPrwaVDm5QEKvmbZ2MPQN96hc3SG0GOOEDk86VAv2WE= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN7PR11MB2530.namprd11.prod.outlook.com (2603:10b6:406:ac::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Wed, 21 Apr 2021 07:34:19 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 07:34:19 +0000 From: "Wang, Haiyue" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Guo, Jia" Thread-Topic: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success Thread-Index: AQHXNn3OioeTeCQZm0+K815k2/iGi6q+lEGg Date: Wed, 21 Apr 2021 07:34:19 +0000 Message-ID: References: <1618986145-15414-1-git-send-email-humin29@huawei.com> <1618989146-7443-1-git-send-email-humin29@huawei.com> In-Reply-To: <1618989146-7443-1-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37241cec-11f6-4f63-37b9-08d90497dfef x-ms-traffictypediagnostic: BN7PR11MB2530: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:486; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WtYU48SSAJVDHvnnzaz1rJHYVgFJye2PS5XlJFm9bw4ZIUrb8JbnIw8y961gNrRBS1+0MEDmKxQq2JZFGE+u78nn6ea8pZhk4TM14QTXBGD1bU3lYbIjTFcA85XV1Rsz+gaIG6kZVTBFwjO1ver3CwhV96aJszJfLVn8pR9xiA+umcdose1h/Rn5poGYFtGfTaXQlTcy9MEY88k3+GwoicMFLkzDmqNx0e2gFJ8/uON6DBwPUdOCOwMes/Ky+ADiPoXh/f6gqMo1fNFoqUni4T8wizVJu+HcNnWStHxcWIU+Zaq5D0c7P6Xez32XhOA3cxNkNED0r4AuMPOOyRoyF4oXre0Bzpyd8ovmIn4AzzRm3Ek2+T/Rrc+OUZ2YNk6Dx6DqusAUdPvnDtXp+bL8dTykb1xYHIutz3kVF4Wh4pAdr9xVyZjemc8dVV+lr/HNU5w5VBlEw4rIB3wIazfCHUX4n9vOGx4u4u5hEj2mCnAPbsHMiVel4toTMgRZ2JK/nfwWvUNcy7JHOwTZ+xSLZ7ZZyivqfzvPRndT0TZatJjRqLveqdj9CAN6y9jJXdChFYjc/J/llUI3IPuQVnAEIFNvhjocapvrlnAqYh+eFTI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39860400002)(136003)(366004)(396003)(346002)(2906002)(122000001)(76116006)(53546011)(38100700002)(26005)(4326008)(66946007)(9686003)(8936002)(7696005)(8676002)(6506007)(71200400001)(66476007)(83380400001)(86362001)(478600001)(66446008)(33656002)(5660300002)(64756008)(54906003)(55016002)(107886003)(66556008)(52536014)(316002)(110136005)(4744005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?gUYNpXSt2YcKzpsnTIRZN4tgIrBpj2XNBPRNW8/72xxvtdW74psPvhujg91m?= =?us-ascii?Q?YRMfZbg2smT4Hk9miFRUPJFhMgQVOVYrIfgTTyYsIo67g2bYvOuwz0k0McGy?= =?us-ascii?Q?qdCO8VGfiuGabEKiUfuEKJO4ZSraO9f9p62upmtV5PYIumYYRakvoa9oQ1NB?= =?us-ascii?Q?E1Bjo8CEcUJtYqoRcs/t7xRCR5qiFHlfTZc1hdpNrbpnS2Ghd57ygIePVy6E?= =?us-ascii?Q?86ibSWKuyJPv3R2NhPmzL9UCF1z16B1oTr5kwXvSznLserQ0VIRrb9sMeD3g?= =?us-ascii?Q?ACQQsIYpSnEijWiWA4iIkeVRrkhs0wkfHlC7ZG/IEqMLWx5QnsOsfe/9lgFe?= =?us-ascii?Q?vIMunT8irUBPZiNXjgG91YUePnwLidCbkbHFZxydz3N68hMcvAY3C6vyOMNh?= =?us-ascii?Q?Fi6LwXhYcZJX374meDea8XMWyspQju9/cXGnR0U6708nBIJw6gXEGZ5u1oSK?= =?us-ascii?Q?X1uDacThOaptAVoeGg/jArCW2euUVCSjb3NLEdD+VpYhG2dbrNhwvXiY3oac?= =?us-ascii?Q?ykQjlQsQisl4y3WeHwhFayM2OkfaJrxLnqg68Ui4nvn2OwyJ2+SwEAH9BNV9?= =?us-ascii?Q?ixqJ2URAIVpMWKXGNjpV6vOcDOPnIA/yRb+qA8s7ZoN/gFWTMGzbPdgoFg/O?= =?us-ascii?Q?QliiDnXT8JOw52BivX5zy3SVF9IStY5ZXZl9sbXoYGt6P47Aq3p0N30vidOR?= =?us-ascii?Q?hr6x2Othy4LgcFZ5bW0pbEuy++Oan8ctxYKrJAydHS5k33GYld9sJCgC8Ap3?= =?us-ascii?Q?ITqciOaBSptSh+ly3dlpQuRjlxwFtE/JInBToJnttZjhCjMgZ8QQMP/khX2T?= =?us-ascii?Q?gLbOxK9MxJe0CkD5CKb5MKkAcb9HSyqm8K+IZN731pwDPcqRof5RAp3U8TeM?= =?us-ascii?Q?V+37AeJJ0Ls7xmpWXiqjB4PV3MzKgNXu50pG9AiQjhLGnkt7omcb1XdUekTE?= =?us-ascii?Q?gCuZa+0eS5klDOeYFDTkG3cqVr6D/xazVy946fGoYulyxiP97Jr/YUM93/aM?= =?us-ascii?Q?d6rd6x3LLdXYSsGu/4ZdS+az47lkHQ5m/Gh558cgQbvhp32gWiApVDu2PiFu?= =?us-ascii?Q?mGGUwY/jvt9yvqKb+u/chwJeTVGJ8gHb5mSRMMFBn5YyIRabycKFgHsHI5Zh?= =?us-ascii?Q?9Ym18igj4vvG5i3ucqoIJBJ+09pNXhDO/kHQYUhY0Ys2DN48g9M1GwHHYLKG?= =?us-ascii?Q?rrq4HslsGt4IvEiVVQNcXroV5ADLlklOvP3ZPEPpmlaiyjpvZA0yIkvxaDVc?= =?us-ascii?Q?6TtYy0ir2N7klSk7lHq92kYc7eOA1E/8EAu8i0FGJrG+A1Q9849tXgeyqWqk?= =?us-ascii?Q?cvm4lk3flIh3tA5QZijmMQRy?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37241cec-11f6-4f63-37b9-08d90497dfef X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 07:34:19.1506 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l+MT9KBfxoC0ibje1ZvsLcdrFJuBmKRGIev6gxU22T5dh/5wGiT5c6aIGH3GII4DqzWbjy4Dvyx+beJik1fCYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2530 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 15:12 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia ;= Wang, Haiyue > > Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success >=20 > From: Chengwen Feng >=20 > This patch fixes e1000_write_nvm_srwr() alwayes return success. >=20 As I said in v1: "This commit message seems not so correct, it should be like: This fixes the timed out for shadow RAM write EEWR can't be detected." What do you think ? > Fixes: 5a32a257f957 ("e1000: more NICs in base driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > v2: > * change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'. > --- > -- > 2.7.4