From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A2CFA04BE; Mon, 7 Sep 2020 04:14:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 753201C0C9; Mon, 7 Sep 2020 04:14:20 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4EB4E29AC for ; Mon, 7 Sep 2020 04:14:18 +0200 (CEST) IronPort-SDR: yFPQKzSFnGiyaPg3gqAiUHceh215+Dv8CfR2LFRlNOcrr2NCGZ5Gu6aiguP5oQKyFKcGr32Nw+ Ii6JwQFILDsw== X-IronPort-AV: E=McAfee;i="6000,8403,9736"; a="242759385" X-IronPort-AV: E=Sophos;i="5.76,400,1592895600"; d="scan'208";a="242759385" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2020 19:14:16 -0700 IronPort-SDR: gewjDIkX7IQwSQKVxTaM+qfozF+49FMFiD+791kwa2k7ip7BmjOycMYEB7S9OEVZ3Gw5S3/h2r D2jiRX4kIz2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,400,1592895600"; d="scan'208";a="377070527" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 06 Sep 2020 19:14:17 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 6 Sep 2020 19:14:16 -0700 Received: from orsmsx102.amr.corp.intel.com (10.22.225.129) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 6 Sep 2020 19:14:16 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 6 Sep 2020 19:14:16 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 6 Sep 2020 19:14:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=diA4cTV89hwglm4ieb8kxl2suK5WT0iLfAvtZiSI50Z03OOQBKmnZCTs+MiHIuG2wCktPuHhvmzBQdU+4G+MtK9YeX1Faa0gXsNB1Rectw8z8qW1B12JaIyEDEV0eoZEZy+nafvDelDSiLz1lerOV7NWMOfAU3Atp2EDd8Li1cPJTru3k5l9MTaum4OyZPfrp9dOc0Ogty25XnyGz+BH2YcWlc4Q+FXHoqX1Zl7FwM4LL3mOg7RVmUEY3pW7hKoSscNyb/sglLm12guPAbb4zsTQK40C/qqmnXEwHywsUEYgosgfo2mzVleqe1tKQsWkD1aS6QRqtJoglSm/A440wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=66APMmb9rdKBUTJgQlaSI3ghPtYhXMrMa4EVMAxjTZc=; b=c62uM63lwZzmjpb4br9aPs9LRi9VzgsMn8wBvAIu6yL45MRbq07n0jZ8odoy9m0OIeIEtCzFhwKW90ROkR+0Ickx2NjGzK+Du2A73AGkUaEbNkEt5PqJ4libHeDWG4eIw9li2gASE51nCCIUb1xNkW5eJrPxb7BemF7lri2GGblVavOdffxZsNg2uql4auy+wP47//2Wg1s8kdBQgh0kAddrumCDR6LacGvnLyZN1A7Vw/6xZuWjiSSEQTZzZrorQHP/tUaa93LrX/ddugeChXrYT0TC1ziDkI9Pe0vDRXKivXbWuRQG1uEQplhlsiFwyQs6Y03wwGfu2dW2hlaDDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=66APMmb9rdKBUTJgQlaSI3ghPtYhXMrMa4EVMAxjTZc=; b=l3ofpaaXiu1huLe90rRcfGW/l+z2OW8n7dDWrOUHfYTe86MZ25L4dVtk4W7pMqDuL/HbKv4DuzLXrK1pMyxv/JcgPCgbro6tiqEH+atzNFNf4kJgjV3KzyzJtySXX5t+Zln9SKRZ0rqvQWHdECKakmsc0SRCfhxkZqOGvGVprN8= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1297.namprd11.prod.outlook.com (2603:10b6:404:4a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Mon, 7 Sep 2020 02:14:13 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dd0f:7f49:bc5f:2fde]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dd0f:7f49:bc5f:2fde%5]) with mapi id 15.20.3348.019; Mon, 7 Sep 2020 02:14:13 +0000 From: "Wang, Haiyue" To: Stephen Hemminger CC: "dev@dpdk.org" , "Yigit, Ferruh" , Olivier Matz Thread-Topic: [PATCH v2] net: adjust the header length parse size Thread-Index: AQHWgzMcv5KBZmlRaUGVvCfpXqA1i6laRJaAgAIsYmA= Date: Mon, 7 Sep 2020 02:14:12 +0000 Message-ID: References: <20200904054020.77648-1-haiyue.wang@intel.com> <20200905030646.374157-1-haiyue.wang@intel.com> <20200905095618.0844b4b6@hermes.lan> In-Reply-To: <20200905095618.0844b4b6@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ad3dde2-8db0-4578-d77d-08d852d3b6b8 x-ms-traffictypediagnostic: BN6PR11MB1297: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j7qy9+EPwI4ijvtAOQbV/87mf6B8s7V3hdhe91D1suEK1IwAD1U3imxURayEQldZtVk1dNNl5Q0PLAjeFTq0kyWMj8CkBYYC9vmUueoluckAhDGGSgZoRm2vvVCV3VSlx/fY22cBnPCfT3S1LKppYgD7za2vvv+29a10l9p2Xk9ba4u72RDuWvBmetMJ7Ew6Xp4SpPX0pn78pIKwzUqDsMmgMvGeFQHHyE8CvFP9yaoPh+M0A4cp9UVDy+QrpQSq37T5WQlTP2jhf5CULVE59YspeJ0zDm3iYpBX7SxQby5SWwPbVrsR86iHKXxfp7Vd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(366004)(39860400002)(396003)(376002)(66476007)(66946007)(76116006)(5660300002)(66556008)(64756008)(66446008)(71200400001)(4326008)(52536014)(26005)(83380400001)(55016002)(186003)(8936002)(6916009)(478600001)(8676002)(6506007)(53546011)(7696005)(2906002)(86362001)(9686003)(316002)(54906003)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: gA3p/u2WZLHkczhdw1yc7DOxE3LjO+1PtqDPQcNyck0Ni6/0kGToJ3wusBjHw2ftDWqQvbGuYIRlw8IiX1dIgND7ZLOab2/CMWFWI5o0spk7NkViaSu3jixqYYf6R6v3dSwVihkOa/eNvRClLityP+9yMCYU82vm7Ep+9In3h0jvTbduQrmQQPCZDl2TJAO9rRc9KsksXt8u/098EC8ZnjV5aOWZfIdsCXNKRaRV2jERkFdm1gdjSyXGRZ/CWfIBMck++x/2K0C5ahFNYXj2ZcQxdVbETbct6iPPTjupLGCrC74lhyAluGbtMTwagdXQAk7F8do1JZpo5+va44rr32xTd10F5ncNBf6sy8m76PsKtzUCiMAiTYB95E2nCAXTFuXu5QRh9uIddD2BecF9J4xgmjbETM6qY2M34horhxEi4HHXj7Ng+fUemI21zS1Gjlr4fCtW6Qssc8YD12/lhwnlxD1JxLFu6OB5QoLgUMYiTr8AAxN7U/uz/ToipkuiSAcTX9e7V/1sw+upMLzTOd4WnbNQ/q4RbzilxiZzWOrX7246mMUa9eR9k8ll6bEM+TlmQRw3ypqHE3s1nExBpfUuW9DNSZm+yJmJLhsQ3Eiyy7NI5cx7NW/+08G85i4m6ggMGFTxBSo0tLzb5u41sA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ad3dde2-8db0-4578-d77d-08d852d3b6b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2020 02:14:12.8770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yI1kuJTLmsBxtf6+RGRTFqgSgKiNSSkG1fTRftyEFYCQWpAkJHIcJSMz2kkAyIykvK9BM1zw1G3d1We87QnE0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1297 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net: adjust the header length parse size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: Hi Stephen, > -----Original Message----- > From: Stephen Hemminger > Sent: Sunday, September 6, 2020 00:56 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yigit, Ferruh ; Olivier Matz > Subject: Re: [PATCH v2] net: adjust the header length parse size >=20 > On Sat, 5 Sep 2020 11:06:46 +0800 > Haiyue Wang wrote: >=20 > > Align to the rte_mbuf's design about Tx header length data size for the > > header length parse result. > > struct { > > uint64_t l2_len:7; /* 88: 0 8 */ > > uint64_t l3_len:9; /* 88: 7 8 */ > > uint64_t l4_len:8; /* 88:16 8 */ > > uint64_t tso_segsz:16; /* 88:24 8 */ > > uint64_t outer_l3_len:9; /* 88:40 8 */ > > uint64_t outer_l2_len:7; /* 88:49 8 */ > > }; > > > > Now the IPv6 can support bigger extension header. > > > > The below is the structure hole analysis result: > > > > Before: > > struct rte_net_hdr_lens { > > uint8_t l2_len; /* 0 1= */ > > uint8_t l3_len; /* 1 1= */ > > uint8_t l4_len; /* 2 1= */ > > uint8_t tunnel_len; /* 3 1= */ > > uint8_t inner_l2_len; /* 4 1= */ > > uint8_t inner_l3_len; /* 5 1= */ > > uint8_t inner_l4_len; /* 6 1= */ > > > > /* size: 7, cachelines: 1, members: 7 */ > > /* last cacheline: 7 bytes */ > > }; > > > > Now: > > struct rte_net_hdr_lens { > > uint64_t l2_len:7; /* 0: 0 8= */ > > uint64_t l3_len:9; /* 0: 7 8= */ > > uint64_t l4_len:8; /* 0:16 8= */ > > uint64_t tunnel_len:8; /* 0:24 8= */ > > uint64_t inner_l2_len:7; /* 0:32 8= */ > > uint64_t inner_l3_len:9; /* 0:39 8= */ > > uint64_t inner_l4_len:8; /* 0:48 8= */ > > > > /* size: 8, cachelines: 1, members: 7 */ > > /* bit_padding: 8 bits */ > > /* last cacheline: 8 bytes */ > > }; > > > > Signed-off-by: Haiyue Wang >=20 > Bitfields are slow to access, compiler has to do mask/shift operations. Yes, you are right, I use rdtsc to trace the rte_net_get_ptype run clock about 100000 times, bitfields is near 40, but original is about 30. > And there is no requirement that structure be the same size. >=20 > There is no requirement that fields be ordered the same as > the protocol header. Also tunnel length might get big. > Why not: >=20 > struct rte_net_hdr_lens { > uint8_t l2_len; > uint8_t inner_l2_len; > uint16_t l3_len; > uint16_t inner_l3_len; > uint16_t tunnel_len; > uint8_t l4_len; > uint8_t inner_l4_len; > }; >=20 Thanks for your comment, this is better, and in v3. ;-) The run clock is ne= arly the same as original type.