From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C72EA04AC; Mon, 31 Aug 2020 16:30:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E4491C07D; Mon, 31 Aug 2020 16:30:00 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 65503255 for <dev@dpdk.org>; Mon, 31 Aug 2020 16:29:58 +0200 (CEST) IronPort-SDR: tQHq1kD12yg+mSiAswZlL40i9ECLQpQ1n7SCl7Eba+B9sY8zn8B8225ug4u5+vz4l56hCye1lA w80hlvf/1GVA== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="156980185" X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="156980185" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 07:29:57 -0700 IronPort-SDR: cD1en2pOUWR+ZtyLax0o6Vj6m4MebLympllzE5NSb4Mfhpf/E+oykSH/Fuj5197Yole2OCP4rr mvV+FwYxnclw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="281661312" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 31 Aug 2020 07:29:56 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 31 Aug 2020 07:27:15 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 31 Aug 2020 07:27:15 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 31 Aug 2020 07:27:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N0tM22uvaora+TDl0K8e9QHNXbWodEyTT95YvtTf8SJDtC8HlwYQCwEMAdB3rME5Df0GyceOxLDmaxSfdtJoDLJuQ6ZYXT16BQl81vl6NK45uJ4krp7H9qL/axxuGM9oziaraDHqnTpguqLcPuVzNeWSp9qSQ0qTiO9SfnxuQzqO5jICpLFewgfz6P4oHRl9mRZsLTpFTp0n0CSOyBlqCnoH5NFtgjA1AAV9XgD+fqqXcVA1HdZIApiDx1E9gf/gAEL0RjEc4CZlRP7LbxxO1xdR56fj8lvkCbn8Ond+BUfpLFcFxajhrcDKtmxZgvSc4LkUsGLsWhYz9e26U5O09w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cOykpzvFcESDHL1Ultt1O5JSU3i6NsRZi+5Rh2zX5Yk=; b=eYBP11Hoq8NXQSKxLQJaRUAtxCst7CcLQgHbiK+v3fD2dRXRORNjNlzb6g32nKEZIo0WYVnFno1M+oDI4jJPfxhfk601mk4XAUW38+cl/vNwEfSVr+L3xcHgrYQqMsi1P7IsQVhmLwif8uRFNWYUUBPmfsbtMaaYP37zZugAZx/W0aYVKBrRD/Aey4Ii7Pq8DdZQrcMPCxgg4KdtMlGC/Lf4TcevYHLHQROMQ/g699EgU2sq2toLhQt03ObZa/PP02pkd70H4AQUW6P0SMEo+AglIgl3GYBViGVGVczPthKzEVMydLHoaVaIYfzl6isnyUxDhBTIzG6Fcijv1dKGRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cOykpzvFcESDHL1Ultt1O5JSU3i6NsRZi+5Rh2zX5Yk=; b=RFrhn7vgN6iimbALxTn2/y/rq/R8f1v+f4sHC9V8h8vWnk9NkqUrIGUGDj8XfqYmTGuCWNM0V6PVpNXwg8JJquk6osYO7zk15/aqxgrWo4eX3EhU1W8Eu8WIGUBQbG4ZsQ9QoDb850LR0KHbmc4L0+rVDlnKXNQB4zVsMv+tWag= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB0034.namprd11.prod.outlook.com (2603:10b6:405:6b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Mon, 31 Aug 2020 14:27:10 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dd0f:7f49:bc5f:2fde]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dd0f:7f49:bc5f:2fde%5]) with mapi id 15.20.3326.025; Mon, 31 Aug 2020 14:27:10 +0000 From: "Wang, Haiyue" <haiyue.wang@intel.com> To: Stephen Hemminger <stephen@networkplumber.org>, "Guo, Jia" <jia.guo@intel.com> CC: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>, "Yang, Qiming" <qiming.yang@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "Zhao1, Wei" <wei.zhao1@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin" <helin.zhang@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "barbette@kth.se" <barbette@kth.se> Thread-Topic: [dpdk-dev] [PATCH v2 0/5] maximize vector rx burst for PMDs Thread-Index: AQHWfG8MrFMXCmY4L0OnyqrBFwJRWalMxLpQgABOYoCAAOhCAIAETgWQ Date: Mon, 31 Aug 2020 14:27:09 +0000 Message-ID: <BN8PR11MB37956731F9B066CB3C6777C5F7510@BN8PR11MB3795.namprd11.prod.outlook.com> References: <20200827101008.76906-1-jia.guo@intel.com> <98CBD80474FA8B44BF855DF32C47DC35C6125C@smartserver.smartshare.dk> <BN8PR11MB37953723252F126F73207B6AF7520@BN8PR11MB3795.namprd11.prod.outlook.com> <77c760bb-7034-72b6-d4ba-c970764b7f3d@intel.com> <20200828133050.74e38bf3@hermes.lan> In-Reply-To: <20200828133050.74e38bf3@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7032bd5b-50d8-4d0b-befa-08d84db9f26f x-ms-traffictypediagnostic: BN6PR11MB0034: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BN6PR11MB0034C91AFB137A4F991464E2F7510@BN6PR11MB0034.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v+2VvTwCMPgAopNj4rh8ZwM6NO8fBQRJx4NVgpvyLdne3HadvZVDxGfKRO82/5Hd7MKGaCD+CadBiVKrM3cwk5xFvR8Lz2ofCnIjodLpliNIB0nfFJwsg9KN4YaoVmhNGgDqMz66zzE59U6lVHqBaqO67MAA/7YQKirC8UUToF8ktA9JxyAtlJZnkEgBOWK5c88wJWbAiUVhXc5iEEI9+3TpTCz/stbShgpLub55tC692UQSEtbyPC9G7GOgSuVTZ6D6F0pdBmJRqp6+NFqUJDTrv3In7lJJKhLr/lPKVvD1Klds6eD/3PpFTzw1Sv2yQppfLpF938GEUsmi+NIoeYkAcZdyalSzz9ms8F4D0l4SFz9HkU/ZJiZVVB00rw2h x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(136003)(346002)(396003)(376002)(7696005)(55016002)(6636002)(8676002)(8936002)(478600001)(26005)(4326008)(9686003)(53546011)(186003)(6506007)(2906002)(110136005)(52536014)(71200400001)(54906003)(33656002)(83380400001)(66574015)(76116006)(86362001)(66946007)(5660300002)(66476007)(66446008)(64756008)(316002)(66556008)(14963001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: v4803xQK13ernC3UlBpK+rk9LIHt29XH/UMvEn9guoZDwq+0/qRrR/7Pi2j5Y0SN8vOY4C7aPalpNyLmLoNNgO1oVgFYO9nicVKXHMOhV94BjL8Jse4VLv7Hvf1VhBfNrna+EsFVsfQR38slCLWr+EU3aHEiwYZ0leYwF2vLpOvNYIpMaChsCWEyjX2XqR3cJr2LT1EqjOlvEMm+QQ/2Vm99oXqoj2C27cq6Zna1aBOyrqeAX6OQMlzsr5vLZhzSr9nz2rueCIQPbD/rjd4W2ogiILapdmV8PV9DH9Jk4luehZtptYFkRaiFeCbE+zqTL2DHLTniDECp6+DxebjfL9uGIWmnWND4Q+1pO+pyMqSlXXSwiRUGO5qEp7gKyNvpJrhJRQA0qReX0Kzi9W4wx0gUl1l7emPJpQE3EffX3oJVvepfTjPJeWXwlXulKuEocawQREf09I1Wx7MBWoQHnTlS2BEXZQU994dzLXHY+19EweBtEW8DllfzOjr7zHd/sbZddiTf+DmD231yK1pLe0+0WqWagzoqePAVmg/ZU7wsbZySZBP3FcU07rBj5LVEHKaSTG61ySAw3mslb5BV4cfB3OY5aTY8Xyiair7hOna16bMcJpjauJcg0xhgIP1DT3mkE7Z1wGSj01enCnIWyg== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7032bd5b-50d8-4d0b-befa-08d84db9f26f X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2020 14:27:09.6727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: roWwcE89zk9saLrCeRhqDN5DYUItj5usKljNWE15pLpfLXGBFoNwUSPwK6x/KoCVnNWB4GGYCf2SaXLd2UxRlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0034 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/5] maximize vector rx burst for PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Stephen Hemminger <stephen@networkplumber.org> > Sent: Saturday, August 29, 2020 04:31 > To: Guo, Jia <jia.guo@intel.com> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; Morten Br=F8rup <mb@smartshares= ystems.com>; Yang, Qiming > <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhao1, Wei= <wei.zhao1@intel.com>; Zhang, > Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Richar= dson, Bruce > <bruce.richardson@intel.com>; dev@dpdk.org; Zhang, Helin <helin.zhang@int= el.com>; Yigit, Ferruh > <ferruh.yigit@intel.com>; barbette@kth.se > Subject: Re: [dpdk-dev] [PATCH v2 0/5] maximize vector rx burst for PMDs >=20 > On Fri, 28 Aug 2020 14:39:33 +0800 > Jeff Guo <jia.guo@intel.com> wrote: >=20 > > >> I am not sure about this, but if I read it correctly, calling rte_et= h_rx_burst() with nb_pkts =3D > 33 > > >> (not 32) would only return 32 packets, even if more packets are avai= lable. (I assume that > > >> RTE_I40E_DESCS_PER_LOOP is 32.) In this case, I guess that you need = to read the remaining of the > > >> requested packets using the non-vector function in order to support = any nb_pkts value. > > >> > > > This is vector instruction handling design requirement, like for avx2= : #define > ICE_DESCS_PER_LOOP_AVX 8, > > > if deep into the real loop handling, you will get the point why doing= RTE_ALIGN_FLOOR. ;-) > > > > > > _ice_recv_raw_pkts_vec_avx2: > > > for (i =3D 0, received =3D 0; i < nb_pkts; i +=3D ICE_DESCS_PER_LOOP_= AVX, rxdp +=3D ICE_DESCS_PER_LOOP_AVX) > > > > > > Maybe it is worth to tell PMD to stop using vector by calling rte_eth= _rx_queue_setup with the > application > > > burst size it wants. >=20 > There is no need for yet another nerd knob in DPDK. >=20 > The driver must accept any burst size > 0. > If it wants to optimize for certain multiples, then it can do so in its b= urst handler. > Like any optimized checksum calculator does. I think if people care about performance, then PMDs have done every possibl= e methods like the burst size, then no need to invent their burst handers. ;-) At least, burst size is an optimize hit for performance.=20