From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46698A04DC; Mon, 26 Oct 2020 12:41:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8065A2BAA; Mon, 26 Oct 2020 12:41:30 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C6EBF2B9E for ; Mon, 26 Oct 2020 12:41:27 +0100 (CET) IronPort-SDR: btJQYAf//dIytF1u+uFGQ0DtyaJonhmmq7rIxrDQuxCIGukA457vgmLOGrvpAg8+MYbbpcsjLL a45pJU6/HhUw== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="168032951" X-IronPort-AV: E=Sophos;i="5.77,419,1596524400"; d="scan'208";a="168032951" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 04:41:25 -0700 IronPort-SDR: +FdCtFcHVnmYPDsLDYdV3oN5TZ0X174d0JplKW2+Zi+CmSW3DtnJPrRJjcQdoh+UfhEUsXa8Bq u2Q+v7jody2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,419,1596524400"; d="scan'208";a="360342108" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 26 Oct 2020 04:41:25 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 04:41:25 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 04:41:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 26 Oct 2020 04:41:24 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 26 Oct 2020 04:41:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CCwXelbK59WZEfuTWHuQI+X5qr+muIj4eNTcuje/BXHaQno5eH8TWe7A0eYzZqcnnU9yv6HIpyoig2yMY+o0HLOq+x1anqsrKhrppFQ27zHOaJUfxenPByT24657KbGBIDXoorvNKhqV6XYhy8AbK13oAqxBiD0Dz2JgNaExusvnZm7BLrOu5vQCgGeHpoCWZu763+vhYr5DpT8uP6LWUrmK78Dcosg1ZnpC05kBDIyouEnfeapuyjyyJ6XvpQDa3Ny40XGF0LTsRUVUjLVHt7wAjCwk26/9jQ6L698/7zh79KmWU78ezBFfrQKfmEHACEkoPEasQLRhHItoFLIlhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1pWq0WwMsWl7JBKi5YTj/Q0447JgbhiZBCTdcJO69/Q=; b=WO93hGQo4OE4WiIhnQQncxqqFk/lsAoFIZ1AEYGEj4lQPtZ44rBR4eAtOo8k74zYD8iHdqKvij7L0nm6Vjemm/Pjfl5vW25woLe+iLVtfiiygS9+ScJLHaZb+NbgKlLAs6qJAIP19ow6ZBDVOfrwUjIiTolzsSIrG9UC3S67Lyr019ZCVt2v/nw7HxwzLW6+EbLH1PhcJrX8XOrRilaqcbxzDk2Fu+96eiWaBgPuaBtI1nYtRU1f4+5QWHkq6ComF1VHFvWGsZm4EFRSODKWzoPCBJBMLB0Yh5US1aBPhIAlVa54IKfg6vEEKSqTs3p+wRINPiz2muvWllenGV504g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1pWq0WwMsWl7JBKi5YTj/Q0447JgbhiZBCTdcJO69/Q=; b=oOTEw48k8zt/rFAjxx3baK5/Dmh+VUJnQQBRzcHo6FHw1Ksy3I3Mhm2ijDIybyrpwDP3zgN4qGU/DW0tf/ejZ9TjyHts+K1uYbzuUlueLZoP5J4DtnUBu2XamXJYo9VRj9dtkEZUVe1lUHhKGZ1jAOmy6OgTZBZl7qgd1BkvvIk= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB4115.namprd11.prod.outlook.com (2603:10b6:405:80::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Mon, 26 Oct 2020 11:41:19 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3477.029; Mon, 26 Oct 2020 11:41:19 +0000 From: "Wang, Haiyue" To: Olivier Matz , "Yigit, Ferruh" CC: "Guo, Jia" , "Wu, Jingjing" , "Zhang, Qi Z" , "Xing, Beilei" , "dev@dpdk.org" , "Richardson, Bruce" Thread-Topic: [PATCH v8] net/iavf: support flex desc metadata extraction Thread-Index: AQHWoToyEnqrY4lfj0qM4sB+g4BgOqmXCXiAgBKrQICAACClgA== Date: Mon, 26 Oct 2020 11:41:19 +0000 Message-ID: References: <20200909025415.6185-1-jia.guo@intel.com> <20201013081734.47507-1-jia.guo@intel.com> <0257ccb2-88eb-a49a-77f9-9e611f3c266a@intel.com> <20201026093715.GJ1898@platinum> In-Reply-To: <20201026093715.GJ1898@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.209] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4f3bebef-52fe-4fd9-7fac-08d879a40e6e x-ms-traffictypediagnostic: BN6PR11MB4115: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N6fDx6Ybfvcvj6fCgqBgwt3KY+Kj/zLrSxB5J20ZTwfW4oUhAQTycufuBvuYnYczscrJ0B/1tywzqIPa0A7AyHrm9ur4xu20Lqx+i0yz6NF2PpK+JNqBR8K2e3kXS79QyPmzS+EEpyf4HRPkaqhiNQvGtdFXXdoU5cWEAFoHHOqnZ5H52qy+/9Gp/PFpvcEGTdqC9mxiE+NgjFJdGqO8Ex9Hge7twDtmEeTMuuL64OLQPlE2K5o6vBozrkp6Xuw8ZqrHyRrq7sYDrX9HYY2NSHv/ehb7f+tUBBWdNGAH5io9JVntpEnpjgrbMlt33UksogUPMWWL+P+qRi7pxwSL/X4MCFjxgHwX8hWRak7FOGPO5+LnAOjda1DuR/qXDlJavnqeXFQHPIdOjCEfc1KgPmZaC17SvfNlOA+/F60ho+jh4sOdi4p7zpfxFfv0G9Z4+U6uiefEM0FDHtwvg2QNNw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(39860400002)(396003)(136003)(71200400001)(6506007)(66556008)(110136005)(186003)(54906003)(53546011)(66476007)(6636002)(26005)(66946007)(86362001)(7696005)(55016002)(64756008)(5660300002)(66446008)(52536014)(19627235002)(4326008)(9686003)(107886003)(2906002)(478600001)(76116006)(316002)(8676002)(966005)(8936002)(83380400001)(33656002)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: EDiy43uRYJAfo+kLUdWppt3m1UplQKaPPShmGbeCJFJIYTa+DGJGRs+0gWJeZgCAHO3rkAwiU1OROrCZnFAtDznwbDO/9FDwCXdmi/I71DcjtXwfGv8hMunjTHDu9NykoO6Mftn+Y7dYzhfjRPPUJHhdq5ZkFITr8b3mcVXrSmnzwyJW2pOXHtIbbaiMr9oeKbYf7G7h+Vwd3ICtdp1ufYhZXMNkXw5EY7qelAkJa2iFVjhna8itcthha8W9RUkBzimpfA5TTpJjewL23VwsBJPLK8wSGMzS55sTJ9yXhKzkv2R90UrEAiPRNEsS6oRQAer5Ulc7Np8JdwgWhkREkYrZHAiyVACk/PoNHW5CtDZmpGDFHs0ZGlY287S4iKQ+wBdyG3yAs7azU8hg5pg/76VX9x/XNaxZ5rLjOU8xvZSM18LAPIwtqj/eSnuFnUCXERVMdxGCSF44YpOdl2uDnbJ7OEhuM1WuRNowK/X/YL8rsDtixcqJc88/xe9tdSbZdaMgr42ykCyXURLVsLwkuWUw7wNbcPsocmoGe1OGOXQjpyk8/xBCDwiAzaJ3VVC+dDQDui6cvOTIrwAL+8iMt4pFoE78RjEtYcfg2O3gZIgSn8Lba0xiZBaFteHUXXcHBPSniaWnWBxqRhZazK2cMQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f3bebef-52fe-4fd9-7fac-08d879a40e6e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2020 11:41:19.5176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cwFWNmM7zF5T0o5F7cekmkRLVBt67tUYJoeu5QBLLFRrF55fuvolzqWihGT5F7SWOmm0EXDVWAVHLmuAr2B1MQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4115 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v8] net/iavf: support flex desc metadata extraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier, > -----Original Message----- > From: Olivier Matz > Sent: Monday, October 26, 2020 17:37 > To: Yigit, Ferruh > Cc: Guo, Jia ; Wu, Jingjing ; Z= hang, Qi Z > ; Xing, Beilei ; dev@dpdk.or= g; Wang, Haiyue > ; Richardson, Bruce > Subject: Re: [PATCH v8] net/iavf: support flex desc metadata extraction >=20 > Hi, >=20 > On Wed, Oct 14, 2020 at 01:31:39PM +0100, Ferruh Yigit wrote: > > On 10/13/2020 9:17 AM, Jeff Guo wrote: > > > Enable metadata extraction for flexible descriptors in AVF, that woul= d > > > allow network function directly get metadata without additional parsi= ng > > > which would reduce the CPU cost for VFs. The enabling metadata > > > extractions involve the metadata of VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS > > > flexible descriptors, and the VF could negotiate the capability of > > > the flexible descriptor with PF and correspondingly configure the > > > specific offload at receiving queues. > > > > > > Signed-off-by: Jeff Guo > > > Acked-by: Haiyue Wang >=20 > [...] >=20 > > > +EXPERIMENTAL { > > > + global: > > > + > > > + # added in 20.11 > > > + rte_net_iavf_dynfield_proto_xtr_metadata_offs; > > > + rte_net_iavf_dynflag_proto_xtr_vlan_mask; > > > + rte_net_iavf_dynflag_proto_xtr_ipv4_mask; > > > + rte_net_iavf_dynflag_proto_xtr_ipv6_mask; > > > + rte_net_iavf_dynflag_proto_xtr_ipv6_flow_mask; > > > + rte_net_iavf_dynflag_proto_xtr_tcp_mask; > > > + rte_net_iavf_dynflag_proto_xtr_ip_offset_mask; > > > > As a namespace previously "rte_pmd_xxx" was used for PMD specific APIs,= can > > you please switch to that? > > 'rte_net_' is used by the 'librte_net' library. > > > > Above list is the dynfield values, what is the correct usage for dynfie= lds, > > 1- Put dynfileds names in to the header, and application does a lookup > > ('rte_mbuf_dynfield_lookup()') to get the dynfield values. > > or > > 2- Expose dynfield values to be accessed directly from application, as = done above. > > > > @Oliver, can you please support. > > > > I can see (1) has advantage of portability if more than one PMD support= s > > same dynfield names, but that sees not a case for above ones. >=20 > If I understand the question correctly, this is the same that was > discussed here: >=20 > http://inbox.dpdk.org/dev/20191030165626.w3flq5wdpitpsv2v@platinum/ >=20 > To me, exporting the variables containing the dynfield offsets is easier > to use: we don't need to have additional private variables to store them > in each API users (usually one static variable per file, which can be > heavy). No issue for one PMD, but if two PMDs share the same dynfields, the applica= tion has to use two namespace variables to access the same value, like: if (mb->ol_flags & PMD_A_DYNFIELD_B_MASK) else if (mb->ol_flags & PMD_B_DYNFIELD_B_MASK) This make the application code a little duplicated. ;-) >=20 > Olivier