From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA99CA0C4B; Mon, 13 Sep 2021 07:46:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DF9540151; Mon, 13 Sep 2021 07:46:47 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id ACFC94014F; Mon, 13 Sep 2021 07:46:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="208682204" X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="208682204" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2021 22:46:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="608659405" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 12 Sep 2021 22:46:43 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 12 Sep 2021 22:46:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 12 Sep 2021 22:46:43 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sun, 12 Sep 2021 22:46:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4wMEyOf2MkO8hgtRs7cZU95I/1zTcqgNVz0fDQbns+kGxaDguxz2eoIsZJtVbU/rkBNZ/AKeEZkQW+GgTBJ4hkRPDGSzZscQGsGONu8yFKhLPotkX1B+xvAvIRQ7eEzUzMqV38wHyJ7+fmAHSAKiu2XRtAhKYJkPbUNcveR92otQEcofrAdA7fevfO4P/cIZc9FFGHvcAS2Hp9xUb4URAlFY1D4FI539ZSq5TBXLoBmxuW5gktO5YrTmh3swEu7iOvtdRJktiaWSOQpN/qonB/CIhxj7SO2L8kS5IIXAe4nKHDtVAsSH4sjcRxD/TjRe+siWfLPPxr9yVK5uoCjew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=akIidN81dOJxzGcFdIQWp5x8CbfAPho7520k4l/ZrXQ=; b=YrunOteanVYgmfgRDCF5HVY2JY38ZgK8yZy5fGt4HDM5BUABiLodCzKQDJv0ITHVuF6LfKw0WG/nAmmF92AkIL/Vhwe/52L0D0kWgr6mY00IDuIr2A0vg//6WH4ngiC+1PsJd+a3sHVRX4BkL1ZiJrEkZfGhqlTW1aYm4FB+gohMhFcryOdwS1PelRO4hna1X9zIeElHAvauTJ4Lv/Ya7rzmyx8O1TkuTsrZu2JerSHKyQz8r+qOcANdAIRxWVxZh6uSj4EkvawJLxIfgNg3MTROIem0ai2q7K41MfQisI3GLrfZs2tix4f7KEJmVmgSDyJdd/d1vA3brHaropy4Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=akIidN81dOJxzGcFdIQWp5x8CbfAPho7520k4l/ZrXQ=; b=hBMB8WPpIBHc1y3ZC2HArgVCvWdNti1S+lt1yXB8Rv5n2u0dTxBYA3hEqQHtYw5cCC44mzc7SsEROpcIw1h0l6f+zleds3E+Iy5FOr05gD22/sK9CKApQgGIujkjbjDPgklAAlf7KhoZ1mZjZ2kLOZvYYVhoKjGK7+U+jBV2fOw= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1410.namprd11.prod.outlook.com (2603:10b6:404:4a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.18; Mon, 13 Sep 2021 05:46:41 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7%3]) with mapi id 15.20.4500.018; Mon, 13 Sep 2021 05:46:40 +0000 From: "Wang, Haiyue" To: "Yu, DapengX" , "Yang, Qiming" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] net/ice: fix representor port segmentation fault Thread-Index: AQHXo4xQ1B3OwR2EC0iI4RNRM5lZj6uhfjSA Date: Mon, 13 Sep 2021 05:46:40 +0000 Message-ID: References: <20210903054140.1530911-1-dapengx.yu@intel.com> <20210907020033.2113437-1-dapengx.yu@intel.com> In-Reply-To: <20210907020033.2113437-1-dapengx.yu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 27f3d497-6e98-42e4-0b3b-08d97679dc4e x-ms-traffictypediagnostic: BN6PR11MB1410: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f51jbZxcCSmJBCW0gJC2t6W0IfLBSlQJmVMcqkRlXcfazTFULWYxVQ4pJnmB4wp6ZIQQfE1gZgIOK8sc0GI9LvAnDbI7ABu1Fp06aRm0+CpCR9nqvv7SAa42zQ2R+DrWCXVAIaqhLTFYxeM5b3YPEwcRDVD3zEspBjdzS34tRefUxJBmxv3MwgSEjBQ8qCElMHA4daaWgtBpdwnnxac40Hrby6FHnKpNrCoznMhCRh9bVNQuv0bQq4hJH9INHMQh//0AWOm+kS5UvdXIplR5wGbHvYoPLCd2D7q20SqlRpqNdoEmC8hHrTM1CwXS/cvgfwBXTI4X5VQNB9BiY2NgdNJ1t+xaFM2MkEG4anEw09uHXfJ0EQ+NHVN53T9LdLTtTAXUlKLc028MMSNo5K5THGbp7XsEDrUtaziYnQrylDgaZa5I0wgWFcPsb9zmVA7/reBviVgUUvlZb0BN+TYcMTHnck0vCE1O9ipMqZSMN21FzHWAZL3iOC/g4xA+/6rJ5G8P/RwlrRyo8CXzqcsPryYx0bYKjmMCVfMufCoGaxsiROPQNYHrF1KRe/H+jEXppPYlX6XLCG3Hm+Db0FS/M7OAf7mIcvl7XsvklINyXuhj4jGK1B+7HKpuzSLyAd3KlQlVcm8caQFPudJH7YsA57YpJgdLnDsEKbGWlP4utqxBVVq2oQ9nlhTTt0EWDLe8N5ILMcS9E+R0ku6eVrf7Dw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(366004)(346002)(396003)(76116006)(6636002)(4326008)(316002)(450100002)(86362001)(2906002)(83380400001)(71200400001)(8936002)(8676002)(38070700005)(122000001)(38100700002)(33656002)(66556008)(66446008)(64756008)(5660300002)(9686003)(54906003)(4744005)(186003)(7696005)(52536014)(6506007)(478600001)(26005)(110136005)(66476007)(55016002)(66946007)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sVs7qW+/F+OPLG4LrHXGZN0i/mc29BmFOeXlBaxikvESSNP5nleTtQKjCxN2?= =?us-ascii?Q?S6Z5N1oWdo1S6HtCFCWIPFZ1tCB48p6B5gvTjucDHrMhzhZGMmacINqIhqbz?= =?us-ascii?Q?NRn2q462m1u6vnH8ePh+9buxsO73vErHZytYWOmJDRuxan0o5YsPjicf9Is5?= =?us-ascii?Q?j5bCfWsmHU0G297rfEUeKjWmFK+KF1vcqzO+31zAG0BlHpUhYRadKXbuDedq?= =?us-ascii?Q?hY4/4OID2jo2O2GunQkYjBZicgGzD1K6+qCosgG8ACT6sSpxb7/H6+aPl5HC?= =?us-ascii?Q?6sx1ZqBEqPa0scTvGpZx6Rq4juyGDXzZe9eyiyaIAqbiwl32nLZtJk3IA/19?= =?us-ascii?Q?gF2x6HKbMJtK4J/Lb444ZxdmaqnZu/8GpSzPJk+Omqw5HJmr7Ce+2BCBrO3E?= =?us-ascii?Q?se+KCciL7WJbqZyKg+nhRml2o4RMzCTxGmoZVE4lb7iSGz6mDV9hLU4MoVy8?= =?us-ascii?Q?VNrkf1kkT4teOoQXKiDmu40MbraOo3rm4mVr0KmUoz1X0n/0PKHV+9LDQOkJ?= =?us-ascii?Q?1RBv+nyFRMxeduStiIjMQpFixtF4z8WMlQqAZ0Ps2pb6FnorMO8jvXVqZHCd?= =?us-ascii?Q?k35qdXXqTCPgk7zm1m+XPO8qbGSGXiyKUF4to6LOp2BNL3DxLaKvt38e+mcr?= =?us-ascii?Q?TBFgpsnEasJA4iZHAD10pW9UEWDH+7vg66995k2q/m5bOH6JHiQ1nhLIYddt?= =?us-ascii?Q?dnov1Js4robNU6FVJOjIeIpub0xhyQ9VRRIm5Pi84wCFR+CYtDb0twkEYixK?= =?us-ascii?Q?z4zfH4fgQtKVEhGbGoNfq3AbDIN23HabH5Ph1RjT/Rf7slp9CJ2nIRsB/AOF?= =?us-ascii?Q?GIKabxOxB8IMKr12gSUnV5wvAKOrm5AmLxbFh4vKBLL0lQhGR3h5vj+gUlr7?= =?us-ascii?Q?wdQy9UsP3lKWKzBdl/hQCNtrLuJLPpJB847haky2GG2EI8b4zUP691iluNlU?= =?us-ascii?Q?eizOIqpL6ubqEvCOFBfb1szlchZE28iVwG8FhFDhBO/lT59V5jaXOuJ56Ene?= =?us-ascii?Q?637eZvKfO/6F3ntMxJsSolqG7/B+U9mOCbrFM4UIfuTEhV9bUrjIWeXIm6TA?= =?us-ascii?Q?pKYcfJ+WnOVklLadNpfRsiQb0jTumi2/K8OrXPsxd6Px7DuHj8hcH6qOcdB6?= =?us-ascii?Q?M0hbnnLAemcCniId/CfBjy0NIYsBSd9QPGI/1V46LwAr8ewDXke7qUr97Ra1?= =?us-ascii?Q?YGWr8xRkQ09Hos3v4ZHAHsHztVj8L6YYUlPyh6q9bI7mIjpMA5Ww4rnIGMws?= =?us-ascii?Q?RiZipqXrqDF1c8dAdtf+J3fQWroRh0rvBIxsj1AfF93ow6BT54ooorloz3DL?= =?us-ascii?Q?VTi92llVLe+740eTHURa2Cd5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27f3d497-6e98-42e4-0b3b-08d97679dc4e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2021 05:46:40.7369 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8D4doBHfUFXQ/mj7omYnQYGFRnnqpSBBfC+F7B37edwEEHMn+nkAA5gz9JuuCp0LsZt42E3TmH9k8mCy/J3lfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1410 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix representor port segmentation fault X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yu, DapengX > Sent: Tuesday, September 7, 2021 10:01 > To: Yang, Qiming ; Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX ; > stable@dpdk.org > Subject: [PATCH v3] net/ice: fix representor port segmentation fault >=20 > From: Dapeng Yu >=20 > If DCF representor port is closed after DCF port is closed, there will > be segmentation fault because representor accesses the released resource > of DCF port. >=20 > This patch checks if the resource is present before accessing. >=20 > Fixes: 5674465a32c8 ("net/ice: add DCF VLAN handling") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu > --- > V2: > * Remove (void) to make code clean. > V3: > * Only check resource accessibility but not release it. > --- > drivers/net/ice/ice_dcf_vf_representor.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 Acked-by: Haiyue Wang > -- > 2.27.0