From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1301A09E4; Fri, 29 Jan 2021 03:02:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FEEA4067B; Fri, 29 Jan 2021 03:02:15 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 70D7F40395 for ; Fri, 29 Jan 2021 03:02:14 +0100 (CET) IronPort-SDR: 3kvah68HoAOWDJ3ufS7KI1P6epGZjIh1y0oyy9dH0QoeQHl544L6Sl4fVak9yDmJGJm2igscFF NoEEPs2YGucw== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="179565660" X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="179565660" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 18:02:12 -0800 IronPort-SDR: +vU1jOcVQQtuHFbkdBYmbYtd0wR7MEcQr3u3Prj0dfD4G2DwBip8UeFH7g5G78ME611vRyo5sB 7ALiEWSq5wmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="573866335" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 28 Jan 2021 18:02:12 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 28 Jan 2021 18:02:11 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 28 Jan 2021 18:02:11 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 28 Jan 2021 18:02:11 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 28 Jan 2021 18:02:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tlv16fkT6AJomzcoW0KnJQP+Wk7Ed9H+yudCdvyVXjPSZ5CVvv8HltRSAjUnMkjsMW3igNWLrSbnXsOQdOyoIsLjJE1gxGeTXluKsxTef0zKdB/yFmpU9lGv72UtN2b4eqf0MMY3ZG+YnuL9FY5M1sqAlIcD1AinaU1Aw1n7XYyI4SB5sDhF8I5indkNd7Qn4/ji72Rrky6v7adMnnixbhS0Q2eN60IFWVtqs/yq9oZ9JXHW2lGG3APVtTXPa+0lDMzmMT2fuZtlkVyaCpVzCJSwGqDfv/X58FwDP86cO8NjR2TaRg2wi89sR9OJnqCVFDW5SNxsGwGsX1j6WJrUkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xq8cOpyfBZVc6+CE3FZsO2EAy5medEwSBfM6JbPSrBo=; b=RaZfx/2iNMPcZOevh7kFGxO/3/Jw7DQnWkoY0N5VxHPMKxmnPnfgF4/phSsKfuUCqQQTOm9pHAH64x3yxa6tDBNZJBhD1gb1VfT2cbxWgWIAf5Sq0ZBdkyK55YsyrHRDqkd+RTSMptlGk0wZe6YCsc303uSElYyPpaDkwwVg3n8gAkHGDr2IMrl0is4en78SAHvC1+l1xHTc9KEepQ8eTOgzhkEDLN2QPHL9E9GRUVzOxseeTS1bHUPwzEm9VgULaVHrFHiMhuKSpOsOLW4dwGKyz/CRiFK9/mWEn1r7jmyHZASFU8dgaFK2ggyZlIQLOACYtpE8H2vRXpTJzZjEoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xq8cOpyfBZVc6+CE3FZsO2EAy5medEwSBfM6JbPSrBo=; b=LarCxnmSQQI/2ukZ1JXVP5niuYAyaiDs2PVvcIVjEMgJ4TJCzBMz8ruNaPrieZgvVxUKlTr3uvMfCBN8QO1vo5FeF+6XGFEm7cPMm6EfFmKU1L2LcjyZOLIYwTi0r363Y2HC3aWJKAGxV/6wa0wkfIp8loCIbnsnsA9nue8FmgY= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN8PR11MB3556.namprd11.prod.outlook.com (2603:10b6:408:8d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Fri, 29 Jan 2021 02:02:06 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::b50a:60a1:8190:c67f]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::b50a:60a1:8190:c67f%6]) with mapi id 15.20.3784.017; Fri, 29 Jan 2021 02:02:06 +0000 From: "Wang, Haiyue" To: Paolo Valerio CC: "Guo, Jia" , Aaron Conole , "dev@dpdk.org" Thread-Topic: ixgbe and UDP with zero checksum Thread-Index: AQHW9LNKYEOnPlbHCUiCOz71l2GA46o7uJHwgABGrYCAAdrE0A== Date: Fri, 29 Jan 2021 02:02:06 +0000 Message-ID: References: <87im7i12si.fsf@fed.void> In-Reply-To: <87im7i12si.fsf@fed.void> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41e0d3a5-be1c-4b8b-8d01-08d8c3f9e133 x-ms-traffictypediagnostic: BN8PR11MB3556: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3bsXtbOW3GUCQO1tDUxAVknaejUHw5qmzt7nUuwDCocjnRt9HgiO6H+IsSH9HWzH53hDSx6wQRZZH6CVwgzg4VWXRCm11jlSpJOpoU1FZuHzPbZRvKeeJCZY2I7qS/SPHt9F+DTvT6M0KBqHd8dadDYjmle07ITdxAe9N0cvE/cLoTfeSlP63ALETSC2XLyGHYzauoBYNJuSjrqWehdGRF/khZ3vEldgDHp/Wwf4yEgeEMVlnyQ8bglvNWDy+0gdnCPkpqdgcOZlh9CAnLIkpnIekza5pX59keZ91xlpl+khmeblofaA2rVCcuxI00hSnor8Fwr4AD2A1u0rHL/7lkoUH5qzPJsqE9/lpkSo7MY1lBvGsNqeR+KdNHyAHhs9i6HZj3RfIeM0ClVI2f/EBh/0/CUxsh6Ib5s4zldiXTYnKepdDwVO39sl0t5szrL28QzpJdXp+af+bvugj8NCXExpZZMAUxHuRhYreZZhvMAQAdhNyOGGpVig6PtkN8QHr+zIjwrze7SKDNe27AMl0oqryNxTPO0S4OWvCLSEQfYYgOm0PbGffJtAzxUSNLE78YPjjEek6Dl8ZXXhnvmh0Ma++zawlzeMhjIq19bxfn0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(39860400002)(136003)(396003)(83380400001)(8936002)(71200400001)(2906002)(33656002)(8676002)(4326008)(52536014)(66446008)(66946007)(66556008)(55016002)(64756008)(66476007)(86362001)(5660300002)(76116006)(7696005)(186003)(966005)(478600001)(26005)(6506007)(53546011)(6916009)(54906003)(9686003)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Wd36LodUJ0XGM06+nWUrXvZkk+CC14QgX/y/HElrjcuF11WAV7jtytlf/ZCC?= =?us-ascii?Q?UVGrw1rCjblXgRrVUVzzDMpNHJDQ6k0gQB+7hWPLBib/iiZr/gPxHOn1vRCU?= =?us-ascii?Q?cfWKhdksPD5lO5FFljZswgf3OwzjQpu3lgJN97/Bpn/ye13dGwqH9TEtPFZ6?= =?us-ascii?Q?mnrc4WibW4jXIri8kG4SMWsxCkKq5OEBfc4FfhQIi4R8nrP1puH6W8guP33B?= =?us-ascii?Q?Pd9YsENX+uJh2+1dfFPlbqHgJ6xdzw+3bn4bWb6avNfn5fDF/ge0MYdc1cJJ?= =?us-ascii?Q?/zPcGanF4mboJfx8W/vy3gFLAwexAsam0h5xp0ODH8af88e+xKnh/l0TOaNA?= =?us-ascii?Q?wXAj7DtY3INi7A5xTyrhMpBZ386peQo0nMEZD3lgdHgrlTVOmVREkksF+fIv?= =?us-ascii?Q?FQLRSFM3r1JoBA5ZQX7qryzll0N4MCW6XnRecNKs2a7KyotqLrs5yCPC1cuH?= =?us-ascii?Q?fz5k3t2om1V1251I6RDQhgRXkMBXvb9EsI/lnDy+uGttTEffYuvqa3hNiyEj?= =?us-ascii?Q?K7WovalTFAgZHUVxzz+b+JZvGZNVSdBmPcIcwK301WHrQ7zzScaGYaMLYDxP?= =?us-ascii?Q?lRL9/dHMjOZnU1iBVIzUgyslW3H3MamcDHpD18HBay/3VWgeFO73mCwNr1cS?= =?us-ascii?Q?0kmpO4kj60geQbtIFSnoccaMTQ1QHQMt5l1HeB5KeqZtxF79GeM46uiwo0M8?= =?us-ascii?Q?y7Y4zupckyZlWITrUhbKc9A+0NBxTk9CmFklib8REsOPd4UV191MyUXImrJv?= =?us-ascii?Q?3a6Z3fgTe7XAQlvPzWjbtjhXrzJPXKGpQR7zB8DcWLIJ2e+ontvetQMbgCLb?= =?us-ascii?Q?HG2OHAZqseTHi+b1SSHQAD3zfn/s3ubc6B4Db0EAdJHWJ7MI0CVQjBMnUc6/?= =?us-ascii?Q?ao89bLJYER3KWI5d1rJbB1oRS8/gX9LzMQrAWJ9MxT/DAm/SLHkQ80fDGVVR?= =?us-ascii?Q?vFwx3q/oq2w/DEL/G+cRW1f3z3fGxIM/tbjghhqKLIhBWil+lfKHT0dUnj6e?= =?us-ascii?Q?/a+q+EbWrkJMMwU+5ZWc3vYsjhpfwQHq/gmsVjG7anibKDC+jBvyjRnlFrsY?= =?us-ascii?Q?0mmprCXD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41e0d3a5-be1c-4b8b-8d01-08d8c3f9e133 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2021 02:02:06.4570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +QXWQ/nu1QLEmHoU7MyhTriJhyCXAlM8qPtZyU7cP6CXFF2tTyLtuGGIaYvQRAMvul45wtGcAdfSniYzUBNBFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3556 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] ixgbe and UDP with zero checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Paolo Valerio > Sent: Thursday, January 28, 2021 05:35 > To: Wang, Haiyue > Cc: Guo, Jia ; Aaron Conole ; dev@= dpdk.org > Subject: RE: ixgbe and UDP with zero checksum >=20 > "Wang, Haiyue" writes: >=20 > > Hi Paolo, > > > >> -----Original Message----- > >> From: Paolo Valerio > >> Sent: Wednesday, January 27, 2021 21:50 > >> To: dev@dpdk.org > >> Cc: Guo, Jia ; Wang, Haiyue = ; Aaron Conole > >> > >> Subject: ixgbe and UDP with zero checksum > >> > >> Hi, > >> > >> performing some tests, I noticed that on ixgbe when receiving UDP > >> packets with zero checksum (no checksum) over IPv4, the corresponding > >> ol_flag for the l4 checksum is set to PKT_RX_L4_CKSUM_BAD. > >> > >> In particular, this apparently has an impact on OvS using ct() action > >> where UDP packets with zero checksum are not tracked because of that. > > > > > >> > >> [1] > >> > https://patchwork.ozlabs.org/project/netdev/patch/20090724040031.30202.15= 31.stgit@localhost.localdomai > >> n/ > > > > About 12 years old patch, it is hardware errata. For fixing this, > > have to always disable vector Rx path for 82599, it seems not a > > good idea to bring in this workaround. :( > > >=20 > Thanks for the answer. > Yes, as I mentioned, the patch is old although still meaningful. > I linked it mostly because it mentions the hw errata. >=20 What's your PCI device ID ? My worked ixgbe: 86:00.0 Ethernet controller [0200]: Intel Corporation 82599ES 10-Gigabit SF= I/SFP+ Network Connection [8086:10fb] (rev 01) I'm wondering if people will complain that the patch will mark the real bad= checksum UDP as GOOD. For handling this correctly, looks like driver needs to check the UDP= 's checksum value, if zero, then skip the error information, but this makes driver do the netw= ork stack things ...