From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix memzone leak when firmware is missing
Date: Tue, 6 Jul 2021 13:36:19 +0000 [thread overview]
Message-ID: <BN8PR11MB3795855060D96F2BF0FDDDF1F71B9@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xDETvJ8WAw91n3xqhifvMgVAD4LweL-5ddvGmVXUoLiA@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, July 6, 2021 21:28
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>
> Subject: Re: [PATCH] net/ice: fix memzone leak when firmware is missing
>
> On Tue, Jul 6, 2021 at 2:53 PM Wang, Haiyue <haiyue.wang@intel.com> wrote:
> > > > The function 'ice_deinit_hw' should be used. ;-)
> > > >
> > > >
> > >
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ice
> > > /ice_main.c#n4508
> > >
> > > Well I was inspired by ice_dev_close(), so I guess this code too could
> > > use some cleanup but I don't have the hw anymore to test this change.
> > > I'll trust you and simply update ice_dev_init.
>
> Adding to this, there are other potential leaks if ice_flow_init() or
> ice_reset_fxp_resource() fails.
> Probably worth opening a bz for later processing.
> WDYT?
Yeah, make sense. ;-)
>
>
> --
> David Marchand
next prev parent reply other threads:[~2021-07-06 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 8:56 David Marchand
2021-07-06 12:40 ` Wang, Haiyue
2021-07-06 12:47 ` David Marchand
2021-07-06 12:53 ` Wang, Haiyue
2021-07-06 13:27 ` David Marchand
2021-07-06 13:36 ` Wang, Haiyue [this message]
2021-07-06 13:50 ` David Marchand
2021-07-06 14:12 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-07-06 15:07 ` Wang, Haiyue
2021-07-07 0:35 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB3795855060D96F2BF0FDDDF1F71B9@BN8PR11MB3795.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=paul.m.stillwell.jr@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).