From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E15DA0C3F; Wed, 28 Apr 2021 03:18:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 089DB40147; Wed, 28 Apr 2021 03:18:16 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 32E1440041 for ; Wed, 28 Apr 2021 03:18:14 +0200 (CEST) IronPort-SDR: lumb4B6t6/zQOrhkOIPmBMTuHQKg7vi0lYGTlkJCayUO8JWVDgUP6gGY0FHFgHlrr+XovpaM7N uXSmsJF2gABg== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="281964109" X-IronPort-AV: E=Sophos;i="5.82,256,1613462400"; d="scan'208";a="281964109" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 18:18:12 -0700 IronPort-SDR: d4xd6v+5vEI41goGPsVP7CWXYPJxBhHp/eXWMbycyBAlgTRXySvLQDWFgD9jk/rI3DEWtyzNyH Pqfb4SN3kIyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,256,1613462400"; d="scan'208";a="423297185" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga008.fm.intel.com with ESMTP; 27 Apr 2021 18:18:12 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 18:18:12 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 18:18:11 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 27 Apr 2021 18:18:11 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 27 Apr 2021 18:18:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EZw6AE4v+rQi2Yi8YHoX0NBGW03p3dt985kfYYd2zwmOuOzql29vMR+zTPeXu9LIojOrAeNOa5hQFPaEG7ypXn1qpa/2sTeYpB2BtHQBMwmVhRL827ry1JML1fuV14aiXerTiTplLIhIBRXVPrlksKya8+sw/uUA1Lwc5oDA3irIC//NBTbmr8f9MDtjFjCNkERDFtGKlzsqAu4hHlsQoyFdFUAZTU608kIlhhrhyac3goPL0NmWeVThk6zkpk2yr0Zq+wVDrUKyXART/W+9mO5Xhm5rYvhMp4dGPqg2unA91Hrw3Rrxut8cOWimuBzcvHCMbcEzLigjyFIdiDQTHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvGPEg9BtAcCxWJnKp6Ar1J82YwxCh6xwo9NIRt9sTg=; b=fETPvZNxEnobtXtq88PQLXiisqoTP3/h2qX6hVokN3I2lMKj7gDjPLEmYakd8pXx8xLYCOXcATrAKZAx3JD4/RTGLaC57ghgxLhPPAnWAyytzcKHU28UXP0QXK/Vk9SjqojbjwNRc28arM7VbUArGR/tfcLwdpQQ5p4VkJioz8FpjhJF0UGLpyY3fMyqqxICrRDvkr0Ug4UBqaifNYelE3mISA06G5eAT21G4Am3fgliT0afiIAeSWfQDvxxQAMaiBfTs9xWh1cX/RjzXXIZAlRWxxJ7X2i2ZCQCr1AJ9mixNESVawR63Imjg+FW1xv1kZWC6y0Obcf0GwP68X2iKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvGPEg9BtAcCxWJnKp6Ar1J82YwxCh6xwo9NIRt9sTg=; b=KGzdd+qMM6MRjcLxgrWiRKKOcDmRA0vRKO/AzL+hw47mvE+E1BbGALOuTlnOLtODDCS7sslyl5BJhPvZd7+1lrMqHzVaAji5+jFh/jTSal9Mhb8M/LfwDRTAg1JGGsLaopw0Sg2GQGXf6lToPX5BwCUubm7Ga3epljw8NzsKt4w= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Wed, 28 Apr 2021 01:18:07 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.4065.027; Wed, 28 Apr 2021 01:18:07 +0000 From: "Wang, Haiyue" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Guo, Jia" Thread-Topic: [PATCH] net/e1000: fix param misusage when set rte flow error Thread-Index: AQHXO0KHEfgRWO9o9ECQvoRQdxZdyarIWbrQgADH1QCAAACCgA== Date: Wed, 28 Apr 2021 01:18:07 +0000 Message-ID: References: <1619513481-15370-1-git-send-email-humin29@huawei.com> <6cc502b9-2ad2-4024-8961-9ca123864c0f@huawei.com> In-Reply-To: <6cc502b9-2ad2-4024-8961-9ca123864c0f@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7eb8e571-b438-4bde-3785-08d909e37b2c x-ms-traffictypediagnostic: BN8PR11MB3795: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:862; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K7bZ3CHbAG/NHyDkOBVb/SsLAWea5iq76AJrjBwvW7EvvDKpHt76bHOxDUtSwdjtrVRzVDgKMHPvInyUmPB85vX0572ztGztF0YX1Qv7P3VXwlz2d66303H+B2LMyvnN1cdMdsaorbDt2vGkSTYXw1rILqvoaZddJf9zGMk9TP3fbBcXIbcRTjP5K7HbaJCDcLMrcslK3ETRacqRrQTKcYgP7cmEXBTLCj6pF45xIYacPH4PAf0zz7OTmTlOvTUlu0RUCNXRGAF9nMzb4+hPEhqM5wDlBZGWbQ0F4ZuVPU5bBSmt95lXwqbPYQnZUFJUq06AB2z2glgdKDFGfEpRzGSO3tDHwwMQklbitNTJFI6A3xb6YXo66OCfwqSLG4pIxvrOM+tj205AVIHOwDY6X3xwASJjysE+zOG2mIheaasxaaQsmVUAIgKkJMO4/67VJcImo4UrzO8YNkzPwN3cJmtrMA3DhCT+Cmdv4nD8wAz530wjOa1z0GpOCsuz5HrLvQq+HYFiWK6WCgp7sZwiI5dL+OQj5zxbKFHf3R7gOdkgz9h8ouOFmsCP2sO3WKWlrGtE09vwidU7K6WWpSQtUCDDS7PjTEtdbIObHUTWmU0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(376002)(346002)(396003)(39860400002)(52536014)(122000001)(478600001)(66946007)(66476007)(38100700002)(110136005)(2906002)(33656002)(86362001)(83380400001)(8676002)(186003)(9686003)(107886003)(64756008)(4326008)(66556008)(316002)(5660300002)(71200400001)(55016002)(66446008)(76116006)(54906003)(7696005)(53546011)(8936002)(26005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?VERlL2FkYjhqdmhxZ0ROUW1JQ1B5RWx2d3VTQ29jd1dQSytEdHdOTUhE?= =?iso-2022-jp?B?TkhaMk8yUE9Fd1J0NHU3ZlgwaGszRmpaVFZLM3lWOTdTTDRPTm9UZ3Z4?= =?iso-2022-jp?B?OGVHUk43aTg2UjJoVzNZQjJjRUR1cG1nU3QwSTNHT0FORW1iWG13UGVV?= =?iso-2022-jp?B?bE0rbzFYNTdHamdYYzMyNjFQOHM5MklOcVZaSE8wVkZKS3pZbDh2SVdJ?= =?iso-2022-jp?B?UHpVNDVyaW50Y1NnaysyM1l5dnJuWUdTUFRNVVdJTWJrL0xIMXFYeWU1?= =?iso-2022-jp?B?dlN6NnJiOSs0VnJ3Q2gzUG5NSXE5TGhuUzM0SVBBWUduejliZmx2Mk1P?= =?iso-2022-jp?B?aU1vT0RQRnJQT2RRbGc5V3pkMTlzK0g0ZHFyZE1VSmp4cUZWeFJUTzgy?= =?iso-2022-jp?B?ejJ2TmRKR01reFYrMUkreEJpODE5SDF2SERFZWdQQ1o0WTlDMjRUcmM2?= =?iso-2022-jp?B?SFFkRllCYUlPS05vVG9Bd0psdU40VXRheFJtQys0emtkRVptTTU0NjFl?= =?iso-2022-jp?B?WTREN1MzNFRjQnp4aW1COWhJR2dWZjAzOTNpLzlqVzVFY1ZBUEw0VTQ1?= =?iso-2022-jp?B?QWlsdGw5RVptZTFvZGlRNyt2cHNPVzdSU1FtTzBGenZzWEpaNGExbURx?= =?iso-2022-jp?B?QTNiOUpaZGRnNlFBQ1JFMkM5QnJHZkptNFdjd1JwUWlheDFBeFVUV1lZ?= =?iso-2022-jp?B?UzNKNEhUSFQ2cHQ1TldETnZ5TnM1WVFUSWMwUHNNWUE5a1o0cWcwRFEz?= =?iso-2022-jp?B?dG9qVGs3UVFxOThsdnpkMkhadDJvVXV0UVpZSFNYSVFuSlRCOUdaVlI5?= =?iso-2022-jp?B?dTQvd0VXaEhXSVA4czZtaFI5U2F4enlVNnZmSUdta3ZKSldITTl0c2po?= =?iso-2022-jp?B?T1Q3Z3BGZE45SW9reUo1Uk91VGg2ZERRelUxQWtOWGtMSUJmdE5vY0lN?= =?iso-2022-jp?B?R04zK1llRklMaEZUWnBiYlFYaWx6WjB4ZnlBQmNZNEtleTJ2U0RONnpn?= =?iso-2022-jp?B?L3Y3R25ldGc1azFDV0RqNzFWN0xlcW9sZHZxRzIvUVNGSS9ESTZRcDJ2?= =?iso-2022-jp?B?TTAzTzMvUXBuUWxscWlhRjZJR3I0enNOd1lSc1Y5bnMyNW96Y0dIREpi?= =?iso-2022-jp?B?NURPbjkwc3ROT1FJVWFtQUZPcnoxSDNUY0YyUFJleDZxZGp5a050dzhO?= =?iso-2022-jp?B?dTlvY2hybnF6Y3ArS3lBTWR5UGl1VVdOUWg2VWFsbHRBWXFha01jOURw?= =?iso-2022-jp?B?S0UzbmlQaXMzSyt2SVhnak41YVd6UmtvM3JtdDhwRDVvODh6aW9vMkM3?= =?iso-2022-jp?B?WC9yNGo2cGtZSUl4eWc4aTdOTnJRblZqMUdkQjg5dFcvRDJVZTNvTm9Z?= =?iso-2022-jp?B?ZDFjdUU4eUE1TGRxMmZMYzV1UXdWcG83MVhueVlwMVduQ1hFaldkKy9F?= =?iso-2022-jp?B?TEhxZHJEeUkwaGFGdUwyTUZhRW1IKzE5TUFqMm1vd1RuN2szelg3SnNW?= =?iso-2022-jp?B?YzUvdTIwSXNjNXp0Q3REWkl6Q2w2RiswK2hYazVTZUxNcERGVTFRNnlp?= =?iso-2022-jp?B?dzVEOHdrM0xkSEVQbmtiTkVqSFJBbWtJL1BSN1cxaXdkem9MOHJsN2M1?= =?iso-2022-jp?B?VVNhMHNjc0JGUjRBeDNBdk9rQ0lOM0RFS1pWN1FSc3JWQWprOVh5R2pY?= =?iso-2022-jp?B?ckRZZFFLclVDemNCd0F2NkUycEpEUzhJNWhxS2tYb2syWGppbkgzelFr?= =?iso-2022-jp?B?V3hoQmlFYWNDZy9LWHZPNjFYc0EydklQOEF4Q0Z6cGo4K2Njamp5TlJG?= =?iso-2022-jp?B?YTBlV1BGcTl1N0xUQTA5OVo1N1JyQVhMRnVOUnFWcDJFcDB1cG5wZTlY?= =?iso-2022-jp?B?ODJZdm54T01hbTkyRXFveDVpd2NWTStrbml0YlY1WkxIbXFEdEt6MUZh?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7eb8e571-b438-4bde-3785-08d909e37b2c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2021 01:18:07.7377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +zZD3XGmZUOQSroo2vp0b8jw+zXK/wAWZVr1axOlmwVyOcTKNGhk0skaXevaOKFIs+gARS/jAjjO3BArnVSsIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3795 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Min Hu (Connor) > Sent: Wednesday, April 28, 2021 09:16 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia > Subject: Re: [PATCH] net/e1000: fix param misusage when set rte flow erro= r >=20 >=20 >=20 > =1B$B:_=1B(B 2021/4/27 21:22, Wang, Haiyue =1B$B >> -----Original Message----- > >> From: Min Hu (Connor) > >> Sent: Tuesday, April 27, 2021 16:51 > >> To: dev@dpdk.org > >> Cc: Yigit, Ferruh ; Guo, Jia ; Wang, Haiyue > >> > >> Subject: [PATCH] net/e1000: fix param misusage when set rte flow error > >> > >> This patch fixes parameter misusage when set rte flow action error. > >> > >> Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Min Hu (Connor) > >> --- > >> drivers/net/e1000/igb_flow.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > > Acked-by: Haiyue Wang > > > > > >> diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow= .c > >> index 33f6b1d..e72376f 100644 > >> --- a/drivers/net/e1000/igb_flow.c > >> +++ b/drivers/net/e1000/igb_flow.c > >> @@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_att= r *attr, > >> memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); > >> rte_flow_error_set(error, EINVAL, > >> RTE_FLOW_ERROR_TYPE_ACTION, > >> - item, "Not supported action."); > >> + act, "Not supported action."); > > > > Thanks, Connor. > > > > Just wonder how do you get this error ? With some code scan tool ? ;-) > > > No, I just read your code to help me understand flow table. I found this > part of codes are the same as others. > So I think this mistake derived from other drivers. OK, understood. ;-) > >> return -rte_errno; > >> } > >> filter->queue =3D > >> -- > >> 2.7.4 > > > > . > >