From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAC30A04E1; Tue, 22 Sep 2020 08:09:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2E601D628; Tue, 22 Sep 2020 08:09:25 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BCCEB1D617 for ; Tue, 22 Sep 2020 08:09:23 +0200 (CEST) IronPort-SDR: gTFacJcWk0hi6rL4d1tJwY5yGZn9Px/SGTzM5zGJ+Sasy2iK2Ggdt9QadpPtrCCuyotietAMeT W5UydsTbdSYw== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="148205136" X-IronPort-AV: E=Sophos;i="5.77,289,1596524400"; d="scan'208";a="148205136" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 23:09:21 -0700 IronPort-SDR: QZnHMHhq+6Atoqu3rmbTto6GTzBrgwFgrVljYLDlDE6sHChZLUzDIBomz3VwJm0S9F0uO3wd1z JtNdXuzsoo0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,289,1596524400"; d="scan'208";a="412551824" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 21 Sep 2020 23:09:21 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Sep 2020 23:09:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Sep 2020 23:09:20 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Sep 2020 23:09:20 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 21 Sep 2020 23:09:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RYRrvwWBXYH3s18E2mHQqjSbMPMyhQAXxtxv2yCoFR2blY5RXu/Ic9wPKHqsVbExuduEkFshMF8y+sTX7h28q6yq2kO9JQTnm1BDSJeubPKqgJtTDXqxisk6+e7HlPGXrsD2TKymT3IJo1BwT/JNcFJpfXmMsqGcdbwfZ71sb8xYHZiKQVLK4XZvoYJtqdZl9vn1haQrCYBJqnRHrOa8H6EBIRtGtidfh9Cnl0KyijpenztF2g7byLjRnPkKjx82ykYF+raGTqduch04XKnl9ojdpLWDboTD9SQMsfhyvqVjUfH/L96b6lleWmTON+CQ//ECZacy7KQjB2BDPA5e1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sn0Jvc9ADZ4MLbwMfe7zX7IjE7kUAtYSbulYgwsUX20=; b=RMH30Niwlds3ALRL9EKPIdQ/tQXQF+t1whJfeNGZdyoKIzsLRFvLt3wald9FHvHWa2CSSK3THYozVQrjIW9pETTRvW6HnEwQjIxlALicCclePweKPbwy5NU2XjWqolVexzqsw508y6GgpwsCLzollT7LpmbzgkFit08fatc/Xll/oXuAXhpZg0BQmLX8Mf8QaHXllFUDSWV6pZkii6Fzg1HCBh7lhGqRXJryyzsSbylUWVLfV05rYsJKRcdYOV4w/hfqJ2I2lTvKFVx2WhckQCgFE/SamWZWVKJBACOQsXwWUzfYhkmAAyrSWFJ367uZzF7CdldoXJuwTAOcnp+meQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sn0Jvc9ADZ4MLbwMfe7zX7IjE7kUAtYSbulYgwsUX20=; b=GI1h2fH1FZ1iFd9gSlx1/iIpKMUJCnK5w6Wunq4kfoUc10tdZLU6urFpcSewfM0mj/5oJmS6eR0kfuOq9Od0iPLk55XOTF5FYU8y/p3HffWSOG2tfYpC7O9VoSyjazQBFQcSkGQW/n/UsB90Z1j9UU6A4KUPYV17wmc+xeI2EO0= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1585.namprd11.prod.outlook.com (2603:10b6:405:d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15; Tue, 22 Sep 2020 06:09:18 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3391.024; Tue, 22 Sep 2020 06:09:17 +0000 From: "Wang, Haiyue" To: "Guo, Jia" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Jiang, JunyuX" , "Rong, Leyi" , "Yang, Qiming" , "Sun, GuinanX" , "Guo, Junfeng" Thread-Topic: [PATCH v3] net/ice: refactor the Rx FlexiMD handling Thread-Index: AQHWjVqODQZiBCMujEmaKI484vIaQ6l0KZMAgAAAVVCAAAQDgIAAAO5A Date: Tue, 22 Sep 2020 06:09:17 +0000 Message-ID: References: <20200917115332.45663-1-haiyue.wang@intel.com> <20200918010535.27089-1-haiyue.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 546e1a59-f815-446c-cdd2-08d85ebe0a10 x-ms-traffictypediagnostic: BN6PR11MB1585: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Pgb8IvcEZ0VkaTOEwI4wOlVhxRI2/mG/d8Eso5irStEA4ScJB7+ih4fwbFFK+kVmoZqocSOgbLTx1+h6+wD5cmELLlZCpS6kxUpw1KmoLQ7PE2dhryLE6nekOfs5xeyvIVguOUn6bIwkdleOj4yybbM53CvYY2Hn8cctedPCPhVhsfpoa/cP70pKahyN9l1LIZbsk1RKtyJaxiHHsSiXZA1sTJwZq00udtvtg1aJJZXVCm95ewLtoHQfOkZOsqn6Ui6Y2mfhrWSFgS0PWT6YUF59Rh/Xu7xmdxnmlgLsQ98eAPvck1DbIoyh/ZKk6U4j x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(71200400001)(64756008)(66556008)(66476007)(66946007)(7696005)(66446008)(110136005)(52536014)(86362001)(76116006)(2906002)(8936002)(6506007)(8676002)(54906003)(26005)(478600001)(316002)(53546011)(186003)(33656002)(9686003)(5660300002)(83380400001)(4326008)(55016002)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: oVNnRATlRZ6ECHVb3dTddc0kPczSxWoIkdxyPLrk9XhoSSBQ1itSQqTQ4tHQTlL0TUxVxHbbGZt1WwI5pHAiIB0XBLVz+IvyX2ST/yuvGh3135s42ac7Nz2MLnuVFz5A8crAKLpyeuW1FCI/0U0tOeK1UkHd5uaAgs3dZWgj3X+ij9dCReKuJLIOocDPCCj08yPinjXR19fytHzktpOV1Qn0kS8FYejPKecbY6aLyKwzYWpXT5N/jlZYWHo0yEmped7AkXPkNue8vcBrWDhdgnmME7mxzPhge5UiJRzPXlbAtMEdkg9gfDGKmdeixqaT//2xMNYjEy+32QxRnZfJ9zi46WJOOfg5ew6AQVtL74+adE5q+tIKNIDGaT/qn/WfHiJZJGI6eRLbXJi/SPjP609TUiiAT+q0SzxMNZY6xJ5zLsCcMK6Roib5eWt4HzsZx+rk3sok4xfKq0HVNlrapDzxZvuTq2qXU8QRYrpoLh/dq2noxuAdudSsW9gvzQT1Vb5b0+fQqUUZtp8WhLj4hid22M8Pj6cAYlSzCnaO0s2r8pMzrCe2I5Y8xZUr9ZAg7+WGeZo0AzqVfxhAGEf0EyFR2Gw+va5gxydAVPlMe4GQjWQoQBzy37Ucz1gXd9nQ4cMQNQqJs2cGUH2VIK1OCg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 546e1a59-f815-446c-cdd2-08d85ebe0a10 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2020 06:09:17.6487 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qKG7QFbZq1rKj96P6xkamES7NIz7KiXN6Q5vuyek7BHpRNQKV6EORqbDJyqhOqKa7/MbzfYFZWg6buRzb61wYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1585 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/ice: refactor the Rx FlexiMD handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Guo, Jia > Sent: Tuesday, September 22, 2020 13:51 > To: Wang, Haiyue ; dev@dpdk.org > Cc: Zhang, Qi Z ; Jiang, JunyuX ; Rong, Leyi > ; Yang, Qiming ; Sun, GuinanX= ; Guo, > Junfeng > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD handling >=20 >=20 > > -----Original Message----- > > From: Wang, Haiyue > > Sent: Tuesday, September 22, 2020 1:42 PM > > To: Guo, Jia ; dev@dpdk.org > > Cc: Zhang, Qi Z ; Jiang, JunyuX > > ; Rong, Leyi ; Yang, Qimin= g > > ; Sun, GuinanX ; Guo, > > Junfeng > > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD handling > > > > Hi Jeff, > > > > > -----Original Message----- > > > From: Guo, Jia > > > Sent: Tuesday, September 22, 2020 13:35 > > > To: Wang, Haiyue ; dev@dpdk.org > > > Cc: Zhang, Qi Z ; Jiang, JunyuX > > > ; Rong, Leyi ; Yang, > > > Qiming ; Sun, GuinanX ; > > > Guo, Junfeng > > > Subject: RE: [PATCH v3] net/ice: refactor the Rx FlexiMD handling > > > > > > Hi, haiyue > > > > > > > + struct rte_mbuf *mb, > > > > + volatile union ice_rx_flex_desc *rxdp) { volatile struct > > > > +ice_32b_rx_flex_desc_comms_ovs *desc =3D (volatile struct > > > > +ice_32b_rx_flex_desc_comms_ovs > > > > *)rxdp; #ifndef > > > > +RTE_LIBRTE_ICE_16BYTE_RX_DESC > > > > +uint16_t stat_err; > > > > +#endif > > > > > > This #ifndef could be better combine with below #ifndef. > > > > > > > I changed it to according to the different offsets, like ovs has rss ha= sh in > > Qword 3, which is after flow Id Qword 1, others are opposite. So that t= his > > handling order can reflect the offset difference, although, it MAY look= s not > > so beautiful. What do you think ? :) > > >=20 > I am not sure I got you point about the order reason, but I think in or o= ut #ifndef should be clear > show the offset difference,=20 You mean below ? If so, 'uint16_t stat_err;' is not so good in the middle o= f two code blocks. #ifndef RTE_LIBRTE_ICE_16BYTE_RX_DESC uint16_t stat_err; stat_err =3D rte_le_to_cpu_16(desc->status_error0); if (likely(stat_err & (1 << ICE_RX_FLEX_DESC_STATUS0_RSS_VALID_S))) { mb->ol_flags |=3D PKT_RX_RSS_HASH; mb->hash.rss =3D rte_le_to_cpu_32(desc->rss_hash); } #endif I am insist about that but if other also agree. And I still have 2 > comments assume you are default agree and could I expect a new version or= not? >=20 Oh, I missed you other two comments. Your reply is embedded into my origina= l many code lines. You can remove the unnecessary codes, so that people can get yo= ur comments quickly without moving mouse down to check line by line. ;-) > > > > +if (rxq->xtr_ol_flag) { > > > > +uint32_t metadata =3D 0; > > > > + > > > > +if (desc->flex_ts.flex.aux0 !=3D 0xFFFF) metadata =3D > > > > +rte_le_to_cpu_16(desc- > > > > >flex_ts.flex.aux0); > > > > +else if (desc->flex_ts.flex.aux1 !=3D 0xFFFF) metadata =3D > > > > +rte_le_to_cpu_16(desc- > > > > >flex_ts.flex.aux1); > > > > > > So you mean the ICE_RX_FLEX_DESC_STATUS1_XTRMD4_VALID_S and > > > ICE_RX_FLEX_DESC_STATUS1_XTRMD5_VALID_S > > > could not use to identify the IPv4 hdr offset and IPv6 hdr offset her= e in > > rxdid # 25? > > > And if yes they can and they will not set at the same time, is that s= eparate > > this v2 from v1 necessary? XTRMD4/5_VALID_S can't detect the value of IP offset available, non 0xfffff= fff is the right check condition. > > > > +uint64_t xtr_ol_flag; /* Protocol extraction offload flag */ > > > > +ice_rxd_to_pkt_fields_t rxd_to_pkt_fields; > > > > > > If create a function pointer here in .h, it is better add some doc. C comments: /* .... */ ? > > > > > > > ice_rx_release_mbufs_t rx_rel_mbufs; > > > > }; > > > > > > > > -- > > > > 2.28.0 > > > > > >=20