From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A072BA052A; Wed, 27 Jan 2021 18:26:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EF19140FAC; Wed, 27 Jan 2021 18:26:47 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id C8CEA140F95 for ; Wed, 27 Jan 2021 18:26:44 +0100 (CET) IronPort-SDR: OlXjSc9XpOoUbti04hg9wG2GV2ydjf/b8wlB2X0RLIjHpvmG4521xtgA6w9E6XKy24l2Bbmogn PeeJmmUru34g== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="177539458" X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="177539458" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 09:26:43 -0800 IronPort-SDR: lheYV0rzMvEjwIVuE9iqHTwrwTXirc3Rk5DQp8u2UCGy1faBPzD/oAL07VRDvu+m6qZjxb/hm/ M9Oh7gsITOUQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,380,1602572400"; d="scan'208";a="410600629" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jan 2021 09:26:43 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 27 Jan 2021 09:26:43 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 27 Jan 2021 09:26:43 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 27 Jan 2021 09:26:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cD/4jt5syQ0tI7BCFb1p9y7/QNjgPV4CE3XbHcub4X67CMcckzLR+WAcT9YSacvAVSUEkReU/D81ct+8hSHeGhMMJ4F3jPrQkRVtvVFGxOubPxMPDhY3phSjjDBeuvyHdtN1UEAm/77Q+o2AMI1QXjcS3MGy7zv0529XzcF6tIrUw4rsI870HhJYfoagV4a00Bpt1KIypudna5eBQGmXKVOxpwYcpk+Vs7ohDlPjzBnNh9EjvE53n32VfV01x/YJ3lAvoaA63+Nr95mhb4AZnVZ42hewCc9Ex+ZkSpEk1rsdC8ZlQ+GzdE/5C//sa5WsM7hYgGsrKVZQrRoR6I8Iug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJm9rv5npvPtlQpvPkE/PNUGuIpWpSr3TaMw4NmmQnk=; b=Su46b8DpsSTIqpg9u5lqT8WbRg1sZ6PRHhgcxoTNbz/W1dm1FMEmeeXZk8alUIolmXLHB3gmMahWIetijuiWX7zf4HNt+RTv5GYQcZnOgu9UFUlYyWGKhTtNzwpBu51PGMb7s/cpj6K7WdTne2KVjd32bcQD64+tX41Q2Gi1VNuv/v5s4qGHBvFYk4fQ0G0xv0LFO8x9UJBTWQ4e4ACe7tEMjpZ+I1yriKRF1HnWqsTxva+nHGOsBVO8EpcI4g05BStdC8nzvb5lhKQyFfBzgbdhCKCyaXcygj8kqg3b6o/Q08SgXFBDIy3KCL4bX9mt9oTq1F2Men/1hgOwkmRdWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJm9rv5npvPtlQpvPkE/PNUGuIpWpSr3TaMw4NmmQnk=; b=i3sgRuaSG5VsZsuORYrlPmt0lda2qoPHs3rUqbskf5n1WAFxJwR3Xjra+rObygReyzUHgCRmCXsN42CZeP7Xy8mtPvX045E3d/kF1TiHuUM/ZgioxBBG9xoSf9THeZTYo38KuP4DJp3N78BXk3Z2SgyUQm2mAPyNIvZqFjKmeBc= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN7PR11MB2673.namprd11.prod.outlook.com (2603:10b6:406:b7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.15; Wed, 27 Jan 2021 17:26:39 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::b50a:60a1:8190:c67f]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::b50a:60a1:8190:c67f%6]) with mapi id 15.20.3784.017; Wed, 27 Jan 2021 17:26:39 +0000 From: "Wang, Haiyue" To: Paolo Valerio , "dev@dpdk.org" CC: "Guo, Jia" , Aaron Conole Thread-Topic: ixgbe and UDP with zero checksum Thread-Index: AQHW9LNKYEOnPlbHCUiCOz71l2GA46o7uJHw Date: Wed, 27 Jan 2021 17:26:39 +0000 Message-ID: References: <87zh0u1od0.fsf@fed.void> In-Reply-To: <87zh0u1od0.fsf@fed.void> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78da4c03-cc26-4902-0182-08d8c2e8b4e5 x-ms-traffictypediagnostic: BN7PR11MB2673: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cXxdS4eINNYWaPdNxSDuXtL4RRNxwX+IatYMfgk0ALL8ymIkheCEu3A2OkHlt6jMh46Bp1b7I1H0BzsiAb3PnT/GuhjIuNc6t44QXQFMuMx5+w3xPetJhiXj9BvyOsnwaW7H1k40L5bII+x7hA/lutHflfOL61N68exsrbkv4aelBAiy24f/kefHbXbBe5swZt0VqI3Ts+f1YHKrVtgI/EaccIT0ShWG+WOVIXqmL+QJ6NlJCzB/zE6CSg85MkHlCGO6d8AGBut4W6tH4BJ/6HMmQYAEm9gIv/f9tO20VAB10323qvZ+gSlmw468S7dlS+fBRAHXHveLIYR19CfVOpluAnaovfP4QuG9oTfp2mbbtirW8+PvRfwrElVzVD7ohJxljkvq8v8dLKT9jYOZhrCbmaT2DZGRzlF8/jo7FAFyr3fDD0by1QF/YR9y4BFJRmFsw/FpTA1wdyH6B9BH4w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(39860400002)(366004)(346002)(76116006)(966005)(9686003)(66476007)(186003)(7696005)(52536014)(66446008)(55016002)(26005)(64756008)(2906002)(66556008)(316002)(6506007)(66946007)(86362001)(8676002)(83380400001)(8936002)(53546011)(110136005)(71200400001)(4326008)(54906003)(33656002)(478600001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?D7OmUMr95SojJ7gC79dXgC0TVJcX0y8yDWhMs2A4aUz1V4x3K6pgRJFFIeji?= =?us-ascii?Q?ARnFJTRGJUNRA/CODWRoYQMsTLnpawDwqJ0R3cYsi2R1TErtLTF6dUvrOUfs?= =?us-ascii?Q?6VG6xKD/S7wuVuhTATib7BcCxzo204HntRS1304wQpo9aPC1mhFwYSGqyMHT?= =?us-ascii?Q?Zaf1GikqgktYY6h48KJwQspWE42cKQ4s3HBoMcHFRUPgwfjEafhTEnYyJme1?= =?us-ascii?Q?0vtDnqRk9kf7nv5qecpKT+D4ZYz3HAHb8qwp5Grm7pn8YX/NWANt3DgCHETo?= =?us-ascii?Q?5pTwsZ4sLs/YUPoFTJh4aqd/owL8u1k4PonoUXJZva40lnUebwZUv3xGONFb?= =?us-ascii?Q?vWmmAb7eZ8D5/JDkm9Ze4sPPa2gH5w+wbj/pu6Z79gJ7R+xzYE0lhK7K2k6c?= =?us-ascii?Q?vH5uejQSDL4GUVbZMG027hdjzYF9N7BOamWI5CAWK3jqft+IMtBmhblGNXzU?= =?us-ascii?Q?EUxnHDGD63q+MSC/Dlf4Itp9rYX76sppnejXmmx3mzY+GdNYFYlhXG0VJ3IP?= =?us-ascii?Q?Nw6v6VYxcAhz8SGAqhQgkkYFKDeiee9c+V9f7kBhL0WJSsceBjF5+o0hYwbN?= =?us-ascii?Q?ASSlyVDvSUPg4379cI0KNdAzepwIhz6CMSAZvACRnhd9QDKyGKdJaZsDRzka?= =?us-ascii?Q?eG+wP7VhQltOKi7PUrdC+0IiF3gQx8HlEgFCEZpWMuKlCDVm6i6XKExFGq2U?= =?us-ascii?Q?pDbFNXuwtzA+nlBtaRwK7/d88cklCyEYdeflxAbNPKeAiw+kjPyzfyJc+6GB?= =?us-ascii?Q?Q52z8NEXRBNRt3lCshZE/9FC6D7q9C6ckCnEnJjuIPRPRAVOtQXTfq8LuPUC?= =?us-ascii?Q?Ev+tqFSDd+dgvDfDwvF0tlg+yO0ek+nbAScsWhecdBnDyIEVb5zgC+grRzRn?= =?us-ascii?Q?QwBrw+1InmJk16WBhbVRs+LUjM6wnmP1NXf7SqOIykxnJHBjv45KGNATESA3?= =?us-ascii?Q?y10LH3H0d5rVoLoBlazoF5DvectUm2LKzUlkEoybtRglLUtlPmK/RQORkuAx?= =?us-ascii?Q?omdb3qPxj57XxHj9DDn4seTZGXN9cy8zFbgf966xb0XmOU/V5Bn9xeklnSDu?= =?us-ascii?Q?sjEBQOJp?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78da4c03-cc26-4902-0182-08d8c2e8b4e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2021 17:26:39.5593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +ULarplJiKYXjRsI69FBeLRljEAvpM3hom4/JsvgaTsesz6RrCJLQpkSbwzTc6Jm8bEG1n2nd0kbxqUH5F+6bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2673 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] ixgbe and UDP with zero checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Paolo, > -----Original Message----- > From: Paolo Valerio > Sent: Wednesday, January 27, 2021 21:50 > To: dev@dpdk.org > Cc: Guo, Jia ; Wang, Haiyue ; A= aron Conole > > Subject: ixgbe and UDP with zero checksum >=20 > Hi, >=20 > performing some tests, I noticed that on ixgbe when receiving UDP > packets with zero checksum (no checksum) over IPv4, the corresponding > ol_flag for the l4 checksum is set to PKT_RX_L4_CKSUM_BAD. >=20 > In particular, this apparently has an impact on OvS using ct() action > where UDP packets with zero checksum are not tracked because of that. >=20 > [1] > https://patchwork.ozlabs.org/project/netdev/patch/20090724040031.30202.15= 31.stgit@localhost.localdomai > n/ About 12 years old patch, it is hardware errata. For fixing this, have to always disable vector Rx path for 82599, it seems not a good idea to bring in this workaround. :( + /* + * 82599 errata, UDP frames with a 0 checksum can be marked as + * checksum errors. + */ + if ((pkt_info & IXGBE_RXDADV_PKTTYPE_UDP) && + (adapter->hw.mac.type =3D=3D ixgbe_mac_82599EB)) + return; >=20 > Regards, > Paolo