* [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
@ 2020-12-08 8:10 banxiaozhen, benhaz1024
2020-12-08 9:04 ` Wang, Haiyue
2021-03-17 9:15 ` [dpdk-dev] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
0 siblings, 2 replies; 15+ messages in thread
From: banxiaozhen, benhaz1024 @ 2020-12-08 8:10 UTC (permalink / raw)
To: jia.guo, haiyue.wang; +Cc: dev, banxiaozhen
From: banxiaozhen <benhaz1024@gmail.com>
Signed-off-by: banxiaozhen <benhaz1024@gmail.com>
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 647aa8d99..8695426c2 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
default:
PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
filter_type);
+ ret = -EINVAL;
break;
}
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
2020-12-08 8:10 [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported banxiaozhen, benhaz1024
@ 2020-12-08 9:04 ` Wang, Haiyue
2020-12-08 9:58 ` haz ben
2021-03-17 9:15 ` [dpdk-dev] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
1 sibling, 1 reply; 15+ messages in thread
From: Wang, Haiyue @ 2020-12-08 9:04 UTC (permalink / raw)
To: banxiaozhen benhaz1024@gmail.com, Guo, Jia; +Cc: dev, banxiaozhen
> -----Original Message-----
> From: banxiaozhen benhaz1024@gmail.com <banxiaozhen benhaz1024@gmail.com>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; banxiaozhen <benhaz1024@gmail.com>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
>
> From: banxiaozhen <benhaz1024@gmail.com>
>
> Signed-off-by: banxiaozhen <benhaz1024@gmail.com>
The patch looks good.
The name format should be like "Banxiao Zhen", and the commit message is empty ?
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
> default:
> PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> filter_type);
> + ret = -EINVAL;
> break;
> }
>
> --
> 2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
2020-12-08 9:04 ` Wang, Haiyue
@ 2020-12-08 9:58 ` haz ben
2020-12-08 10:40 ` Wang, Haiyue
2020-12-08 11:05 ` Wang, Haiyue
0 siblings, 2 replies; 15+ messages in thread
From: haz ben @ 2020-12-08 9:58 UTC (permalink / raw)
To: Wang, Haiyue; +Cc: ban, xiaozhen, Guo, Jia, dev
my name is ban, xiaozhen.
the commit message is "net/e1000: fix incorrect return value if filter type
not supported." does additional details should be add?
Wang, Haiyue <haiyue.wang@intel.com> 于2020年12月8日周二 下午5:04写道：
> > -----Original Message-----
> > From: banxiaozhen benhaz1024@gmail.com <banxiaozhen benhaz1024@gmail.com
> >
> > Sent: Tuesday, December 8, 2020 16:10
> > To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> > Cc: dev@dpdk.org; banxiaozhen <benhaz1024@gmail.com>
> > Subject: [PATCH] net/e1000: fix incorrect return value if filter type
> not supported.
> >
> > From: banxiaozhen <benhaz1024@gmail.com>
> >
> > Signed-off-by: banxiaozhen <benhaz1024@gmail.com>
>
> The patch looks good.
>
> The name format should be like "Banxiao Zhen", and the commit message is
> empty ?
>
> > ---
> > drivers/net/e1000/igb_ethdev.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c
> > index 647aa8d99..8695426c2 100644
> > --- a/drivers/net/e1000/igb_ethdev.c
> > +++ b/drivers/net/e1000/igb_ethdev.c
> > @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev
> __rte_unused,
> > default:
> > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> > filter_type);
> > + ret = -EINVAL;
> > break;
> > }
> >
> > --
> > 2.24.3 (Apple Git-128)
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
2020-12-08 9:58 ` haz ben
@ 2020-12-08 10:40 ` Wang, Haiyue
2020-12-08 11:05 ` Wang, Haiyue
1 sibling, 0 replies; 15+ messages in thread
From: Wang, Haiyue @ 2020-12-08 10:40 UTC (permalink / raw)
To: haz ben; +Cc: Guo, Jia, dev
From: haz ben <benhaz1024@gmail.com>
Sent: Tuesday, December 8, 2020 17:58
To: Wang, Haiyue <haiyue.wang@intel.com>
Cc: ban, xiaozhen <benhaz1024@gmail.com>; Guo, Jia <jia.guo@intel.com>; dev@dpdk.org
Subject: Re: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
my name is ban, xiaozhen.
OK, ;-)
the commit message is "net/e1000: fix incorrect return value if filter type not supported." does additional details should be add?
It is not about additional, it is better for title + more descriptive message.
Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>> 于2020年12月8日周二 下午5:04写道：
> -----Original Message-----
> From: banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com> <banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo@intel.com<mailto:jia.guo@intel.com>>; Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>>
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>; banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
>
> From: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
>
> Signed-off-by: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
The patch looks good.
The name format should be like "Banxiao Zhen", and the commit message is empty ?
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
> default:
> PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> filter_type);
> + ret = -EINVAL;
> break;
> }
>
> --
> 2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
2020-12-08 9:58 ` haz ben
2020-12-08 10:40 ` Wang, Haiyue
@ 2020-12-08 11:05 ` Wang, Haiyue
1 sibling, 0 replies; 15+ messages in thread
From: Wang, Haiyue @ 2020-12-08 11:05 UTC (permalink / raw)
To: haz ben; +Cc: Guo, Jia, dev
From: haz ben <benhaz1024@gmail.com>
Sent: Tuesday, December 8, 2020 17:58
To: Wang, Haiyue <haiyue.wang@intel.com>
Cc: ban, xiaozhen <benhaz1024@gmail.com>; Guo, Jia <jia.guo@intel.com>; dev@dpdk.org
Subject: Re: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
my name is ban, xiaozhen.
the commit message is "net/e1000: fix incorrect return value if filter type not supported." does additional details should be add?
http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line
1.
./devtools/checkpatches.sh -n1
### net/e1000: fix incorrect return value if filter type not supported.
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
0/1 valid patch
2.
./devtools/check-git-log.sh -1
Wrong headline format:
net/e1000: fix incorrect return value if filter type not supported.
Headline too long:
net/e1000: fix incorrect return value if filter type not supported.
Missing 'Fixes' tag:
net/e1000: fix incorrect return value if filter type not supported.
Invalid patch(es) found - checked 1 patch
3. Please configure your mail system with plain text, not in rich text.
Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>> 于2020年12月8日周二 下午5:04写道：
> -----Original Message-----
> From: banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com> <banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo@intel.com<mailto:jia.guo@intel.com>>; Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>>
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>; banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
>
> From: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
>
> Signed-off-by: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
The patch looks good.
The name format should be like "Banxiao Zhen", and the commit message is empty ?
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
> default:
> PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> filter_type);
> + ret = -EINVAL;
> break;
> }
>
> --
> 2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH] net/e1000: fix filter control return value
2020-12-08 8:10 [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported banxiaozhen, benhaz1024
2020-12-08 9:04 ` Wang, Haiyue
@ 2021-03-17 9:15 ` Xiaozhen Ban
2021-03-17 11:23 ` Wang, Haiyue
1 sibling, 1 reply; 15+ messages in thread
From: Xiaozhen Ban @ 2021-03-17 9:15 UTC (permalink / raw)
To: jia.guo, haiyue.wang; +Cc: dev, stable
If filter_type not supported, eth_igb_filter_ctrl() will return
incorrect value.
Fixes: dd5c2dd7e5e5 ("igb: use generic filter control for ethertype filter")
Cc: stable@dpdk.org
Signed-off-by: Xiaozhen Ban <benhaz1024@gmail.com>
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 1716d6b90..325461247 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -4599,6 +4599,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
default:
PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
filter_type);
+ ret = -EINVAL;
break;
}
--
2.25.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
2021-03-17 9:15 ` [dpdk-dev] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
@ 2021-03-17 11:23 ` Wang, Haiyue
2021-03-18 11:44 ` Xiaozhen Ban
0 siblings, 1 reply; 15+ messages in thread
From: Wang, Haiyue @ 2021-03-17 11:23 UTC (permalink / raw)
To: Xiaozhen Ban, Guo, Jia; +Cc: dev, stable
> -----Original Message-----
> From: Xiaozhen Ban <benhaz1024@gmail.com>
> Sent: Wednesday, March 17, 2021 17:16
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] net/e1000: fix filter control return value
>
> If filter_type not supported, eth_igb_filter_ctrl() will return
> incorrect value.
>
> Fixes: dd5c2dd7e5e5 ("igb: use generic filter control for ethertype filter")
> Cc: stable@dpdk.org
> Signed-off-by: Xiaozhen Ban <benhaz1024@gmail.com>
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 1716d6b90..325461247 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4599,6 +4599,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
> default:
> PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> filter_type);
> + ret = -EINVAL;
> break;
> }
>
New design will be applied:
https://patchwork.dpdk.org/project/dpdk/patch/20210312174645.162801-2-thomas@monjalon.net/
> --
> 2.25.1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
2021-03-17 11:23 ` Wang, Haiyue
@ 2021-03-18 11:44 ` Xiaozhen Ban
2021-03-18 15:28 ` Wang, Haiyue
0 siblings, 1 reply; 15+ messages in thread
From: Xiaozhen Ban @ 2021-03-18 11:44 UTC (permalink / raw)
To: jia.guo, haiyue.wang; +Cc: dev, stable
OK, but I think this bug affects all stable release about 6 years before today.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
2021-03-18 11:44 ` Xiaozhen Ban
@ 2021-03-18 15:28 ` Wang, Haiyue
2021-03-19 4:08 ` Xiaozhen Ban
0 siblings, 1 reply; 15+ messages in thread
From: Wang, Haiyue @ 2021-03-18 15:28 UTC (permalink / raw)
To: Xiaozhen Ban, Guo, Jia; +Cc: dev, stable
> -----Original Message-----
> From: Xiaozhen Ban <benhaz1024@gmail.com>
> Sent: Thursday, March 18, 2021 19:44
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
>
> OK, but I think this bug affects all stable release about 6 years before today.
I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
always use RTE_ETH_FILTER_GENERIC. ;-)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
2021-03-18 15:28 ` Wang, Haiyue
@ 2021-03-19 4:08 ` Xiaozhen Ban
2021-03-25 8:46 ` Zhang, Qi Z
0 siblings, 1 reply; 15+ messages in thread
From: Xiaozhen Ban @ 2021-03-19 4:08 UTC (permalink / raw)
To: jia.guo, haiyue.wang; +Cc: dev, stable
> > -----Original Message-----
> > From: Xiaozhen Ban <benhaz1024 at gmail.com>
> > Sent: Thursday, March 18, 2021 19:44
> > To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>
> > Cc: dev at dpdk.org; stable at dpdk.org
> > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> >
> > OK, but I think this bug affects all stable release about 6 years before today.
> I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
> always use RTE_ETH_FILTER_GENERIC. ;-)
eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application
developer know how to use the parameter filter_type correctly, it's OK.
otherwise he will get rte_eth_dev_filter_ctrl() return value is success
but actually is failed.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
2021-03-19 4:08 ` Xiaozhen Ban
@ 2021-03-25 8:46 ` Zhang, Qi Z
2021-04-20 8:08 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 15+ messages in thread
From: Zhang, Qi Z @ 2021-03-25 8:46 UTC (permalink / raw)
To: Xiaozhen Ban, Guo, Jia, Wang, Haiyue; +Cc: dev, stable
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaozhen Ban
> Sent: Friday, March 19, 2021 12:08 PM
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
>
> > > -----Original Message-----
> > > From: Xiaozhen Ban <benhaz1024 at gmail.com>
> > > Sent: Thursday, March 18, 2021 19:44
> > > To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at
> > > intel.com>
> > > Cc: dev at dpdk.org; stable at dpdk.org
> > > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> > >
> > > OK, but I think this bug affects all stable release about 6 years before today.
>
> > I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
> > always use RTE_ETH_FILTER_GENERIC. ;-)
>
> eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application developer
> know how to use the parameter filter_type correctly, it's OK.
> otherwise he will get rte_eth_dev_filter_ctrl() return value is success but
> actually is failed.
After check with Haiyue, we think the patch is still needed for LTS <= 19.11, so
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value
2021-03-25 8:46 ` Zhang, Qi Z
@ 2021-04-20 8:08 ` Ferruh Yigit
2021-04-20 9:54 ` Zhang, Qi Z
0 siblings, 1 reply; 15+ messages in thread
From: Ferruh Yigit @ 2021-04-20 8:08 UTC (permalink / raw)
To: Zhang, Qi Z, Xiaozhen Ban, Guo, Jia, Wang, Haiyue; +Cc: dev, stable
On 3/25/2021 8:46 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaozhen Ban
>> Sent: Friday, March 19, 2021 12:08 PM
>> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
>>
>>>> -----Original Message-----
>>>> From: Xiaozhen Ban <benhaz1024 at gmail.com>
>>>> Sent: Thursday, March 18, 2021 19:44
>>>> To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at
>>>> intel.com>
>>>> Cc: dev at dpdk.org; stable at dpdk.org
>>>> Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
>>>>
>>>> OK, but I think this bug affects all stable release about 6 years before today.
>>
>>> I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
>>> always use RTE_ETH_FILTER_GENERIC. ;-)
>>
>> eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application developer
>> know how to use the parameter filter_type correctly, it's OK.
>> otherwise he will get rte_eth_dev_filter_ctrl() return value is success but
>> actually is failed.
>
> After check with Haiyue, we think the patch is still needed for LTS <= 19.11, so
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
>
What is the status of this patch?
It seems it did not applied, and the status in the patchwork is "Superseded".
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value
2021-04-20 8:08 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2021-04-20 9:54 ` Zhang, Qi Z
2021-04-20 14:33 ` Luca Boccassi
0 siblings, 1 reply; 15+ messages in thread
From: Zhang, Qi Z @ 2021-04-20 9:54 UTC (permalink / raw)
To: Yigit, Ferruh, Xiaozhen Ban, Guo, Jia, Wang, Haiyue, Luca Boccassi
Cc: dev, stable
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Tuesday, April 20, 2021 4:09 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xiaozhen Ban
> <benhaz1024@gmail.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix filter control
> return value
>
> On 3/25/2021 8:46 AM, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaozhen Ban
> >> Sent: Friday, March 19, 2021 12:08 PM
> >> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> >> <haiyue.wang@intel.com>
> >> Cc: dev@dpdk.org; stable@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return
> >> value
> >>
> >>>> -----Original Message-----
> >>>> From: Xiaozhen Ban <benhaz1024 at gmail.com>
> >>>> Sent: Thursday, March 18, 2021 19:44
> >>>> To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at
> >>>> intel.com>
> >>>> Cc: dev at dpdk.org; stable at dpdk.org
> >>>> Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> >>>>
> >>>> OK, but I think this bug affects all stable release about 6 years before
> today.
> >>
> >>> I don't think so, since it is PMD internal ops, the real API
> 'rte_flow_ops_get'
> >>> always use RTE_ETH_FILTER_GENERIC. ;-)
> >>
> >> eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if
> >> application developer know how to use the parameter filter_type correctly,
> it's OK.
> >> otherwise he will get rte_eth_dev_filter_ctrl() return value is
> >> success but actually is failed.
> >
> > After check with Haiyue, we think the patch is still needed for LTS <=
> > 19.11, so
> >
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> > Applied to dpdk-next-net-intel.
> >
>
> What is the status of this patch?
> It seems it did not applied, and the status in the patchwork is "Superseded".
The patch is dropped during rebase, as the function eth_igb_filter_ctrl is removed at below code refectory
http://patchwork.dpdk.org/project/dpdk/patch/20210321090002.595744-2-thomas@monjalon.net/
this is a mistake as we still need this to be captured in LTS
unfortunately, its too late to capture it as the refectory code is already applied to main tree.
@Luca Boccassi
Could you capture this patch as an LTS only one?
Thanks
Qi
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value
2021-04-20 9:54 ` Zhang, Qi Z
@ 2021-04-20 14:33 ` Luca Boccassi
0 siblings, 0 replies; 15+ messages in thread
From: Luca Boccassi @ 2021-04-20 14:33 UTC (permalink / raw)
To: Zhang, Qi Z, Yigit, Ferruh, Xiaozhen Ban, Guo, Jia, Wang, Haiyue
Cc: dev, stable
On Tue, 2021-04-20 at 09:54 +0000, Zhang, Qi Z wrote:
> > -----Original Message-----
> > From: Yigit, Ferruh <ferruh.yigit@intel.com>
> > Sent: Tuesday, April 20, 2021 4:09 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xiaozhen Ban
> > <benhaz1024@gmail.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> > <haiyue.wang@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix filter control
> > return value
> >
> > On 3/25/2021 8:46 AM, Zhang, Qi Z wrote:
> > >
> > > > -----Original Message-----
> > > > From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaozhen Ban
> > > > Sent: Friday, March 19, 2021 12:08 PM
> > > > To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> > > > <haiyue.wang@intel.com>
> > > > Cc: dev@dpdk.org; stable@dpdk.org
> > > > Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return
> > > > value
> > > >
> > > > > > -----Original Message-----
> > > > > > From: Xiaozhen Ban <benhaz1024 at gmail.com>
> > > > > > Sent: Thursday, March 18, 2021 19:44
> > > > > > To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at
> > > > > > intel.com>
> > > > > > Cc: dev at dpdk.org; stable at dpdk.org
> > > > > > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> > > > > >
> > > > > > OK, but I think this bug affects all stable release about 6 years before
> > today.
> > > > > I don't think so, since it is PMD internal ops, the real API
> > 'rte_flow_ops_get'
> > > > > always use RTE_ETH_FILTER_GENERIC. ;-)
> > > >
> > > > eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if
> > > > application developer know how to use the parameter filter_type correctly,
> > it's OK.
> > > > otherwise he will get rte_eth_dev_filter_ctrl() return value is
> > > > success but actually is failed.
> > >
> > > After check with Haiyue, we think the patch is still needed for LTS <=
> > > 19.11, so
> > >
> > > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > >
> > > Applied to dpdk-next-net-intel.
> > >
> >
> > What is the status of this patch?
> > It seems it did not applied, and the status in the patchwork is "Superseded".
>
> The patch is dropped during rebase, as the function eth_igb_filter_ctrl is removed at below code refectory
> http://patchwork.dpdk.org/project/dpdk/patch/20210321090002.595744-2-thomas@monjalon.net/
>
> this is a mistake as we still need this to be captured in LTS
> unfortunately, its too late to capture it as the refectory code is already applied to main tree.
>
> @Luca Boccassi
> Could you capture this patch as an LTS only one?
>
> Thanks
> Qi
Please rebase it on 20.11 and test it, and if it works send it to
stable@dpdk.org with --subject-prefix='PATCH 20.11'
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
@ 2020-12-08 8:02 banxiaozhen, benhaz1024
0 siblings, 0 replies; 15+ messages in thread
From: banxiaozhen, benhaz1024 @ 2020-12-08 8:02 UTC (permalink / raw)
To: jia.guo, haiyue.wang; +Cc: dev, banxiaozhen
From: banxiaozhen <benhaz1024@gmail.com>
Signed-off-by: banxiaozhen <benhaz1024@gmail.com>
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 647aa8d99..8695426c2 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
default:
PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
filter_type);
+ ret = -EINVAL;
break;
}
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-04-20 14:34 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 8:10 [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported banxiaozhen, benhaz1024
2020-12-08 9:04 ` Wang, Haiyue
2020-12-08 9:58 ` haz ben
2020-12-08 10:40 ` Wang, Haiyue
2020-12-08 11:05 ` Wang, Haiyue
2021-03-17 9:15 ` [dpdk-dev] [PATCH] net/e1000: fix filter control return value Xiaozhen Ban
2021-03-17 11:23 ` Wang, Haiyue
2021-03-18 11:44 ` Xiaozhen Ban
2021-03-18 15:28 ` Wang, Haiyue
2021-03-19 4:08 ` Xiaozhen Ban
2021-03-25 8:46 ` Zhang, Qi Z
2021-04-20 8:08 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-04-20 9:54 ` Zhang, Qi Z
2021-04-20 14:33 ` Luca Boccassi
-- strict thread matches above, loose matches on Subject: below --
2020-12-08 8:02 [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported banxiaozhen, benhaz1024
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).