From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25C60A09E5; Tue, 8 Dec 2020 10:04:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A20AA3; Tue, 8 Dec 2020 10:04:25 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0383F98 for ; Tue, 8 Dec 2020 10:04:23 +0100 (CET) IronPort-SDR: DCWLIsSmyH7+ESntdHCbGPPk7uyHEzj2vTvga09B4burycuq+dW0Ue6jV0Vd/dbSBudV4JRfMJ rJDudNv65Bdw== X-IronPort-AV: E=McAfee;i="6000,8403,9828"; a="173092931" X-IronPort-AV: E=Sophos;i="5.78,402,1599548400"; d="scan'208";a="173092931" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 01:04:19 -0800 IronPort-SDR: Wui1nzy+k8h3GxcKzpvlg1M8zHtv0HWwWyOn2sYKhK204yI6hXZu3a7sOObM1Q52W4eS9xnLYr 5lL4StC0bohw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,402,1599548400"; d="scan'208";a="337521577" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 08 Dec 2020 01:04:18 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Dec 2020 01:04:17 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Dec 2020 01:04:17 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Dec 2020 01:04:17 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Dec 2020 01:04:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PgyEXIx091ZzkPt6Qu9+Fiz7RXFhqQklVK6IHl/9q/P8ygLsO2kz+EvMFod6VMOvXmJCwy9+DI1ERTCyUYBYq+7q+fWeItT0vO0T1qU0krxtEpBiddhsZ0dnxdVARD5dSHscGHjVAkbzWuL2i9XB2PXZeu5cLWb/vbiAd504Ln/XZEuAchnILhcufJKodmrxnUMunFbaV0lFfxfyu4OK5JseBoYQTZzC0rQGmhqGQTU+xVznCEDRJwrFUM8ecQ8fS4i88GlAooMHdvxghANlBqhdOIpiemzbaOSxFg5NmxSacY/3jN2XtZGc+7n+tgI00FhawYmZzGccsyEwySD0Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6zs2wYWF/4PIcX4I2fKnxJxiVKVLDAqp5XSbHe56d2Q=; b=WGITR+wm/T9ByDMKLbDAs28FbUwq3wQOgn+0b5D7pdm1rD7bji86gGs9oGg4FAkBXLDPlTZjvV36MCE/i4FTTdsPBBaXiE8Sz9OIAWSlIuvK7TDf7R3cGwLTOw1Gl0G5Tyl7S4V2o6ZcrLEP3gWsPxi+eCj2CcI3beHdeX/0Q0FaWztVUczpqjgnsdgd5F4KGeCXYUWqiNJMvrMvv55K03iZ38YHPVEvE73OXEzdwCcc6MgslBESK4J/LVMtmxpG6NIztH5QQwiGD67hMq6oHGk9ua70CG96DE4z1IFeNrhI5OHcU39t3p6pe2iu0DK5n9tbvWE44sRWkqHJhLcpDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6zs2wYWF/4PIcX4I2fKnxJxiVKVLDAqp5XSbHe56d2Q=; b=eUn0JKR4TUTgqhAcawLOtdm4s751XUKzlKCVuFlF4FkdpCtm/5s42aqpZRYycbpbkcRq1xWMrFMBNgda8W+xOKhukp3k8WeMQVJuyE8+M4wt+zq1cdFdGFUhXmA1VyCNnlivjtSEQ8Y489WYOQcYkDNLk/nkRUtITe+yR25uMRk= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN7PR11MB2530.namprd11.prod.outlook.com (2603:10b6:406:ac::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Tue, 8 Dec 2020 09:04:14 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::6023:fb44:aa7b:cf29]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::6023:fb44:aa7b:cf29%7]) with mapi id 15.20.3632.018; Tue, 8 Dec 2020 09:04:13 +0000 From: "Wang, Haiyue" To: "banxiaozhen benhaz1024@gmail.com" <"banxiaozhen benhaz1024"@gmail.com>, "Guo, Jia" CC: "dev@dpdk.org" , banxiaozhen Thread-Topic: [PATCH] net/e1000: fix incorrect return value if filter type not supported. Thread-Index: AQHWzTmgBjovx8xVB0S0FrXHSySesqns51ng Date: Tue, 8 Dec 2020 09:04:13 +0000 Message-ID: References: <20201208081006.35125-1-benhaz1024@gmail.com> In-Reply-To: <20201208081006.35125-1-benhaz1024@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9085f349-4eff-4f85-b792-08d89b583c05 x-ms-traffictypediagnostic: BN7PR11MB2530: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:176; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WYs2gWcU3uPXfAoecPu85q68Cilyl9Ey2Klg4XyCgM+4KA+xvp+LiZLJzdZjOOZXI1eSteq29L3qDmqY1klM8HEFzO2fjt5LZ6CvPw1zSq0bb5pUBkNhijNdjW5TILb40rALriYXMJg5GVWeqvKz8JcWjh0/N+42O5wwDDvOBJuVoQbWF0iHT4QiFr1eh6K7JATct8ma9OyOEOMjx13LXl2uRB+/EK1x4KPo/imL4xJz3pJsUQOcdgcZElgWAsHMa9WIDOFLqekCYG94SOut8HJ7C42pVVn3Vg42vCPEWUhw5OIb9zuzslpsvICBJbKvwC7ukBxZ9F5wn3XWxqpxGQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(39860400002)(376002)(396003)(4744005)(64756008)(6506007)(4326008)(8676002)(66556008)(9686003)(83380400001)(71200400001)(53546011)(6636002)(54906003)(86362001)(66476007)(26005)(33656002)(7696005)(478600001)(76116006)(66946007)(52536014)(186003)(316002)(55016002)(110136005)(66446008)(8936002)(5660300002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/IuRSvKg0OQHDkMD/aey0hodkeclLZKBDV0eO+x91fmDyVhOw7KGYRpSQZXH?= =?us-ascii?Q?sVsqGiv1a2JIZnIVY+L9EDtiyWzIXucswgKRbSwresyStFuIjAM67iGWhCyL?= =?us-ascii?Q?h92IOL8gKUBQNIYFlHVmI/LgJ2DHf5HMdCUFrGMHUsIo95RKNL9gfqFcrULj?= =?us-ascii?Q?0OnIf0JemTPr/R8Jv5CUBVt2cpaAFlc6eOwsMOME0iI0WSAfAz7D+OS6lrPC?= =?us-ascii?Q?KzNHZ0D4k1tsbKeNJobZW4S6pQmf/MS4prioH51bp/EPKyJGZV9QtdnQHBkv?= =?us-ascii?Q?RIVo5NFvkMglCo+frBuN5oNGtIIZn0OnT+ItxXz+g9rKR7CjgG9aQ0zENaPW?= =?us-ascii?Q?WKf7J7DVzH3t3JNsXcHmKnTJHZh9e06N8xKYCJc19ts/TMJ8vQpMQ1R+PTvE?= =?us-ascii?Q?QfyeHoTZFQ23TLTVXmmgSTeq227xY5P4xkBHmr61u2Oah7xSEuVRT+19Mm9b?= =?us-ascii?Q?GYvUO0ysaVKBSIgALy9DSMm2LjRRqzIIfClu+EhJcMvmU+f1iWkTTARmp4Fy?= =?us-ascii?Q?BQWXA1xhRCot4HHXc96Shfin99nKqPFTwucu1CFHNidgd5mWLDyC0qik9j6h?= =?us-ascii?Q?OKsCUI1C1+AlLNzNyg2JZnKGSEEG8jv2ZYbz+RTPfW7Ak6EJuZoiXn+0r66H?= =?us-ascii?Q?tdzr4g605a7a0s+mjmfjocPBDKTJUnD2CpV+ophJtNrVi5GYPgdswz105w3X?= =?us-ascii?Q?dKphi/HnKQo3dGcrjolclydFbRCyFSf6E9ISvRrve2p0TFNs6EW0LxQe8KTB?= =?us-ascii?Q?/9vXByu9FwyPmeWGl1kXZWxoqCEJ1jQ2GmeQC6dGdYy5Skonsdkz7HC3i8aQ?= =?us-ascii?Q?6RsQYuicO1vZonEgcuNXiWgzGRhmSyCsdVGsJERKA9IDRSEin3K9lhp+YATJ?= =?us-ascii?Q?2RayHGBo/lMBiPtoKbXLhPpSnAFNgPQCoCydBtUx3ANH4dO++hWm3vikh6n0?= =?us-ascii?Q?v5lTRnph/j50N9czalvxfk/ZuCYYV+pNB3SjOywr5b9TdPNx1QjZexrYLuQ9?= =?us-ascii?Q?VqfZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9085f349-4eff-4f85-b792-08d89b583c05 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2020 09:04:13.9010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XBJ6afzZmC6UTKN0G18jefsKzN/nm/ZJ924I5aXmR8fO8JTkiBazE5anDLX1DR3ES7UbPxSTOmodbTFj+Wufuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2530 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: banxiaozhen benhaz1024@gmail.com > Sent: Tuesday, December 8, 2020 16:10 > To: Guo, Jia ; Wang, Haiyue > Cc: dev@dpdk.org; banxiaozhen > Subject: [PATCH] net/e1000: fix incorrect return value if filter type not= supported. >=20 > From: banxiaozhen >=20 > Signed-off-by: banxiaozhen The patch looks good. The name format should be like "Banxiao Zhen", and the commit message is em= pty ? > --- > drivers/net/e1000/igb_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethde= v.c > index 647aa8d99..8695426c2 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_u= nused, > default: > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported", > filter_type); > + ret =3D -EINVAL; > break; > } >=20 > -- > 2.24.3 (Apple Git-128)