From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A847A0524; Thu, 6 May 2021 12:31:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 078D9410DB; Thu, 6 May 2021 12:31:59 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id B38B040040; Thu, 6 May 2021 12:31:57 +0200 (CEST) IronPort-SDR: rh6+TbBU/7Ii0RjOGxxXEY2kJegVG7jCaOfy5jJZ+qApvKlldygrqTw0QpKn5N6IpBzJi5ouuX mufvrVSRTSlw== X-IronPort-AV: E=McAfee;i="6200,9189,9975"; a="198078516" X-IronPort-AV: E=Sophos;i="5.82,277,1613462400"; d="scan'208";a="198078516" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2021 03:31:56 -0700 IronPort-SDR: z2CCxy8Bsut6dJ+a0AGEZbZ0G8aq8YE6/sGaZT6OafST3kkmLc22en0Ie6g4U1kRC0vHng42Au 8dKl86Se6NzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,277,1613462400"; d="scan'208";a="434286728" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 06 May 2021 03:31:55 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 6 May 2021 03:31:55 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 6 May 2021 03:31:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 6 May 2021 03:31:54 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 6 May 2021 03:31:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dMuFDfIQ+zakDuWAMZHixifcFVqN6gMo8hyPNnZzXw7nAltwVGacEeYaf/AJfAJhhELFW8xdKIXrNX5RdJSdFf5r5U4tGTFjsOSFsmvjlBcnD1wP5EN4BOrEXMspxSFhaZS5n4RZkxARG5/aOESJgq2QpDLcDWiblLhvmFIVG42t3LqDnzxURW09dnhf2k+CTc+OjuyjEUtVQzsyqBPwyPeBrpvstntqD379kLn8Og7L/0kUpRfphRoo1tcgjKrmN3n6mqvzzRhk7qmuCLCQ0JQli59KhTkjleQxE/SnsDepdZW5WqMsc8kUUnMp9gbCjNSvin2f5LEwx3P1wI44fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PKwPIESPBffcfSFnqFQmqoRRGm9e7ZjSZY9O61jQ/Co=; b=VOMMa35o1IFXn1kr5V3TKZPl+2XqkZcloB+to+kvfPe+b0igvStzUyizwtyRIy+ejZMi1oxbh8QR31iSgXoFnUZ+UbbbdWTTqXULL3UCJMOmoY/nyov5KwMiJIRdzlSUXVqA77OzpGSJPA0GKHZkchDGAhC0QA6XXOrVYtqIGIFsP1dgiIZi3klHoHB6t8oJjKMSvHdo8scfYQmbPdyARO0HRyT8mp4d+G8JOSHwHh7sQEDLRe6Wpj0T9xFIPr87PEgoSgQwH0ZPC4sUSUAnN96/Sd3FZDREjK1ti6tQ4EDt2AVQqtSyjdDokfvCIiiKlwxl74BUv/X/tnRZw0jAXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PKwPIESPBffcfSFnqFQmqoRRGm9e7ZjSZY9O61jQ/Co=; b=xB0KwF3pYKIEo8W4JkJRrHb9n93TLO8kgGlkfYykld2+hfFmg/Hu74uHziYIEBjTcmHP7LXAgh5JREaYpgvz0Zp6SOVw/bSCsQQfJ4TRkK4jyWl2F6KHcjolP2OD6qkvjx4i8GMFWe2q7J+YkOw4NRCCQZWvk0lb5OhlfQ+Eklc= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB3969.namprd11.prod.outlook.com (2603:10b6:405:77::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.35; Thu, 6 May 2021 10:31:50 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.4087.045; Thu, 6 May 2021 10:31:50 +0000 From: "Wang, Haiyue" To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhang, Qi Z" Thread-Topic: [PATCH 2/2] net/ice: fix leak on thread termination Thread-Index: AQHXQlyUK4uJOBVH3Uqzk2o/I8kSDKrWQOfw Date: Thu, 6 May 2021 10:31:50 +0000 Message-ID: References: <20210506094452.1689-1-david.marchand@redhat.com> <20210506094452.1689-3-david.marchand@redhat.com> In-Reply-To: <20210506094452.1689-3-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b9d34fd-679d-4458-b4dc-08d9107a28c1 x-ms-traffictypediagnostic: BN6PR11MB3969: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GSe1I06OowocbanlFJkPcj74QnzYyvdqtILTMO7R4sWbS8QHvCt5K78ewUnJ83EclYlnAUSjlHQcy+alSXRBKWhdn4u/Ag0RqKrs3+OUdXakPxnXeADGLvdBObA+k4+DIdLYmC0gGS1nHls0tA1R0icln017Zbl+BGK+gko+oCI9X2qRwHBp1/h7rYOhlIZix513AUJngkhjk28MxXWUWCpS+yvjXIfk4juj706Y6mn8LIjuV1JxBedEF4EyjGLvs9yLLHFGMLI3VNRigtW2MMYYYS9J7JKyKI4JC7uT1N9nxh9PdMhCvKCujX2ah+7MgNeP5Ssm7kHpXy7OZw7DT6oSfCmWVFiqz2GsLZL7c/SEsCtdlxb1X3UXd6XfjuebFrIbROsS5PuQ7H5QSG3lJCq4jJD9ojxoMCjxUQGppglUXusgvdB2RwmPg+Vdbfl+u/V4kg5HjyeT+TdvNsPFOG/zvGMUHh8GisWQTz1ertpkgqOup9xMd3JRFHRjrXkWiEn4RxleGqhcOop4IiJUA7UfH/avk6iDI9o5lxandxvnhlhurlSNfCQrCEeOmij0ICtinHReow6ykCmXWMoy26GCWxKqzwgkDFk0aGh3W5Q= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(39850400004)(366004)(396003)(136003)(186003)(83380400001)(316002)(5660300002)(53546011)(71200400001)(4744005)(38100700002)(478600001)(76116006)(8936002)(6506007)(86362001)(2906002)(26005)(107886003)(7696005)(55016002)(66946007)(64756008)(54906003)(33656002)(66446008)(8676002)(9686003)(122000001)(110136005)(4326008)(66556008)(66476007)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Sj5PswBYs3ZnMHlacFQC5Lgacey+R44jMFl/6xE73ozQNLBMjny/Pht1xxRx?= =?us-ascii?Q?OarHHjyUohH+Iog6fCzh2uV6aSaXyqe8o/oebYSCARpz7ojVpoP0hdi6Kt4y?= =?us-ascii?Q?3g9S68G8NifF7hvNr36vLD/1mcigmYITb12uISNv9zB8T7MOpiyjofwwWroH?= =?us-ascii?Q?EGOZVGMgushRVuUpb/oDAbeuW9OGORqwjGKnmp5TcBfJD+sGhtc8xhDiTNGo?= =?us-ascii?Q?O+c/P6ZV9TwOdt+1TysVO9RGselOajZjhBlAlbEOvBV6wCnLQpSAWCrn4YTr?= =?us-ascii?Q?dNHjC9A6DQO5gZvpLlbn7E6SHDKEP+LyJDubZBheUGwTqwcb8YMUqXUyGjnX?= =?us-ascii?Q?1ExadUE5SR5KUjXEsw+1qHoj/wOW3Xz4vtQGmDOL1Q+LH0SODXxdJ6hejgb7?= =?us-ascii?Q?u9N1OT4k1aSBRFg56ieiu4F8Oq1JbpZc4KKSHJ18I00js7Kne3Bnd+1UGdtW?= =?us-ascii?Q?Vvf+x2P7HQeTbYTFdVvuZ6/owW5YMzZzRns+PBwUaPazwuo/GjQTyIUotISQ?= =?us-ascii?Q?zJthYqV7PRF+FRWze0PPHC/akRt5d3BiPu+TDMSX6RBDSq6j4dnExj7d0hPU?= =?us-ascii?Q?AHHEWOtLKP51ChcJD7MnauWdWiAqbdcGyDs+qn9GMhFl0B2BRGAVgTUEu/xm?= =?us-ascii?Q?kPQMAtNLDhwNbK5z29XBQmDa33b7nDLEDNbTnc7L+l3ij3qk6yC1lQkqoqCz?= =?us-ascii?Q?fp7OtbmyzJHE165L2LwWpoPtaNEQTWZYt0Se5Z8bSgX9tTvjq5Kyvtc2t4Yo?= =?us-ascii?Q?JIWGJjB7wTElPkQs72OC3R7JRRcD4qHt+DuUVV3UjgBERW9KCE2lzhhL3kaV?= =?us-ascii?Q?ocYnJTmQxCzWJhwntQdyj8uMAVzEUy3V/OCjc/SLSttwJHwUPA2gcV16L4n+?= =?us-ascii?Q?LDl7vHdX+RSxhEVFR1/E5Z9mM5OzKWaBZGi1YmLWoG5dVyva5E3b8eOh0yEt?= =?us-ascii?Q?pt7Aj/uYMkzQkJ4h7pJROf0frSsPXjAarNQ4M05FYLWU+KpwufUjeihfdoDP?= =?us-ascii?Q?bMi6ssaZnbCrHKODlneBAS0FkgLugd/yjurEbZiVjqTOT5LOulxjqLcAKFHo?= =?us-ascii?Q?fhw5CPVHntj4o1mcXEK0mTrilsP+Wkco5PyLbd5v3+7Rid9tvI0qMMvUfWCh?= =?us-ascii?Q?YmbAqqkLLMDAbrUZomwACfsraD96bi0vXSEpW9zH66FIEAO85LXfdZ9UTolv?= =?us-ascii?Q?NU9QKtg0bE5RfAzjiuEVG7/XjPs+xsQF8IZGd3zj5iyKmBP+H6qBwaT3iDXw?= =?us-ascii?Q?5ZaEhQyKyV1OvrFCPuU33sFpDY+70ipdZ39YO/bcYHbigvWthahzQZwRc9tX?= =?us-ascii?Q?/dx82M3uXzSqKKXckjZMMmEV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b9d34fd-679d-4458-b4dc-08d9107a28c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2021 10:31:50.4134 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e7u5MWVnx76d2vUQwYqzKRTiHNTQt2mW45m5JJRbQ8RWVan6smo7vEmU4ouc4aei04GmntZIWqqquLv2mBJ1nA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3969 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] net/ice: fix leak on thread termination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: David Marchand > Sent: Thursday, May 6, 2021 17:45 > To: dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhang, Qi Z ; Wang, > Haiyue > Subject: [PATCH 2/2] net/ice: fix leak on thread termination >=20 > A terminated pthread should be joined or detached so that its associated > resources are released. >=20 > The "ice-reset-" threads are used to service some reset task in th= e > background, but they are never joined by the thread that created them. > The easiest solution is to detach new threads. >=20 > Fixes: 3b3757bda3c3 ("net/ice: get VF hardware index in DCF") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > drivers/net/ice/ice_dcf_parent.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 Got it, thanks! Acked-by: Haiyue Wang > -- > 2.23.0