From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC924A0548; Wed, 21 Apr 2021 08:56:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3854C4195D; Wed, 21 Apr 2021 08:56:24 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C927341932 for ; Wed, 21 Apr 2021 08:56:22 +0200 (CEST) IronPort-SDR: svmx+MphEIB/GXIj1DU4IWMmG+K8Qio1xKDPfLqnQtIG55MftOskmAIuoVDsQhVkVC+yGO2jAi 21e1y5y77rRQ== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="216285834" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="216285834" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 23:56:21 -0700 IronPort-SDR: pjLvWYUmnsoC2XEOMBYdcR3sJ7Cp6I/fBd7wjkYLP+OoENr9L90b0IdRZFsXzR3vrWzX8YN0XD 736nvLgYiK9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="463479389" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 20 Apr 2021 23:56:21 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 23:56:21 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 20 Apr 2021 23:56:21 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.55) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 20 Apr 2021 23:56:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ewjvH9faMuEeE2EFMQlg8Gmwc6KExqnwgTpKwSoraS41CyhB+Am4VXMx/yFvr/eYVaysl7nzOXCNFdTRY56nP886lyz6e5WZo29v8IIyacMGd/zflxqq+R52ub6PHnlfjEKT1VDUmXYB/v5CcEdlS/7TLlncO2kRojgLr+AL7pQ/BhqirW3r0HxKvFd0HBTWD5VVtKurswPQ148yfIhaBt1bDCfd0aY9MkiGbL20fb9q+kt7ysnTqqs8sH9nlvw/6gg+th++NG54O7m9fQWa/CTLZhRE/cZyCNDoagf3Sc0pB0xACvsW1JT9X40gTHNIrXAxTtV7vK+GyLhXAYYWFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hIhtu4Wn23NfbrY8pKJBmvTV3aebF7slx2Owh1cBJhc=; b=Mi+VKyzETSTewUoTm9BP4bWTLj1vgEj9DhzuidpMNX7VmPu/MhKNgtFYNey2OWMXIO0Fyf4Jo4Toc+7g9rS/s+80qSszuvsHX7tL5Tw6b8TPOX+SIvKQiCvzQtjA9D8AjNcH8udXXdPPONWgK/nSqQE2all6ltI3Bjv92VVCm9WoE4ZQkV3SUoOlL9ZphV/jlPYZ0k9DEbQ10Tmm6Vk0vsMG9IXIARXSXlAPqV9flTHMfyPgMcYKG1gkUz/VBYIvWvOGJMsI3a8UXmBCLKRW5z9oeGgKyVMjrrAu7aFokwgqPA7K4DLJnEnsCvU8EskUa2YdyoFkNUmi4SIcjox/+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hIhtu4Wn23NfbrY8pKJBmvTV3aebF7slx2Owh1cBJhc=; b=k/WjxOH9nRgIBEMBLhV+0TOPlV7ZfP3dytjIi2nFO57BLathskzrl65B4EPmvRJV7ZAf/mpoR+0rYU/AcV4+S397SbtkVeb0JYYoiysOFWm2iSB8Mc6TXOn+3XosKTwHUWebwS1BlUstCgB8NXKoyKNnFdoCQkZb7tUlr7mrm8Q= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN7PR11MB2802.namprd11.prod.outlook.com (2603:10b6:406:b7::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Wed, 21 Apr 2021 06:56:15 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 06:56:15 +0000 From: "Wang, Haiyue" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Guo, Jia" Thread-Topic: [PATCH] net/e1000: fix write NVM srwr alwayes return success Thread-Index: AQHXNna8pVV44xMa+kSC1LjqGyVssqq+iQ1A Date: Wed, 21 Apr 2021 06:56:14 +0000 Message-ID: References: <1618986145-15414-1-git-send-email-humin29@huawei.com> In-Reply-To: <1618986145-15414-1-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc8d7d11-207c-4992-c69a-08d904928e6e x-ms-traffictypediagnostic: BN7PR11MB2802: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:457; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mkCXcE2+wCaoprYY9o9HuRl1MeM97V1Yr6F5TtvitzfYAIMbGf660O9YIwFtprkm4IVSooOyJ3DqKJa/BqpYWzlM3nPGhOSquN7kx3lV8zszMnReq6MRdQ5qaPzqHvxnFE32yyBOY4wMMk3ecviupOPjh3FZwni/mFNrQXIWDXRdlGoAXVmEoQCXSky87Dlh7zsnGGv4Xqit4EwqJj3yVfAIIdFrmRMDWqOZcuj0GAmFGlmQAY3JKeZmyRffonE/6tBSYGYveMHV8Fi8Tuhk6+uZWfAGH1BMDO8Fn07QRw+KpFT3nSxb4YEJInZSCY0Fp90o/JkhovEGVtdRkCF88JLQwbYxzsUSH0nEpvMEme+IoA0gCWds26VvkFS9VXYCl4vkTUoxTMvUbvWRz/5zrhgX6q8PDhbj7dY8Bng261P4vKn41TS8/Uh1t4KkJe4jrUwuvdNNSGRDjkXKGABqPAb2WB8bCxCHBseL1m/NIV67MpMzxmlYn6z9P0iETqT6yeFCLHTHkwifZF9Tvibrt2wYNdcMAPfjqLXMWg/zeiA8yN+CJiQe7MV8aAgdLmnMAXHHsdoWjKp4i57BKhH45F0JISPKFAKmjwO67acZnz4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(396003)(346002)(39860400002)(366004)(26005)(2906002)(107886003)(38100700002)(33656002)(122000001)(4326008)(9686003)(55016002)(8936002)(66446008)(66476007)(64756008)(7696005)(66556008)(478600001)(53546011)(71200400001)(66946007)(5660300002)(76116006)(52536014)(8676002)(316002)(54906003)(186003)(83380400001)(110136005)(86362001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?bkXnZZl8DQ7Vt7SEdaOzv07wCwaOT3dC8sioMDX3Mjq4aOSkUDNzGuzHPQ4B?= =?us-ascii?Q?T70h+4EIjFh8oxliVSd2Z5W9BHR9iuCjGmPWziTnQQ5J/UDcfHQjG7uCfiQU?= =?us-ascii?Q?UJzS4/zC1AcX7BgRKNkGwV9vnnvcP4fjb4sO+xyrSUyfaJnIPs8HXfxsYVdJ?= =?us-ascii?Q?c2ftUmTmPnpPs1jLzhZW59mhrGTksyw48ZY/UUHYv84byE1ab9G7vMmTCAf0?= =?us-ascii?Q?/y9xtGHkqv4pY1ZBGPMXXGcYd78tFYOjSrRgH7N5rB6y40uDlaPiIl5Zdohd?= =?us-ascii?Q?kKM/PGgFxUlBSR2G1axOs4j9+8MJ1HPBsz8NcQjqlhx+yajhUJ+urS7DKTnP?= =?us-ascii?Q?Ct9MgIOSBSrZFlzdPGuu4bLGentl8QU+pFufSmzm9splBmIDI0FWl7cJMRwX?= =?us-ascii?Q?kvtdxQff8uclNUhYWbUCyKHp46y7shLp8HKVekwwoXzcIYNdv4PqJAMb0r6n?= =?us-ascii?Q?mo8ARZAi6VpGYUnmADHhvZKOJvsMZaHIlMCzxEDjjqbcM78QUrdjGn6yqJzF?= =?us-ascii?Q?a//qLMB93mJpSN/osqHy7QNJUUnR7mFYd4rv6qAiur5u3pulULFbotA2UXfL?= =?us-ascii?Q?fZTJ55wKkUQw3M3yphS9CfUYJzMz/RT4oAyM1rfDAcSOJW0KW5r9mDB5NONY?= =?us-ascii?Q?LwgQlkh2UajqFD97sQkk/BNIGIMBUR9wuuD3exF2oSKi+OEr8i54Jjx+E3oP?= =?us-ascii?Q?qsxKgRXSODxqImqwU8sKd8A7W/ojWbPFewhRw3hyDI/3MQcFcYu9Q7EaNEnj?= =?us-ascii?Q?AhF1gihvWaZTLicPovZwJ0wylt2nX32ZhHUXJpCt6Dw9bFRxnf6sayryv1PD?= =?us-ascii?Q?pIb+SQ98yxjDbtaYeiC/oDtvez708q27VV01kJbx+EDsU+xRUmRmv9pxfAGc?= =?us-ascii?Q?zz5jMbC31EUt+r1W85gWFOzE7mM+CzdlukaRoztQnAbPlYTGPvYh7MmLyomQ?= =?us-ascii?Q?exGTCQvI8zDFQSQhuWaGadN7EmWQWu3COdbHiyEffG/d6H6VJY/whhIivJRk?= =?us-ascii?Q?cJ1iJkdvRqE1LS9H03C9rAcN+p9AIfSTxq1BZE+5KsNKyO/ikFhc1d/EOy53?= =?us-ascii?Q?Ar4dFfNVBhnMzFC4AWs7kNJgkVEuEGNcynX3/rwcwMmtHcahv36EqJ54eR14?= =?us-ascii?Q?UJF/c7p9ln7mSaZ6OBAS4AfrVPeyKliHVwFIIZEUadHut2ccrkJ7LfvKhr+l?= =?us-ascii?Q?v83y6PndU2tHJCGzS9DJtysjgd2ERaX5KFdeM8oHCIgZ3GXzUeIIilEocI1u?= =?us-ascii?Q?pFe8s5m5/cgOTjmYPhPgbfmNfFajfxcoUDHdXQ/fQxz8lg6phD/vpN/ympzO?= =?us-ascii?Q?Ty1HU5TL6qTkqHQD4TkWgg3h?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc8d7d11-207c-4992-c69a-08d904928e6e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 06:56:14.9597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OYZ9UyqV7RuItx8m0OwPMcUg6Aw8dlmPm1PzQCiq0HQHWntdVLuEHjYG6GCtp0zK5ices8qY56cdSvvTwhQQ6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2802 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 14:22 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia ;= Wang, Haiyue > > Subject: [PATCH] net/e1000: fix write NVM srwr alwayes return success >=20 > From: Chengwen Feng >=20 > This patch fixes e1000_write_nvm_srwr() alwayes return success. This commit message seems not so correct, it should be like: This fixes the timed out for shadow RAM write EEWR can't be detected. >=20 > Fixes: 5a32a257f957 ("e1000: more NICs in base driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > drivers/net/e1000/base/e1000_i210.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base= /e1000_i210.c > index 3c349d3..615e7c9 100644 > --- a/drivers/net/e1000/base/e1000_i210.c > +++ b/drivers/net/e1000/base/e1000_i210.c > @@ -310,6 +310,8 @@ STATIC s32 e1000_write_nvm_srwr(struct e1000_hw *hw, = u16 offset, u16 words, > } >=20 > for (i =3D 0; i < words; i++) { > + ret_val =3D E1000_ERR_NVM; Should be "-E1000_ERR_NVM" as the below used: if ((offset >=3D nvm->word_size) || (words > (nvm->word_size - offset)) || (words =3D=3D 0)) { DEBUGOUT("nvm parameter(s) out of bounds\n"); ret_val =3D -E1000_ERR_NVM; <--- goto out; } > + > eewr =3D ((offset + i) << E1000_NVM_RW_ADDR_SHIFT) | > (data[i] << E1000_NVM_RW_REG_DATA) | > E1000_NVM_RW_REG_START; > -- > 2.7.4