From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE2FAA04C0; Tue, 29 Sep 2020 04:39:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBEF61D5BF; Tue, 29 Sep 2020 04:39:16 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2484A1D58D for ; Tue, 29 Sep 2020 04:39:14 +0200 (CEST) IronPort-SDR: O9RScKBmHD7NgdPNXLRpXO0qpA23EfVBPyg0I30CssOzMaDfhlQjGin8W5MNMW1WC8dCgHQCqX iBF+kwVKqDMw== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="149761344" X-IronPort-AV: E=Sophos;i="5.77,316,1596524400"; d="scan'208";a="149761344" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 19:39:13 -0700 IronPort-SDR: rY8oj80KjewP9s+rm1LW63NJ+xGzmnmMx5TvItdasXdjSiKPOnSSKanX+juWj7U3sjTJn5jnWt O71ezPdkFIxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,316,1596524400"; d="scan'208";a="513682120" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2020 19:39:13 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 19:39:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Sep 2020 19:39:12 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.53) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 28 Sep 2020 19:39:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aWF15Zh9z8Pp+fS4zNgKIvR7sUErJyF1jtNCzXPCaRoQvHjlaH+BgyrcW0FhPSe0BhBhvVmKeAZwpZJBvfmfpmrI1g1uQ+/eSMjUKtf0aYDrnOvJ/KXBgjx3dLT/mehu+8k5RAjH6OxMGLZNqVTfTi/pF9H6ex3T4mf7zqIzdvrjq9+cMP/UNBHp/DOQl6Ral1C9GH48Odh6G1nYPtZp+n7UbQ1SdVpZfGNs7gnektkM5enBQgrnveS33PqWCXA0L37l2ZmVg/4WqHDWJZsofx+zFSiyzFrhtpOzJ24DaT22Qx+8Z7yAKwXoLzW73fNwl/13TlqEErYXyGRnXmkGTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v6b0gG2NOwCu/P0LxsldBVIlAKqauQbIABTBsH4441E=; b=EJaOd4goRZv2pjzKZFKHLCVqCOiA2TzLy0DRZiBq6RuRuDhAL27oKcDqLiQL09ivCPImhOh5mtt5T28IHEWkJDfHpg0JqdaJ/NujLMdpd5tfPy/KHi4d93iTxff1BPBQDiFmX4mBfLrpWDWQRlhbaFS/7gB6KR+l4s65k9r6I2gm5VcHPfmBUvWySSHVxZriTE764HkzVK9noZ7drQC84DfPs+AeeKslwjpsc/QVpN07yzU4AsWCQKQ5v1vYY1FhU4RBemeuAfTwCzrl60vP9T8ai8W6tNTEnnsAhk84VJWzODHUFr6yaEqnKJdt5Sm5+MJHwVgNWh6ko4PbpLQVtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v6b0gG2NOwCu/P0LxsldBVIlAKqauQbIABTBsH4441E=; b=X6psmZle6coCnmuta9U5VSozBzUYzLIV/+ujSWs93nh6e6xC0MeeBPBT8VU3GlPJiA/cyivm450ECuYVHG3lF551OgsEZDnkSwZUPmoiPc/nBjWXDekes7/uPlmjV+bRbs2jvOAc9UZs+xRHrLHK3Uhl4pfTDYXb9nduNbt2rI8= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1666.namprd11.prod.outlook.com (2603:10b6:405:4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.25; Tue, 29 Sep 2020 02:39:10 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 02:39:10 +0000 From: "Wang, Haiyue" To: Thomas Monjalon , "dev@dpdk.org" CC: "Yigit, Ferruh" , "arybchenko@solarflare.com" , "Xu, Rosen" , Sachin Saxena , Ajit Khaparde , Liron Himi , "Loftus, Ciara" , "Zhang, Qi Z" , Shepard Siegel , Ed Czeck , "John Miller" , Steven Webster , Matt Peters , Somnath Kotur , Rahul Lakkireddy , "Guo, Jia" , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , "Wang, Xiao W" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , Alfredo Cardigliano , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Zyta Szpak , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Akhil Goyal , Jerin Jacob , Maciej Czekaj , Maxime Coquelin , "Xia, Chenbo" , "Wang, Zhihong" , Yong Wang , "Burakov, Anatoly" Thread-Topic: [PATCH v3 23/29] drivers/net: check process type in close operation Thread-Index: AQHWle1ihtJ9m+jlv0aqtBExxOI0fql+5mzQ Date: Tue, 29 Sep 2020 02:39:09 +0000 Message-ID: References: <20200913220711.3768597-1-thomas@monjalon.net> <20200928231437.414489-1-thomas@monjalon.net> <20200928231437.414489-24-thomas@monjalon.net> In-Reply-To: <20200928231437.414489-24-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7f841be-0098-41c7-a493-08d86420d860 x-ms-traffictypediagnostic: BN6PR11MB1666: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MD2EBCdOqNDEonBHEo1e/2LdpnYA9LR3JRbPZCu3Jd4FA+8j9n3mntpoDQu8BjVUK4OdHXl/9BeEjxI97kvzEPM0OClzm+MtrrhCHUOj4EfinPZ+iPbZ7Q9tta54+UNz2bCvGDA/+/aVeXBOyqeH1U91TfbRWj6StkfXPCiLZb/PSpyt8kq9IBzXQmXy5WEOpKLDKyU0O3aCM1rIrr7fmSRAz7BvwTf0eva2AaJ3vbmWGOiudPIwLNX6VQYE1CsUOQStrhViWF63dL+jGSLvLfETmHSdZVEmP+fMtmMVYWEINWB3X/4Btgmn45vAZk90/G004gq6+3u6oZaNNNdQvf0x9aYIYoOg5aT+IM8MBHkCmj1sjyJvzvrF3Qk+sUZQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(396003)(39860400002)(346002)(66476007)(8936002)(71200400001)(64756008)(66446008)(86362001)(66556008)(5660300002)(7406005)(33656002)(478600001)(7416002)(7696005)(316002)(186003)(26005)(8676002)(83380400001)(110136005)(6506007)(53546011)(66946007)(52536014)(9686003)(55016002)(107886003)(76116006)(4326008)(54906003)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: oL8PL24zav4tpk0AOstSA5SsaGOb+TA9BnSECHwCzqYTjzmfmzYbO2wq5PFtQjf8PykC+OYRBZ7p+r33MsWm3nQzQOtk/ZnxnQkW/jdJeTLvj9HgQsXzjsBFD6pY8ZKWDx3I4wtJxX1S97kLS0k0e7OHyka5eIms5GTHQFM2IxW+0dWmORInB0ZkWxl4LRAi9MhqW/My9OnaX/U3sQ3pK9r/kRZrYecdCA6cboRasG+knaoM/hqFCf/Bcv4z9WLNJFiiwCnFcmyynZSz5bTLzjKgBj8ikeypksILcuBnt5UjHyKHUuJta3cCe5Jphq4n36259eQgeQKeE1fAHp/dQBMs9qciczmmMaWMFf8kUPABOsCik2PISoa7II22m8pSt1eUP8urO1WilvAoRnB4FLrn41d6ej54ffR60O366PRnO0b6/ebqiBVB8OLapDn5QzTDdWJzrWO54AmkxsljuhKp4Z3rtEJ5nd8mP6fFA+8Vy+ViGirJhgl3zQI6J8jfddHInSPMuQch/3v5DEc4NZjqo3JnZcQ7HJFXhhlP38USIRTtp4nzCzWrBBKb5YN+IPCowUx2QYFLaEH9eBEdlav2ivEznpjOrZAZK1x01Kn/U/iHcfvLvs5H0pLY6hFsqmYroW7WJEYLzlUE92jLog== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7f841be-0098-41c7-a493-08d86420d860 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 02:39:09.8961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lN0N94ZnnHjGUyTpOjLIiYOsVL0YmA1esOqObRkDlJKhrHciZNxuLqKNOnF1Fu8wQyp6I0Cyi+g5XagchfgndA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1666 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 23/29] drivers/net: check process type in close operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, September 29, 2020 07:15 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; arybchenko@solarflare.com; Xu= , Rosen ; > Sachin Saxena ; Ajit Khaparde ; Liron Himi > ; Loftus, Ciara ; Zhang, Qi Z= ; > Shepard Siegel ; Ed Czeck ; John Miller > ; Steven Webster ; Matt Peters > ; Somnath Kotur ; = Rahul Lakkireddy > ; Guo, Jia ; Wang, Haiyu= e ; > Marcin Wojtas ; Michal Krawczyk ; Guy T= zalik ; > Evgeny Schemeilin ; Igor Chauskin = ; Gagandeep Singh > ; John Daley ; Hyong Youb Kim ; Wang, Xiao W > ; Ziyang Xuan ; Xiaoyun Wa= ng > ; Guoyang Zhou ; Xi= ng, Beilei > ; Wu, Jingjing ; Yang, Qimi= ng ; > Alfredo Cardigliano ; Shijith Thotton ; Srisivasubramanian > Srinivasan ; Matan Azrad ; Shah= af Shuler > ; Zyta Szpak ; Stephen Hemminger ; K. Y. > Srinivasan ; Haiyang Zhang ; L= ong Li ; > Martin Spinler ; Heinrich Kuhn ; Harman Kalra > ; Akhil Goyal ; Jerin Jacob ; Maciej > Czekaj ; Maxime Coquelin ; Xia, Chenbo > ; Wang, Zhihong ; Yong Wang= ; > Burakov, Anatoly > Subject: [PATCH v3 23/29] drivers/net: check process type in close operat= ion >=20 > The secondary processes are not allowed to release shared resources. > Only process-private resources should be freed in a secondary process. > Most of the time, there is no process-private resource, > so the close operation is just forbidden in a secondary process. >=20 > After adding proper check in the port close functions, > some redundant checks in the device remove functions are dropped. >=20 > Signed-off-by: Thomas Monjalon > Reviewed-by: Rosen Xu > Reviewed-by: Sachin Saxena > Reviewed-by: Ajit Khaparde > Reviewed-by: Liron Himi > --- > drivers/net/e1000/em_ethdev.c | 3 +++ > drivers/net/e1000/igb_ethdev.c | 6 +++++ > drivers/net/igc/igc_ethdev.c | 6 ++--- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++ For e1000/igc/ixgbe Reviewed-by: Haiyue Wang > -- > 2.28.0