From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 313B2A04C0; Tue, 29 Sep 2020 04:17:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C4081D5CC; Tue, 29 Sep 2020 04:16:59 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id B39B51D5BF for ; Tue, 29 Sep 2020 04:16:57 +0200 (CEST) IronPort-SDR: ON7DjvazVGkZG7d3JW/RMlftJi6mOUBDmFx+aH8Rw5lAW7+ncNDTLQeH07/0lHkAQgiFlQEK/N xIlt2mUg+JtQ== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="223689819" X-IronPort-AV: E=Sophos;i="5.77,316,1596524400"; d="scan'208";a="223689819" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 19:16:55 -0700 IronPort-SDR: KLnOIeYUezhhzGCzSNBrBXYLM5yjGMesAcLpWv0dHy35F6wB3F8ZQDmBZQYSnjPlFpUPe/F4Ac S08NLHwKwOlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,316,1596524400"; d="scan'208";a="488850227" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 28 Sep 2020 19:16:52 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 19:16:52 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 19:16:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Sep 2020 19:16:51 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 28 Sep 2020 19:16:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bNtyHY3OmVwn/7eU98F9tp8SMGkTo9OCnhqZioyQbjzc8ERWx+QTLaz4dcHvLvDvFaMJE+lTUgv3jEK5jDWjPr1qfJmatSNa+F1A72rOjXbNiRcP7ZCSjWfpHtpq+VAfDAe/+QjobT3pXdeljoSs0p/HAWV7LqaQUrGNCSBEJQsQlBeMLA4AlJ3S5VXVLyErN+1p3xd0EYQnHskScLJ9m9NTDvlJuwRoB8VpdwU9vRNUS7IWere8z3n/hTqfCOj3HlKaCwibnhB35y1KD9VB1lm508OCCVHp9U02ALEpEXs6rHlcjZykul7T2XF4DeC9Dao6EGzHMvLf5z2phB1x0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3c+Q0xMq84+qp5XYOYpY0GSi3I0JeCrrGveKO017V/I=; b=CE6V9xJpAZsLq754SIpuITU8Afh92WHVvcrGYKJixs81kB6J0lDHvWCxmWQS4AT8yLqhBDTys3RDc9t6PWIyRg0xY6F99fjkyIKmQhZAPAKdn7ueK7/V7Q+PFkZLXs6WY++Io1eO1QyZAxj9Yhgtv5f+t9zpmz3WiWP2W3a8zk7VtfPVS9/UMV8rX5ENIV4H3cstEHFrWdNoR+K9GmAgBvqcNOg1TiPcQb9fpXVH5logPJ1JPKk/TdpOW8tmjLNqiXN0O6M5wDAu6T5OUZZ9J1UUPwuvRrsdTGY/p1kh5FkXkVMJew0+MtpIALlmGiRO6ZKZjIhjP7ggD/agsxnwGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3c+Q0xMq84+qp5XYOYpY0GSi3I0JeCrrGveKO017V/I=; b=wcBVk7Vh9NThfQ9XpJUv2EBCPmkx/fSBsiv5xBymPtZRb7M+111/M2+Z6BPmz/ph+8ZrzFnXx8JmKSxtfIQsrm1FInVGpND2tZVXEmxMoqx2Sf7a16CUG8JaLf2HLtCEnnn2IWDQLiXR6jKVTkZbQLnLCUqFuMDiLkG/pGYhLYA= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB4115.namprd11.prod.outlook.com (2603:10b6:405:80::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.23; Tue, 29 Sep 2020 02:16:43 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 02:16:43 +0000 From: "Wang, Haiyue" To: Thomas Monjalon , "dev@dpdk.org" CC: "Yigit, Ferruh" , "arybchenko@solarflare.com" , "Xu, Rosen" , Sachin Saxena , Liron Himi , "John W. Linville" , "Loftus, Ciara" , "Zhang, Qi Z" , Shepard Siegel , Ed Czeck , "John Miller" , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , "Rasesh Mody" , Shahed Shaikh , "Ajit Khaparde" , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , "Guo, Jia" , Marcin Wojtas , "Michal Krawczyk" , Guy Tzalik , "Evgeny Schemeilin" , Igor Chauskin , Gagandeep Singh , John Daley , "Hyong Youb Kim" , Gaetan Rivet , "Wang, Xiao W" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Alfredo Cardigliano" , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , "Zyta Szpak" , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , "Long Li" , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , "Kiran Kumar K" , Akhil Goyal , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Wiles, Keith" , Maciej Czekaj , Maxime Coquelin , "Xia, Chenbo" , "Wang, Zhihong" , Yong Wang Thread-Topic: [PATCH v3 02/29] ethdev: allow drivers to return error on close Thread-Index: AQHWle1Oq+Xm8AfM7ka0S4BA5tC916l+4MVg Date: Tue, 29 Sep 2020 02:16:43 +0000 Message-ID: References: <20200913220711.3768597-1-thomas@monjalon.net> <20200928231437.414489-1-thomas@monjalon.net> <20200928231437.414489-3-thomas@monjalon.net> In-Reply-To: <20200928231437.414489-3-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d2136d2-cc34-46e6-7555-08d8641db5b0 x-ms-traffictypediagnostic: BN6PR11MB4115: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2150; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PTcJoHLZibDh4WK8CY9nyR5NIxFyqafZE8YiTKD4tocSn581x8G49/NvEe7Sd7qqj+0dFBqGCKEh7RDo/gUUpH5Zgvj8HpqiBvCRquoXQ5vymoyN1134o0zMcPsnKEfZJXaAS6VOq45kUyV3D6NkD+ZlbkqUK1P7qZEnPzS1eAWDCip0EGV7Z5AJi28/6WlDADb/HWCfGb7ugmlys17P39SAOag+ZCH7wLfc2ORmrYXOYc8ZMzC0UCv/o41HVby1gI38ZuwWvqnVnCrHuTmcGp5plE78N4U6HdR6LpB/sW5qSewtXE3BO1ZrghfuD2THGVTETqMWpteaXRauOpGjfMKfG1ICyD9mc/kQfm7o37FXNJakGtCB2ijCfPzuRVCA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(186003)(52536014)(5660300002)(9686003)(26005)(71200400001)(478600001)(110136005)(8936002)(54906003)(66946007)(6506007)(53546011)(7696005)(66476007)(66556008)(64756008)(66446008)(33656002)(8676002)(316002)(2906002)(4326008)(7406005)(7416002)(83380400001)(55016002)(7366002)(76116006)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: tMv7ye++jZYO5JnIehNbe8Zc4KfZ0ieQb5zRwRMQGd3h032F9mcEIqWFHYu47aXA4QpIptrPtMKohE6y7MymwuGjfZ10ZXGrWzhOwoLFz7fVh36AdjNWbOszSPTJouFCpaYsQgy/iTsWFbLOWCGfwUPgc/BNY+ChL4vUWf5EbS5ULZJwu/N55JQ5XvLNQFelQKTmCim6bMNzoLB5iVxsF2ca2Jfei0kg8ITx3dA5Rz1c2J6fL9sX/3Fsw6E5ndM+ydL0ve3sO0rK3ZvawsVkvKoKAoIVGs2KagqxaqpXThQ7pUhqlV+29pgvTVg5UHu2/sYgT6tUxn/6+6BaNJnf3ez9NhrxtVyz/P/3pTY7DbJcnO/wcIrvtb3LOinKowp1qI3rciILZewfeS6czeGSgwKjiri0yfCd8FokuEj4jKhXNP+FOjqWn9tYj6Z5VjiUA+nlY4ZANfA79buto+J3brxkuBLMyjmtXTvBx3kd4qK5G7iDXBIItMBxQNv9SU0NSOa77TeZSM0vdJgc0DHbUW5kfeDpNU4Kk2BPuv+OyMAPAk/zKmT/UFUrZvS4hoB5Ywylbz9GJs9qhzHoPMeaJEzVBHnQLoBm2ROKch9Dc1YUPLTjA3Ok7L73YCP6WgkAado7q+wsO6H2Ml48pZbPVA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d2136d2-cc34-46e6-7555-08d8641db5b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 02:16:43.1798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Avo0ZT6CsBusUEYAKSsOX9Aid6U8Bm4gOEmHsf7GApzwwncNDPGSxUKNTJHvjVXjbE+XYh5I8zxHu8QWPe8bHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4115 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 02/29] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, September 29, 2020 07:14 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; arybchenko@solarflare.com; Xu= , Rosen ; > Sachin Saxena ; Liron Himi ; John W. Linville > ; Loftus, Ciara ; Zhang, = Qi Z ; > Shepard Siegel ; Ed Czeck ; John Miller > ; Igor Russkikh = ; Pavel Belous > ; Steven Webster ; Matt Peters > ; Somalapuram Amaranath ; Ra= sesh Mody ; > Shahed Shaikh ; Ajit Khaparde ; Somnath Kotur > ; Chas Williams ; Wei Hu (Xavi= er) ; > Rahul Lakkireddy ; Hemant Agrawal ; Guo, Jia > ; Wang, Haiyue ; Marcin Wojtas = ; Michal > Krawczyk ; Guy Tzalik ; Evgeny Schem= eilin ; > Igor Chauskin ; Gagandeep Singh ; Joh= n Daley ; > Hyong Youb Kim ; Gaetan Rivet ; Wang, = Xiao W > ; Ziyang Xuan ; Xiaoyun Wa= ng > ; Guoyang Zhou ; Mi= n Hu (Connor) > ; Yisen Zhuang ; Xing, Beile= i ; Wu, > Jingjing ; Yang, Qiming ; A= lfredo Cardigliano > ; Shijith Thotton ; Srisivasu= bramanian Srinivasan > ; Jakub Grajciar ; Matan Azra= d ; Shahaf > Shuler ; Viacheslav Ovsiienko ; Zyta Szpak > ; Stephen Hemminger ; K. Y. Srin= ivasan ; > Haiyang Zhang ; Long Li ; M= artin Spinler > ; Heinrich Kuhn ; Harman = Kalra ; > Jerin Jacob ; Nithin Dabilpuram ; Kiran Kumar K > ; Akhil Goyal ; Singh, Jasv= inder > ; Dumitrescu, Cristian ; Wiles, Keith > ; Maciej Czekaj ; Maxime Coqu= elin > ; Xia, Chenbo ; Wang, Z= hihong > ; Yong Wang > Subject: [PATCH v3 02/29] ethdev: allow drivers to return error on close >=20 > The device operation .dev_close was returning void. > This driver interface is changed to return an int. >=20 > Note that the API rte_eth_dev_close() is still returning void, > although a deprecation notice is pending to change it as well. >=20 > Signed-off-by: Thomas Monjalon > Reviewed-by: Rosen Xu > Reviewed-by: Sachin Saxena > Reviewed-by: Liron Himi > --- > drivers/net/e1000/em_ethdev.c | 6 ++++-- > drivers/net/e1000/igb_ethdev.c | 12 ++++++++---- > drivers/net/igc/igc_ethdev.c | 6 ++++-- > drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++---- For e1000/igc/ixgbe Reviewed-by: Haiyue Wang > 2.28.0