From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE3D9A04AE; Sat, 15 Aug 2020 04:48:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C9A031C0C0; Sat, 15 Aug 2020 04:48:34 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DBD9A1C0BD for ; Sat, 15 Aug 2020 04:48:32 +0200 (CEST) IronPort-SDR: lyEEOYq/t1lgcywR9baXKUimzvU537S1FkRvuQo1oEdtyFog/WHB6rbDnOcC53lScwy0K4idFx 0fEgvxYuyWkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9713"; a="216033027" X-IronPort-AV: E=Sophos;i="5.76,314,1592895600"; d="scan'208";a="216033027" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2020 19:48:30 -0700 IronPort-SDR: SovZiwrRqim+awOShHoy0lRHnU897aUatapFpEnEJ2aEGWR9oUEwKS3XW8fnbYG+3hCv/RHMpC 75y8jhuJOlVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,314,1592895600"; d="scan'208";a="278559825" Received: from unknown (HELO fmsmsx604.amr.corp.intel.com) ([10.18.84.214]) by fmsmga008.fm.intel.com with ESMTP; 14 Aug 2020 19:48:30 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 14 Aug 2020 19:48:29 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 14 Aug 2020 19:48:29 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 14 Aug 2020 19:48:29 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 14 Aug 2020 19:48:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XAoha2vU3Bnv1eEflbmaBWYyhAdASddV2vP3nSR+rKJCnSlr0xnsuoDH9ns3X9xNx6v3YWNZgEAEooWo2IytdiweLlyjvmxff6WXNOCnDI3JJ1xvkIHS/jEr/DgxCI7mg8VnpM0JEwxYkax+U20O+EFoojMZhrPzQjIZHO9w3H5g3DXZa4LMJ2ujSzpvJ7SWiDwthkY3DWQ70aYXyX1hRmM/DSuA137EKpc73RJ9/Lv6JnaMhhgQMI7P6PWKFmVqEdnjrJ4vniygebHJFeqJw3xfI4FZWChnBydhbLp2GqnzEGmpQes7K6DdM3WhapsH0XeempvEizTRmZXXeXy/8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YVP3g3wnlV4+Yf5d2E30p7Lem0WApu0tscMJtiq5RXg=; b=REf3Mj8xTAXkHqsl39m+qeF5krc5BxMfHJBVxZVVE7BFQ//xBQYRYw3myYocMfrFrVvza7wuJicBunPqkQfr6SyNT4QJRy3N31nEnnwvusLGYHRqwtUUXjsEj+CXMS5kHINXTwREG//WgrapZY+5zWzix3gNieluUzeoKF+4jX6zk2jJL9k+JpTC6U5atzaKAuLf0RM8QjRJOxtlX8xVx1Fy7I7kAOHXrZzpep32cnKa+YkMY72429PoZN4ukTKsrs3rzhz1nP4mNGY/xwI3VFUVtvwD88i6mk/RnasyEuBiHbYmaVlp0VoTq5xt+ew87Ac2YOPqJA76xlgfUnNt9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YVP3g3wnlV4+Yf5d2E30p7Lem0WApu0tscMJtiq5RXg=; b=Y23ws6K1IuGf7LjzBxgvW1KFJFlmt7yHhe+ENTcrRJ9YTV/q8lX/zGb50cOYlymCYMpFnzKwugpyjAspGQblVeihyK7kWO6DQE0mBUa/junxsNBJf4klNSVcP08dB9kusVjtiUi+r+/4IUqlZTwBdGz5Mi10M7oPpI6qEMibrDE= Received: from BN8PR11MB3812.namprd11.prod.outlook.com (2603:10b6:408:90::11) by BN6PR11MB1492.namprd11.prod.outlook.com (2603:10b6:405:b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15; Sat, 15 Aug 2020 02:48:07 +0000 Received: from BN8PR11MB3812.namprd11.prod.outlook.com ([fe80::d5fd:6323:f50f:eba1]) by BN8PR11MB3812.namprd11.prod.outlook.com ([fe80::d5fd:6323:f50f:eba1%5]) with mapi id 15.20.3283.018; Sat, 15 Aug 2020 02:48:07 +0000 From: "Varghese, Vipin" To: Stephen Hemminger CC: Thomas Monjalon , "Tahhan, Maryam" , "Pattan, Reshma" , "hemant.agrawal@nxp.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 2/7] app/proc-info: eliminate useless borders Thread-Index: AQHWcYx3JFjm+U7AnUGnGf9vw28vUak2xOEwgAAIaiCAACLKgIAAgnbggABArACAAMU2oA== Date: Sat, 15 Aug 2020 02:48:06 +0000 Message-ID: References: <20200506193741.24117-1-stephen@networkplumber.org> <20200715212228.28010-1-stephen@networkplumber.org> <20200715212228.28010-3-stephen@networkplumber.org> <1686569.X5dskYFTH4@thomas> <20200813091121.3b3f9e9d@hermes.lan> <20200813201833.09b95d69@hermes.lan> <20200814075658.2b8544b1@hermes.lan> In-Reply-To: <20200814075658.2b8544b1@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [49.207.212.119] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d668e7e5-dbc6-4966-ebb5-08d840c5a396 x-ms-traffictypediagnostic: BN6PR11MB1492: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NF9b9I7zS5nRzNdYpCDcymlPDKF9168hJyDDOdPpvOeIwyWJHM5HulQvclUFoL4Jv96SljQzss9wU2f6dqdtB5Z7sAcrBRlNQmE6Pdjt2VPJZrm30per/9oBFyBQgwDmxvHmHM3J7sQYFQP2dc4dHBKv8LcrKXuRRqLFh+MKX8deMRrW8DHpKfFCxqnuYdQEeyh//UbK6cLu70bHY1jeZ6D6gD4Jx2fAlrY57I+DVcTIIBvwzeP6XV1KylbC2voSRcdWB7n46UlZE/nGmVCv2rn/Hhy8caO9kZluipBo04uWbZInXZrjPIlMoewCY4ODZzfG1NL6fxMUunRbt7RKzQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3812.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(346002)(39860400002)(396003)(136003)(6916009)(55236004)(33656002)(8676002)(7696005)(9686003)(52536014)(86362001)(478600001)(5660300002)(6506007)(316002)(8936002)(4326008)(2906002)(66476007)(186003)(26005)(71200400001)(55016002)(54906003)(83380400001)(76116006)(64756008)(66946007)(66556008)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 6cYCUPInSqk1r9S9MPijiBF1YmEXfbMBldqnFYSGP83TKxRnHutKNmQHkWi3SFsI3H3Y+BP2w63pZw+Hxz0kmfazxCoe+bMl/qdQ7Lp87avOIyAy0ix7cJbyXuTdwWhl92mLy2igXROLgzWVQmn/kla6Cj9sEcu1nkAzUsqg0B28w6mTHjHh3tUzGObQZkkMgXAtpyJsm+MScuqxgGlvnsCyLU/5DHSUEgerjoL7GCMsAfMjUuiy8WFFBJDbiWTknJC2y0KHpc9uj/S8kjkj4jvVexoGNE78XvzGIfF9gvTqHxyxFOfG27HCLHaoq+7KDNwIFt70+5/zdbS2plZaHewEwgHwpnHWijdw/+ckV4cQLhzqMosB/2wrlzVkFWWo7f2d/wFnlsfUDH3trQmr8NMl07LKV76wEUzph5skxe+8sr9hfn+5MrmWkfF7fDd0Y4QEnY1ZwQKM7tZ4hr7bDOhkGDeUXTGsoT32XNkl1j+gfhnyChuBbjkTYE90x68FJylNXVKhhmxcHPCdUbIF5AUa2nfl8/k5QJIKuRsZ/R0S1iWhScl4iwZ3eyjeYHdvQKMDiaGy0slKhm0hCyTFFdfWCO5rTkeefRo5QBVYGzTKuf4m9BUzi2IRSP2dG6vrJLDW/tLmgMdJPkldcoEXWA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3812.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d668e7e5-dbc6-4966-ebb5-08d840c5a396 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2020 02:48:06.8987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yYdmEwq6qfepLpc5FzyQDmGaBIsY+FQxzUGh7GW7lAJ6HXDOY9dMJONjatM2dWvpMP+bJvHI59JJ9yzeCHstmIrSS/YZnhvdDFF9ON6ZiGo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1492 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/7] app/proc-info: eliminate useless borders X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > > Hi Stephen, > > > > > > > > > snipped > > > > > > > > > > snipped > > > > > > > > > > > > > > snipped > > > > > > > > > > > > > > > > 15/07/2020 23:22, Stephen Hemminger: > > > > > > > > > Printing extra borders does not improve readability, and > > > > > > > > > is just unnecessary. Putting TSC hz in header also makes > > > > > > > > > no sense > > > here. > > > > > > > > > > > > > > > > The CPU frequency on headers! > > > > > > > > OK to remove :) > > > > > > > > > > > > > > > > > > > > > > The rational of having Time Stamp Counter as the header for > > > > > > > port info and > > > > > > stats, is to account for each iteration for an average > > > > > > `packets per second`. That is using `watch -d -n 1 > > > > > > ./dpdk-procinfo -- --xstats | grep - > > > v ": 0"`. > > > > > > > > > > > > > > But if there better way to do this or add as new feature, +1 = to > remove. > > > > > > > > > > > > Proc info should just use standard clock for its updates, not T= SC? > > > > > > > > > > Can you please explain the rationale behind the (syscall for > > > > > time) and not > > > TSC? > > > > > > > > Looking forward for the patch with clock change too. > > > > > > There is no part of what proc-info is show with xstats that displays > > > or uses tsc directly. > > > Do you have a driver that is putting TSC information in xstats? > > > > I am sorry I did not follow you on this, In the earlier implementation = with > `proc-info` header we had TSC so coupling `--show --xstats`. But with the > header removed out with TSC, how can we get this? >=20 > I am asking why is the TSC hz a useful piece of information here? > Sure, proc-info could print lots of things but unless it serves a useful = purpose > for examining the interfaces, it is just noise. >=20 > Developers love to clutter output, but it just raises the signal to noise= ratio. Thanks for the update, as mentioned earlier from my end `+1` for cleaning u= p the console output interface. Also `+1` for adding option to get timestam= p too. But I am still not able to understand the suggestions like=20 `1. Why Proc info should just use standard clock for its updates, not TSC? 2. CPU frequency in header?` As I understand standard clock is syscall and TSC is register fetch for clo= ck ticks after reset and not CPU frequency.