From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40CE9A0A0C; Mon, 28 Jun 2021 16:21:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4F554069F; Mon, 28 Jun 2021 16:21:07 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2074.outbound.protection.outlook.com [40.107.212.74]) by mails.dpdk.org (Postfix) with ESMTP id 2EB6640692; Mon, 28 Jun 2021 16:21:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IkrLk6KP4rZwNLbutkRns7gL/ex0BmLkvblISSJRcQuK4+xLuC97FFxv4ngklBVKIuYxyPN6koddOdCIfUWu/7eSLQFDf0MMb9dfDBTpjIIuClVVnsav+naMC6ruxtj8fFWLRhvNGbb/vfGLRJ0lDhJhID8cMdOrlZx8zHoZNpsBXQuqaa6+qmfgNKKaMpKnbO9ijTcAq0SOV4a7caKG/d/cKIARBvhzZtXjUTraByOy1xqmDXrsegcIlP8iUeFnJv5YY/MnZnSsDE0pkgo9ynRwtdM7Qnm/uQ9rdb4uQkEXFluZFWYUW3FiO7VStdvQ1v22VUok2GsCRCn5oAjqUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+dbIv1AqYtZhaAiEeYJy5Bil00jriWrrTfIXxrcB3w=; b=hWfcqmFRcj8VI6nwGGaQIe1NyzcIDL9ldDD6o3tQe1OcAGyHjTg69YeyJFIZZ8tmPFzo72Ti8+W9rrQwOTwd8qA049JR9f6X9JNDpsEyjG3KluIMeZ/2kph/LuhkI+jkpznLiHR9skfMr/5YaosMDZwg4aCHF5SCYlZffd+/MB+6tDG+ZJXw5g35gabwTXdMOBWWBu0zdk4eczXLWQtHBAl5A8DSvJxYgf8z0pld4WSuyriVSwv5JwR63eEdJedGfr1BzJr5a1RjC2zfX5VucCCiF3lgDxep9NexkS4KkIPvewt5JjiRwvA0ipRyKbBZY/MGDyaIMLJoHkwHX+s3vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+dbIv1AqYtZhaAiEeYJy5Bil00jriWrrTfIXxrcB3w=; b=up1NjdQmeEroANnuYJYnhFLSzibkI9Xi5/qqh4BlC9+LQo8ACd1Eh0oLKZmrGErZNQfnAXJkEFNTXO5ycDaiTZo4VncrgcEEmM4mmSP0M2ThPRJuDtjvQ++al3h7vbEezLr94hQDuqexdvj7rmnR/uWl2M3m/a/GIxvp0iSr8bYP/wKyiGklu1VLnRsB18vKAkI5s7JUw1sL+fiPPESYfHC4Ygs7CzxE1QYJ1oZecMryinuVuFCfrfe1TtbMvdK6pzYRy7zLx7hczsKntLQHTQjM2jkEmPwtDV51ATWEd0TVtZlhVBUE4JGsFEQRhZlcA4C4anB5s9csQ4iIn+jJcg== Received: from BN8PR12MB4980.namprd12.prod.outlook.com (2603:10b6:408:a8::18) by BN6PR12MB1233.namprd12.prod.outlook.com (2603:10b6:404:1c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Mon, 28 Jun 2021 14:21:05 +0000 Received: from BN8PR12MB4980.namprd12.prod.outlook.com ([fe80::9572:afee:26fc:ad63]) by BN8PR12MB4980.namprd12.prod.outlook.com ([fe80::9572:afee:26fc:ad63%5]) with mapi id 15.20.4264.026; Mon, 28 Jun 2021 14:21:05 +0000 From: Michael Baum <michaelba@nvidia.com> To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>, Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com> Thread-Topic: [dpdk-stable] [PATCH 2/4] compress/mlx5: fix constant size in QP creation Thread-Index: AQHXZ/uxQxBbk0PZt0Cl5t2BAA7gQKspfyNw Date: Mon, 28 Jun 2021 14:21:04 +0000 Message-ID: <BN8PR12MB498054CB400D940982969F3CCC039@BN8PR12MB4980.namprd12.prod.outlook.com> References: <20210601071122.1612432-1-michaelba@nvidia.com> <20210601071122.1612432-2-michaelba@nvidia.com> <2171041.exsR1beKra@thomas> In-Reply-To: <2171041.exsR1beKra@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 174b9387-4576-4dea-3f2f-08d93a3ff6f3 x-ms-traffictypediagnostic: BN6PR12MB1233: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BN6PR12MB123397178F8D5209B6989D3CCC039@BN6PR12MB1233.namprd12.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZgdA1FfsE+nAu8PxVYXo6Oh5cWLPGbopYyfyaccr7tF/V2MObRe4HY0TRJzKFzeqCqy+vGpj+uOIe6W4WtOOuQxjEbAlCNDCei9NfeDmcgrMAIuD9rr0x/Hmqrszz6zlod3ElFUHRY2q5uZTc6u1pI8QHptmlV4p7/dNFGDhNNr2SBL1emqkJyBy4Ai3Bbgrdr509Op1fqs5cPPIOgQLyIxcHx1npxoM+XvHQOh0ukP3NiZBRF6DpY+lvjW7zWb2h+GgPUbxTVEnKWHzGFOqJ2WbFYjYUZ211SRYwfTO0zspOE226z0cOULKdXYLL+hRz5+uKRa9SNeRDM4HDUbAAmrjFg+FpYkDI0kT5rU5UG5gcMr4t1LiCQHvSxbPdz01jxsFMfTzTgMFr2AF1fuXGJ089vQLykU9xv/VlET3gDp3nZff6YqRMu8LRCwA62bX6Jks38MLpeAWYmOHSSRPRSbK2CFQhNk6xyuU8JuUMDQ8mbI6E1HiIRne39gL9RA+Y+EGsTayx7Samn0+kh4YOOoLs2sKFdq55u2jxa6mdDgfrlVjc+OusJtHjIvgHUlTt6pbFHlNkTQQTs3h6/4hXVIOaMqDRjvBXyNp5H+euCapRvuUiVmpMfmP26Q7Lnl/NyEXBdZ34km+3/HOheXccw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR12MB4980.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(396003)(39860400002)(136003)(346002)(316002)(54906003)(83380400001)(8676002)(33656002)(55016002)(6916009)(478600001)(8936002)(9686003)(107886003)(38100700002)(186003)(2906002)(5660300002)(53546011)(4326008)(6506007)(7696005)(66476007)(76116006)(66946007)(66556008)(66446008)(64756008)(52536014)(71200400001)(86362001)(122000001)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QPnA7/WXcUSkvviVCecC0zBJbwuix8QjXzEKT+Q6/y/Hk36uz6QuoV0mIPXe?= =?us-ascii?Q?OAtKr7KwMh1vWddpeQb03JeuMifIOljbWt0OEmUmDf1pTL7S70LN/Jgwv1A2?= =?us-ascii?Q?WrbhQXQw1hpoitHbYaTLZe/3fIswyTnvWS4gpCNmnVYgrO+nrkkCqbP4TNpA?= =?us-ascii?Q?Phe9KbzbVB2LL0YlRPN6qoV6L8YUjbxt/X1gvvpw0Z+NzP9hMrjwWaGtfXI0?= =?us-ascii?Q?ijbuD6uOORlze8BhMyp1NBSQoSU0nSCSyaz7wT0uYb2ZyhbQOsMjRL2XP9hl?= =?us-ascii?Q?syWPUTVgCpQ8HLyshx/tffnBNsxsPLmMLcnekAlO3cQXzeMZjc9y93tf0eLr?= =?us-ascii?Q?paEzy7qH4GLtnXQn/QxLtb2lAAPzHKk0cVoW8opoHCPXu+ZTGWSbqo00Bba5?= =?us-ascii?Q?+Q8kjjQCaVTMYrWhtoWIfxzesnkwXOC+Tf2riKGmfSChRFV1vTB69ory+IJA?= =?us-ascii?Q?41ZrYzuWaUb2JPBKeCPyw/ytrJqsvySGMhIDPGeeSdTK48L0S7nJgTQd+Ntg?= =?us-ascii?Q?jKpI2/0RRdnZJhlXnTity/FdQ1zxiJr/474yCXA+zmnYRYjRG0XTx8mCxmLF?= =?us-ascii?Q?ni8MaO339HYlSROGSzJNu0Ezqd2D1uf6SXNReesjTUxCC5eq7rKM3ZiG+DOK?= =?us-ascii?Q?HDwzoZ2YLsjnDqI5lFeru3ZewnE0+CnP2e3Dp+YniivLXoqovQ1BU0Bk5NA3?= =?us-ascii?Q?fj7NopH5KW8HvbCaYqR1KQewFjqOdoPRff+UuFHK64wjmCdaVNDHVxbUIISK?= =?us-ascii?Q?oj5kO9zn3GYydcQyWGbdMKnXxbYTGfi2Fmn3BDyYbGHAetXNbDoWu27PCbn3?= =?us-ascii?Q?RlzqdblWzfawArxA3kif7Md3SAGv9HTZZilAKR8VzeRPDa3u0KhynNDQYJlp?= =?us-ascii?Q?7iktxdCjsCci2LECqRh1RsxO+Q7m0rnPWb8YpVsao5sOgB++jrF3ZHQwSXzN?= =?us-ascii?Q?qX1KeO04MmqD+uN+eJKeGzaek6aNNFWfiJYxEFfIrwlRFs5bUC9uu3AkH0Fv?= =?us-ascii?Q?QC4mOJzRTEV2XCD1avrLGb8NLltoFnC7ke6/yL2x1E1jE12ZipqhjGnCYCGJ?= =?us-ascii?Q?oGvXgvtV/F7/xWgwi0XSNX2BKQuPvHhS8tZJuHPy2icYRYyKck7g2m1cKJ5r?= =?us-ascii?Q?J6xDyEo/Cc7t+RfdIpq98IesfPAmkNhH8u+YAZshmLAOKDiHQxHDsuN7pg3b?= =?us-ascii?Q?ydPL52OHVNaFFJokegsTKGK/QW/MB9ji50vn2Nf13nG05t0cg1x5A/Cv6ieS?= =?us-ascii?Q?wA/V6msnb5AjM+NsC1haJOlvouU3lcqbkZMPdW5WDu655Ezg/8E4sd5UFnA0?= =?us-ascii?Q?9CI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB4980.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 174b9387-4576-4dea-3f2f-08d93a3ff6f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2021 14:21:04.9543 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SdWZjWHHTyPThVibvOMmD8HDjttNUJfAOPTa/CxDd2yWLKYJSRjP8fVtr+oteICIhw80JmwHDbMXG3769mDuMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1233 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] compress/mlx5: fix constant size in QP creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> External email: Use caution opening links or attachments > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Wednesday, June 23, 2021 9:48 AM > To: Michael Baum <michaelba@nvidia.com> > Cc: dev@dpdk.org; stable@dpdk.org; Matan Azrad <matan@nvidia.com>; > Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko > <viacheslavo@nvidia.com> > Subject: Re: [dpdk-stable] [PATCH 2/4] compress/mlx5: fix constant size i= n > QP creation >=20 > External email: Use caution opening links or attachments >=20 >=20 > 01/06/2021 09:11, Michael Baum: > > The mlx5_compress_qp_setup function makes shifting to the numeric > > constant 1, then sends it as a parameter to rte_calloc function. > > > > The rte_calloc function expects to get size_t (64 bits, unsigned) and >=20 > No on 32-bit systems, size_t is 32 bits. Thanks for the comment, I'll send v2. > > instead gets a 32-bit variable, because the numeric constant size is a > > 32-bit. >=20 > Most of the patches of this series say "constant" where it is a variable. >=20 > > In case the shift is greater than 32 the variable will lose its value > > even though the function can get 64-bit argument. > > > > Change the size of the numeric constant 1 to 64-bit. > [...] > > - opaq_buf =3D rte_calloc(__func__, 1u << log_ops_n, > > + opaq_buf =3D rte_calloc(__func__, RTE_BIT64(log_ops_n), >=20 >=20