From: Michael Baum <michaelba@nvidia.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: support timestamp format
Date: Thu, 2 Sep 2021 11:52:07 +0000 [thread overview]
Message-ID: <BN8PR12MB498094A1BF9DFFAEF0085F2ECCCE9@BN8PR12MB4980.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB448415BCB690E89D40387E2FD8CE9@CO6PR18MB4484.namprd18.prod.outlook.com>
Hi,
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, September 2, 2021 1:14 PM
> To: Michael Baum <michaelba@nvidia.com>; dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; stable@dpdk.org
> Subject: RE: [EXT] [dpdk-dev] [PATCH] crypto/mlx5: support timestamp
> format
>
> External email: Use caution opening links or attachments
>
>
> > This patch adds support for the timestamp format settings for the
> > receive and send queues. If the firmware version x.30.1000 or above is
> > installed and the NIC timestamps are configured with the real-time
> > format, the default zero values for newly added fields cause the queue
> > creation to fail.
> >
> > The patch queries the timestamp formats supported by the hardware and
> > sets the configuration values in queue context accordingly.
> >
> > Fixes: 6152534e211e ("crypto/mlx5: support queue pairs operations")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Michael Baum <michaelba@nvidia.com>
> > ---
> Is this a fix or a feature, title says a new feature, but description says it as a
> fix.
Yes you're right.
Could you please change the title to: crypto/mlx5: fix timestamp format configuration?
Or will I send v2?
>
> Please align title and description of the patch.
next prev parent reply other threads:[~2021-09-02 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 20:40 [dpdk-dev] " Michael Baum
2021-09-01 7:48 ` Matan Azrad
2021-09-02 10:13 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-09-02 11:52 ` Michael Baum [this message]
2021-09-05 8:04 ` [dpdk-dev] [PATCH v2] crypto/mlx5: fix timestamp format configuration Michael Baum
2021-09-06 18:15 ` [dpdk-dev] [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR12MB498094A1BF9DFFAEF0085F2ECCCE9@BN8PR12MB4980.namprd12.prod.outlook.com \
--to=michaelba@nvidia.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).